Re: [Intel-gfx] [PATCH v2 1/9] drm/i915: Polish CHV CGM CSC loading

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Fri, Mar 06, 2020 at 02:14:15PM +0530, Sharma, Swati2 wrote:
> 
> 
> On 03-Mar-20 11:03 PM, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Only load the CGM CSC based on the cgm_mode bit like we
> > do with the gamma/degamma LUTs. And make the function
> > naming and arguments consistent as well.
> > 
> > TODO: the code to convert the coefficients look totally
> > bogus. IIRC CHV uses two's complement format but the code
> > certainly doesn't generate that, so probably negative
> > coefficients are totally busted.
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> >   drivers/gpu/drm/i915/display/intel_color.c | 69 +++++++++++-----------
> >   1 file changed, 35 insertions(+), 34 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c
> > index 98aefeebda28..444980fdeda6 100644
> > --- a/drivers/gpu/drm/i915/display/intel_color.c
> > +++ b/drivers/gpu/drm/i915/display/intel_color.c
> > @@ -348,48 +348,43 @@ static void icl_load_csc_matrix(const struct intel_crtc_state *crtc_state)
> >   		       crtc_state->csc_mode);
> >   }
> >   
> > -/*
> > - * Set up the pipe CSC unit on CherryView.
> > - */
> > -static void cherryview_load_csc_matrix(const struct intel_crtc_state *crtc_state)
> > +static void chv_load_cgm_csc(struct intel_crtc *crtc,
> > +			     const struct drm_property_blob *blob)
> Nitpick: Spacing?

I think it's just the use of tabs and the diff's '+' making it look off.

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx