Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* Re: [Intel-gfx] [PATCH] drm/i915/gvt: Fix NULL pointer dereference in intel_vgpu_reg_rw_edid()
@ 2020-09-08 15:47 Markus Elfring
  2020-09-08 18:11 ` [Intel-gfx] [PATCH v2] drm/i915/gvt: Prevent " Alejandro Sior
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Markus Elfring @ 2020-09-08 15:47 UTC (permalink / raw)
  To: Alejandro W. Sior, dri-devel, intel-gfx, intel-gvt-dev
  Cc: David Airlie, kernel-janitors, linux-kernel

> In the function intel_vgpu_reg_rw_edid of gvt/kvmgt.c, pos can get equal to NULL for GPUs that do not
> properly support EDID. …

* I propose to reconsider the previous patch subject once more.

* Did the script “checkpatch.pl” point any adjustment possibilities out
  for the change description?


> This patch solves this problem by …

Would an imperative wording be preferred for the commit message?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n151


> … to a nagative value, …

Please avoid a typo here.


I suggest to add the tag “Fixes” to the commit message.

Regards,
Markus
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-09-12  7:02 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-08 15:47 [Intel-gfx] [PATCH] drm/i915/gvt: Fix NULL pointer dereference in intel_vgpu_reg_rw_edid() Markus Elfring
2020-09-08 18:11 ` [Intel-gfx] [PATCH v2] drm/i915/gvt: Prevent " Alejandro Sior
2020-09-11  5:39   ` Zhenyu Wang
2020-09-12  7:02     ` Aho Sior
2020-09-08 18:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-09-08 18:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-08 19:41 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-09-11  6:00 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gvt: Prevent NULL pointer dereference in intel_vgpu_reg_rw_edid() (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox