Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915: Fix an error code i915_gem_object_copy_blt()
@ 2020-09-10 10:08 Dan Carpenter
  2020-09-10 12:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Dan Carpenter @ 2020-09-10 10:08 UTC (permalink / raw)
  To: Jani Nikula, Maarten Lankhorst
  Cc: kernel-janitors, David Airlie, intel-gfx, Chris Wilson,
	Matthew Auld

This code should use "vma[1]" instead of "vma".  The "vma" is a variable
is a valid pointer.

Fixes: 6b05030496f7 ("drm/i915: Convert i915_gem_object/client_blt.c to use ww locking as well, v2.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_object_blt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c
index d93eb36160c9..aee7ad3cc3c6 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_object_blt.c
@@ -364,7 +364,7 @@ int i915_gem_object_copy_blt(struct drm_i915_gem_object *src,
 
 	vma[1] = i915_vma_instance(dst, vm, NULL);
 	if (IS_ERR(vma[1]))
-		return PTR_ERR(vma);
+		return PTR_ERR(vma[1]);
 
 	i915_gem_ww_ctx_init(&ww, true);
 	intel_engine_pm_get(ce->engine);
-- 
2.28.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-09-17 10:49 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-10 10:08 [Intel-gfx] [PATCH] drm/i915: Fix an error code i915_gem_object_copy_blt() Dan Carpenter
2020-09-10 12:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-09-10 13:23 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-09-10 20:14 ` [Intel-gfx] [PATCH] " Mika Kuoppala
2020-09-11  7:52   ` [Intel-gfx] [PATCH v2] " Dan Carpenter
2020-09-17 10:49     ` Maarten Lankhorst
2020-09-11  9:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix an error code i915_gem_object_copy_blt() (rev2) Patchwork
2020-09-11 10:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox