* [Intel-gfx] [PATCH] drm/i915/ehl: Implement W/A 22010492432
@ 2020-10-28 9:16 Tejas Upadhyay
2020-10-28 10:30 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tejas Upadhyay @ 2020-10-28 9:16 UTC (permalink / raw)
To: intel-gfx; +Cc: hariom.pandey
As per W/A implemented for TGL to program half of the nominal
DCO divider fraction value which is also applicable on EHL.
Cc: Deak Imre <imre.deak@intel.com>
Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
---
drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
index eaef7a2d041f..0f3208d3c083 100644
--- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
@@ -2636,13 +2636,15 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc_state *crtc_state)
}
/*
- * Display WA #22010492432: tgl
+ * Display WA #22010492432: ehl, tgl
* Program half of the nominal DCO divider fraction value.
*/
static bool
-tgl_combo_pll_div_frac_wa_needed(struct drm_i915_private *i915)
+combo_pll_div_frac_wa_needed(struct drm_i915_private *i915)
{
- return IS_TIGERLAKE(i915) && i915->dpll.ref_clks.nssc == 38400;
+ return (IS_PLATFORM(i915, INTEL_ELKHARTLAKE) ||
+ IS_TIGERLAKE(i915)) &&
+ i915->dpll.ref_clks.nssc == 38400;
}
static int __cnl_ddi_wrpll_get_freq(struct drm_i915_private *dev_priv,
@@ -2696,7 +2698,7 @@ static int __cnl_ddi_wrpll_get_freq(struct drm_i915_private *dev_priv,
dco_fraction = (pll_state->cfgcr0 & DPLL_CFGCR0_DCO_FRACTION_MASK) >>
DPLL_CFGCR0_DCO_FRACTION_SHIFT;
- if (tgl_combo_pll_div_frac_wa_needed(dev_priv))
+ if (combo_pll_div_frac_wa_needed(dev_priv))
dco_fraction *= 2;
dco_freq += (dco_fraction * ref_clock) / 0x8000;
@@ -3086,7 +3088,7 @@ static void icl_calc_dpll_state(struct drm_i915_private *i915,
memset(pll_state, 0, sizeof(*pll_state));
- if (tgl_combo_pll_div_frac_wa_needed(i915))
+ if (combo_pll_div_frac_wa_needed(i915))
dco_fraction = DIV_ROUND_CLOSEST(dco_fraction, 2);
pll_state->cfgcr0 = DPLL_CFGCR0_DCO_FRACTION(dco_fraction) |
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ehl: Implement W/A 22010492432
2020-10-28 9:16 [Intel-gfx] [PATCH] drm/i915/ehl: Implement W/A 22010492432 Tejas Upadhyay
@ 2020-10-28 10:30 ` Patchwork
2020-10-28 12:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-10-28 17:40 ` [Intel-gfx] [PATCH] " Imre Deak
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-10-28 10:30 UTC (permalink / raw)
To: Tejas Upadhyay; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 7873 bytes --]
== Series Details ==
Series: drm/i915/ehl: Implement W/A 22010492432
URL : https://patchwork.freedesktop.org/series/83135/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9207 -> Patchwork_18796
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/index.html
New tests
---------
New tests have been introduced between CI_DRM_9207 and Patchwork_18796:
### New CI tests (1) ###
* boot:
- Statuses : 39 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18796 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-byt-j1900: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/fi-byt-j1900/igt@i915_pm_rpm@basic-pci-d3-state.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/fi-byt-j1900/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@vgem_basic@dmabuf-fence:
- fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([i915#402]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/fi-tgl-y/igt@vgem_basic@dmabuf-fence.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/fi-tgl-y/igt@vgem_basic@dmabuf-fence.html
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- fi-tgl-u2: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/fi-tgl-u2/igt@core_hotunplug@unbind-rebind.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/fi-tgl-u2/igt@core_hotunplug@unbind-rebind.html
* igt@debugfs_test@read_all_entries:
- {fi-kbl-7560u}: [INCOMPLETE][9] ([i915#2417]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/fi-kbl-7560u/igt@debugfs_test@read_all_entries.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/fi-kbl-7560u/igt@debugfs_test@read_all_entries.html
* igt@i915_module_load@reload:
- {fi-tgl-dsi}: [DMESG-WARN][11] ([i915#1982] / [k.org#205379]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/fi-tgl-dsi/igt@i915_module_load@reload.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/fi-tgl-dsi/igt@i915_module_load@reload.html
- fi-tgl-u2: [DMESG-WARN][13] ([i915#1982] / [k.org#205379]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/fi-tgl-u2/igt@i915_module_load@reload.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/fi-tgl-u2/igt@i915_module_load@reload.html
- fi-icl-y: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/fi-icl-y/igt@i915_module_load@reload.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/fi-icl-y/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [DMESG-FAIL][19] ([i915#541]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_busy@basic@flip:
- fi-kbl-soraka: [DMESG-WARN][21] ([i915#1982]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/fi-kbl-soraka/igt@kms_busy@basic@flip.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/fi-kbl-soraka/igt@kms_busy@basic@flip.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [INCOMPLETE][23] ([i915#2606]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- {fi-tgl-dsi}: [DMESG-WARN][25] ([i915#1982]) -> [PASS][26] +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/fi-tgl-dsi/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/fi-tgl-dsi/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_psr@primary_mmap_gtt:
- fi-cml-s: [INCOMPLETE][27] ([i915#2606]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/fi-cml-s/igt@kms_psr@primary_mmap_gtt.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/fi-cml-s/igt@kms_psr@primary_mmap_gtt.html
* igt@prime_self_import@basic-with_two_bos:
- fi-tgl-y: [DMESG-WARN][29] ([i915#402]) -> [PASS][30] +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
#### Warnings ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-tgl-y: [DMESG-WARN][31] ([i915#2411]) -> [DMESG-WARN][32] ([i915#1982] / [i915#2411])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/fi-tgl-y/igt@i915_pm_rpm@basic-pci-d3-state.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/fi-tgl-y/igt@i915_pm_rpm@basic-pci-d3-state.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1784]: https://gitlab.freedesktop.org/drm/intel/issues/1784
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2417]: https://gitlab.freedesktop.org/drm/intel/issues/2417
[i915#2606]: https://gitlab.freedesktop.org/drm/intel/issues/2606
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (41 -> 39)
------------------------------
Additional (1): fi-cml-u2
Missing (3): fi-bdw-samus fi-skl-6600u fi-elk-e7500
Build changes
-------------
* Linux: CI_DRM_9207 -> Patchwork_18796
CI-20190529: 20190529
CI_DRM_9207: 5fde6a8070fd3847130e7f4f0dfd08cbbef0ca1d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5827: 7fd7e3fb8b42eb4e62a4575f6edc5a048e5bec3d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18796: eaf07c85e80822b5393cbe5dcad739aa8abde9c5 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
eaf07c85e808 drm/i915/ehl: Implement W/A 22010492432
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/index.html
[-- Attachment #1.2: Type: text/html, Size: 9555 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ehl: Implement W/A 22010492432
2020-10-28 9:16 [Intel-gfx] [PATCH] drm/i915/ehl: Implement W/A 22010492432 Tejas Upadhyay
2020-10-28 10:30 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-10-28 12:56 ` Patchwork
2020-10-28 17:40 ` [Intel-gfx] [PATCH] " Imre Deak
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-10-28 12:56 UTC (permalink / raw)
To: Tejas Upadhyay; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 23652 bytes --]
== Series Details ==
Series: drm/i915/ehl: Implement W/A 22010492432
URL : https://patchwork.freedesktop.org/series/83135/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9207_full -> Patchwork_18796_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18796_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18796_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18796_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_flip@blocking-wf_vblank@a-hdmi-a1:
- shard-hsw: [PASS][1] -> [INCOMPLETE][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-hsw1/igt@kms_flip@blocking-wf_vblank@a-hdmi-a1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-hsw2/igt@kms_flip@blocking-wf_vblank@a-hdmi-a1.html
#### Warnings ####
* igt@gem_exec_create@basic:
- shard-hsw: [FAIL][3] ([i915#1888]) -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-hsw7/igt@gem_exec_create@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-hsw4/igt@gem_exec_create@basic.html
* igt@runner@aborted:
- shard-skl: ([FAIL][5], [FAIL][6], [FAIL][7], [FAIL][8], [FAIL][9], [FAIL][10], [FAIL][11], [FAIL][12], [FAIL][13], [FAIL][14], [FAIL][15], [FAIL][16], [FAIL][17], [FAIL][18], [FAIL][19], [FAIL][20], [FAIL][21], [FAIL][22], [FAIL][23], [FAIL][24], [FAIL][25], [FAIL][26]) ([i915#1436] / [i915#1814]) -> ([FAIL][27], [FAIL][28], [FAIL][29], [FAIL][30], [FAIL][31], [FAIL][32], [FAIL][33], [FAIL][34], [FAIL][35], [FAIL][36], [FAIL][37], [FAIL][38], [FAIL][39], [FAIL][40], [FAIL][41], [FAIL][42], [FAIL][43], [FAIL][44], [FAIL][45]) ([i915#1814] / [i915#2439])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl6/igt@runner@aborted.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl1/igt@runner@aborted.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl4/igt@runner@aborted.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl10/igt@runner@aborted.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl10/igt@runner@aborted.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl3/igt@runner@aborted.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl4/igt@runner@aborted.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl6/igt@runner@aborted.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl2/igt@runner@aborted.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl8/igt@runner@aborted.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl2/igt@runner@aborted.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl9/igt@runner@aborted.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl9/igt@runner@aborted.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl4/igt@runner@aborted.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl7/igt@runner@aborted.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl1/igt@runner@aborted.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl3/igt@runner@aborted.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl2/igt@runner@aborted.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl8/igt@runner@aborted.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl7/igt@runner@aborted.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl9/igt@runner@aborted.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl3/igt@runner@aborted.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl8/igt@runner@aborted.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl9/igt@runner@aborted.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl10/igt@runner@aborted.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl10/igt@runner@aborted.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl7/igt@runner@aborted.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl1/igt@runner@aborted.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl2/igt@runner@aborted.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl7/igt@runner@aborted.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl1/igt@runner@aborted.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl8/igt@runner@aborted.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl10/igt@runner@aborted.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl4/igt@runner@aborted.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl3/igt@runner@aborted.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl8/igt@runner@aborted.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl9/igt@runner@aborted.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl3/igt@runner@aborted.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl3/igt@runner@aborted.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl6/igt@runner@aborted.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl1/igt@runner@aborted.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs}:
- shard-skl: NOTRUN -> [FAIL][46]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
New tests
---------
New tests have been introduced between CI_DRM_9207_full and Patchwork_18796_full:
### New CI tests (1) ###
* boot:
- Statuses : 200 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18796_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@hotrebind-lateclose:
- shard-snb: [PASS][47] -> [INCOMPLETE][48] ([i915#82])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-snb6/igt@core_hotunplug@hotrebind-lateclose.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-snb7/igt@core_hotunplug@hotrebind-lateclose.html
* igt@drm_read@empty-block:
- shard-glk: [PASS][49] -> [DMESG-WARN][50] ([i915#1982])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-glk8/igt@drm_read@empty-block.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-glk2/igt@drm_read@empty-block.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-0:
- shard-apl: [PASS][51] -> [DMESG-WARN][52] ([i915#1635] / [i915#1982]) +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-apl7/igt@kms_big_fb@x-tiled-8bpp-rotate-0.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-apl8/igt@kms_big_fb@x-tiled-8bpp-rotate-0.html
* igt@kms_big_fb@y-tiled-32bpp-rotate-0:
- shard-glk: [PASS][53] -> [FAIL][54] ([i915#1119])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-glk5/igt@kms_big_fb@y-tiled-32bpp-rotate-0.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-glk7/igt@kms_big_fb@y-tiled-32bpp-rotate-0.html
* igt@kms_cursor_edge_walk@pipe-b-64x64-left-edge:
- shard-skl: [PASS][55] -> [DMESG-WARN][56] ([i915#1982]) +2 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl10/igt@kms_cursor_edge_walk@pipe-b-64x64-left-edge.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl2/igt@kms_cursor_edge_walk@pipe-b-64x64-left-edge.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][57] -> [FAIL][58] ([i915#72])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-glk9/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][59] -> [FAIL][60] ([i915#2122])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-glk2/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-glk3/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt:
- shard-tglb: [PASS][61] -> [INCOMPLETE][62] ([i915#2606])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-blt:
- shard-skl: [PASS][63] -> [INCOMPLETE][64] ([i915#123]) +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl7/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-blt.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl2/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-skl: [PASS][65] -> [INCOMPLETE][66] ([i915#123] / [i915#2606])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_psr@cursor_render:
- shard-skl: [PASS][67] -> [INCOMPLETE][68] ([i915#2606])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl2/igt@kms_psr@cursor_render.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl3/igt@kms_psr@cursor_render.html
* igt@kms_psr@suspend:
- shard-skl: [PASS][69] -> [INCOMPLETE][70] ([i915#198])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl3/igt@kms_psr@suspend.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl9/igt@kms_psr@suspend.html
* igt@kms_vblank@pipe-c-wait-forked-busy:
- shard-kbl: [PASS][71] -> [DMESG-WARN][72] ([i915#1982]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-kbl2/igt@kms_vblank@pipe-c-wait-forked-busy.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-kbl6/igt@kms_vblank@pipe-c-wait-forked-busy.html
* igt@perf@polling-parameterized:
- shard-glk: [PASS][73] -> [FAIL][74] ([i915#1542])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-glk2/igt@perf@polling-parameterized.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-glk7/igt@perf@polling-parameterized.html
#### Possible fixes ####
* igt@gem_exec_gttfill@all:
- shard-glk: [DMESG-WARN][75] ([i915#118] / [i915#95]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-glk7/igt@gem_exec_gttfill@all.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-glk5/igt@gem_exec_gttfill@all.html
* igt@gem_exec_nop@basic-sequential:
- shard-skl: [DMESG-WARN][77] ([i915#1982]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl10/igt@gem_exec_nop@basic-sequential.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl1/igt@gem_exec_nop@basic-sequential.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [DMESG-WARN][79] ([i915#1436] / [i915#716]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl3/igt@gen9_exec_parse@allowed-single.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl8/igt@gen9_exec_parse@allowed-single.html
* {igt@kms_async_flips@async-flip-with-page-flip-events}:
- shard-glk: [FAIL][81] ([i915#2521]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-glk5/igt@kms_async_flips@async-flip-with-page-flip-events.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-glk4/igt@kms_async_flips@async-flip-with-page-flip-events.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-skl: [INCOMPLETE][83] ([i915#300]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl9/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_flip_tiling@flip-y-tiled:
- shard-kbl: [DMESG-WARN][85] ([i915#1982]) -> [PASS][86] +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-kbl6/igt@kms_flip_tiling@flip-y-tiled.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-kbl1/igt@kms_flip_tiling@flip-y-tiled.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
- shard-iclb: [INCOMPLETE][87] ([i915#2606]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html
* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu:
- shard-tglb: [INCOMPLETE][89] ([i915#2606]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-skl: [DMESG-WARN][91] ([i915#2606]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl10/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-blt:
- shard-skl: [INCOMPLETE][93] ([i915#123] / [i915#2606]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-blt.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render:
- shard-skl: [INCOMPLETE][95] ([i915#123]) -> [PASS][96] +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [DMESG-FAIL][97] ([fdo#108145] / [i915#1982]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-kbl: [DMESG-WARN][99] ([i915#165] / [i915#78]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-kbl2/igt@kms_plane_lowres@pipe-a-tiling-x.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-kbl4/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@cursor_blt:
- shard-skl: [INCOMPLETE][101] ([i915#2606]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl10/igt@kms_psr@cursor_blt.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl8/igt@kms_psr@cursor_blt.html
* igt@kms_psr@primary_blt:
- shard-skl: [INCOMPLETE][103] -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl6/igt@kms_psr@primary_blt.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl4/igt@kms_psr@primary_blt.html
* igt@kms_vblank@pipe-c-wait-forked-busy:
- shard-apl: [DMESG-WARN][105] ([i915#1635] / [i915#1982]) -> [PASS][106] +3 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-apl4/igt@kms_vblank@pipe-c-wait-forked-busy.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-apl2/igt@kms_vblank@pipe-c-wait-forked-busy.html
* igt@perf_pmu@module-unload:
- shard-hsw: [DMESG-WARN][107] ([i915#1982]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-hsw6/igt@perf_pmu@module-unload.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-hsw1/igt@perf_pmu@module-unload.html
#### Warnings ####
* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: [SKIP][109] ([fdo#109271]) -> [FAIL][110] ([i915#183])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-hsw7/igt@gem_tiled_swapping@non-threaded.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-hsw4/igt@gem_tiled_swapping@non-threaded.html
* igt@i915_pm_dc@dc6-psr:
- shard-skl: [FAIL][111] ([i915#454]) -> [INCOMPLETE][112] ([i915#198])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl8/igt@i915_pm_dc@dc6-psr.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl10/igt@i915_pm_dc@dc6-psr.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
- shard-tglb: [INCOMPLETE][113] ([i915#2606]) -> [DMESG-WARN][114] ([i915#2606])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
- shard-iclb: [INCOMPLETE][115] ([i915#2606]) -> [DMESG-WARN][116] ([i915#2606]) +2 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-msflip-blt:
- shard-skl: [DMESG-WARN][117] ([i915#1982]) -> [INCOMPLETE][118] ([i915#123] / [i915#2606]) +1 similar issue
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-msflip-blt.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render:
- shard-skl: [DMESG-WARN][119] -> [INCOMPLETE][120] ([i915#123])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9207/shard-skl2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/shard-skl8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1119]: https://gitlab.freedesktop.org/drm/intel/issues/1119
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#183]: https://gitlab.freedesktop.org/drm/intel/issues/183
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2606]: https://gitlab.freedesktop.org/drm/intel/issues/2606
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9207 -> Patchwork_18796
CI-20190529: 20190529
CI_DRM_9207: 5fde6a8070fd3847130e7f4f0dfd08cbbef0ca1d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5827: 7fd7e3fb8b42eb4e62a4575f6edc5a048e5bec3d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18796: eaf07c85e80822b5393cbe5dcad739aa8abde9c5 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18796/index.html
[-- Attachment #1.2: Type: text/html, Size: 27580 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/ehl: Implement W/A 22010492432
2020-10-28 9:16 [Intel-gfx] [PATCH] drm/i915/ehl: Implement W/A 22010492432 Tejas Upadhyay
2020-10-28 10:30 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-10-28 12:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2020-10-28 17:40 ` Imre Deak
2 siblings, 0 replies; 4+ messages in thread
From: Imre Deak @ 2020-10-28 17:40 UTC (permalink / raw)
To: Tejas Upadhyay; +Cc: intel-gfx, hariom.pandey
On Wed, Oct 28, 2020 at 02:46:41PM +0530, Tejas Upadhyay wrote:
> As per W/A implemented for TGL to program half of the nominal
> DCO divider fraction value which is also applicable on EHL.
>
> Cc: Deak Imre <imre.deak@intel.com>
> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> index eaef7a2d041f..0f3208d3c083 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> @@ -2636,13 +2636,15 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc_state *crtc_state)
> }
>
> /*
> - * Display WA #22010492432: tgl
> + * Display WA #22010492432: ehl, tgl
> * Program half of the nominal DCO divider fraction value.
> */
> static bool
> -tgl_combo_pll_div_frac_wa_needed(struct drm_i915_private *i915)
> +combo_pll_div_frac_wa_needed(struct drm_i915_private *i915)
The usual way is to prefix such function names with the earliest
relevant platform, so I'd use ehl_ here.
> {
> - return IS_TIGERLAKE(i915) && i915->dpll.ref_clks.nssc == 38400;
> + return (IS_PLATFORM(i915, INTEL_ELKHARTLAKE) ||
On EHL the WA is needed only B stepping onwards.
> + IS_TIGERLAKE(i915)) &&
> + i915->dpll.ref_clks.nssc == 38400;
> }
>
> static int __cnl_ddi_wrpll_get_freq(struct drm_i915_private *dev_priv,
> @@ -2696,7 +2698,7 @@ static int __cnl_ddi_wrpll_get_freq(struct drm_i915_private *dev_priv,
> dco_fraction = (pll_state->cfgcr0 & DPLL_CFGCR0_DCO_FRACTION_MASK) >>
> DPLL_CFGCR0_DCO_FRACTION_SHIFT;
>
> - if (tgl_combo_pll_div_frac_wa_needed(dev_priv))
> + if (combo_pll_div_frac_wa_needed(dev_priv))
> dco_fraction *= 2;
>
> dco_freq += (dco_fraction * ref_clock) / 0x8000;
> @@ -3086,7 +3088,7 @@ static void icl_calc_dpll_state(struct drm_i915_private *i915,
>
> memset(pll_state, 0, sizeof(*pll_state));
>
> - if (tgl_combo_pll_div_frac_wa_needed(i915))
> + if (combo_pll_div_frac_wa_needed(i915))
> dco_fraction = DIV_ROUND_CLOSEST(dco_fraction, 2);
>
> pll_state->cfgcr0 = DPLL_CFGCR0_DCO_FRACTION(dco_fraction) |
> --
> 2.28.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-28 17:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-28 9:16 [Intel-gfx] [PATCH] drm/i915/ehl: Implement W/A 22010492432 Tejas Upadhyay
2020-10-28 10:30 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-10-28 12:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-10-28 17:40 ` [Intel-gfx] [PATCH] " Imre Deak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox