* [Intel-gfx] [PATCH] drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout
@ 2020-12-09 15:39 Imre Deak
2020-12-09 15:53 ` Anshuman Gupta
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Imre Deak @ 2020-12-09 15:39 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
For an enabled DSC during HW readout the corresponding power reference
is taken along the CRTC power domain references in
get_crtc_power_domains(). Remove the incorrect get ref from the DSI
encoder hook.
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/display/icl_dsi.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
index a9439b415603..b3533a32f8ba 100644
--- a/drivers/gpu/drm/i915/display/icl_dsi.c
+++ b/drivers/gpu/drm/i915/display/icl_dsi.c
@@ -1616,10 +1616,6 @@ static void gen11_dsi_get_power_domains(struct intel_encoder *encoder,
get_dsi_io_power_domains(i915,
enc_to_intel_dsi(encoder));
-
- if (crtc_state->dsc.compression_enable)
- intel_display_power_get(i915,
- intel_dsc_power_domain(crtc_state));
}
static bool gen11_dsi_get_hw_state(struct intel_encoder *encoder,
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout
2020-12-09 15:39 [Intel-gfx] [PATCH] drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout Imre Deak
@ 2020-12-09 15:53 ` Anshuman Gupta
2020-12-09 16:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Anshuman Gupta @ 2020-12-09 15:53 UTC (permalink / raw)
To: Imre Deak; +Cc: Nikula, Jani, intel-gfx@lists.freedesktop.org
On 2020-12-09 at 21:09:52 +0530, Imre Deak wrote:
> For an enabled DSC during HW readout the corresponding power reference
> is taken along the CRTC power domain references in
> get_crtc_power_domains(). Remove the incorrect get ref from the DSI
> encoder hook.
Looks good to me.
Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com>
>
> Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/display/icl_dsi.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
> index a9439b415603..b3533a32f8ba 100644
> --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> @@ -1616,10 +1616,6 @@ static void gen11_dsi_get_power_domains(struct intel_encoder *encoder,
>
> get_dsi_io_power_domains(i915,
> enc_to_intel_dsi(encoder));
> -
> - if (crtc_state->dsc.compression_enable)
> - intel_display_power_get(i915,
> - intel_dsc_power_domain(crtc_state));
> }
>
> static bool gen11_dsi_get_hw_state(struct intel_encoder *encoder,
> --
> 2.25.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout
2020-12-09 15:39 [Intel-gfx] [PATCH] drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout Imre Deak
2020-12-09 15:53 ` Anshuman Gupta
@ 2020-12-09 16:44 ` Patchwork
2020-12-09 18:30 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-01-07 7:01 ` [Intel-gfx] [PATCH] " Jani Nikula
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2020-12-09 16:44 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 6439 bytes --]
== Series Details ==
Series: drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout
URL : https://patchwork.freedesktop.org/series/84735/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9464 -> Patchwork_19093
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/index.html
Known issues
------------
Here are the changes found in Patchwork_19093 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-byt-j1900: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/fi-byt-j1900/igt@amdgpu/amd_basic@userptr.html
* igt@i915_getparams_basic@basic-subslice-total:
- fi-tgl-y: [PASS][2] -> [DMESG-WARN][3] ([i915#402]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html
* igt@i915_selftest@live@active:
- fi-bsw-kefka: [PASS][4] -> [DMESG-FAIL][5] ([i915#2675] / [i915#541])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/fi-bsw-kefka/igt@i915_selftest@live@active.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/fi-bsw-kefka/igt@i915_selftest@live@active.html
* igt@runner@aborted:
- fi-kbl-r: NOTRUN -> [FAIL][6] ([i915#1569] / [i915#192] / [i915#193] / [i915#194] / [i915#2295] / [i915#2722])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/fi-kbl-r/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0:
- {fi-tgl-dsi}: [INCOMPLETE][7] ([i915#1602] / [i915#2411] / [i915#456]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/fi-tgl-dsi/igt@gem_exec_suspend@basic-s0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/fi-tgl-dsi/igt@gem_exec_suspend@basic-s0.html
* igt@i915_pm_rpm@module-reload:
- fi-byt-j1900: [INCOMPLETE][9] ([i915#142] / [i915#2405]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
- fi-kbl-guc: [FAIL][11] ([i915#579]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@gt_lrc:
- fi-bsw-n3050: [DMESG-FAIL][13] ([i915#2675]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/fi-bsw-n3050/igt@i915_selftest@live@gt_lrc.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/fi-bsw-n3050/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@sanitycheck:
- fi-kbl-7500u: [DMESG-WARN][15] ([i915#2605]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/fi-kbl-7500u/igt@i915_selftest@live@sanitycheck.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/fi-kbl-7500u/igt@i915_selftest@live@sanitycheck.html
* igt@vgem_basic@create:
- fi-tgl-y: [DMESG-WARN][17] ([i915#402]) -> [PASS][18] +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/fi-tgl-y/igt@vgem_basic@create.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/fi-tgl-y/igt@vgem_basic@create.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#142]: https://gitlab.freedesktop.org/drm/intel/issues/142
[i915#1569]: https://gitlab.freedesktop.org/drm/intel/issues/1569
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759
[i915#192]: https://gitlab.freedesktop.org/drm/intel/issues/192
[i915#193]: https://gitlab.freedesktop.org/drm/intel/issues/193
[i915#194]: https://gitlab.freedesktop.org/drm/intel/issues/194
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2373]: https://gitlab.freedesktop.org/drm/intel/issues/2373
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605
[i915#2675]: https://gitlab.freedesktop.org/drm/intel/issues/2675
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
Participating hosts (43 -> 40)
------------------------------
Missing (3): fi-ilk-m540 fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_9464 -> Patchwork_19093
CI-20190529: 20190529
CI_DRM_9464: a2561d7ce07920c1fc05013c87d21d3c8b05149f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5885: d99f644b1868b9c92435b05ebfafa230721cd677 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19093: 65ab8dd2be36c0b2e2fdc112cdfe1bbcd7e6f09c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
65ab8dd2be36 drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/index.html
[-- Attachment #1.2: Type: text/html, Size: 6794 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout
2020-12-09 15:39 [Intel-gfx] [PATCH] drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout Imre Deak
2020-12-09 15:53 ` Anshuman Gupta
2020-12-09 16:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-12-09 18:30 ` Patchwork
2020-12-10 18:45 ` Imre Deak
2021-01-07 7:01 ` [Intel-gfx] [PATCH] " Jani Nikula
3 siblings, 1 reply; 7+ messages in thread
From: Patchwork @ 2020-12-09 18:30 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 12960 bytes --]
== Series Details ==
Series: drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout
URL : https://patchwork.freedesktop.org/series/84735/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9464_full -> Patchwork_19093_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_19093_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_params@no-vebox:
- shard-skl: NOTRUN -> [SKIP][1] ([fdo#109271]) +38 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl2/igt@gem_exec_params@no-vebox.html
* igt@gem_exec_reloc@basic-many-active@vcs1:
- shard-iclb: NOTRUN -> [FAIL][2] ([i915#2389])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-iclb2/igt@gem_exec_reloc@basic-many-active@vcs1.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-hsw: [PASS][3] -> [WARN][4] ([i915#1519])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-hsw2/igt@i915_pm_rc6_residency@rc6-idle.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-hsw2/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_chamelium@dp-hpd-storm-disable:
- shard-skl: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl2/igt@kms_chamelium@dp-hpd-storm-disable.html
* igt@kms_cursor_crc@pipe-c-cursor-128x42-onscreen:
- shard-skl: [PASS][6] -> [FAIL][7] ([i915#54]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-128x42-onscreen.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-128x42-onscreen.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][8] -> [FAIL][9] ([i915#2346] / [i915#533])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-tglb: [PASS][10] -> [FAIL][11] ([i915#2346])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-tglb5/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-tglb5/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-skl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#533])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl2/igt@kms_cursor_legacy@pipe-d-single-bo.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][13] -> [FAIL][14] ([i915#79])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
- shard-tglb: [PASS][15] -> [FAIL][16] ([i915#2598])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-tglb1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-tglb1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#1188])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl6/igt@kms_hdr@bpc-switch-dpms.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl6/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-skl: NOTRUN -> [FAIL][19] ([fdo#108145] / [i915#265]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][20] -> [FAIL][21] ([fdo#108145] / [i915#265]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][22] -> [SKIP][23] ([fdo#109441]) +2 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_gtt.html
#### Possible fixes ####
* igt@gem_exec_gttfill@engines@rcs0:
- shard-glk: [DMESG-WARN][24] ([i915#118] / [i915#95]) -> [PASS][25] +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-glk4/igt@gem_exec_gttfill@engines@rcs0.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-glk9/igt@gem_exec_gttfill@engines@rcs0.html
* igt@kms_color@pipe-c-ctm-0-75:
- shard-skl: [DMESG-WARN][26] ([i915#1982]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl4/igt@kms_color@pipe-c-ctm-0-75.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl2/igt@kms_color@pipe-c-ctm-0-75.html
* igt@kms_cursor_crc@pipe-a-cursor-128x128-random:
- shard-skl: [FAIL][28] ([i915#54]) -> [PASS][29] +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-128x128-random.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-128x128-random.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-skl: [INCOMPLETE][30] ([i915#300]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
- shard-skl: [FAIL][32] ([i915#2346]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-skl: [FAIL][34] ([i915#2122]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl2/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl5/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][36] ([fdo#109441]) -> [PASS][37] +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-iclb3/igt@kms_psr@psr2_no_drrs.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@perf@polling-parameterized:
- shard-apl: [FAIL][38] ([i915#1542]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-apl4/igt@perf@polling-parameterized.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-apl1/igt@perf@polling-parameterized.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][40] ([i915#2684]) -> [WARN][41] ([i915#1804] / [i915#2684])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-iclb2/igt@i915_pm_rc6_residency@rc6-fence.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-iclb3/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [SKIP][42] ([fdo#109441]) -> [DMESG-WARN][43] ([i915#1602])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-iclb1/igt@kms_psr@psr2_suspend.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-iclb2/igt@kms_psr@psr2_suspend.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-kbl: [INCOMPLETE][44] ([i915#155] / [i915#2405]) -> [DMESG-WARN][45] ([i915#1602])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-kbl2/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-kbl7/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
* igt@runner@aborted:
- shard-kbl: [FAIL][46] ([i915#2295] / [i915#2722] / [i915#483]) -> ([FAIL][47], [FAIL][48]) ([i915#1814] / [i915#2295] / [i915#2722] / [i915#483] / [i915#602])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-kbl1/igt@runner@aborted.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-kbl2/igt@runner@aborted.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-kbl7/igt@runner@aborted.html
- shard-glk: ([FAIL][49], [FAIL][50]) ([i915#1814] / [i915#2295] / [i915#2722] / [i915#483] / [k.org#202321]) -> ([FAIL][51], [FAIL][52]) ([i915#1814] / [i915#2295] / [i915#2722] / [k.org#202321])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-glk7/igt@runner@aborted.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-glk4/igt@runner@aborted.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-glk4/igt@runner@aborted.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-glk1/igt@runner@aborted.html
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#602]: https://gitlab.freedesktop.org/drm/intel/issues/602
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9464 -> Patchwork_19093
CI-20190529: 20190529
CI_DRM_9464: a2561d7ce07920c1fc05013c87d21d3c8b05149f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5885: d99f644b1868b9c92435b05ebfafa230721cd677 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19093: 65ab8dd2be36c0b2e2fdc112cdfe1bbcd7e6f09c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/index.html
[-- Attachment #1.2: Type: text/html, Size: 15907 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout
2020-12-09 18:30 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2020-12-10 18:45 ` Imre Deak
0 siblings, 0 replies; 7+ messages in thread
From: Imre Deak @ 2020-12-10 18:45 UTC (permalink / raw)
To: intel-gfx, Anshuman Gupta
On Wed, Dec 09, 2020 at 06:30:16PM +0000, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout
> URL : https://patchwork.freedesktop.org/series/84735/
> State : success
Thanks for the review, pushed to din.
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_9464_full -> Patchwork_19093_full
> ====================================================
>
> Summary
> -------
>
> **SUCCESS**
>
> No regressions found.
>
>
>
> Known issues
> ------------
>
> Here are the changes found in Patchwork_19093_full that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@gem_exec_params@no-vebox:
> - shard-skl: NOTRUN -> [SKIP][1] ([fdo#109271]) +38 similar issues
> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl2/igt@gem_exec_params@no-vebox.html
>
> * igt@gem_exec_reloc@basic-many-active@vcs1:
> - shard-iclb: NOTRUN -> [FAIL][2] ([i915#2389])
> [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-iclb2/igt@gem_exec_reloc@basic-many-active@vcs1.html
>
> * igt@i915_pm_rc6_residency@rc6-idle:
> - shard-hsw: [PASS][3] -> [WARN][4] ([i915#1519])
> [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-hsw2/igt@i915_pm_rc6_residency@rc6-idle.html
> [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-hsw2/igt@i915_pm_rc6_residency@rc6-idle.html
>
> * igt@kms_chamelium@dp-hpd-storm-disable:
> - shard-skl: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +4 similar issues
> [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl2/igt@kms_chamelium@dp-hpd-storm-disable.html
>
> * igt@kms_cursor_crc@pipe-c-cursor-128x42-onscreen:
> - shard-skl: [PASS][6] -> [FAIL][7] ([i915#54]) +1 similar issue
> [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-128x42-onscreen.html
> [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-128x42-onscreen.html
>
> * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
> - shard-skl: [PASS][8] -> [FAIL][9] ([i915#2346] / [i915#533])
> [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
> [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
>
> * igt@kms_cursor_legacy@flip-vs-cursor-legacy:
> - shard-tglb: [PASS][10] -> [FAIL][11] ([i915#2346])
> [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-tglb5/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
> [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-tglb5/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
>
> * igt@kms_cursor_legacy@pipe-d-single-bo:
> - shard-skl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#533])
> [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl2/igt@kms_cursor_legacy@pipe-d-single-bo.html
>
> * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
> - shard-skl: [PASS][13] -> [FAIL][14] ([i915#79])
> [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
> [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
> - shard-tglb: [PASS][15] -> [FAIL][16] ([i915#2598])
> [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-tglb1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
> [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-tglb1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
>
> * igt@kms_hdr@bpc-switch-dpms:
> - shard-skl: [PASS][17] -> [FAIL][18] ([i915#1188])
> [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl6/igt@kms_hdr@bpc-switch-dpms.html
> [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl6/igt@kms_hdr@bpc-switch-dpms.html
>
> * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
> - shard-skl: NOTRUN -> [FAIL][19] ([fdo#108145] / [i915#265]) +1 similar issue
> [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
>
> * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
> - shard-skl: [PASS][20] -> [FAIL][21] ([fdo#108145] / [i915#265]) +1 similar issue
> [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
> [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
>
> * igt@kms_psr@psr2_sprite_mmap_gtt:
> - shard-iclb: [PASS][22] -> [SKIP][23] ([fdo#109441]) +2 similar issues
> [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
> [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_gtt.html
>
>
> #### Possible fixes ####
>
> * igt@gem_exec_gttfill@engines@rcs0:
> - shard-glk: [DMESG-WARN][24] ([i915#118] / [i915#95]) -> [PASS][25] +3 similar issues
> [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-glk4/igt@gem_exec_gttfill@engines@rcs0.html
> [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-glk9/igt@gem_exec_gttfill@engines@rcs0.html
>
> * igt@kms_color@pipe-c-ctm-0-75:
> - shard-skl: [DMESG-WARN][26] ([i915#1982]) -> [PASS][27]
> [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl4/igt@kms_color@pipe-c-ctm-0-75.html
> [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl2/igt@kms_color@pipe-c-ctm-0-75.html
>
> * igt@kms_cursor_crc@pipe-a-cursor-128x128-random:
> - shard-skl: [FAIL][28] ([i915#54]) -> [PASS][29] +3 similar issues
> [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-128x128-random.html
> [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-128x128-random.html
>
> * igt@kms_cursor_crc@pipe-c-cursor-suspend:
> - shard-skl: [INCOMPLETE][30] ([i915#300]) -> [PASS][31]
> [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
> [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
>
> * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
> - shard-skl: [FAIL][32] ([i915#2346]) -> [PASS][33]
> [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
> [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
>
> * igt@kms_flip@flip-vs-expired-vblank@b-edp1:
> - shard-skl: [FAIL][34] ([i915#2122]) -> [PASS][35]
> [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-skl2/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
> [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-skl5/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
>
> * igt@kms_psr@psr2_no_drrs:
> - shard-iclb: [SKIP][36] ([fdo#109441]) -> [PASS][37] +1 similar issue
> [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-iclb3/igt@kms_psr@psr2_no_drrs.html
> [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
>
> * igt@perf@polling-parameterized:
> - shard-apl: [FAIL][38] ([i915#1542]) -> [PASS][39]
> [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-apl4/igt@perf@polling-parameterized.html
> [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-apl1/igt@perf@polling-parameterized.html
>
>
> #### Warnings ####
>
> * igt@i915_pm_rc6_residency@rc6-fence:
> - shard-iclb: [WARN][40] ([i915#2684]) -> [WARN][41] ([i915#1804] / [i915#2684])
> [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-iclb2/igt@i915_pm_rc6_residency@rc6-fence.html
> [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-iclb3/igt@i915_pm_rc6_residency@rc6-fence.html
>
> * igt@kms_psr@psr2_suspend:
> - shard-iclb: [SKIP][42] ([fdo#109441]) -> [DMESG-WARN][43] ([i915#1602])
> [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-iclb1/igt@kms_psr@psr2_suspend.html
> [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-iclb2/igt@kms_psr@psr2_suspend.html
>
> * igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
> - shard-kbl: [INCOMPLETE][44] ([i915#155] / [i915#2405]) -> [DMESG-WARN][45] ([i915#1602])
> [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-kbl2/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
> [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-kbl7/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
>
> * igt@runner@aborted:
> - shard-kbl: [FAIL][46] ([i915#2295] / [i915#2722] / [i915#483]) -> ([FAIL][47], [FAIL][48]) ([i915#1814] / [i915#2295] / [i915#2722] / [i915#483] / [i915#602])
> [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-kbl1/igt@runner@aborted.html
> [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-kbl2/igt@runner@aborted.html
> [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-kbl7/igt@runner@aborted.html
> - shard-glk: ([FAIL][49], [FAIL][50]) ([i915#1814] / [i915#2295] / [i915#2722] / [i915#483] / [k.org#202321]) -> ([FAIL][51], [FAIL][52]) ([i915#1814] / [i915#2295] / [i915#2722] / [k.org#202321])
> [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-glk7/igt@runner@aborted.html
> [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9464/shard-glk4/igt@runner@aborted.html
> [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-glk4/igt@runner@aborted.html
> [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/shard-glk1/igt@runner@aborted.html
>
>
> [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
> [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
> [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
> [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
> [i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519
> [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
> [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
> [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
> [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
> [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
> [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
> [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
> [i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
> [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
> [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
> [i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
> [i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
> [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
> [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
> [i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
> [i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
> [i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
> [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
> [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
> [i915#602]: https://gitlab.freedesktop.org/drm/intel/issues/602
> [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
> [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
> [k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
>
>
> Participating hosts (10 -> 10)
> ------------------------------
>
> No changes in participating hosts
>
>
> Build changes
> -------------
>
> * Linux: CI_DRM_9464 -> Patchwork_19093
>
> CI-20190529: 20190529
> CI_DRM_9464: a2561d7ce07920c1fc05013c87d21d3c8b05149f @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_5885: d99f644b1868b9c92435b05ebfafa230721cd677 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_19093: 65ab8dd2be36c0b2e2fdc112cdfe1bbcd7e6f09c @ git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19093/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout
2020-12-09 15:39 [Intel-gfx] [PATCH] drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout Imre Deak
` (2 preceding siblings ...)
2020-12-09 18:30 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2021-01-07 7:01 ` Jani Nikula
2021-01-07 12:56 ` Imre Deak
3 siblings, 1 reply; 7+ messages in thread
From: Jani Nikula @ 2021-01-07 7:01 UTC (permalink / raw)
To: Imre Deak, intel-gfx
On Wed, 09 Dec 2020, Imre Deak <imre.deak@intel.com> wrote:
> For an enabled DSC during HW readout the corresponding power reference
> is taken along the CRTC power domain references in
> get_crtc_power_domains(). Remove the incorrect get ref from the DSI
> encoder hook.
Does this fix [1] which is v5.11-rc2 on TGL DSI? Should we pick this up
for fixes?
BR,
Jani.
[1] https://intel-gfx-ci.01.org/tree/drm-intel-fixes/CI_DIF_538/fi-tgl-dsi/igt@gem_exec_suspend@basic-s0.html
>
> Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/display/icl_dsi.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
> index a9439b415603..b3533a32f8ba 100644
> --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> @@ -1616,10 +1616,6 @@ static void gen11_dsi_get_power_domains(struct intel_encoder *encoder,
>
> get_dsi_io_power_domains(i915,
> enc_to_intel_dsi(encoder));
> -
> - if (crtc_state->dsc.compression_enable)
> - intel_display_power_get(i915,
> - intel_dsc_power_domain(crtc_state));
> }
>
> static bool gen11_dsi_get_hw_state(struct intel_encoder *encoder,
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout
2021-01-07 7:01 ` [Intel-gfx] [PATCH] " Jani Nikula
@ 2021-01-07 12:56 ` Imre Deak
0 siblings, 0 replies; 7+ messages in thread
From: Imre Deak @ 2021-01-07 12:56 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Thu, Jan 07, 2021 at 09:01:40AM +0200, Jani Nikula wrote:
> On Wed, 09 Dec 2020, Imre Deak <imre.deak@intel.com> wrote:
> > For an enabled DSC during HW readout the corresponding power reference
> > is taken along the CRTC power domain references in
> > get_crtc_power_domains(). Remove the incorrect get ref from the DSI
> > encoder hook.
>
> Does this fix [1] which is v5.11-rc2 on TGL DSI?
Yes, looks like it:
<4> [199.269612] i915 0000:00:02.0: i915 raw-wakerefs=1 wakelocks=1 on cleanup
...
<7> [199.277233] i915 Wakeref x1 taken at:
intel_display_power_get+0x1f/0x60 [i915]
intel_modeset_setup_hw_state+0xbcf/0x19b0 [i915]
> Should we pick this up for fixes?
Yes.
Thanks,
Imre
> BR,
> Jani.
>
>
> [1] https://intel-gfx-ci.01.org/tree/drm-intel-fixes/CI_DIF_538/fi-tgl-dsi/igt@gem_exec_suspend@basic-s0.html
>
>
>
> >
> > Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/icl_dsi.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
> > index a9439b415603..b3533a32f8ba 100644
> > --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> > +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> > @@ -1616,10 +1616,6 @@ static void gen11_dsi_get_power_domains(struct intel_encoder *encoder,
> >
> > get_dsi_io_power_domains(i915,
> > enc_to_intel_dsi(encoder));
> > -
> > - if (crtc_state->dsc.compression_enable)
> > - intel_display_power_get(i915,
> > - intel_dsc_power_domain(crtc_state));
> > }
> >
> > static bool gen11_dsi_get_hw_state(struct intel_encoder *encoder,
>
> --
> Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-01-07 12:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-09 15:39 [Intel-gfx] [PATCH] drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout Imre Deak
2020-12-09 15:53 ` Anshuman Gupta
2020-12-09 16:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-12-09 18:30 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-12-10 18:45 ` Imre Deak
2021-01-07 7:01 ` [Intel-gfx] [PATCH] " Jani Nikula
2021-01-07 12:56 ` Imre Deak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox