* [Intel-gfx] Missing DPPLL case on i7-1165G7
@ 2020-12-21 4:07 Matthew Wilcox
2020-12-29 14:41 ` Imre Deak
0 siblings, 1 reply; 5+ messages in thread
From: Matthew Wilcox @ 2020-12-21 4:07 UTC (permalink / raw)
To: intel-gfx
At boot,
[ 2.787995] [drm:lspcon_init [i915]] *ERROR* Failed to probe lspcon
[ 2.788001] i915 0000:00:02.0: [drm] *ERROR* LSPCON init failed on port E
[ 2.790752] ------------[ cut here ]------------
[ 2.790753] Missing case (clock == 539440)
[ 2.790790] WARNING: CPU: 0 PID: 159 at drivers/gpu/drm/i915/display/intel_dpll_mgr.c:2967 icl_get_dplls+0x53a/0xa50 [i915]
In drivers/gpu/drm/i915/display/intel_dpll_mgr.c, I see an entry for 540,000.
Presumbly, this clock was supposed to be rounded up to that somewhere.
This is an HP Spectre x360 using the internal display. Here's the EDID
in case that's useful:
$ edid-decode /sys/class/drm/card0-eDP-1/edid
edid-decode (hex):
00 ff ff ff ff ff ff 00 4c 83 49 41 00 00 00 00
13 1d 01 04 b5 1d 11 78 02 38 d1 ae 51 3b b8 23
0b 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
01 01 01 01 01 01 b9 d5 00 40 f1 70 20 80 30 20
88 00 26 a5 10 00 00 1b b9 d5 00 40 f1 70 20 80
30 20 88 00 26 a5 10 00 00 1b 00 00 00 0f 00 ff
09 3c ff 09 3c 2c 80 00 00 00 00 00 00 00 00 10
00 00 01 00 00 00 00 00 00 00 00 00 00 00 01 af
02 03 0f 00 e3 05 80 00 e6 06 05 01 73 6d 07 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ab
----------------
EDID version: 1.4
Manufacturer: SDC Model 16713 Serial Number 0
Made in week 19 of 2019
Digital display
10 bits per primary color channel
DisplayPort interface
Maximum image size: 29 cm x 17 cm
Gamma: 2.20
Supported color formats: RGB 4:4:4
First detailed timing includes the native pixel format and preferred refresh rate
Color Characteristics
Red: 0.6796, 0.3193
Green: 0.2324, 0.7187
Blue: 0.1396, 0.0439
White: 0.3125, 0.3291
Established Timings I & II: none
Standard Timings: none
Detailed mode: Clock 547.130 MHz, 294 mm x 165 mm
3840 3888 3920 4160 ( 48 32 240)
2160 2168 2176 2192 ( 8 8 16)
+hsync -vsync
VertFreq: 60.001 Hz, HorFreq: 131.522 kHz
Detailed mode: Clock 547.130 MHz, 294 mm x 165 mm
3840 3888 3920 4160 ( 48 32 240)
2160 2168 2176 2192 ( 8 8 16)
+hsync -vsync
VertFreq: 60.001 Hz, HorFreq: 131.522 kHz
Manufacturer-Specified Display Descriptor (0x0f): 00 0f 00 ff 09 3c ff 09 3c 2c 80 00 00 00 00 00 .....<..<,......
Dummy Descriptor
Has 1 extension block
Checksum: 0xaf
----------------
CTA-861 Extension Block Revision 3
0 native detailed modes
11 bytes of CTA data blocks
Extended tag: Colorimetry Data Block
BT2020RGB
Extended tag: HDR Static Metadata Data Block
Electro optical transfer functions:
Traditional gamma - SDR luminance range
SMPTE ST2084
Supported static metadata descriptors:
Static metadata type 1
Desired content max luminance: 115 (603.666 cd/m^2)
Desired content max frame-average luminance: 109 (530.095 cd/m^2)
Desired content min luminance: 7 (0.005 cd/m^2)
Checksum: 0xab
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Intel-gfx] Missing DPPLL case on i7-1165G7
2020-12-21 4:07 [Intel-gfx] Missing DPPLL case on i7-1165G7 Matthew Wilcox
@ 2020-12-29 14:41 ` Imre Deak
2021-01-05 5:50 ` Matthew Wilcox
0 siblings, 1 reply; 5+ messages in thread
From: Imre Deak @ 2020-12-29 14:41 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: intel-gfx
Hi,
On Mon, Dec 21, 2020 at 04:07:58AM +0000, Matthew Wilcox wrote:
>
> At boot,
>
> [ 2.787995] [drm:lspcon_init [i915]] *ERROR* Failed to probe lspcon
> [ 2.788001] i915 0000:00:02.0: [drm] *ERROR* LSPCON init failed on port E
> [ 2.790752] ------------[ cut here ]------------
> [ 2.790753] Missing case (clock == 539440)
> [ 2.790790] WARNING: CPU: 0 PID: 159 at drivers/gpu/drm/i915/display/intel_dpll_mgr.c:2967 icl_get_dplls+0x53a/0xa50 [i915]
the above warn looks to be due to a missing workaround fixed by
commit 0e2497e334de42dbaaee8e325241b5b5b34ede7e
Author: Imre Deak <imre.deak@intel.com>
Date: Sat Oct 3 03:18:46 2020 +0300
drm/i915/tgl: Fix Combo PHY DPLL fractional divider for 38.4MHz ref clock
in drm-tip. Could you give it a try?
> In drivers/gpu/drm/i915/display/intel_dpll_mgr.c, I see an entry for 540,000.
> Presumbly, this clock was supposed to be rounded up to that somewhere.
> This is an HP Spectre x360 using the internal display. Here's the EDID
> in case that's useful:
>
> $ edid-decode /sys/class/drm/card0-eDP-1/edid
> edid-decode (hex):
>
> 00 ff ff ff ff ff ff 00 4c 83 49 41 00 00 00 00
> 13 1d 01 04 b5 1d 11 78 02 38 d1 ae 51 3b b8 23
> 0b 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 b9 d5 00 40 f1 70 20 80 30 20
> 88 00 26 a5 10 00 00 1b b9 d5 00 40 f1 70 20 80
> 30 20 88 00 26 a5 10 00 00 1b 00 00 00 0f 00 ff
> 09 3c ff 09 3c 2c 80 00 00 00 00 00 00 00 00 10
> 00 00 01 00 00 00 00 00 00 00 00 00 00 00 01 af
>
> 02 03 0f 00 e3 05 80 00 e6 06 05 01 73 6d 07 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ab
>
> ----------------
>
> EDID version: 1.4
> Manufacturer: SDC Model 16713 Serial Number 0
> Made in week 19 of 2019
> Digital display
> 10 bits per primary color channel
> DisplayPort interface
> Maximum image size: 29 cm x 17 cm
> Gamma: 2.20
> Supported color formats: RGB 4:4:4
> First detailed timing includes the native pixel format and preferred refresh rate
> Color Characteristics
> Red: 0.6796, 0.3193
> Green: 0.2324, 0.7187
> Blue: 0.1396, 0.0439
> White: 0.3125, 0.3291
> Established Timings I & II: none
> Standard Timings: none
> Detailed mode: Clock 547.130 MHz, 294 mm x 165 mm
> 3840 3888 3920 4160 ( 48 32 240)
> 2160 2168 2176 2192 ( 8 8 16)
> +hsync -vsync
> VertFreq: 60.001 Hz, HorFreq: 131.522 kHz
> Detailed mode: Clock 547.130 MHz, 294 mm x 165 mm
> 3840 3888 3920 4160 ( 48 32 240)
> 2160 2168 2176 2192 ( 8 8 16)
> +hsync -vsync
> VertFreq: 60.001 Hz, HorFreq: 131.522 kHz
> Manufacturer-Specified Display Descriptor (0x0f): 00 0f 00 ff 09 3c ff 09 3c 2c 80 00 00 00 00 00 .....<..<,......
> Dummy Descriptor
> Has 1 extension block
> Checksum: 0xaf
>
> ----------------
>
> CTA-861 Extension Block Revision 3
> 0 native detailed modes
> 11 bytes of CTA data blocks
> Extended tag: Colorimetry Data Block
> BT2020RGB
> Extended tag: HDR Static Metadata Data Block
> Electro optical transfer functions:
> Traditional gamma - SDR luminance range
> SMPTE ST2084
> Supported static metadata descriptors:
> Static metadata type 1
> Desired content max luminance: 115 (603.666 cd/m^2)
> Desired content max frame-average luminance: 109 (530.095 cd/m^2)
> Desired content min luminance: 7 (0.005 cd/m^2)
> Checksum: 0xab
>
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Intel-gfx] Missing DPPLL case on i7-1165G7
2020-12-29 14:41 ` Imre Deak
@ 2021-01-05 5:50 ` Matthew Wilcox
2021-01-06 17:25 ` Imre Deak
0 siblings, 1 reply; 5+ messages in thread
From: Matthew Wilcox @ 2021-01-05 5:50 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
On Tue, Dec 29, 2020 at 04:41:31PM +0200, Imre Deak wrote:
> Hi,
>
> On Mon, Dec 21, 2020 at 04:07:58AM +0000, Matthew Wilcox wrote:
> >
> > At boot,
> >
> > [ 2.787995] [drm:lspcon_init [i915]] *ERROR* Failed to probe lspcon
> > [ 2.788001] i915 0000:00:02.0: [drm] *ERROR* LSPCON init failed on port E
> > [ 2.790752] ------------[ cut here ]------------
> > [ 2.790753] Missing case (clock == 539440)
> > [ 2.790790] WARNING: CPU: 0 PID: 159 at drivers/gpu/drm/i915/display/intel_dpll_mgr.c:2967 icl_get_dplls+0x53a/0xa50 [i915]
>
> the above warn looks to be due to a missing workaround fixed by
>
> commit 0e2497e334de42dbaaee8e325241b5b5b34ede7e
> Author: Imre Deak <imre.deak@intel.com>
> Date: Sat Oct 3 03:18:46 2020 +0300
>
> drm/i915/tgl: Fix Combo PHY DPLL fractional divider for 38.4MHz ref clock
>
> in drm-tip. Could you give it a try?
I tried -rc2, which contains that commit, and the problem is gone. Thank
you!
There is a different problem, which is that the brightness buttons
(on F2 and F3 on this laptop) do not actually increase/decrease the
brightness. GNOME pops up a graphic that illustrates it is changing
the brightness, but nothing actually changes.
xbacklight says "No outputs have backlight property" and using
xrandr --output XWAYLAND0 --brightness 0.0001 doesn't change anything
(for various different values, not just 0.0001). Using xrandr --prop
--verbose shows the reported value of "Brightness" changing, but nothing
has changed on the screen.
I found
/sys/devices/pci0000:00/0000:00:02.0/drm/card0/card0-eDP-1/intel_backlight
and tried setting 'brightness' in there to a few different values (100,
2000, 19200, 7000) and also nothing changed.
Any thoughts?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] Missing DPPLL case on i7-1165G7
2021-01-05 5:50 ` Matthew Wilcox
@ 2021-01-06 17:25 ` Imre Deak
2021-01-08 17:53 ` Jani Nikula
0 siblings, 1 reply; 5+ messages in thread
From: Imre Deak @ 2021-01-06 17:25 UTC (permalink / raw)
To: Matthew Wilcox, Jani Nikula; +Cc: intel-gfx
On Tue, Jan 05, 2021 at 05:50:41AM +0000, Matthew Wilcox wrote:
> On Tue, Dec 29, 2020 at 04:41:31PM +0200, Imre Deak wrote:
> > Hi,
> >
> > On Mon, Dec 21, 2020 at 04:07:58AM +0000, Matthew Wilcox wrote:
> > >
> > > At boot,
> > >
> > > [ 2.787995] [drm:lspcon_init [i915]] *ERROR* Failed to probe lspcon
> > > [ 2.788001] i915 0000:00:02.0: [drm] *ERROR* LSPCON init failed on port E
> > > [ 2.790752] ------------[ cut here ]------------
> > > [ 2.790753] Missing case (clock == 539440)
> > > [ 2.790790] WARNING: CPU: 0 PID: 159 at drivers/gpu/drm/i915/display/intel_dpll_mgr.c:2967 icl_get_dplls+0x53a/0xa50 [i915]
> >
> > the above warn looks to be due to a missing workaround fixed by
> >
> > commit 0e2497e334de42dbaaee8e325241b5b5b34ede7e
> > Author: Imre Deak <imre.deak@intel.com>
> > Date: Sat Oct 3 03:18:46 2020 +0300
> >
> > drm/i915/tgl: Fix Combo PHY DPLL fractional divider for 38.4MHz ref clock
> >
> > in drm-tip. Could you give it a try?
>
> I tried -rc2, which contains that commit, and the problem is gone. Thank
> you!
Thanks for testing it, I'll send a patch for the 5.10 stable tree as
well.
> There is a different problem, which is that the brightness buttons
> (on F2 and F3 on this laptop) do not actually increase/decrease the
> brightness. GNOME pops up a graphic that illustrates it is changing
> the brightness, but nothing actually changes.
>
> xbacklight says "No outputs have backlight property" and using
> xrandr --output XWAYLAND0 --brightness 0.0001 doesn't change anything
> (for various different values, not just 0.0001). Using xrandr --prop
> --verbose shows the reported value of "Brightness" changing, but nothing
> has changed on the screen.
>
> I found
> /sys/devices/pci0000:00/0000:00:02.0/drm/card0/card0-eDP-1/intel_backlight
> and tried setting 'brightness' in there to a few different values (100,
> 2000, 19200, 7000) and also nothing changed.
>
> Any thoughts?
One possibility is that from the different backlight methods (DPCD,
direct PWM on a CPU pin) the driver selects the incorrect one. Could you
provide a log booting with drm.debug=0x1e adding it to a new ticket at
https://gitlab.freedesktop.org/drm/intel/-/issues/new?issue
or at least in a reply to this thread?
Adding Jani for further ideas.
--Imre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] Missing DPPLL case on i7-1165G7
2021-01-06 17:25 ` Imre Deak
@ 2021-01-08 17:53 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2021-01-08 17:53 UTC (permalink / raw)
To: imre.deak, Matthew Wilcox; +Cc: intel-gfx
On Wed, 06 Jan 2021, Imre Deak <imre.deak@intel.com> wrote:
> On Tue, Jan 05, 2021 at 05:50:41AM +0000, Matthew Wilcox wrote:
>> On Tue, Dec 29, 2020 at 04:41:31PM +0200, Imre Deak wrote:
>> > Hi,
>> >
>> > On Mon, Dec 21, 2020 at 04:07:58AM +0000, Matthew Wilcox wrote:
>> > >
>> > > At boot,
>> > >
>> > > [ 2.787995] [drm:lspcon_init [i915]] *ERROR* Failed to probe lspcon
>> > > [ 2.788001] i915 0000:00:02.0: [drm] *ERROR* LSPCON init failed on port E
>> > > [ 2.790752] ------------[ cut here ]------------
>> > > [ 2.790753] Missing case (clock == 539440)
>> > > [ 2.790790] WARNING: CPU: 0 PID: 159 at drivers/gpu/drm/i915/display/intel_dpll_mgr.c:2967 icl_get_dplls+0x53a/0xa50 [i915]
>> >
>> > the above warn looks to be due to a missing workaround fixed by
>> >
>> > commit 0e2497e334de42dbaaee8e325241b5b5b34ede7e
>> > Author: Imre Deak <imre.deak@intel.com>
>> > Date: Sat Oct 3 03:18:46 2020 +0300
>> >
>> > drm/i915/tgl: Fix Combo PHY DPLL fractional divider for 38.4MHz ref clock
>> >
>> > in drm-tip. Could you give it a try?
>>
>> I tried -rc2, which contains that commit, and the problem is gone. Thank
>> you!
>
> Thanks for testing it, I'll send a patch for the 5.10 stable tree as
> well.
>
>> There is a different problem, which is that the brightness buttons
>> (on F2 and F3 on this laptop) do not actually increase/decrease the
>> brightness. GNOME pops up a graphic that illustrates it is changing
>> the brightness, but nothing actually changes.
>>
>> xbacklight says "No outputs have backlight property" and using
>> xrandr --output XWAYLAND0 --brightness 0.0001 doesn't change anything
>> (for various different values, not just 0.0001). Using xrandr --prop
>> --verbose shows the reported value of "Brightness" changing, but nothing
>> has changed on the screen.
>>
>> I found
>> /sys/devices/pci0000:00/0000:00:02.0/drm/card0/card0-eDP-1/intel_backlight
>> and tried setting 'brightness' in there to a few different values (100,
>> 2000, 19200, 7000) and also nothing changed.
>>
>> Any thoughts?
>
> One possibility is that from the different backlight methods (DPCD,
> direct PWM on a CPU pin) the driver selects the incorrect one. Could you
> provide a log booting with drm.debug=0x1e adding it to a new ticket at
>
> https://gitlab.freedesktop.org/drm/intel/-/issues/new?issue
>
> or at least in a reply to this thread?
>
> Adding Jani for further ideas.
Please try:
1) i915.enable_dpcd_backlight=1 module param
2) https://cgit.freedesktop.org/drm/drm-tip drm-tip branch with patches
from Lyude on top https://patchwork.freedesktop.org/series/81702/
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-08 17:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-21 4:07 [Intel-gfx] Missing DPPLL case on i7-1165G7 Matthew Wilcox
2020-12-29 14:41 ` Imre Deak
2021-01-05 5:50 ` Matthew Wilcox
2021-01-06 17:25 ` Imre Deak
2021-01-08 17:53 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox