From: Aditya Swarup <aditya.swarup@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [Intel-gfx] [PATCH 3/8] drm/i915/adl_s: Re-use TGL GuC/HuC firmware
Date: Fri, 29 Jan 2021 10:29:40 -0800 [thread overview]
Message-ID: <20210129182945.217078-4-aditya.swarup@intel.com> (raw)
In-Reply-To: <20210129182945.217078-1-aditya.swarup@intel.com>
From: Matt Roper <matthew.d.roper@intel.com>
ADL-S, like RKL, uses the same internal device ID for the GuC and HuC as
TGL did, making them all firmware-compatible. Let's re-use TGL's
firmware for ADL-S.
Bspec: 50668
Cc: John Harrison <John.C.Harrison@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
Reviewed-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
index 67b06fde1225..984fa79e0fa7 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
@@ -44,9 +44,11 @@ void intel_uc_fw_change_status(struct intel_uc_fw *uc_fw,
* List of required GuC and HuC binaries per-platform.
* Must be ordered based on platform + revid, from newer to older.
*
- * Note that RKL uses the same firmware as TGL.
+ * Note that RKL and ADL-S have the same GuC/HuC device ID's and use the same
+ * firmware as TGL.
*/
#define INTEL_UC_FIRMWARE_DEFS(fw_def, guc_def, huc_def) \
+ fw_def(ALDERLAKE_S, 0, guc_def(tgl, 49, 0, 1), huc_def(tgl, 7, 5, 0)) \
fw_def(ROCKETLAKE, 0, guc_def(tgl, 49, 0, 1), huc_def(tgl, 7, 5, 0)) \
fw_def(TIGERLAKE, 0, guc_def(tgl, 49, 0, 1), huc_def(tgl, 7, 5, 0)) \
fw_def(JASPERLAKE, 0, guc_def(ehl, 49, 0, 1), huc_def(ehl, 9, 0, 0)) \
--
2.27.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-29 18:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 18:29 [Intel-gfx] [PATCH 0/8] Final set of patches for ADLS enabling Aditya Swarup
2021-01-29 18:29 ` [Intel-gfx] [PATCH 1/8] drm/i915/adl_s: Update PHY_MISC programming Aditya Swarup
2021-01-29 18:29 ` [Intel-gfx] [PATCH 2/8] drm/i915/adl_s: Add power wells Aditya Swarup
2021-01-29 18:29 ` Aditya Swarup [this message]
2021-01-29 18:29 ` [Intel-gfx] [PATCH 4/8] drm/i915/display: Add HAS_D12_PLANE_MINIMIZATION Aditya Swarup
2021-01-29 18:29 ` [Intel-gfx] [PATCH 5/8] drm/i915/adl_s: Load DMC Aditya Swarup
2021-01-29 18:29 ` [Intel-gfx] [PATCH 6/8] drm/i915/adl_s: Update memory bandwidth parameters Aditya Swarup
2021-01-29 18:29 ` [Intel-gfx] [PATCH 7/8] drm/i915/adl_s: Add display WAs for ADL-S Aditya Swarup
2021-01-29 18:54 ` Souza, Jose
2021-01-29 18:29 ` [Intel-gfx] [PATCH 8/8] drm/i915/adl_s: Add GT and CTX " Aditya Swarup
2021-01-29 19:02 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Final set of patches for ADLS enabling (rev3) Patchwork
2021-01-29 19:04 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-01-29 19:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-30 1:23 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-01-30 17:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Final set of patches for ADLS enabling (rev4) Patchwork
2021-01-30 17:11 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-01-30 17:40 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210129182945.217078-4-aditya.swarup@intel.com \
--to=aditya.swarup@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox