public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v3 2/5] drm/i915/dg2: Add Wa_14010547955
Date: Tue, 16 Nov 2021 09:48:15 -0800	[thread overview]
Message-ID: <20211116174818.2128062-3-matthew.d.roper@intel.com> (raw)
In-Reply-To: <20211116174818.2128062-1-matthew.d.roper@intel.com>

This workaround is documented a bit strangely in the bspec; it's listed
as an A0 workaround, but the description clarifies that the workaround
is implicitly handled by the hardware and what the driver really needs
to do is program a chicken bit to reenable some internal behavior.

Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 4 ++++
 drivers/gpu/drm/i915/i915_reg.h              | 5 +++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 0ceee8ac6671..1639bdbe2091 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -988,6 +988,10 @@ static void icl_set_pipe_chicken(const struct intel_crtc_state *crtc_state)
 	else if (DISPLAY_VER(dev_priv) >= 13)
 		tmp |= UNDERRUN_RECOVERY_DISABLE_ADLP;
 
+	/* Wa_14010547955:dg2 */
+	if (IS_DG2_DISPLAY_STEP(dev_priv, STEP_B0, STEP_FOREVER))
+		tmp |= DG2_RENDER_CCSTAG_4_3_EN;
+
 	intel_de_write(dev_priv, PIPE_CHICKEN(pipe), tmp);
 }
 
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index f15ffc53e858..c187ec122fdb 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -8568,8 +8568,9 @@ enum {
 							   _PIPEB_CHICKEN)
 #define   UNDERRUN_RECOVERY_DISABLE_ADLP	REG_BIT(30)
 #define   UNDERRUN_RECOVERY_ENABLE_DG2		REG_BIT(30)
-#define   PIXEL_ROUNDING_TRUNC_FB_PASSTHRU 	(1 << 15)
-#define   PER_PIXEL_ALPHA_BYPASS_EN		(1 << 7)
+#define   PIXEL_ROUNDING_TRUNC_FB_PASSTHRU	REG_BIT(15)
+#define   DG2_RENDER_CCSTAG_4_3_EN		REG_BIT(12)
+#define   PER_PIXEL_ALPHA_BYPASS_EN		REG_BIT(7)
 
 #define VFLSKPD				_MMIO(0x62a8)
 #define   DIS_OVER_FETCH_CACHE		REG_BIT(1)
-- 
2.33.0


  parent reply	other threads:[~2021-11-16 17:58 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 17:48 [Intel-gfx] [PATCH v3 0/5] i915: Additional DG2 workarounds Matt Roper
2021-11-16 17:48 ` [Intel-gfx] [PATCH v3 1/5] drm/i915/dg2: s/DISP_STEPPING/DISPLAY_STEPPING/ Matt Roper
2021-11-16 19:39   ` Jani Nikula
2021-11-16 17:48 ` Matt Roper [this message]
2021-12-02 22:47   ` [Intel-gfx] [PATCH v3 2/5] drm/i915/dg2: Add Wa_14010547955 Clint Taylor
2021-11-16 17:48 ` [Intel-gfx] [PATCH v3 3/5] drm/i915/dg2: Add Wa_16011777198 Matt Roper
2021-12-02 22:54   ` Clint Taylor
2021-11-16 17:48 ` [Intel-gfx] [PATCH v3 4/5] drm/i915/dg2: Add Wa_16013000631 Matt Roper
2021-12-02 22:57   ` Clint Taylor
2021-11-16 17:48 ` [Intel-gfx] [PATCH v3 5/5] drm/i915/dg2: extend Wa_1409120013 to DG2 Matt Roper
2021-11-17 18:43   ` Ville Syrjälä
2021-11-17 18:51     ` Matt Roper
2021-11-17 19:01       ` Ville Syrjälä
2021-11-17 18:54     ` Ville Syrjälä
2021-11-19 16:36   ` Souza, Jose
2021-11-19 17:11     ` Matt Roper
2021-12-02 23:00   ` Clint Taylor
2021-11-17  1:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: Additional DG2 workarounds (rev3) Patchwork
2021-11-17  1:18 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-11-17  1:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-11-17  4:50 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-12-03  5:49   ` Matt Roper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211116174818.2128062-3-matthew.d.roper@intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox