public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Clint Taylor <Clinton.A.Taylor@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>,
	<intel-gfx@lists.freedesktop.org>
Cc: dri-devel@lists.freedesktop.org, Chris Wilson <chris.p.wilson@intel.com>
Subject: Re: [Intel-gfx] [PATCH v3 4/5] drm/i915/dg2: Add Wa_16013000631
Date: Thu, 2 Dec 2021 14:57:09 -0800	[thread overview]
Message-ID: <d13b149a-dd93-9ad9-4406-4e339c4b9525@intel.com> (raw)
In-Reply-To: <20211116174818.2128062-5-matthew.d.roper@intel.com>

Reviewed-by: Clint Taylor <Clinton.A.Taylor@intel.com>

-Clint


On 11/16/21 9:48 AM, Matt Roper wrote:
> From: Ramalingam C <ramalingam.c@intel.com>
>
> Invalidate IC cache through pipe control command as part of the ctx
> restore flow through indirect ctx pointer.
>
> v2:
>   - Move pipe control from xcs indirect context to the rcs indirect
>     context.  We'll eventually need this on the CCS engines too, but
>     support for those hasn't landed yet.
>
> Cc: Chris Wilson <chris.p.wilson@intel.com>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>   drivers/gpu/drm/i915/gt/intel_lrc.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
> index 56156cf18c41..b3489599e4de 100644
> --- a/drivers/gpu/drm/i915/gt/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
> @@ -1167,6 +1167,11 @@ gen12_emit_indirect_ctx_rcs(const struct intel_context *ce, u32 *cs)
>   	cs = gen12_emit_cmd_buf_wa(ce, cs);
>   	cs = gen12_emit_restore_scratch(ce, cs);
>   
> +	/* Wa_16013000631:dg2 */
> +	if (IS_DG2_GRAPHICS_STEP(ce->engine->i915, G10, STEP_B0, STEP_C0) ||
> +	    IS_DG2_G11(ce->engine->i915))
> +		cs = gen8_emit_pipe_control(cs, PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE, 0);
> +
>   	return cs;
>   }
>   

  reply	other threads:[~2021-12-02 22:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 17:48 [Intel-gfx] [PATCH v3 0/5] i915: Additional DG2 workarounds Matt Roper
2021-11-16 17:48 ` [Intel-gfx] [PATCH v3 1/5] drm/i915/dg2: s/DISP_STEPPING/DISPLAY_STEPPING/ Matt Roper
2021-11-16 19:39   ` Jani Nikula
2021-11-16 17:48 ` [Intel-gfx] [PATCH v3 2/5] drm/i915/dg2: Add Wa_14010547955 Matt Roper
2021-12-02 22:47   ` Clint Taylor
2021-11-16 17:48 ` [Intel-gfx] [PATCH v3 3/5] drm/i915/dg2: Add Wa_16011777198 Matt Roper
2021-12-02 22:54   ` Clint Taylor
2021-11-16 17:48 ` [Intel-gfx] [PATCH v3 4/5] drm/i915/dg2: Add Wa_16013000631 Matt Roper
2021-12-02 22:57   ` Clint Taylor [this message]
2021-11-16 17:48 ` [Intel-gfx] [PATCH v3 5/5] drm/i915/dg2: extend Wa_1409120013 to DG2 Matt Roper
2021-11-17 18:43   ` Ville Syrjälä
2021-11-17 18:51     ` Matt Roper
2021-11-17 19:01       ` Ville Syrjälä
2021-11-17 18:54     ` Ville Syrjälä
2021-11-19 16:36   ` Souza, Jose
2021-11-19 17:11     ` Matt Roper
2021-12-02 23:00   ` Clint Taylor
2021-11-17  1:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: Additional DG2 workarounds (rev3) Patchwork
2021-11-17  1:18 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-11-17  1:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-11-17  4:50 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-12-03  5:49   ` Matt Roper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d13b149a-dd93-9ad9-4406-4e339c4b9525@intel.com \
    --to=clinton.a.taylor@intel.com \
    --cc=chris.p.wilson@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox