Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Christian König" <christian.koenig@amd.com>
Subject: [Intel-gfx] [PATCH v3 15/16] drm/i915/guc: Convert __guc_ads_init to iosys_map
Date: Wed, 16 Feb 2022 09:41:46 -0800	[thread overview]
Message-ID: <20220216174147.3073235-16-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20220216174147.3073235-1-lucas.demarchi@intel.com>

Now that all the called functions from __guc_ads_init() are converted to
use ads_map, stop using ads_blob in __guc_ads_init().

Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 25 ++++++++++++----------
 1 file changed, 14 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c
index 90cbb93a2945..d0593063c0dc 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c
@@ -608,7 +608,6 @@ static void __guc_ads_init(struct intel_guc *guc)
 {
 	struct intel_gt *gt = guc_to_gt(guc);
 	struct drm_i915_private *i915 = gt->i915;
-	struct __guc_ads_blob *blob = guc->ads_blob;
 	struct iosys_map info_map = IOSYS_MAP_INIT_OFFSET(&guc->ads_map,
 			offsetof(struct __guc_ads_blob, system_info));
 	u32 base;
@@ -619,17 +618,18 @@ static void __guc_ads_init(struct intel_guc *guc)
 	/* System info */
 	fill_engine_enable_masks(gt, &info_map);
 
-	blob->system_info.generic_gt_sysinfo[GUC_GENERIC_GT_SYSINFO_SLICE_ENABLED] =
-		hweight8(gt->info.sseu.slice_mask);
-	blob->system_info.generic_gt_sysinfo[GUC_GENERIC_GT_SYSINFO_VDBOX_SFC_SUPPORT_MASK] =
-		gt->info.vdbox_sfc_access;
+	ads_blob_write(guc, system_info.generic_gt_sysinfo[GUC_GENERIC_GT_SYSINFO_SLICE_ENABLED],
+		       hweight8(gt->info.sseu.slice_mask));
+	ads_blob_write(guc, system_info.generic_gt_sysinfo[GUC_GENERIC_GT_SYSINFO_VDBOX_SFC_SUPPORT_MASK],
+		       gt->info.vdbox_sfc_access);
 
 	if (GRAPHICS_VER(i915) >= 12 && !IS_DGFX(i915)) {
 		u32 distdbreg = intel_uncore_read(gt->uncore,
 						  GEN12_DIST_DBS_POPULATED);
-		blob->system_info.generic_gt_sysinfo[GUC_GENERIC_GT_SYSINFO_DOORBELL_COUNT_PER_SQIDI] =
-			((distdbreg >> GEN12_DOORBELLS_PER_SQIDI_SHIFT) &
-			 GEN12_DOORBELLS_PER_SQIDI) + 1;
+		ads_blob_write(guc,
+			       system_info.generic_gt_sysinfo[GUC_GENERIC_GT_SYSINFO_DOORBELL_COUNT_PER_SQIDI],
+			       ((distdbreg >> GEN12_DOORBELLS_PER_SQIDI_SHIFT)
+				& GEN12_DOORBELLS_PER_SQIDI) + 1);
 	}
 
 	/* Golden contexts for re-initialising after a watchdog reset */
@@ -643,14 +643,17 @@ static void __guc_ads_init(struct intel_guc *guc)
 	guc_capture_list_init(guc);
 
 	/* ADS */
-	blob->ads.scheduler_policies = base + ptr_offset(blob, policies);
-	blob->ads.gt_system_info = base + ptr_offset(blob, system_info);
+	ads_blob_write(guc, ads.scheduler_policies, base +
+		       offsetof(struct __guc_ads_blob, policies));
+	ads_blob_write(guc, ads.gt_system_info, base +
+		       offsetof(struct __guc_ads_blob, system_info));
 
 	/* MMIO save/restore list */
 	guc_mmio_reg_state_init(guc);
 
 	/* Private Data */
-	blob->ads.private_data = base + guc_ads_private_data_offset(guc);
+	ads_blob_write(guc, ads.private_data, base +
+		       guc_ads_private_data_offset(guc));
 
 	i915_gem_object_flush_map(guc->ads_vma->obj);
 }
-- 
2.35.1


  parent reply	other threads:[~2022-02-16 17:41 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-16 17:41 [Intel-gfx] [PATCH v3 00/16] drm/i915/guc: Refactor ADS access to use iosys_map Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 01/16] iosys-map: Add offset to iosys_map_memcpy_to() Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 02/16] iosys-map: Add a few more helpers Lucas De Marchi
2022-02-17  8:42   ` Thomas Zimmermann
2022-02-20  4:28     ` Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 03/16] drm/i915/gt: Add helper for shmem copy to iosys_map Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 04/16] drm/i915/guc: Keep iosys_map of ads_blob around Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 05/16] drm/i915/guc: Add read/write helpers for ADS blob Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 06/16] drm/i915/guc: Convert golden context init to iosys_map Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 07/16] drm/i915/guc: Convert policies update " Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 08/16] drm/i915/guc: Convert engine record " Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 09/16] drm/i915/guc: Convert guc_ads_private_data_reset " Lucas De Marchi
2022-02-18 20:36   ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 10/16] drm/i915/guc: Convert golden context prep " Lucas De Marchi
2022-02-18 22:06   ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 11/16] drm/i915/guc: Replace check for golden context size Lucas De Marchi
2022-02-18 20:39   ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 12/16] drm/i915/guc: Convert mapping table to iosys_map Lucas De Marchi
2022-02-18 20:45   ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 13/16] drm/i915/guc: Convert capture list " Lucas De Marchi
2022-02-18 20:50   ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 14/16] drm/i915/guc: Convert guc_mmio_reg_state_init " Lucas De Marchi
2022-02-18 20:56   ` Matthew Brost
2022-02-16 17:41 ` Lucas De Marchi [this message]
2022-02-18 21:07   ` [Intel-gfx] [PATCH v3 15/16] drm/i915/guc: Convert __guc_ads_init " Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 16/16] drm/i915/guc: Remove plain ads_blob pointer Lucas De Marchi
2022-02-18 21:12   ` Matthew Brost
2022-02-17  7:24 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Refactor ADS access to use iosys_map (rev3) Patchwork
2022-02-17  7:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-02-17  7:56 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-02-18 19:44 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Refactor ADS access to use iosys_map (rev4) Patchwork
2022-02-18 19:46 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-02-18 20:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-02-19 12:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-02-19 18:46   ` Lucas De Marchi
2022-02-22 16:50     ` Vudum, Lakshminarayana
2022-02-22 16:46 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220216174147.3073235-16-lucas.demarchi@intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=sumit.semwal@linaro.org \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox