From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
linux-kernel@vger.kernel.org,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Christian König" <christian.koenig@amd.com>
Subject: [Intel-gfx] [PATCH v3 01/16] iosys-map: Add offset to iosys_map_memcpy_to()
Date: Wed, 16 Feb 2022 09:41:32 -0800 [thread overview]
Message-ID: <20220216174147.3073235-2-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20220216174147.3073235-1-lucas.demarchi@intel.com>
In certain situations it's useful to be able to write to an
offset of the mapping. Add a dst_offset to iosys_map_memcpy_to().
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Christian König <christian.koenig@amd.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/drm_cache.c | 2 +-
drivers/gpu/drm/drm_fb_helper.c | 2 +-
include/linux/iosys-map.h | 17 +++++++++--------
3 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c
index 66597e411764..c3e6e615bf09 100644
--- a/drivers/gpu/drm/drm_cache.c
+++ b/drivers/gpu/drm/drm_cache.c
@@ -218,7 +218,7 @@ static void memcpy_fallback(struct iosys_map *dst,
if (!dst->is_iomem && !src->is_iomem) {
memcpy(dst->vaddr, src->vaddr, len);
} else if (!src->is_iomem) {
- iosys_map_memcpy_to(dst, src->vaddr, len);
+ iosys_map_memcpy_to(dst, 0, src->vaddr, len);
} else if (!dst->is_iomem) {
memcpy_fromio(dst->vaddr, src->vaddr_iomem, len);
} else {
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 409d8dd7f868..d265a73313c9 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -385,7 +385,7 @@ static void drm_fb_helper_damage_blit_real(struct drm_fb_helper *fb_helper,
iosys_map_incr(dst, offset); /* go to first pixel within clip rect */
for (y = clip->y1; y < clip->y2; y++) {
- iosys_map_memcpy_to(dst, src, len);
+ iosys_map_memcpy_to(dst, 0, src, len);
iosys_map_incr(dst, fb->pitches[0]);
src += fb->pitches[0];
}
diff --git a/include/linux/iosys-map.h b/include/linux/iosys-map.h
index f4186f91caa6..edd730b1e899 100644
--- a/include/linux/iosys-map.h
+++ b/include/linux/iosys-map.h
@@ -220,22 +220,23 @@ static inline void iosys_map_clear(struct iosys_map *map)
}
/**
- * iosys_map_memcpy_to - Memcpy into iosys mapping
+ * iosys_map_memcpy_to - Memcpy into offset of iosys_map
* @dst: The iosys_map structure
+ * @dst_offset: The offset from which to copy
* @src: The source buffer
* @len: The number of byte in src
*
- * Copies data into a iosys mapping. The source buffer is in system
- * memory. Depending on the buffer's location, the helper picks the correct
- * method of accessing the memory.
+ * Copies data into a iosys_map with an offset. The source buffer is in
+ * system memory. Depending on the buffer's location, the helper picks the
+ * correct method of accessing the memory.
*/
-static inline void iosys_map_memcpy_to(struct iosys_map *dst, const void *src,
- size_t len)
+static inline void iosys_map_memcpy_to(struct iosys_map *dst, size_t dst_offset,
+ const void *src, size_t len)
{
if (dst->is_iomem)
- memcpy_toio(dst->vaddr_iomem, src, len);
+ memcpy_toio(dst->vaddr_iomem + dst_offset, src, len);
else
- memcpy(dst->vaddr, src, len);
+ memcpy(dst->vaddr + dst_offset, src, len);
}
/**
--
2.35.1
next prev parent reply other threads:[~2022-02-16 17:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 17:41 [Intel-gfx] [PATCH v3 00/16] drm/i915/guc: Refactor ADS access to use iosys_map Lucas De Marchi
2022-02-16 17:41 ` Lucas De Marchi [this message]
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 02/16] iosys-map: Add a few more helpers Lucas De Marchi
2022-02-17 8:42 ` Thomas Zimmermann
2022-02-20 4:28 ` Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 03/16] drm/i915/gt: Add helper for shmem copy to iosys_map Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 04/16] drm/i915/guc: Keep iosys_map of ads_blob around Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 05/16] drm/i915/guc: Add read/write helpers for ADS blob Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 06/16] drm/i915/guc: Convert golden context init to iosys_map Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 07/16] drm/i915/guc: Convert policies update " Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 08/16] drm/i915/guc: Convert engine record " Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 09/16] drm/i915/guc: Convert guc_ads_private_data_reset " Lucas De Marchi
2022-02-18 20:36 ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 10/16] drm/i915/guc: Convert golden context prep " Lucas De Marchi
2022-02-18 22:06 ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 11/16] drm/i915/guc: Replace check for golden context size Lucas De Marchi
2022-02-18 20:39 ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 12/16] drm/i915/guc: Convert mapping table to iosys_map Lucas De Marchi
2022-02-18 20:45 ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 13/16] drm/i915/guc: Convert capture list " Lucas De Marchi
2022-02-18 20:50 ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 14/16] drm/i915/guc: Convert guc_mmio_reg_state_init " Lucas De Marchi
2022-02-18 20:56 ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 15/16] drm/i915/guc: Convert __guc_ads_init " Lucas De Marchi
2022-02-18 21:07 ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 16/16] drm/i915/guc: Remove plain ads_blob pointer Lucas De Marchi
2022-02-18 21:12 ` Matthew Brost
2022-02-17 7:24 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Refactor ADS access to use iosys_map (rev3) Patchwork
2022-02-17 7:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-02-17 7:56 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-02-18 19:44 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Refactor ADS access to use iosys_map (rev4) Patchwork
2022-02-18 19:46 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-02-18 20:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-02-19 12:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-02-19 18:46 ` Lucas De Marchi
2022-02-22 16:50 ` Vudum, Lakshminarayana
2022-02-22 16:46 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216174147.3073235-2-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox