From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Christian König" <christian.koenig@amd.com>
Subject: [Intel-gfx] [PATCH v3 07/16] drm/i915/guc: Convert policies update to iosys_map
Date: Wed, 16 Feb 2022 09:41:38 -0800 [thread overview]
Message-ID: <20220216174147.3073235-8-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20220216174147.3073235-1-lucas.demarchi@intel.com>
Use iosys_map to write the policies update so access to IO and system
memory is abstracted away.
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Matt Atwood <matthew.s.atwood@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 41 ++++++++++++----------
1 file changed, 23 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c
index 5c52bee516cf..7906a4df5a53 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c
@@ -130,33 +130,37 @@ static u32 guc_ads_blob_size(struct intel_guc *guc)
guc_ads_private_data_size(guc);
}
-static void guc_policies_init(struct intel_guc *guc, struct guc_policies *policies)
+static void guc_policies_init(struct intel_guc *guc)
{
struct intel_gt *gt = guc_to_gt(guc);
struct drm_i915_private *i915 = gt->i915;
+ u32 global_flags = 0;
- policies->dpc_promote_time = GLOBAL_POLICY_DEFAULT_DPC_PROMOTE_TIME_US;
- policies->max_num_work_items = GLOBAL_POLICY_MAX_NUM_WI;
+ ads_blob_write(guc, policies.dpc_promote_time,
+ GLOBAL_POLICY_DEFAULT_DPC_PROMOTE_TIME_US);
+ ads_blob_write(guc, policies.max_num_work_items,
+ GLOBAL_POLICY_MAX_NUM_WI);
- policies->global_flags = 0;
if (i915->params.reset < 2)
- policies->global_flags |= GLOBAL_POLICY_DISABLE_ENGINE_RESET;
+ global_flags |= GLOBAL_POLICY_DISABLE_ENGINE_RESET;
- policies->is_valid = 1;
+ ads_blob_write(guc, policies.global_flags, global_flags);
+ ads_blob_write(guc, policies.is_valid, 1);
}
void intel_guc_ads_print_policy_info(struct intel_guc *guc,
struct drm_printer *dp)
{
- struct __guc_ads_blob *blob = guc->ads_blob;
-
- if (unlikely(!blob))
+ if (unlikely(iosys_map_is_null(&guc->ads_map)))
return;
drm_printf(dp, "Global scheduling policies:\n");
- drm_printf(dp, " DPC promote time = %u\n", blob->policies.dpc_promote_time);
- drm_printf(dp, " Max num work items = %u\n", blob->policies.max_num_work_items);
- drm_printf(dp, " Flags = %u\n", blob->policies.global_flags);
+ drm_printf(dp, " DPC promote time = %u\n",
+ ads_blob_read(guc, policies.dpc_promote_time));
+ drm_printf(dp, " Max num work items = %u\n",
+ ads_blob_read(guc, policies.max_num_work_items));
+ drm_printf(dp, " Flags = %u\n",
+ ads_blob_read(guc, policies.global_flags));
}
static int guc_action_policies_update(struct intel_guc *guc, u32 policy_offset)
@@ -171,23 +175,24 @@ static int guc_action_policies_update(struct intel_guc *guc, u32 policy_offset)
int intel_guc_global_policies_update(struct intel_guc *guc)
{
- struct __guc_ads_blob *blob = guc->ads_blob;
struct intel_gt *gt = guc_to_gt(guc);
+ u32 scheduler_policies;
intel_wakeref_t wakeref;
int ret;
- if (!blob)
+ if (iosys_map_is_null(&guc->ads_map))
return -EOPNOTSUPP;
- GEM_BUG_ON(!blob->ads.scheduler_policies);
+ scheduler_policies = ads_blob_read(guc, ads.scheduler_policies);
+ GEM_BUG_ON(!scheduler_policies);
- guc_policies_init(guc, &blob->policies);
+ guc_policies_init(guc);
if (!intel_guc_is_ready(guc))
return 0;
with_intel_runtime_pm(>->i915->runtime_pm, wakeref)
- ret = guc_action_policies_update(guc, blob->ads.scheduler_policies);
+ ret = guc_action_policies_update(guc, scheduler_policies);
return ret;
}
@@ -593,7 +598,7 @@ static void __guc_ads_init(struct intel_guc *guc)
u32 base;
/* GuC scheduling policies */
- guc_policies_init(guc, &blob->policies);
+ guc_policies_init(guc);
/* System info */
fill_engine_enable_masks(gt, &blob->system_info);
--
2.35.1
next prev parent reply other threads:[~2022-02-16 17:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 17:41 [Intel-gfx] [PATCH v3 00/16] drm/i915/guc: Refactor ADS access to use iosys_map Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 01/16] iosys-map: Add offset to iosys_map_memcpy_to() Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 02/16] iosys-map: Add a few more helpers Lucas De Marchi
2022-02-17 8:42 ` Thomas Zimmermann
2022-02-20 4:28 ` Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 03/16] drm/i915/gt: Add helper for shmem copy to iosys_map Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 04/16] drm/i915/guc: Keep iosys_map of ads_blob around Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 05/16] drm/i915/guc: Add read/write helpers for ADS blob Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 06/16] drm/i915/guc: Convert golden context init to iosys_map Lucas De Marchi
2022-02-16 17:41 ` Lucas De Marchi [this message]
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 08/16] drm/i915/guc: Convert engine record " Lucas De Marchi
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 09/16] drm/i915/guc: Convert guc_ads_private_data_reset " Lucas De Marchi
2022-02-18 20:36 ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 10/16] drm/i915/guc: Convert golden context prep " Lucas De Marchi
2022-02-18 22:06 ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 11/16] drm/i915/guc: Replace check for golden context size Lucas De Marchi
2022-02-18 20:39 ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 12/16] drm/i915/guc: Convert mapping table to iosys_map Lucas De Marchi
2022-02-18 20:45 ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 13/16] drm/i915/guc: Convert capture list " Lucas De Marchi
2022-02-18 20:50 ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 14/16] drm/i915/guc: Convert guc_mmio_reg_state_init " Lucas De Marchi
2022-02-18 20:56 ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 15/16] drm/i915/guc: Convert __guc_ads_init " Lucas De Marchi
2022-02-18 21:07 ` Matthew Brost
2022-02-16 17:41 ` [Intel-gfx] [PATCH v3 16/16] drm/i915/guc: Remove plain ads_blob pointer Lucas De Marchi
2022-02-18 21:12 ` Matthew Brost
2022-02-17 7:24 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Refactor ADS access to use iosys_map (rev3) Patchwork
2022-02-17 7:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-02-17 7:56 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-02-18 19:44 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Refactor ADS access to use iosys_map (rev4) Patchwork
2022-02-18 19:46 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-02-18 20:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-02-19 12:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-02-19 18:46 ` Lucas De Marchi
2022-02-22 16:50 ` Vudum, Lakshminarayana
2022-02-22 16:46 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216174147.3073235-8-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sumit.semwal@linaro.org \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox