Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 3/4] drm/i915: Remove odd any_ms=true assignment
Date: Thu, 17 Feb 2022 12:32:20 +0200	[thread overview]
Message-ID: <20220217103221.10405-4-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20220217103221.10405-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

For some reason we're flagging that we need to run through the
full modeset calculations (any_ms==true -> do cdclk/etc. checks)
if any crtc got initially flagged for a modeset and is not
enabled via the uapi. No idea why this is here since later on
(after all fastset handling) we do full run through the crtcs
and flag any_ms if anything still needs a full modeset. So let's
just throw out this early weirdo.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 59961621fe4a..61adfcd7cf63 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7628,10 +7628,8 @@ static int intel_atomic_check(struct drm_device *dev,
 		}
 
 		if (!new_crtc_state->uapi.enable) {
-			if (!intel_crtc_is_bigjoiner_slave(new_crtc_state)) {
+			if (!intel_crtc_is_bigjoiner_slave(new_crtc_state))
 				intel_crtc_copy_uapi_to_hw_state_modeset(state, crtc);
-				any_ms = true;
-			}
 			continue;
 		}
 
-- 
2.34.1


  parent reply	other threads:[~2022-02-17 10:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-17 10:32 [Intel-gfx] [PATCH 0/4] drm/i915: Fix disabled crtc state clearing, again Ville Syrjala
2022-02-17 10:32 ` [Intel-gfx] [PATCH 1/4] drm/i915: Dump the crtc hw state always Ville Syrjala
2022-02-22 22:38   ` Navare, Manasi
2022-02-17 10:32 ` [Intel-gfx] [PATCH 2/4] drm/i915: Dump hw.enable and pipe_mode Ville Syrjala
2022-02-22 22:41   ` Navare, Manasi
2022-02-22 22:54   ` Navare, Manasi
2022-02-17 10:32 ` Ville Syrjala [this message]
2022-02-22 22:50   ` [Intel-gfx] [PATCH 3/4] drm/i915: Remove odd any_ms=true assignment Navare, Manasi
2022-02-17 10:32 ` [Intel-gfx] [PATCH 4/4] drm/i915: Properly clear crtc state when disabling it fully, again Ville Syrjala
2022-02-22 23:00   ` Navare, Manasi
2022-02-17 20:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix disabled crtc state clearing, again Patchwork
2022-02-18  7:22 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220217103221.10405-4-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox