Re: [Intel-gfx] [PATCH 3/4] drm/i915: Remove odd any_ms=true assignment

["Navare, Manasi" <manasi.d.navare@intel.com>]

On Thu, Feb 17, 2022 at 12:32:20PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> For some reason we're flagging that we need to run through the
> full modeset calculations (any_ms==true -> do cdclk/etc. checks)
> if any crtc got initially flagged for a modeset and is not
> enabled via the uapi. No idea why this is here since later on
> (after all fastset handling) we do full run through the crtcs
> and flag any_ms if anything still needs a full modeset. So let's
> just throw out this early weirdo.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Hmm yea wonder why that got added here

Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>

Manasi

> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 59961621fe4a..61adfcd7cf63 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -7628,10 +7628,8 @@ static int intel_atomic_check(struct drm_device *dev,
>  		}
>  
>  		if (!new_crtc_state->uapi.enable) {
> -			if (!intel_crtc_is_bigjoiner_slave(new_crtc_state)) {
> +			if (!intel_crtc_is_bigjoiner_slave(new_crtc_state))
>  				intel_crtc_copy_uapi_to_hw_state_modeset(state, crtc);
> -				any_ms = true;
> -			}
>  			continue;
>  		}
>  
> -- 
> 2.34.1
>