Re: [Intel-gfx] [PATCH 1/4] drm/i915: Dump the crtc hw state always

["Navare, Manasi" <manasi.d.navare@intel.com>]

On Thu, Feb 17, 2022 at 12:32:18PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Let's just dump the "full" hw crtc state in debugs so that we can
> see if some stale junk was left behind when the crtc is supposed
> to be entirely off.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

So basically always print the debugfs even for crtcs that are not enabled to catch any stale state?

Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>

Manasi

> ---
>  .../gpu/drm/i915/display/intel_display_debugfs.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index 84be489c3399..f1d78b1c7702 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -923,17 +923,15 @@ static void intel_crtc_info(struct seq_file *m, struct intel_crtc *crtc)
>  		   yesno(crtc_state->uapi.active),
>  		   DRM_MODE_ARG(&crtc_state->uapi.mode));
>  
> -	if (crtc_state->hw.enable) {
> -		seq_printf(m, "\thw: active=%s, adjusted_mode=" DRM_MODE_FMT "\n",
> -			   yesno(crtc_state->hw.active),
> -			   DRM_MODE_ARG(&crtc_state->hw.adjusted_mode));
> +	seq_printf(m, "\thw: active=%s, adjusted_mode=" DRM_MODE_FMT "\n",
> +		   yesno(crtc_state->hw.active),
> +		   DRM_MODE_ARG(&crtc_state->hw.adjusted_mode));
>  
> -		seq_printf(m, "\tpipe src size=%dx%d, dither=%s, bpp=%d\n",
> -			   crtc_state->pipe_src_w, crtc_state->pipe_src_h,
> -			   yesno(crtc_state->dither), crtc_state->pipe_bpp);
> +	seq_printf(m, "\tpipe src size=%dx%d, dither=%s, bpp=%d\n",
> +		   crtc_state->pipe_src_w, crtc_state->pipe_src_h,
> +		   yesno(crtc_state->dither), crtc_state->pipe_bpp);
>  
> -		intel_scaler_info(m, crtc);
> -	}
> +	intel_scaler_info(m, crtc);
>  
>  	if (crtc_state->bigjoiner)
>  		seq_printf(m, "\tLinked to 0x%x pipes as a %s\n",
> -- 
> 2.34.1
>