Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/edid: filter DisplayID v2.0 CTA block in audio detection
@ 2022-03-21  4:43 Cooper Chiou
  2022-03-21  4:59 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
                   ` (13 more replies)
  0 siblings, 14 replies; 20+ messages in thread
From: Cooper Chiou @ 2022-03-21  4:43 UTC (permalink / raw)
  To: intel-gfx; +Cc: Jani Nikula, Cooper Chiou

In DisplayID v2.0 CTS data block 0x81 case, there is no any audio
information definition, but drm_detect_monitor_audio didn't filter
it so that it caused eDP dummy audio card be detected improperly.

We observed this issue on some AUO/BOE eDP panel with DID v2.0 CTA
block, and fix issue by adding filter for edid_ext[0]=DATA_BLOCK_CTA
case.

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Shawn C Lee <shawn.c.lee@intel.com>

Signed-off-by: Cooper Chiou <cooper.chiou@intel.com>
---
 drivers/gpu/drm/drm_edid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index f5f5de362ff2..6c9ae4b130bd 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -4845,7 +4845,7 @@ bool drm_detect_monitor_audio(struct edid *edid)
 	int start_offset, end_offset;
 
 	edid_ext = drm_find_cea_extension(edid);
-	if (!edid_ext)
+	if (!edid_ext || (edid_ext[0] == DATA_BLOCK_CTA))
 		goto end;
 
 	has_audio = ((edid_ext[3] & EDID_BASIC_AUDIO) != 0);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2022-03-24  9:57 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-21  4:43 [Intel-gfx] [PATCH] drm/edid: filter DisplayID v2.0 CTA block in audio detection Cooper Chiou
2022-03-21  4:59 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-03-21  5:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-21  7:13 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-03-21  9:05 ` [Intel-gfx] [PATCH] " Jani Nikula
2022-03-23  5:45 ` [Intel-gfx] [v2] drm/edid: check basic audio support on CEA extension block Lee Shawn C
2022-03-23  9:40   ` Jani Nikula
2022-03-23  5:53 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/edid: filter DisplayID v2.0 CTA block in audio detection (rev2) Patchwork
2022-03-23  6:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-23  9:56 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-03-23 10:03 ` [Intel-gfx] [PATCH] drm/edid: filter DisplayID v2.0 CTA block in audio detection Jani Nikula
2022-03-23 10:31   ` Lee, Shawn C
2022-03-23 10:40     ` Jani Nikula
2022-03-23 13:35       ` Lee, Shawn C
2022-03-24  6:12 ` [Intel-gfx] [v3] drm/edid: check basic audio support on CEA extension block Lee Shawn C
2022-03-24  6:16 ` Lee Shawn C
2022-03-24  9:57   ` Jani Nikula
2022-03-24  6:19 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/edid: filter DisplayID v2.0 CTA block in audio detection (rev4) Patchwork
2022-03-24  6:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-24  7:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox