Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <andrzej.hajda@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Subject: [Intel-gfx] [PATCH v2] drm/1915/guc: enable engine reset on CAT
Date: Wed, 19 Oct 2022 16:54:52 +0200	[thread overview]
Message-ID: <20221019145452.256254-1-andrzej.hajda@intel.com> (raw)
In-Reply-To: <84bec81c-0077-60d7-4d3c-210ad739e42c@intel.com>

In case of catastrophic errors GuC is able to initate engine
reset immediately, instead of waiting for timeout.

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
v2: added GuC version check (John)
---
 drivers/gpu/drm/i915/gt/uc/intel_guc.c      | 3 +++
 drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 1 +
 2 files changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
index 27b09ba1d295fc..9b6f6b9be02874 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
@@ -213,6 +213,9 @@ static u32 guc_ctl_feature_flags(struct intel_guc *guc)
 {
 	u32 flags = 0;
 
+	if (GET_UC_VER(guc) >= MAKE_UC_VER(67, 0, 0))
+		flags = GUC_CTL_ENABLE_ENGINE_RESET_ON_CAT;
+
 	if (!intel_guc_submission_is_used(guc))
 		flags |= GUC_CTL_DISABLE_SCHEDULER;
 
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h b/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h
index e7a7fb450f442a..96f3116e263cdf 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h
@@ -109,6 +109,7 @@
 
 #define GUC_CTL_FEATURE			2
 #define   GUC_CTL_ENABLE_SLPC		BIT(2)
+#define   GUC_CTL_ENABLE_ENGINE_RESET_ON_CAT BIT(8)
 #define   GUC_CTL_DISABLE_SCHEDULER	BIT(14)
 
 #define GUC_CTL_DEBUG			3
-- 
2.34.1


  reply	other threads:[~2022-10-19 14:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-13 16:14 [Intel-gfx] [PATCH] drm/1915/guc: enable engine reset on CAT Andrzej Hajda
2022-10-13 18:07 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2022-10-13 18:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-10-13 21:24 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-10-14 20:21 ` [Intel-gfx] [PATCH] " John Harrison
2022-10-19 14:54   ` Andrzej Hajda [this message]
2022-10-19 17:30 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/1915/guc: enable engine reset on CAT (rev2) Patchwork
2022-10-19 17:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-10-19 23:13 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221019145452.256254-1-andrzej.hajda@intel.com \
    --to=andrzej.hajda@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox