Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/1915/guc: enable engine reset on CAT
@ 2022-10-13 16:14 Andrzej Hajda
  2022-10-13 18:07 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
                   ` (6 more replies)
  0 siblings, 7 replies; 9+ messages in thread
From: Andrzej Hajda @ 2022-10-13 16:14 UTC (permalink / raw)
  To: intel-gfx; +Cc: Andrzej Hajda

In case of catastrophic errors GuC is able to initate engine
reset immediately, instead of waiting for timeout.

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
Hi all,

I am new in the subject, so please be polite if this is mistake.
Tests shows that it allows to save about 7 seconds on the machine
(Raptor Lake) in case of CAT.
I am not aware of scenario in which would be reasonable to keep
the engine in hung state.
On the other side I am not sure if there should not be constraints
on firmware version.

Regards
Andrzej
---
 drivers/gpu/drm/i915/gt/uc/intel_guc.c      | 2 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
index 27b09ba1d295fc..2adcdf13db1911 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
@@ -211,7 +211,7 @@ static u32 guc_ctl_debug_flags(struct intel_guc *guc)
 
 static u32 guc_ctl_feature_flags(struct intel_guc *guc)
 {
-	u32 flags = 0;
+	u32 flags = GUC_CTL_ENABLE_ENGINE_RESET_ON_CAT;
 
 	if (!intel_guc_submission_is_used(guc))
 		flags |= GUC_CTL_DISABLE_SCHEDULER;
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h b/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h
index e7a7fb450f442a..96f3116e263cdf 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h
@@ -109,6 +109,7 @@
 
 #define GUC_CTL_FEATURE			2
 #define   GUC_CTL_ENABLE_SLPC		BIT(2)
+#define   GUC_CTL_ENABLE_ENGINE_RESET_ON_CAT BIT(8)
 #define   GUC_CTL_DISABLE_SCHEDULER	BIT(14)
 
 #define GUC_CTL_DEBUG			3
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-10-19 23:13 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-13 16:14 [Intel-gfx] [PATCH] drm/1915/guc: enable engine reset on CAT Andrzej Hajda
2022-10-13 18:07 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2022-10-13 18:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-10-13 21:24 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-10-14 20:21 ` [Intel-gfx] [PATCH] " John Harrison
2022-10-19 14:54   ` [Intel-gfx] [PATCH v2] " Andrzej Hajda
2022-10-19 17:30 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/1915/guc: enable engine reset on CAT (rev2) Patchwork
2022-10-19 17:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-10-19 23:13 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox