* [Intel-gfx] [PATCH] drm/i915/dsc: Add is_dsc_supported()
@ 2022-11-03 6:02 Swati Sharma
2022-11-03 8:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Swati Sharma @ 2022-11-03 6:02 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Lets use RUNTIME_INFO->has_dsc since platforms supporting dsc has this
flag enabled.
This is done based on the review comments received on
https://patchwork.freedesktop.org/patch/509393/
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 6 +++---
drivers/gpu/drm/i915/display/intel_vdsc.c | 7 ++++++-
drivers/gpu/drm/i915/display/intel_vdsc.h | 2 ++
3 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 7400d6b4c587..eb908da80f2b 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1012,7 +1012,7 @@ intel_dp_mode_valid(struct drm_connector *_connector,
* Output bpp is stored in 6.4 format so right shift by 4 to get the
* integer value since we support only integer values of bpp.
*/
- if (DISPLAY_VER(dev_priv) >= 10 &&
+ if (is_dsc_supported(dev_priv) &&
drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)) {
/*
* TBD pass the connector BPC,
@@ -2906,7 +2906,7 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp)
intel_dp_set_max_sink_lane_count(intel_dp);
/* Read the eDP DSC DPCD registers */
- if (DISPLAY_VER(dev_priv) >= 10)
+ if (is_dsc_supported(dev_priv))
intel_dp_get_dsc_sink_cap(intel_dp);
/*
@@ -4691,7 +4691,7 @@ intel_dp_detect(struct drm_connector *connector,
}
/* Read DP Sink DSC Cap DPCD regs for DP v1.4 */
- if (DISPLAY_VER(dev_priv) >= 11)
+ if (is_dsc_supported(dev_priv))
intel_dp_get_dsc_sink_cap(intel_dp);
intel_dp_configure_mst(intel_dp);
diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
index 269f9792390d..e7c1169538da 100644
--- a/drivers/gpu/drm/i915/display/intel_vdsc.c
+++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
@@ -338,13 +338,18 @@ static const struct rc_parameters *get_rc_params(u16 compressed_bpp,
return &rc_parameters[row_index][column_index];
}
+bool is_dsc_supported(struct drm_i915_private *dev_priv)
+{
+ return RUNTIME_INFO(dev_priv)->has_dsc;
+}
+
bool intel_dsc_source_support(const struct intel_crtc_state *crtc_state)
{
const struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
struct drm_i915_private *i915 = to_i915(crtc->base.dev);
enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
- if (!RUNTIME_INFO(i915)->has_dsc)
+ if (!is_dsc_supported(i915))
return false;
if (DISPLAY_VER(i915) >= 12)
diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.h b/drivers/gpu/drm/i915/display/intel_vdsc.h
index 8763f00fa7e2..049e8b95fdde 100644
--- a/drivers/gpu/drm/i915/display/intel_vdsc.h
+++ b/drivers/gpu/drm/i915/display/intel_vdsc.h
@@ -12,7 +12,9 @@ enum transcoder;
struct intel_crtc;
struct intel_crtc_state;
struct intel_encoder;
+struct drm_i915_private;
+bool is_dsc_supported(struct drm_i915_private *dev_priv);
bool intel_dsc_source_support(const struct intel_crtc_state *crtc_state);
void intel_uncompressed_joiner_enable(const struct intel_crtc_state *crtc_state);
void intel_dsc_enable(const struct intel_crtc_state *crtc_state);
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsc: Add is_dsc_supported()
2022-11-03 6:02 [Intel-gfx] [PATCH] drm/i915/dsc: Add is_dsc_supported() Swati Sharma
@ 2022-11-03 8:07 ` Patchwork
2022-11-03 19:20 ` [Intel-gfx] [PATCH] " Navare, Manasi
2022-11-03 19:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2022-11-03 8:07 UTC (permalink / raw)
To: Swati Sharma; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4856 bytes --]
== Series Details ==
Series: drm/i915/dsc: Add is_dsc_supported()
URL : https://patchwork.freedesktop.org/series/110469/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12333 -> Patchwork_110469v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/index.html
Participating hosts (38 -> 26)
------------------------------
Missing (12): fi-tgl-dsi bat-dg2-8 fi-icl-u2 bat-dg2-9 bat-adlp-6 bat-adlp-4 bat-adln-1 bat-rplp-1 bat-rpls-1 bat-rpls-2 bat-dg2-11 bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_110469v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@basic:
- fi-apl-guc: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#4613]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/fi-apl-guc/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][2] -> [INCOMPLETE][3] ([i915#4785])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-bdw-5557u: [PASS][4] -> [INCOMPLETE][5] ([i915#146])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-apl-guc: NOTRUN -> [SKIP][6] ([fdo#109271] / [fdo#111827]) +8 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/fi-apl-guc/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_force_connector_basic@force-connector-state:
- fi-apl-guc: NOTRUN -> [SKIP][7] ([fdo#109271]) +11 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/fi-apl-guc/igt@kms_force_connector_basic@force-connector-state.html
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][8] ([fdo#109271] / [i915#4312] / [i915#5594])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/fi-hsw-4770/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- {fi-tgl-mst}: [DMESG-WARN][9] ([i915#6434]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/fi-tgl-mst/igt@gem_ctx_create@basic-files.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/fi-tgl-mst/igt@gem_ctx_create@basic-files.html
* igt@gem_render_tiled_blits@basic:
- fi-apl-guc: [INCOMPLETE][11] -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/fi-apl-guc/igt@gem_render_tiled_blits@basic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/fi-apl-guc/igt@gem_render_tiled_blits@basic.html
#### Warnings ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [FAIL][13] ([i915#7229]) -> [SKIP][14] ([fdo#109271])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
Build changes
-------------
* Linux: CI_DRM_12333 -> Patchwork_110469v1
CI-20190529: 20190529
CI_DRM_12333: e7d1d39c197e7f06cf4d1ee19cfd467d6b68e10e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7038: 5389b3f3b9b75df6bd8506e4aa3da357fd0c0ab1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_110469v1: e7d1d39c197e7f06cf4d1ee19cfd467d6b68e10e @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
07b5231d4ede drm/i915/dsc: Add is_dsc_supported()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/index.html
[-- Attachment #2: Type: text/html, Size: 5946 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dsc: Add is_dsc_supported()
2022-11-03 6:02 [Intel-gfx] [PATCH] drm/i915/dsc: Add is_dsc_supported() Swati Sharma
2022-11-03 8:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2022-11-03 19:20 ` Navare, Manasi
2022-11-04 10:28 ` Jani Nikula
2022-11-03 19:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Navare, Manasi @ 2022-11-03 19:20 UTC (permalink / raw)
To: Swati Sharma; +Cc: jani.nikula, intel-gfx
On Thu, Nov 03, 2022 at 11:32:22AM +0530, Swati Sharma wrote:
> Lets use RUNTIME_INFO->has_dsc since platforms supporting dsc has this
> flag enabled.
>
> This is done based on the review comments received on
> https://patchwork.freedesktop.org/patch/509393/
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 6 +++---
> drivers/gpu/drm/i915/display/intel_vdsc.c | 7 ++++++-
> drivers/gpu/drm/i915/display/intel_vdsc.h | 2 ++
> 3 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 7400d6b4c587..eb908da80f2b 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1012,7 +1012,7 @@ intel_dp_mode_valid(struct drm_connector *_connector,
> * Output bpp is stored in 6.4 format so right shift by 4 to get the
> * integer value since we support only integer values of bpp.
> */
> - if (DISPLAY_VER(dev_priv) >= 10 &&
> + if (is_dsc_supported(dev_priv) &&
> drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)) {
> /*
> * TBD pass the connector BPC,
> @@ -2906,7 +2906,7 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp)
> intel_dp_set_max_sink_lane_count(intel_dp);
>
> /* Read the eDP DSC DPCD registers */
> - if (DISPLAY_VER(dev_priv) >= 10)
> + if (is_dsc_supported(dev_priv))
> intel_dp_get_dsc_sink_cap(intel_dp);
>
> /*
> @@ -4691,7 +4691,7 @@ intel_dp_detect(struct drm_connector *connector,
> }
>
> /* Read DP Sink DSC Cap DPCD regs for DP v1.4 */
> - if (DISPLAY_VER(dev_priv) >= 11)
> + if (is_dsc_supported(dev_priv))
> intel_dp_get_dsc_sink_cap(intel_dp);
>
> intel_dp_configure_mst(intel_dp);
> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
> index 269f9792390d..e7c1169538da 100644
> --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
> @@ -338,13 +338,18 @@ static const struct rc_parameters *get_rc_params(u16 compressed_bpp,
> return &rc_parameters[row_index][column_index];
> }
>
> +bool is_dsc_supported(struct drm_i915_private *dev_priv)
> +{
> + return RUNTIME_INFO(dev_priv)->has_dsc;
> +}
> +
> bool intel_dsc_source_support(const struct intel_crtc_state *crtc_state)
> {
> const struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
> struct drm_i915_private *i915 = to_i915(crtc->base.dev);
> enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
>
> - if (!RUNTIME_INFO(i915)->has_dsc)
> + if (!is_dsc_supported(i915))
> return false;
>
> if (DISPLAY_VER(i915) >= 12)
In Runtime info, Gen 12 should have Gen 11 runtime has dsc set, so makes
this check here redundant.
Manasi
> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.h b/drivers/gpu/drm/i915/display/intel_vdsc.h
> index 8763f00fa7e2..049e8b95fdde 100644
> --- a/drivers/gpu/drm/i915/display/intel_vdsc.h
> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.h
> @@ -12,7 +12,9 @@ enum transcoder;
> struct intel_crtc;
> struct intel_crtc_state;
> struct intel_encoder;
> +struct drm_i915_private;
>
> +bool is_dsc_supported(struct drm_i915_private *dev_priv);
> bool intel_dsc_source_support(const struct intel_crtc_state *crtc_state);
> void intel_uncompressed_joiner_enable(const struct intel_crtc_state *crtc_state);
> void intel_dsc_enable(const struct intel_crtc_state *crtc_state);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dsc: Add is_dsc_supported()
2022-11-03 6:02 [Intel-gfx] [PATCH] drm/i915/dsc: Add is_dsc_supported() Swati Sharma
2022-11-03 8:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-11-03 19:20 ` [Intel-gfx] [PATCH] " Navare, Manasi
@ 2022-11-03 19:26 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2022-11-03 19:26 UTC (permalink / raw)
To: Swati Sharma; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 35368 bytes --]
== Series Details ==
Series: drm/i915/dsc: Add is_dsc_supported()
URL : https://patchwork.freedesktop.org/series/110469/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12333_full -> Patchwork_110469v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_110469v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_110469v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_110469v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_cursor_legacy@cursor-vs-flip@toggle:
- shard-skl: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-skl4/igt@kms_cursor_legacy@cursor-vs-flip@toggle.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-skl1/igt@kms_cursor_legacy@cursor-vs-flip@toggle.html
#### Warnings ####
* igt@gem_tiled_swapping@non-threaded:
- shard-skl: [SKIP][3] ([fdo#109271]) -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-skl4/igt@gem_tiled_swapping@non-threaded.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-skl1/igt@gem_tiled_swapping@non-threaded.html
Known issues
------------
Here are the changes found in Patchwork_110469v1_full that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- shard-apl: ([PASS][5], [PASS][6], [PASS][7], [FAIL][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29]) ([i915#4386]) -> ([PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl1/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl1/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl1/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl1/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl1/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl1/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl2/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl2/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl2/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl2/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl3/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl3/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl3/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl6/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl6/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl6/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl7/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl7/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl7/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl7/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl8/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl8/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl8/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl8/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl8/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl1/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl1/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl1/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl1/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl1/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl2/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl7/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl2/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl2/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl2/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl2/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl3/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl3/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl3/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl6/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl6/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl6/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl8/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl8/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl6/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl8/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl7/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl7/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl7/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl7/boot.html
### IGT changes ###
#### Issues hit ####
* igt@fbdev@read:
- shard-apl: NOTRUN -> [FAIL][55] ([i915#6724])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl6/igt@fbdev@read.html
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [PASS][56] -> [SKIP][57] ([i915#4525]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb2/igt@gem_exec_balancer@parallel-keep-in-fence.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb8/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][58] -> [FAIL][59] ([i915#2846])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk8/igt@gem_exec_fair@basic-deadline.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-glk1/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][60] -> [FAIL][61] ([i915#2842])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl8/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-glk: NOTRUN -> [FAIL][62] ([i915#2842])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-glk8/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][63] ([i915#2842])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb1/igt@gem_exec_fair@basic-none@vcs1.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][64] -> [FAIL][65] ([i915#2842])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-tglb: [PASS][66] -> [FAIL][67] ([i915#2842])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-tglb7/igt@gem_exec_fair@basic-throttle@rcs0.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-tglb8/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_lmem_swapping@heavy-multi:
- shard-apl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#4613])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl8/igt@gem_lmem_swapping@heavy-multi.html
* igt@gem_lmem_swapping@random-engines:
- shard-iclb: NOTRUN -> [SKIP][69] ([i915#4613])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@gem_lmem_swapping@random-engines.html
* igt@gem_lmem_swapping@verify-random:
- shard-skl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#4613]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-skl7/igt@gem_lmem_swapping@verify-random.html
* igt@gem_media_vme:
- shard-tglb: NOTRUN -> [SKIP][71] ([i915#284])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-tglb3/igt@gem_media_vme.html
* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [INCOMPLETE][72] ([i915#7248])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl8/igt@gem_pread@exhaustion.html
- shard-skl: NOTRUN -> [INCOMPLETE][73] ([i915#7248])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-skl7/igt@gem_pread@exhaustion.html
* igt@gem_userptr_blits@input-checking:
- shard-iclb: NOTRUN -> [DMESG-WARN][74] ([i915#4991])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@gem_userptr_blits@input-checking.html
* igt@gen7_exec_parse@basic-offset:
- shard-tglb: NOTRUN -> [SKIP][75] ([fdo#109289])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-tglb3/igt@gen7_exec_parse@basic-offset.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [PASS][76] -> [DMESG-WARN][77] ([i915#5566] / [i915#716])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl6/igt@gen9_exec_parse@allowed-single.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl7/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][78] -> [FAIL][79] ([i915#3989] / [i915#454])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb1/igt@i915_pm_dc@dc6-psr.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_sseu@full-enable:
- shard-iclb: NOTRUN -> [SKIP][80] ([i915#4387])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@i915_pm_sseu@full-enable.html
* igt@kms_big_fb@4-tiled-16bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][81] ([i915#5286])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-tglb3/igt@kms_big_fb@4-tiled-16bpp-rotate-270.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [SKIP][82] ([fdo#109271]) +25 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-skl7/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-4_tiled_dg2_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][83] ([i915#6095])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-tglb3/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-4_tiled_dg2_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#3886]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-glk8/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#3886]) +5 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl6/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@dp-frame-dump:
- shard-apl: NOTRUN -> [SKIP][86] ([fdo#109271] / [fdo#111827]) +3 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl6/igt@kms_chamelium@dp-frame-dump.html
* igt@kms_chamelium@dp-hpd:
- shard-glk: NOTRUN -> [SKIP][87] ([fdo#109271] / [fdo#111827]) +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-glk8/igt@kms_chamelium@dp-hpd.html
* igt@kms_chamelium@hdmi-crc-single:
- shard-skl: NOTRUN -> [SKIP][88] ([fdo#109271] / [fdo#111827])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-skl7/igt@kms_chamelium@hdmi-crc-single.html
* igt@kms_chamelium@hdmi-hpd-for-each-pipe:
- shard-iclb: NOTRUN -> [SKIP][89] ([fdo#109284] / [fdo#111827])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@kms_chamelium@hdmi-hpd-for-each-pipe.html
* igt@kms_cursor_crc@cursor-onscreen-32x10:
- shard-tglb: NOTRUN -> [SKIP][90] ([i915#3555])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-tglb3/igt@kms_cursor_crc@cursor-onscreen-32x10.html
* igt@kms_cursor_legacy@flip-vs-cursor@toggle:
- shard-iclb: [PASS][91] -> [FAIL][92] ([i915#2346])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor@toggle.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor@toggle.html
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-iclb: NOTRUN -> [SKIP][93] ([fdo#109274])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@kms_flip@2x-flip-vs-expired-vblank.html
* igt@kms_flip@2x-flip-vs-panning-interruptible:
- shard-tglb: NOTRUN -> [SKIP][94] ([fdo#109274] / [fdo#111825] / [i915#3637])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-tglb3/igt@kms_flip@2x-flip-vs-panning-interruptible.html
* igt@kms_flip@flip-vs-absolute-wf_vblank@b-edp1:
- shard-skl: [PASS][95] -> [FAIL][96] ([i915#2122])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-skl1/igt@kms_flip@flip-vs-absolute-wf_vblank@b-edp1.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-skl9/igt@kms_flip@flip-vs-absolute-wf_vblank@b-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][97] -> [FAIL][98] ([i915#79])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1:
- shard-glk: [PASS][99] -> [FAIL][100] ([i915#79])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][101] ([i915#2672])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][102] -> [SKIP][103] ([i915#3555])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][104] ([i915#3555])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][105] ([i915#2587] / [i915#2672]) +2 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb8/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-upscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-apl: NOTRUN -> [SKIP][106] ([fdo#109271]) +69 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-wc:
- shard-tglb: NOTRUN -> [SKIP][107] ([fdo#109280] / [fdo#111825]) +3 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-1p-pri-indfb-multidraw:
- shard-glk: NOTRUN -> [SKIP][108] ([fdo#109271]) +20 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-glk8/igt@kms_frontbuffer_tracking@psr-1p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render:
- shard-iclb: NOTRUN -> [SKIP][109] ([fdo#109280]) +4 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1:
- shard-iclb: [PASS][110] -> [SKIP][111] ([i915#5176]) +2 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb3/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-5@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [SKIP][112] ([i915#5176]) +2 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-5@pipe-b-edp-1.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [SKIP][113] ([i915#5235]) +2 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-iclb: NOTRUN -> [SKIP][114] ([i915#2920])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-glk: NOTRUN -> [SKIP][115] ([fdo#109271] / [i915#658]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-glk8/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@kms_psr2_su@page_flip-nv12@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [FAIL][116] ([i915#5939]) +2 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@kms_psr2_su@page_flip-nv12@pipe-b-edp-1.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][117] -> [SKIP][118] ([fdo#109441]) +2 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb8/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-tglb: [PASS][119] -> [SKIP][120] ([i915#5519])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-tglb6/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-tglb1/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
- shard-iclb: [PASS][121] -> [SKIP][122] ([i915#5519])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb6/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb7/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
* igt@prime_vgem@fence-write-hang:
- shard-tglb: NOTRUN -> [SKIP][123] ([fdo#109295])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-tglb3/igt@prime_vgem@fence-write-hang.html
* igt@sysfs_clients@split-10:
- shard-skl: NOTRUN -> [SKIP][124] ([fdo#109271] / [i915#2994])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-skl7/igt@sysfs_clients@split-10.html
* igt@sysfs_clients@split-25:
- shard-apl: NOTRUN -> [SKIP][125] ([fdo#109271] / [i915#2994])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl6/igt@sysfs_clients@split-25.html
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][126] ([i915#658]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb3/igt@feature_discovery@psr2.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: [FAIL][128] ([i915#6268]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-tglb2/igt@gem_ctx_exec@basic-nohangcheck.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-tglb8/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [SKIP][130] ([i915#4525]) -> [PASS][131] +1 similar issue
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb3/igt@gem_exec_balancer@parallel-bb-first.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb1/igt@gem_exec_balancer@parallel-bb-first.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [FAIL][132] ([i915#2842]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk3/igt@gem_exec_fair@basic-none@vcs0.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-glk8/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][134] ([i915#2842]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-tglb6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [DMESG-WARN][136] ([i915#5566] / [i915#716]) -> [PASS][137]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk2/igt@gen9_exec_parse@allowed-single.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-glk8/igt@gen9_exec_parse@allowed-single.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-apl: [DMESG-FAIL][138] ([i915#5334]) -> [PASS][139]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl2/igt@i915_selftest@live@gt_heartbeat.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl1/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][140] ([i915#2346]) -> [PASS][141] +1 similar issue
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_dp_aux_dev:
- shard-iclb: [DMESG-WARN][142] ([i915#4391]) -> [PASS][143]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb7/igt@kms_dp_aux_dev.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@kms_dp_aux_dev.html
* igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1:
- shard-skl: [FAIL][144] ([i915#2122]) -> [PASS][145] +1 similar issue
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-skl10/igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-skl10/igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-tglb: [INCOMPLETE][146] -> [PASS][147]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen.html
* igt@kms_plane_lowres@tiling-y@pipe-a-hdmi-a-1:
- shard-glk: [DMESG-FAIL][148] ([i915#118]) -> [PASS][149]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-glk6/igt@kms_plane_lowres@tiling-y@pipe-a-hdmi-a-1.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-glk3/igt@kms_plane_lowres@tiling-y@pipe-a-hdmi-a-1.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][150] ([fdo#109441]) -> [PASS][151] +1 similar issue
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb3/igt@kms_psr@psr2_cursor_blt.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][152] ([i915#180]) -> [PASS][153] +1 similar issue
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl8/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl8/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
- shard-skl: [INCOMPLETE][154] ([i915#7404]) -> [PASS][155]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-skl10/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-skl7/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
#### Warnings ####
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [SKIP][156] ([i915#4525]) -> [FAIL][157] ([i915#6117])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb7/igt@gem_exec_balancer@parallel-ordering.html
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@gem_exec_balancer@parallel-ordering.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][158] ([i915#658]) -> [SKIP][159] ([i915#588])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb3/igt@i915_pm_dc@dc3co-vpb-simulation.html
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_rc6_residency@rc6-idle@bcs0:
- shard-iclb: [WARN][160] ([i915#2684]) -> [FAIL][161] ([i915#2684])
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb8/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][162] ([i915#658]) -> [SKIP][163] ([i915#2920])
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-iclb7/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html
* igt@runner@aborted:
- shard-apl: ([FAIL][164], [FAIL][165], [FAIL][166], [FAIL][167]) ([i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][168], [FAIL][169], [FAIL][170]) ([fdo#109271] / [i915#3002] / [i915#4312])
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl7/igt@runner@aborted.html
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl1/igt@runner@aborted.html
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl8/igt@runner@aborted.html
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/shard-apl3/igt@runner@aborted.html
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl7/igt@runner@aborted.html
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl7/igt@runner@aborted.html
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/shard-apl2/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4386]: https://gitlab.freedesktop.org/drm/intel/issues/4386
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6724]: https://gitlab.freedesktop.org/drm/intel/issues/6724
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248
[i915#7404]: https://gitlab.freedesktop.org/drm/intel/issues/7404
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12333 -> Patchwork_110469v1
CI-20190529: 20190529
CI_DRM_12333: e7d1d39c197e7f06cf4d1ee19cfd467d6b68e10e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7038: 5389b3f3b9b75df6bd8506e4aa3da357fd0c0ab1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_110469v1: e7d1d39c197e7f06cf4d1ee19cfd467d6b68e10e @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110469v1/index.html
[-- Attachment #2: Type: text/html, Size: 41715 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dsc: Add is_dsc_supported()
2022-11-03 19:20 ` [Intel-gfx] [PATCH] " Navare, Manasi
@ 2022-11-04 10:28 ` Jani Nikula
2022-11-10 9:32 ` Swati Sharma
0 siblings, 1 reply; 6+ messages in thread
From: Jani Nikula @ 2022-11-04 10:28 UTC (permalink / raw)
To: Navare, Manasi, Swati Sharma; +Cc: intel-gfx
On Thu, 03 Nov 2022, "Navare, Manasi" <manasi.d.navare@intel.com> wrote:
> On Thu, Nov 03, 2022 at 11:32:22AM +0530, Swati Sharma wrote:
>> Lets use RUNTIME_INFO->has_dsc since platforms supporting dsc has this
>> flag enabled.
>>
>> This is done based on the review comments received on
>> https://patchwork.freedesktop.org/patch/509393/
I don't think that's necessary. If it were an idea worth crediting, the
usual way is using Suggested-by: tag.
>>
>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_dp.c | 6 +++---
>> drivers/gpu/drm/i915/display/intel_vdsc.c | 7 ++++++-
>> drivers/gpu/drm/i915/display/intel_vdsc.h | 2 ++
>> 3 files changed, 11 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>> index 7400d6b4c587..eb908da80f2b 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>> @@ -1012,7 +1012,7 @@ intel_dp_mode_valid(struct drm_connector *_connector,
>> * Output bpp is stored in 6.4 format so right shift by 4 to get the
>> * integer value since we support only integer values of bpp.
>> */
>> - if (DISPLAY_VER(dev_priv) >= 10 &&
>> + if (is_dsc_supported(dev_priv) &&
>> drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)) {
>> /*
>> * TBD pass the connector BPC,
>> @@ -2906,7 +2906,7 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp)
>> intel_dp_set_max_sink_lane_count(intel_dp);
>>
>> /* Read the eDP DSC DPCD registers */
>> - if (DISPLAY_VER(dev_priv) >= 10)
>> + if (is_dsc_supported(dev_priv))
>> intel_dp_get_dsc_sink_cap(intel_dp);
>>
>> /*
>> @@ -4691,7 +4691,7 @@ intel_dp_detect(struct drm_connector *connector,
>> }
>>
>> /* Read DP Sink DSC Cap DPCD regs for DP v1.4 */
>> - if (DISPLAY_VER(dev_priv) >= 11)
>> + if (is_dsc_supported(dev_priv))
>> intel_dp_get_dsc_sink_cap(intel_dp);
>>
>> intel_dp_configure_mst(intel_dp);
>> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
>> index 269f9792390d..e7c1169538da 100644
>> --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
>> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
>> @@ -338,13 +338,18 @@ static const struct rc_parameters *get_rc_params(u16 compressed_bpp,
>> return &rc_parameters[row_index][column_index];
>> }
>>
>> +bool is_dsc_supported(struct drm_i915_private *dev_priv)
>> +{
>> + return RUNTIME_INFO(dev_priv)->has_dsc;
>> +}
>> +
All of the wrappers to runtime/device info members are of the form:
#define HAS_DSC(__i915) (RUNTIME_INFO(__i915)->has_dsc)
in i915_drv.h.
>> bool intel_dsc_source_support(const struct intel_crtc_state *crtc_state)
>> {
>> const struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
>> struct drm_i915_private *i915 = to_i915(crtc->base.dev);
>> enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
>>
>> - if (!RUNTIME_INFO(i915)->has_dsc)
>> + if (!is_dsc_supported(i915))
>> return false;
>>
>> if (DISPLAY_VER(i915) >= 12)
>
> In Runtime info, Gen 12 should have Gen 11 runtime has dsc set, so makes
> this check here redundant.
As it is, it's not redundant. It's tied to the transcoder check.
But this could be simplified as:
if (!HAS_DSC(i915))
return false;
if (DISPLAY_VER(i915) == 11 && cpu_transcoder == TRANSCODER_A)
return false;
return true;
It could be condenced even further, but at the const of losing clarity.
BR,
Jani.
>
> Manasi
>
>> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.h b/drivers/gpu/drm/i915/display/intel_vdsc.h
>> index 8763f00fa7e2..049e8b95fdde 100644
>> --- a/drivers/gpu/drm/i915/display/intel_vdsc.h
>> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.h
>> @@ -12,7 +12,9 @@ enum transcoder;
>> struct intel_crtc;
>> struct intel_crtc_state;
>> struct intel_encoder;
>> +struct drm_i915_private;
>>
>> +bool is_dsc_supported(struct drm_i915_private *dev_priv);
>> bool intel_dsc_source_support(const struct intel_crtc_state *crtc_state);
>> void intel_uncompressed_joiner_enable(const struct intel_crtc_state *crtc_state);
>> void intel_dsc_enable(const struct intel_crtc_state *crtc_state);
>> --
>> 2.25.1
>>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dsc: Add is_dsc_supported()
2022-11-04 10:28 ` Jani Nikula
@ 2022-11-10 9:32 ` Swati Sharma
0 siblings, 0 replies; 6+ messages in thread
From: Swati Sharma @ 2022-11-10 9:32 UTC (permalink / raw)
To: Jani Nikula, Navare, Manasi; +Cc: intel-gfx
Thanks Jani/Manasi for the review comments.
Have addressed those in https://patchwork.freedesktop.org/patch/511033/
On 04-Nov-22 3:58 PM, Jani Nikula wrote:
> On Thu, 03 Nov 2022, "Navare, Manasi" <manasi.d.navare@intel.com> wrote:
>> On Thu, Nov 03, 2022 at 11:32:22AM +0530, Swati Sharma wrote:
>>> Lets use RUNTIME_INFO->has_dsc since platforms supporting dsc has this
>>> flag enabled.
>>>
>>> This is done based on the review comments received on
>>> https://patchwork.freedesktop.org/patch/509393/
>
> I don't think that's necessary. If it were an idea worth crediting, the
> usual way is using Suggested-by: tag.
>
>>>
>>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/display/intel_dp.c | 6 +++---
>>> drivers/gpu/drm/i915/display/intel_vdsc.c | 7 ++++++-
>>> drivers/gpu/drm/i915/display/intel_vdsc.h | 2 ++
>>> 3 files changed, 11 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>>> index 7400d6b4c587..eb908da80f2b 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>>> @@ -1012,7 +1012,7 @@ intel_dp_mode_valid(struct drm_connector *_connector,
>>> * Output bpp is stored in 6.4 format so right shift by 4 to get the
>>> * integer value since we support only integer values of bpp.
>>> */
>>> - if (DISPLAY_VER(dev_priv) >= 10 &&
>>> + if (is_dsc_supported(dev_priv) &&
>>> drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd)) {
>>> /*
>>> * TBD pass the connector BPC,
>>> @@ -2906,7 +2906,7 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp)
>>> intel_dp_set_max_sink_lane_count(intel_dp);
>>>
>>> /* Read the eDP DSC DPCD registers */
>>> - if (DISPLAY_VER(dev_priv) >= 10)
>>> + if (is_dsc_supported(dev_priv))
>>> intel_dp_get_dsc_sink_cap(intel_dp);
>>>
>>> /*
>>> @@ -4691,7 +4691,7 @@ intel_dp_detect(struct drm_connector *connector,
>>> }
>>>
>>> /* Read DP Sink DSC Cap DPCD regs for DP v1.4 */
>>> - if (DISPLAY_VER(dev_priv) >= 11)
>>> + if (is_dsc_supported(dev_priv))
>>> intel_dp_get_dsc_sink_cap(intel_dp);
>>>
>>> intel_dp_configure_mst(intel_dp);
>>> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
>>> index 269f9792390d..e7c1169538da 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
>>> @@ -338,13 +338,18 @@ static const struct rc_parameters *get_rc_params(u16 compressed_bpp,
>>> return &rc_parameters[row_index][column_index];
>>> }
>>>
>>> +bool is_dsc_supported(struct drm_i915_private *dev_priv)
>>> +{
>>> + return RUNTIME_INFO(dev_priv)->has_dsc;
>>> +}
>>> +
>
> All of the wrappers to runtime/device info members are of the form:
>
> #define HAS_DSC(__i915) (RUNTIME_INFO(__i915)->has_dsc)
>
> in i915_drv.h.
>
>>> bool intel_dsc_source_support(const struct intel_crtc_state *crtc_state)
>>> {
>>> const struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
>>> struct drm_i915_private *i915 = to_i915(crtc->base.dev);
>>> enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
>>>
>>> - if (!RUNTIME_INFO(i915)->has_dsc)
>>> + if (!is_dsc_supported(i915))
>>> return false;
>>>
>>> if (DISPLAY_VER(i915) >= 12)
>>
>> In Runtime info, Gen 12 should have Gen 11 runtime has dsc set, so makes
>> this check here redundant.
>
> As it is, it's not redundant. It's tied to the transcoder check.
>
> But this could be simplified as:
>
> if (!HAS_DSC(i915))
> return false;
>
> if (DISPLAY_VER(i915) == 11 && cpu_transcoder == TRANSCODER_A)
> return false;
>
> return true;
>
> It could be condenced even further, but at the const of losing clarity.
>
> BR,
> Jani.
>
>
>>
>> Manasi
>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.h b/drivers/gpu/drm/i915/display/intel_vdsc.h
>>> index 8763f00fa7e2..049e8b95fdde 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_vdsc.h
>>> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.h
>>> @@ -12,7 +12,9 @@ enum transcoder;
>>> struct intel_crtc;
>>> struct intel_crtc_state;
>>> struct intel_encoder;
>>> +struct drm_i915_private;
>>>
>>> +bool is_dsc_supported(struct drm_i915_private *dev_priv);
>>> bool intel_dsc_source_support(const struct intel_crtc_state *crtc_state);
>>> void intel_uncompressed_joiner_enable(const struct intel_crtc_state *crtc_state);
>>> void intel_dsc_enable(const struct intel_crtc_state *crtc_state);
>>> --
>>> 2.25.1
>>>
>
--
~Swati Sharma
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-10 9:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-03 6:02 [Intel-gfx] [PATCH] drm/i915/dsc: Add is_dsc_supported() Swati Sharma
2022-11-03 8:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-11-03 19:20 ` [Intel-gfx] [PATCH] " Navare, Manasi
2022-11-04 10:28 ` Jani Nikula
2022-11-10 9:32 ` Swati Sharma
2022-11-03 19:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox