From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>
Subject: [Intel-gfx] [PATCH v2 0/9] drm/i915/tgl+: Enable DC power states on all eDP ports
Date: Mon, 7 Nov 2022 19:09:08 +0200 [thread overview]
Message-ID: <20221107170917.3566758-1-imre.deak@intel.com> (raw)
This is v2 of [1] addressing the review comments from Ville and Jani:
- Select the AUX power domain based on PSR capability instead of is_edp().
- Split out change using AUX vs AUX_IO on port A without PSR.
- Don't enable AUX_IO on eDP w/o PSR and external DP combo PHY ports.
- Simplify intel_display_power_(get/put)_in_set().
[1] https://lore.kernel.org/intel-gfx/20221102171530.3261282-1-imre.deak@intel.com/T/#t
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Imre Deak (9):
drm/i915: Allocate power domain set wakerefs dynamically
drm/i915: Move the POWER_DOMAIN_AUX_IO_A definition to its logical
place
drm/i915: Use the AUX_IO power domain only for eDP/PSR port
drm/i915/tgl+: Enable display DC power states on all eDP ports
drm/i915: Add missing AUX_IO_A power domain->well mappings
drm/i915: Add missing DC_OFF power domain->well mappings
drm/i915: Factor out function to get/put AUX_IO power for main link
drm/i915: Don't enable the AUX_IO power for combo-PHY external DP port
main links
drm/i915/mtl+: Don't enable the AUX_IO power for non-eDP port main
links
drivers/gpu/drm/i915/display/intel_crtc.c | 4 +
drivers/gpu/drm/i915/display/intel_ddi.c | 89 +++++++-----
.../drm/i915/display/intel_display_power.c | 129 ++++++++++++++----
.../drm/i915/display/intel_display_power.h | 14 +-
.../i915/display/intel_display_power_map.c | 69 ++++++++--
5 files changed, 237 insertions(+), 68 deletions(-)
--
2.37.1
next reply other threads:[~2022-11-07 17:23 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 17:09 Imre Deak [this message]
2022-11-07 17:09 ` [Intel-gfx] [PATCH v2 1/9] drm/i915: Allocate power domain set wakerefs dynamically Imre Deak
2022-11-08 8:54 ` Jani Nikula
2022-11-08 13:45 ` Imre Deak
2022-11-08 15:18 ` [Intel-gfx] [PATCH v3 " Imre Deak
2022-11-10 19:11 ` Ville Syrjälä
2022-11-10 19:55 ` Imre Deak
2022-11-10 21:49 ` Ville Syrjälä
2022-11-11 12:37 ` Imre Deak
2022-11-11 13:43 ` Ville Syrjälä
2022-11-11 13:52 ` Ville Syrjälä
2022-11-11 15:47 ` Imre Deak
2022-11-11 18:30 ` Ville Syrjälä
2022-11-11 18:56 ` Imre Deak
2022-11-11 19:23 ` Ville Syrjälä
2022-11-11 21:38 ` Imre Deak
2022-11-07 17:09 ` [Intel-gfx] [PATCH v2 2/9] drm/i915: Move the POWER_DOMAIN_AUX_IO_A definition to its logical place Imre Deak
2022-11-07 17:09 ` [Intel-gfx] [PATCH v2 3/9] drm/i915: Use the AUX_IO power domain only for eDP/PSR port Imre Deak
2022-11-08 15:18 ` [Intel-gfx] [PATCH v3 " Imre Deak
2022-11-07 17:09 ` [Intel-gfx] [PATCH v2 4/9] drm/i915/tgl+: Enable display DC power states on all eDP ports Imre Deak
2022-11-08 15:18 ` [Intel-gfx] [PATCH v3 " Imre Deak
2022-11-10 18:52 ` Ville Syrjälä
2022-11-10 18:57 ` Ville Syrjälä
2022-11-10 19:10 ` Imre Deak
2022-11-07 17:09 ` [Intel-gfx] [PATCH v2 5/9] drm/i915: Add missing AUX_IO_A power domain->well mappings Imre Deak
2022-11-07 17:09 ` [Intel-gfx] [PATCH v2 6/9] drm/i915: Add missing DC_OFF " Imre Deak
2022-11-07 17:09 ` [Intel-gfx] [PATCH v2 7/9] drm/i915: Factor out function to get/put AUX_IO power for main link Imre Deak
2022-11-08 15:18 ` [Intel-gfx] [PATCH v3 " Imre Deak
2022-11-10 10:21 ` Ville Syrjälä
2022-11-10 10:44 ` Jani Nikula
2022-11-10 12:29 ` Imre Deak
2022-11-07 17:09 ` [Intel-gfx] [PATCH v2 8/9] drm/i915: Don't enable the AUX_IO power for combo-PHY external DP port main links Imre Deak
2022-11-08 15:18 ` [Intel-gfx] [PATCH v3 " Imre Deak
2022-11-10 10:37 ` Ville Syrjälä
2022-11-10 12:27 ` Imre Deak
2022-11-07 17:09 ` [Intel-gfx] [PATCH v2 9/9] drm/i915/mtl+: Don't enable the AUX_IO power for non-eDP " Imre Deak
2022-11-08 15:18 ` [Intel-gfx] [PATCH v3 " Imre Deak
2022-11-07 22:20 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl+: Enable DC power states on all eDP ports (rev2) Patchwork
2022-11-07 22:20 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-11-07 22:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-11-08 4:18 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-11-08 17:05 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl+: Enable DC power states on all eDP ports (rev8) Patchwork
2022-11-08 17:05 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-11-08 17:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-11-08 22:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107170917.3566758-1-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox