Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arun R Murthy <arun.r.murthy@intel.com>
To: intel-gfx@lists.freedesktop.org, ville.syrjala@linux.intel.com,
	jani.nikula@intel.com, imre.deak@intel.com
Subject: [Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay
Date: Thu, 24 Nov 2022 12:39:25 +0530	[thread overview]
Message-ID: <20221124070925.3834910-1-arun.r.murthy@intel.com> (raw)

AUX HW timeout is being set to max(4000ms), consider AUX SW timeout to
be 200ms more to avoid AUX boundary read//write.

HSDES: 1409498780

Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_aux.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index 664bebdecea7..6c1c9602518b 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -293,14 +293,13 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 					   DP_AUX_CH_CTL_RECEIVE_ERROR);
 
 			/*
-			 * DP CTS 1.2 Core Rev 1.1, 4.2.1.1 & 4.2.1.2
-			 *   400us delay required for errors and timeouts
-			 *   Timeout errors from the HW already meet this
-			 *   requirement so skip to next iteration
+			 * Once the hw timeouts, before next try
+			 * need to add a sw timeout of 200usec(HSD: 1409498780).
 			 */
-			if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR)
+			if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR) {
+				usleep_range(200, 300);
 				continue;
-
+			}
 			if (status & DP_AUX_CH_CTL_RECEIVE_ERROR) {
 				usleep_range(400, 500);
 				continue;
-- 
2.25.1


             reply	other threads:[~2022-11-24  7:09 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-24  7:09 Arun R Murthy [this message]
2022-11-24  7:45 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dp: wait on timeout before retry include sw delay Patchwork
2022-11-24  8:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-11-25 15:48 ` [Intel-gfx] [PATCH] " Imre Deak
2022-12-01  6:44 ` [Intel-gfx] [PATCHv2] drm/i915/dp: Change aux_ctl reg read to polling read Arun R Murthy
2022-12-05 10:38   ` Jani Nikula
2022-12-07  5:23     ` Murthy, Arun R
2022-12-01  7:14 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev2) Patchwork
2022-12-01  7:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-12-01 17:06 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-12-09  8:35 ` [Intel-gfx] [RESEND PATCHv3] drm/i915/dp: Change aux_ctl reg read to polling read Arun R Murthy
2022-12-09 10:45   ` Jani Nikula
2022-12-13  5:44     ` Murthy, Arun R
2022-12-13  8:08       ` Jani Nikula
2022-12-09  9:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev3) Patchwork
2022-12-09 15:11 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-12-14  3:29 ` [Intel-gfx] [PATCHv4] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
2022-12-14  5:36   ` Murthy, Arun R
2022-12-14  9:29   ` Jani Nikula
2022-12-14  5:11 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: wait on timeout before retry include sw delay (rev4) Patchwork
2022-12-14 16:21 ` [Intel-gfx] [PATCHv5] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
2022-12-15  9:05   ` Jani Nikula
2022-12-14 18:12 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev5) Patchwork
2022-12-14 18:36 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-12-15  9:55 ` [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
2022-12-15 10:30   ` Jani Nikula
2022-12-15 10:37     ` Murthy, Arun R
2022-12-15 10:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev6) Patchwork
2022-12-15 10:34 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-12-15 11:13 ` [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
2022-12-19 10:17   ` Murthy, Arun R
2022-12-20 16:02     ` Jani Nikula
2022-12-20 16:54       ` Murthy, Arun R
2022-12-20 20:58         ` Jani Nikula
2022-12-15 14:14 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dp: wait on timeout before retry include sw delay (rev8) Patchwork
2022-12-15 14:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-12-16 13:42 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-12-21  3:32 ` [Intel-gfx] [PATCHv7] drm/i915/dp: change aux_ctl reg read to polling read Arun R Murthy
2023-01-04 13:27   ` Jani Nikula
2023-01-04 15:21     ` Murthy, Arun R
2022-12-22  1:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev9) Patchwork
2022-12-22  5:27 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221124070925.3834910-1-arun.r.murthy@intel.com \
    --to=arun.r.murthy@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox