From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 3/6] drm/i915/dpt: Introduce HAS_DPT()
Date: Mon, 20 Mar 2023 11:05:19 +0200 [thread overview]
Message-ID: <20230320090522.9909-4-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20230320090522.9909-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Replace the hand rolled DISPLAY_VER check for a more descriptive
HAS_DPT() macro. Will be used on more than one place later.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_fb.c | 2 +-
drivers/gpu/drm/i915/i915_drv.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
index 26ad5fc0c2c1..9609c5de3f91 100644
--- a/drivers/gpu/drm/i915/display/intel_fb.c
+++ b/drivers/gpu/drm/i915/display/intel_fb.c
@@ -718,7 +718,7 @@ static unsigned int intel_fb_modifier_to_tiling(u64 fb_modifier)
static bool intel_modifier_uses_dpt(struct drm_i915_private *i915, u64 modifier)
{
- return DISPLAY_VER(i915) >= 13 && modifier != DRM_FORMAT_MOD_LINEAR;
+ return HAS_DPT(i915) && modifier != DRM_FORMAT_MOD_LINEAR;
}
bool intel_fb_uses_dpt(const struct drm_framebuffer *fb)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 6254aa977398..de6a3cd3f46e 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -813,6 +813,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
#define HAS_FBC(dev_priv) (RUNTIME_INFO(dev_priv)->fbc_mask != 0)
#define HAS_CUR_FBC(dev_priv) (!HAS_GMCH(dev_priv) && DISPLAY_VER(dev_priv) >= 7)
+#define HAS_DPT(dev_priv) (DISPLAY_VER(dev_priv) >= 13)
+
#define HAS_IPS(dev_priv) (IS_HSW_ULT(dev_priv) || IS_BROADWELL(dev_priv))
#define HAS_DP_MST(dev_priv) (INTEL_INFO(dev_priv)->display.has_dp_mst)
--
2.39.2
next prev parent reply other threads:[~2023-03-20 9:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 9:05 [Intel-gfx] [PATCH 0/6] drm/i915/dpt: Fix DPT+shmem combo and add i915.enable_dpt modparam Ville Syrjala
2023-03-20 9:05 ` [Intel-gfx] [PATCH 1/6] drm/i915/dpt: Treat the DPT BO as a framebuffer Ville Syrjala
2023-03-20 9:46 ` Matthew Auld
2023-03-20 9:05 ` [Intel-gfx] [PATCH 2/6] drm/i915/dpt: Only do the POT stride remap when using DPT Ville Syrjala
2023-03-20 9:05 ` Ville Syrjala [this message]
2023-03-20 9:05 ` [Intel-gfx] [PATCH 4/6] drm/i915: Add PLANE_CHICKEN registers Ville Syrjala
2023-03-20 9:05 ` [Intel-gfx] [PATCH 5/6] drm/i915/dpt: Add a modparam to disable DPT via the chicken bit Ville Syrjala
2023-03-20 9:05 ` [Intel-gfx] [PATCH 6/6] drm/i915: Move PLANE_BUG_CFG bit definitons to the correct place Ville Syrjala
2023-03-20 16:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dpt: Fix DPT+shmem combo and add i915.enable_dpt modparam Patchwork
2023-03-20 16:17 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-03-20 16:17 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2023-03-20 16:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-03-20 20:04 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-03-22 15:15 ` [Intel-gfx] [PATCH 0/6] " Juha-Pekka Heikkila
2023-03-22 16:15 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320090522.9909-4-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox