From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 0/6] drm/i915/dpt: Fix DPT+shmem combo and add i915.enable_dpt modparam
Date: Wed, 22 Mar 2023 17:15:56 +0200 [thread overview]
Message-ID: <9b0a61ad-2f02-b35d-9cd4-68367aa4a85c@gmail.com> (raw)
In-Reply-To: <20230320090522.9909-1-ville.syrjala@linux.intel.com>
Set look all ok,
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
I guess should start to think about how to write igt tests which would
target directly at dpt so this kind of issues wouldn't get missed.
/Juha-Pekka
On 20.3.2023 11.05, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Avoid the shrinker evicting the DPT during hibernate and
> causing an oops. This might also fix DPT induced display faults
> during high memory pressure (though still don't have a real
> theory how that could actually happen).
>
> Also add a i915.enable_dpt modparam to disable DPT usage via
> the chicken bit. This can be useful when trying to debug suspected
> DPT issues.
>
> Ville Syrjälä (6):
> drm/i915/dpt: Treat the DPT BO as a framebuffer
> drm/i915/dpt: Only do the POT stride remap when using DPT
> drm/i915/dpt: Introduce HAS_DPT()
> drm/i915: Add PLANE_CHICKEN registers
> drm/i915/dpt: Add a modparam to disable DPT via the chicken bit
> drm/i915: Move PLANE_BUG_CFG bit definitons to the correct place
>
> drivers/gpu/drm/i915/display/intel_display.c | 6 +++++
> drivers/gpu/drm/i915/display/intel_dpt.c | 23 +++++++++++++++++++
> drivers/gpu/drm/i915/display/intel_dpt.h | 2 ++
> drivers/gpu/drm/i915/display/intel_fb.c | 11 +++++----
> drivers/gpu/drm/i915/display/intel_fb.h | 1 +
> .../drm/i915/display/skl_universal_plane.c | 6 +++++
> drivers/gpu/drm/i915/gem/i915_gem_object.h | 2 +-
> .../gpu/drm/i915/gem/i915_gem_object_types.h | 3 +++
> drivers/gpu/drm/i915/i915_drv.h | 2 ++
> drivers/gpu/drm/i915/i915_params.c | 3 +++
> drivers/gpu/drm/i915/i915_params.h | 1 +
> drivers/gpu/drm/i915/i915_reg.h | 21 +++++++++++++----
> 12 files changed, 70 insertions(+), 11 deletions(-)
>
next prev parent reply other threads:[~2023-03-22 15:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 9:05 [Intel-gfx] [PATCH 0/6] drm/i915/dpt: Fix DPT+shmem combo and add i915.enable_dpt modparam Ville Syrjala
2023-03-20 9:05 ` [Intel-gfx] [PATCH 1/6] drm/i915/dpt: Treat the DPT BO as a framebuffer Ville Syrjala
2023-03-20 9:46 ` Matthew Auld
2023-03-20 9:05 ` [Intel-gfx] [PATCH 2/6] drm/i915/dpt: Only do the POT stride remap when using DPT Ville Syrjala
2023-03-20 9:05 ` [Intel-gfx] [PATCH 3/6] drm/i915/dpt: Introduce HAS_DPT() Ville Syrjala
2023-03-20 9:05 ` [Intel-gfx] [PATCH 4/6] drm/i915: Add PLANE_CHICKEN registers Ville Syrjala
2023-03-20 9:05 ` [Intel-gfx] [PATCH 5/6] drm/i915/dpt: Add a modparam to disable DPT via the chicken bit Ville Syrjala
2023-03-20 9:05 ` [Intel-gfx] [PATCH 6/6] drm/i915: Move PLANE_BUG_CFG bit definitons to the correct place Ville Syrjala
2023-03-20 16:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dpt: Fix DPT+shmem combo and add i915.enable_dpt modparam Patchwork
2023-03-20 16:17 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-03-20 16:17 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2023-03-20 16:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-03-20 20:04 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-03-22 15:15 ` Juha-Pekka Heikkila [this message]
2023-03-22 16:15 ` [Intel-gfx] [PATCH 0/6] " Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b0a61ad-2f02-b35d-9cd4-68367aa4a85c@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox