Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v7 5/6] drm/i915/psr: Check that vblank is long enough for psr2
Date: Wed, 29 Mar 2023 18:07:02 +0300	[thread overview]
Message-ID: <20230329150703.432072-6-jouni.hogander@intel.com> (raw)
In-Reply-To: <20230329150703.432072-1-jouni.hogander@intel.com>

Ensure vblank >= psr2 vblank
where
Psr2 vblank = PSR2_CTL Block Count Number maximum line count.

Bspec: 71580, 49274

v2: Use calculated block count number maximum line count

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 07b0c016e78a..446c8acc265b 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -968,6 +968,15 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
 		return false;
 	}
 
+	/* Vblank >= PSR2_CTL Block Count Number maximum line count */
+	if (crtc_state->hw.adjusted_mode.crtc_vblank_end -
+	    crtc_state->hw.adjusted_mode.crtc_vblank_start <
+	    psr2_block_count_lines(intel_dp)) {
+		drm_dbg_kms(&dev_priv->drm,
+			    "PSR2 not enabled, too short vblank time\n");
+		return false;
+	}
+
 	if (HAS_PSR2_SEL_FETCH(dev_priv)) {
 		if (!intel_psr2_sel_fetch_config_valid(intel_dp, crtc_state) &&
 		    !HAS_PSR_HW_TRACKING(dev_priv)) {
-- 
2.34.1


  parent reply	other threads:[~2023-03-29 15:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 15:06 [Intel-gfx] [PATCH v7 0/6] High refresh rate PSR fixes Jouni Högander
2023-03-29 15:06 ` [Intel-gfx] [PATCH v7 1/6] drm/i915/psr: Unify pre/post hooks Jouni Högander
2023-03-29 15:06 ` [Intel-gfx] [PATCH v7 2/6] drm/i915/psr: Modify/Fix Wa_16013835468 and prepare for Wa_14015648006 Jouni Högander
2023-03-29 15:07 ` [Intel-gfx] [PATCH v7 3/6] drm/i915/psr: Implement Wa_14015648006 Jouni Högander
2023-03-29 15:07 ` [Intel-gfx] [PATCH v7 4/6] drm/i915/psr: Add helpers for block count number handling Jouni Högander
2023-03-29 15:07 ` Jouni Högander [this message]
2023-03-29 15:07 ` [Intel-gfx] [PATCH v7 6/6] drm/i915/psr: Implement Display WA #1136 Jouni Högander
2023-03-29 19:21 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for High refresh rate PSR fixes (rev7) Patchwork
2023-03-29 19:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-03-30 11:59 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-03-30 12:23 ` [Intel-gfx] [PATCH v7 0/6] High refresh rate PSR fixes Ville Syrjälä
2023-03-31  5:55   ` Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230329150703.432072-6-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox