From: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v2 3/4] drm/i915/mtl: Extend Wa_22011802037 to MTL A-step
Date: Tue, 18 Apr 2023 15:04:45 -0700 [thread overview]
Message-ID: <20230418220446.2205509-4-radhakrishna.sripada@intel.com> (raw)
In-Reply-To: <20230418220446.2205509-1-radhakrishna.sripada@intel.com>
From: Madhumitha Tolakanahalli Pradeep <madhumitha.tolakanahalli.pradeep@intel.com>
Wa_22011802037 was being applied to all graphics_ver 11 & 12. This patch
updates the if statement to apply the W/A to right platforms and extends
it to MTL-M:A step.
v1.1: Fix checkpatch warning.
v2: Change the check to reflect the wa at other palces(Lucas)
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Signed-off-by: Madhumitha Tolakanahalli Pradeep <madhumitha.tolakanahalli.pradeep@intel.com>
Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
index 88e881b100cf..ee3e8352637f 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
@@ -1629,16 +1629,16 @@ static void guc_reset_state(struct intel_context *ce, u32 head, bool scrub)
static void guc_engine_reset_prepare(struct intel_engine_cs *engine)
{
- if (!IS_GRAPHICS_VER(engine->i915, 11, 12))
- return;
-
- intel_engine_stop_cs(engine);
-
/*
* Wa_22011802037: In addition to stopping the cs, we need
* to wait for any pending mi force wakeups
*/
- intel_engine_wait_for_pending_mi_fw(engine);
+ if (IS_MTL_GRAPHICS_STEP(engine->i915, M, STEP_A0, STEP_B0) ||
+ (GRAPHICS_VER(engine->i915) >= 11 &&
+ GRAPHICS_VER_FULL(engine->i915) < IP_VER(12, 70))) {
+ intel_engine_stop_cs(engine);
+ intel_engine_wait_for_pending_mi_fw(engine);
+ }
}
static void guc_reset_nop(struct intel_engine_cs *engine)
--
2.34.1
next prev parent reply other threads:[~2023-04-18 22:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 22:04 [Intel-gfx] [PATCH v2 0/4] More MTL WA and powerwell patches Radhakrishna Sripada
2023-04-18 22:04 ` [Intel-gfx] [PATCH v2 1/4] drm/i915: Use separate "DC off" power well for ADL-P and DG2 Radhakrishna Sripada
2023-04-18 22:04 ` [Intel-gfx] [PATCH v2 2/4] drm/i915/mtl: Re-use ADL-P's "DC off" power well Radhakrishna Sripada
2023-04-18 22:04 ` Radhakrishna Sripada [this message]
2023-04-19 21:40 ` [Intel-gfx] [PATCH v2 3/4] drm/i915/mtl: Extend Wa_22011802037 to MTL A-step Matt Atwood
2023-04-21 15:05 ` Matt Roper
2023-04-21 15:08 ` Matt Roper
2023-04-21 17:11 ` Sripada, Radhakrishna
2023-04-18 22:04 ` [Intel-gfx] [PATCH v2 4/4] drm/i915/mtl: WA to clear RDOP clock gating Radhakrishna Sripada
2023-04-19 21:49 ` Matt Atwood
2023-04-20 3:20 ` Sripada, Radhakrishna
2023-04-18 22:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for More MTL WA and powerwell patches (rev3) Patchwork
2023-04-18 22:54 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-04-18 23:06 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-04-24 8:10 ` [Intel-gfx] [PATCH v2 0/4] More MTL WA and powerwell patches Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418220446.2205509-4-radhakrishna.sripada@intel.com \
--to=radhakrishna.sripada@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox