public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [Intel-gfx] [CI DO_NOT_MERGE 1/2] drm/i915/mtl: do not enable render power-gating on MTL
@ 2023-05-16 22:03 Andrzej Hajda
  2023-05-16 22:03 ` [Intel-gfx] [CI DO_NOT_MERGE 2/2] drm/i915/gt: do not enable render and media power-gating on RPL-S Andrzej Hajda
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Andrzej Hajda @ 2023-05-16 22:03 UTC (permalink / raw)
  To: intel-gfx; +Cc: Andrzej Hajda

Multiple CI tests fails if render power gatins is enabled,
with forcewake ack timeouts.
BSpec 52698 clearly states it should be 0.
Media gate seems also problematic.

References: https://gitlab.freedesktop.org/drm/intel/-/issues/4983
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---

Let's try disabling render and media pg.
---
 drivers/gpu/drm/i915/gt/intel_rc6.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
index 908a3d0f2343f4..cd63eaf0d0c8de 100644
--- a/drivers/gpu/drm/i915/gt/intel_rc6.c
+++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
@@ -117,9 +117,12 @@ static void gen11_rc6_enable(struct intel_rc6 *rc6)
 			GEN6_RC_CTL_RC6_ENABLE |
 			GEN6_RC_CTL_EI_MODE(1);
 
+	/* BSpec: 52698, GEN9_RENDER_PG_ENABLE must be 0 for MTL */
+	if (IS_METEORLAKE(gt->i915))
+		pg_enable = 0;
 	/* Wa_16011777198 - Render powergating must remain disabled */
-	if (IS_DG2_GRAPHICS_STEP(gt->i915, G10, STEP_A0, STEP_C0) ||
-	    IS_DG2_GRAPHICS_STEP(gt->i915, G11, STEP_A0, STEP_B0))
+	else if (IS_DG2_GRAPHICS_STEP(gt->i915, G10, STEP_A0, STEP_C0) ||
+	         IS_DG2_GRAPHICS_STEP(gt->i915, G11, STEP_A0, STEP_B0))
 		pg_enable =
 			GEN9_MEDIA_PG_ENABLE |
 			GEN11_MEDIA_SAMPLER_PG_ENABLE;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-05-17 15:58 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-16 22:03 [Intel-gfx] [CI DO_NOT_MERGE 1/2] drm/i915/mtl: do not enable render power-gating on MTL Andrzej Hajda
2023-05-16 22:03 ` [Intel-gfx] [CI DO_NOT_MERGE 2/2] drm/i915/gt: do not enable render and media power-gating on RPL-S Andrzej Hajda
2023-05-16 23:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,DO_NOT_MERGE,1/2] drm/i915/mtl: do not enable render power-gating on MTL Patchwork
2023-05-17  0:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-17  6:28 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,DO_NOT_MERGE,1/2] drm/i915/mtl: do not enable render power-gating on MTL (rev2) Patchwork
2023-05-17  6:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-17 15:58 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox