From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v3 21/23] drm/i915/display: Move verbose_state_checks under display
Date: Tue, 24 Oct 2023 13:32:20 +0300 [thread overview]
Message-ID: <20231024103222.302256-22-jouni.hogander@intel.com> (raw)
In-Reply-To: <20231024103222.302256-1-jouni.hogander@intel.com>
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.h | 2 +-
drivers/gpu/drm/i915/display/intel_display_params.c | 3 +++
drivers/gpu/drm/i915/display/intel_display_params.h | 1 +
drivers/gpu/drm/i915/i915_params.c | 3 ---
drivers/gpu/drm/i915/i915_params.h | 1 -
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
index ba3548f9768d..bc95fb377386 100644
--- a/drivers/gpu/drm/i915/display/intel_display.h
+++ b/drivers/gpu/drm/i915/display/intel_display.h
@@ -552,7 +552,7 @@ bool assert_port_valid(struct drm_i915_private *i915, enum port port);
struct drm_device *drm = &(__i915)->drm; \
int __ret_warn_on = !!(condition); \
if (unlikely(__ret_warn_on)) \
- if (!drm_WARN(drm, __i915->params.verbose_state_checks, format)) \
+ if (!drm_WARN(drm, __i915->display.params.verbose_state_checks, format)) \
drm_err(drm, format); \
unlikely(__ret_warn_on); \
})
diff --git a/drivers/gpu/drm/i915/display/intel_display_params.c b/drivers/gpu/drm/i915/display/intel_display_params.c
index 3579fa1fc5b7..cae1449e9b06 100644
--- a/drivers/gpu/drm/i915/display/intel_display_params.c
+++ b/drivers/gpu/drm/i915/display/intel_display_params.c
@@ -87,6 +87,9 @@ intel_display_param_named_unsafe(force_reset_modeset_test, bool, 0400,
intel_display_param_named(disable_display, bool, 0400,
"Disable display (default: false)");
+intel_display_param_named(verbose_state_checks, bool, 0400,
+ "Enable verbose logs (ie. WARN_ON()) in case of unexpected hw state conditions.");
+
intel_display_param_named_unsafe(enable_fbc, int, 0400,
"Enable frame buffer compression for power savings "
"(default: -1 (use per-chip default))");
diff --git a/drivers/gpu/drm/i915/display/intel_display_params.h b/drivers/gpu/drm/i915/display/intel_display_params.h
index 8c4e0f6ac3e3..8b00c141e0a2 100644
--- a/drivers/gpu/drm/i915/display/intel_display_params.h
+++ b/drivers/gpu/drm/i915/display/intel_display_params.h
@@ -39,6 +39,7 @@ struct drm_i915_private;
param(bool, load_detect_test, false, 0600) \
param(bool, force_reset_modeset_test, false, 0600) \
param(bool, disable_display, false, 0400) \
+ param(bool, verbose_state_checks, true, 0) \
param(int, enable_fbc, -1, 0600) \
param(int, enable_psr, -1, 0600) \
param(bool, psr_safest_params, false, 0400) \
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index 4e8c088c69fd..72614c139222 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -93,9 +93,6 @@ i915_param_named(mmio_debug, int, 0400,
"Enable the MMIO debug code for the first N failures (default: off). "
"This may negatively affect performance.");
-i915_param_named(verbose_state_checks, bool, 0400,
- "Enable verbose logs (ie. WARN_ON()) in case of unexpected hw state conditions.");
-
i915_param_named_unsafe(nuclear_pageflip, bool, 0400,
"Force enable atomic functionality on platforms that don't have full support yet.");
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index 8bce7d057634..4b543beb17ca 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -64,7 +64,6 @@ struct drm_printer;
/* leave bools at the end to not create holes */ \
param(bool, enable_hangcheck, true, 0600) \
param(bool, error_capture, true, IS_ENABLED(CONFIG_DRM_I915_CAPTURE_ERROR) ? 0600 : 0) \
- param(bool, verbose_state_checks, true, 0) \
param(bool, nuclear_pageflip, false, 0400) \
param(bool, enable_dp_mst, true, 0600) \
param(bool, enable_gvt, false, IS_ENABLED(CONFIG_DRM_I915_GVT) ? 0400 : 0)
--
2.34.1
next prev parent reply other threads:[~2023-10-24 10:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 10:31 [Intel-gfx] [PATCH v3 00/23] Framework for display parameters Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 01/23] drm/i915/display: Add framework to add parameters specific to display Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 02/23] drm/i915/display: Dump also display parameters Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 03/23] drm/i915/display: Move enable_fbc module parameter under display Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 04/23] drm/i915/display: Move psr related module parameters " Jouni Högander
2023-10-24 11:40 ` Luca Coelho
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 05/23] drm/i915/display: Move vbt_firmware module parameter " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 06/23] drm/i915/display: Move lvds_channel_mode " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 07/23] drm/i915/display: Move panel_use_ssc " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 08/23] drm/i915/display: Move vbt_sdvo_panel_type " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 09/23] drm/i915/display: Move enable_dc " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 10/23] drm/i915/display: Move enable_dpt " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 11/23] drm/i915/display: Move enable_sagv " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 12/23] drm/i915/display: Move disable_power_well " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 13/23] drm/i915/display: Move enable_ips " Jouni Högander
2023-10-24 11:41 ` Luca Coelho
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 14/23] drm/i915/display: Move invert_brightness " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 15/23] drm/i915/display: Move edp_vswing " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 16/23] drm/i915/display: Move enable_dpcd_backlight " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 17/23] drm/i915/display: Move load_detect_test " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 18/23] drm/i915/display: Move force_reset_modeset_test " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 19/23] drm/i915/display: Move disable_display " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 20/23] drm/i915/display: Use device parameters instead of module in I915_STATE_WARN Jouni Högander
2023-10-24 10:32 ` Jouni Högander [this message]
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 22/23] drm/i915/display: Move nuclear_pageflip under display Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 23/23] drm/i915/display: Move enable_dp_mst " Jouni Högander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024103222.302256-22-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox