From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Luca Coelho <luciano.coelho@intel.com>
Subject: [Intel-gfx] [PATCH v3 23/23] drm/i915/display: Move enable_dp_mst under display
Date: Tue, 24 Oct 2023 13:32:22 +0300 [thread overview]
Message-ID: <20231024103222.302256-24-jouni.hogander@intel.com> (raw)
In-Reply-To: <20231024103222.302256-1-jouni.hogander@intel.com>
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Luca Coelho <luciano.coelho@intel.com>
---
drivers/gpu/drm/i915/display/intel_display_params.c | 3 +++
drivers/gpu/drm/i915/display/intel_display_params.h | 1 +
drivers/gpu/drm/i915/display/intel_dp.c | 6 +++---
drivers/gpu/drm/i915/i915_params.c | 3 ---
drivers/gpu/drm/i915/i915_params.h | 1 -
5 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_params.c b/drivers/gpu/drm/i915/display/intel_display_params.c
index f82f5bed69bc..11e03cfb774d 100644
--- a/drivers/gpu/drm/i915/display/intel_display_params.c
+++ b/drivers/gpu/drm/i915/display/intel_display_params.c
@@ -93,6 +93,9 @@ intel_display_param_named(verbose_state_checks, bool, 0400,
intel_display_param_named_unsafe(nuclear_pageflip, bool, 0400,
"Force enable atomic functionality on platforms that don't have full support yet.");
+intel_display_param_named_unsafe(enable_dp_mst, bool, 0400,
+ "Enable multi-stream transport (MST) for new DisplayPort sinks. (default: true)");
+
intel_display_param_named_unsafe(enable_fbc, int, 0400,
"Enable frame buffer compression for power savings "
"(default: -1 (use per-chip default))");
diff --git a/drivers/gpu/drm/i915/display/intel_display_params.h b/drivers/gpu/drm/i915/display/intel_display_params.h
index f3d4ce245c0e..1d985fa2972b 100644
--- a/drivers/gpu/drm/i915/display/intel_display_params.h
+++ b/drivers/gpu/drm/i915/display/intel_display_params.h
@@ -41,6 +41,7 @@ struct drm_i915_private;
param(bool, disable_display, false, 0400) \
param(bool, verbose_state_checks, true, 0) \
param(bool, nuclear_pageflip, false, 0400) \
+ param(bool, enable_dp_mst, true, 0600) \
param(int, enable_fbc, -1, 0600) \
param(int, enable_psr, -1, 0600) \
param(bool, psr_safest_params, false, 0400) \
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 1891c0cc187d..e920524bec51 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -3771,7 +3771,7 @@ intel_dp_can_mst(struct intel_dp *intel_dp)
{
struct drm_i915_private *i915 = dp_to_i915(intel_dp);
- return i915->params.enable_dp_mst &&
+ return i915->display.params.enable_dp_mst &&
intel_dp_mst_source_support(intel_dp) &&
drm_dp_read_mst_cap(&intel_dp->aux, intel_dp->dpcd);
}
@@ -3789,13 +3789,13 @@ intel_dp_configure_mst(struct intel_dp *intel_dp)
encoder->base.base.id, encoder->base.name,
str_yes_no(intel_dp_mst_source_support(intel_dp)),
str_yes_no(sink_can_mst),
- str_yes_no(i915->params.enable_dp_mst));
+ str_yes_no(i915->display.params.enable_dp_mst));
if (!intel_dp_mst_source_support(intel_dp))
return;
intel_dp->is_mst = sink_can_mst &&
- i915->params.enable_dp_mst;
+ i915->display.params.enable_dp_mst;
drm_dp_mst_topology_mgr_set_mst(&intel_dp->mst_mgr,
intel_dp->is_mst);
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index 18424873442d..de43048543e8 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -114,9 +114,6 @@ i915_param_named_unsafe(dmc_firmware_path, charp, 0400,
i915_param_named_unsafe(gsc_firmware_path, charp, 0400,
"GSC firmware path to use instead of the default one");
-i915_param_named_unsafe(enable_dp_mst, bool, 0400,
- "Enable multi-stream transport (MST) for new DisplayPort sinks. (default: true)");
-
#if IS_ENABLED(CONFIG_DRM_I915_DEBUG)
i915_param_named_unsafe(inject_probe_failure, uint, 0400,
"Force an error after a number of failure check points (0:disabled (default), N:force failure at the Nth failure check point)");
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index c7fff571db2c..1315d7fac850 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -64,7 +64,6 @@ struct drm_printer;
/* leave bools at the end to not create holes */ \
param(bool, enable_hangcheck, true, 0600) \
param(bool, error_capture, true, IS_ENABLED(CONFIG_DRM_I915_CAPTURE_ERROR) ? 0600 : 0) \
- param(bool, enable_dp_mst, true, 0600) \
param(bool, enable_gvt, false, IS_ENABLED(CONFIG_DRM_I915_GVT) ? 0400 : 0)
#define MEMBER(T, member, ...) T member;
--
2.34.1
prev parent reply other threads:[~2023-10-24 10:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 10:31 [Intel-gfx] [PATCH v3 00/23] Framework for display parameters Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 01/23] drm/i915/display: Add framework to add parameters specific to display Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 02/23] drm/i915/display: Dump also display parameters Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 03/23] drm/i915/display: Move enable_fbc module parameter under display Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 04/23] drm/i915/display: Move psr related module parameters " Jouni Högander
2023-10-24 11:40 ` Luca Coelho
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 05/23] drm/i915/display: Move vbt_firmware module parameter " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 06/23] drm/i915/display: Move lvds_channel_mode " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 07/23] drm/i915/display: Move panel_use_ssc " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 08/23] drm/i915/display: Move vbt_sdvo_panel_type " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 09/23] drm/i915/display: Move enable_dc " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 10/23] drm/i915/display: Move enable_dpt " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 11/23] drm/i915/display: Move enable_sagv " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 12/23] drm/i915/display: Move disable_power_well " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 13/23] drm/i915/display: Move enable_ips " Jouni Högander
2023-10-24 11:41 ` Luca Coelho
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 14/23] drm/i915/display: Move invert_brightness " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 15/23] drm/i915/display: Move edp_vswing " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 16/23] drm/i915/display: Move enable_dpcd_backlight " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 17/23] drm/i915/display: Move load_detect_test " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 18/23] drm/i915/display: Move force_reset_modeset_test " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 19/23] drm/i915/display: Move disable_display " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 20/23] drm/i915/display: Use device parameters instead of module in I915_STATE_WARN Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 21/23] drm/i915/display: Move verbose_state_checks under display Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 22/23] drm/i915/display: Move nuclear_pageflip " Jouni Högander
2023-10-24 10:32 ` Jouni Högander [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024103222.302256-24-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox