Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Luca Coelho <luciano.coelho@intel.com>
Subject: [Intel-gfx] [PATCH v3 07/23] drm/i915/display: Move panel_use_ssc module parameter under display
Date: Tue, 24 Oct 2023 13:32:06 +0300	[thread overview]
Message-ID: <20231024103222.302256-8-jouni.hogander@intel.com> (raw)
In-Reply-To: <20231024103222.302256-1-jouni.hogander@intel.com>

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_params.c | 4 ++++
 drivers/gpu/drm/i915/display/intel_display_params.h | 1 +
 drivers/gpu/drm/i915/display/intel_panel.c          | 4 ++--
 drivers/gpu/drm/i915/i915_params.c                  | 4 ----
 drivers/gpu/drm/i915/i915_params.h                  | 1 -
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_params.c b/drivers/gpu/drm/i915/display/intel_display_params.c
index 91e2b5056d63..0813adfa5651 100644
--- a/drivers/gpu/drm/i915/display/intel_display_params.c
+++ b/drivers/gpu/drm/i915/display/intel_display_params.c
@@ -34,6 +34,10 @@ intel_display_param_named_unsafe(lvds_channel_mode, int, 0400,
 	 "Specify LVDS channel mode "
 	 "(0=probe BIOS [default], 1=single-channel, 2=dual-channel)");
 
+intel_display_param_named_unsafe(panel_use_ssc, int, 0400,
+	"Use Spread Spectrum Clock with panels [LVDS/eDP] "
+	"(default: auto from VBT)");
+
 intel_display_param_named_unsafe(enable_fbc, int, 0400,
 	"Enable frame buffer compression for power savings "
 	"(default: -1 (use per-chip default))");
diff --git a/drivers/gpu/drm/i915/display/intel_display_params.h b/drivers/gpu/drm/i915/display/intel_display_params.h
index 09bd6614b813..ceed4af192c9 100644
--- a/drivers/gpu/drm/i915/display/intel_display_params.h
+++ b/drivers/gpu/drm/i915/display/intel_display_params.h
@@ -26,6 +26,7 @@ struct drm_i915_private;
 #define INTEL_DISPLAY_PARAMS_FOR_EACH(param) \
 	param(char *, vbt_firmware, NULL, 0400) \
 	param(int, lvds_channel_mode, 0, 0400) \
+	param(int, panel_use_ssc, -1, 0600) \
 	param(int, enable_fbc, -1, 0600) \
 	param(int, enable_psr, -1, 0600) \
 	param(bool, psr_safest_params, false, 0400) \
diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
index 483beedac5b8..0d8e5320a4f8 100644
--- a/drivers/gpu/drm/i915/display/intel_panel.c
+++ b/drivers/gpu/drm/i915/display/intel_panel.c
@@ -46,8 +46,8 @@
 
 bool intel_panel_use_ssc(struct drm_i915_private *i915)
 {
-	if (i915->params.panel_use_ssc >= 0)
-		return i915->params.panel_use_ssc != 0;
+	if (i915->display.params.panel_use_ssc >= 0)
+		return i915->display.params.panel_use_ssc != 0;
 	return i915->display.vbt.lvds_use_ssc &&
 		!intel_has_quirk(i915, QUIRK_LVDS_SSC_DISABLE);
 }
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index ea55cc2c4854..4123424b2c2e 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -72,10 +72,6 @@ i915_param_named_unsafe(enable_dc, int, 0400,
 	"(-1=auto [default]; 0=disable; 1=up to DC5; 2=up to DC6; "
 	"3=up to DC5 with DC3CO; 4=up to DC6 with DC3CO)");
 
-i915_param_named_unsafe(panel_use_ssc, int, 0400,
-	"Use Spread Spectrum Clock with panels [LVDS/eDP] "
-	"(default: auto from VBT)");
-
 i915_param_named_unsafe(vbt_sdvo_panel_type, int, 0400,
 	"Override/Ignore selection of SDVO panel mode in the VBT "
 	"(-2=ignore, -1=auto [default], index in VBT BIOS table)");
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index 03ec2c2b589d..0bd365889e73 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -47,7 +47,6 @@ struct drm_printer;
  */
 #define I915_PARAMS_FOR_EACH(param) \
 	param(int, modeset, -1, 0400) \
-	param(int, panel_use_ssc, -1, 0600) \
 	param(int, vbt_sdvo_panel_type, -1, 0400) \
 	param(int, enable_dc, -1, 0400) \
 	param(bool, enable_dpt, true, 0400) \
-- 
2.34.1


  parent reply	other threads:[~2023-10-24 10:33 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24 10:31 [Intel-gfx] [PATCH v3 00/23] Framework for display parameters Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 01/23] drm/i915/display: Add framework to add parameters specific to display Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 02/23] drm/i915/display: Dump also display parameters Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 03/23] drm/i915/display: Move enable_fbc module parameter under display Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 04/23] drm/i915/display: Move psr related module parameters " Jouni Högander
2023-10-24 11:40   ` Luca Coelho
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 05/23] drm/i915/display: Move vbt_firmware module parameter " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 06/23] drm/i915/display: Move lvds_channel_mode " Jouni Högander
2023-10-24 10:32 ` Jouni Högander [this message]
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 08/23] drm/i915/display: Move vbt_sdvo_panel_type " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 09/23] drm/i915/display: Move enable_dc " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 10/23] drm/i915/display: Move enable_dpt " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 11/23] drm/i915/display: Move enable_sagv " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 12/23] drm/i915/display: Move disable_power_well " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 13/23] drm/i915/display: Move enable_ips " Jouni Högander
2023-10-24 11:41   ` Luca Coelho
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 14/23] drm/i915/display: Move invert_brightness " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 15/23] drm/i915/display: Move edp_vswing " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 16/23] drm/i915/display: Move enable_dpcd_backlight " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 17/23] drm/i915/display: Move load_detect_test " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 18/23] drm/i915/display: Move force_reset_modeset_test " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 19/23] drm/i915/display: Move disable_display " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 20/23] drm/i915/display: Use device parameters instead of module in I915_STATE_WARN Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 21/23] drm/i915/display: Move verbose_state_checks under display Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 22/23] drm/i915/display: Move nuclear_pageflip " Jouni Högander
2023-10-24 10:32 ` [Intel-gfx] [PATCH v3 23/23] drm/i915/display: Move enable_dp_mst " Jouni Högander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231024103222.302256-8-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=luciano.coelho@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox