Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Luca Coelho <luciano.coelho@intel.com>
Subject: [Intel-gfx] [PATCH v4 10/23] drm/i915/display: Move enable_dpt module parameter under display
Date: Tue, 24 Oct 2023 15:40:56 +0300	[thread overview]
Message-ID: <20231024124109.384973-11-jouni.hogander@intel.com> (raw)
In-Reply-To: <20231024124109.384973-1-jouni.hogander@intel.com>

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_params.c | 3 +++
 drivers/gpu/drm/i915/display/intel_display_params.h | 1 +
 drivers/gpu/drm/i915/display/intel_dpt.c            | 6 ++++--
 drivers/gpu/drm/i915/display/intel_fb.c             | 2 +-
 drivers/gpu/drm/i915/display/skl_universal_plane.c  | 2 +-
 drivers/gpu/drm/i915/i915_params.c                  | 3 ---
 drivers/gpu/drm/i915/i915_params.h                  | 1 -
 7 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_params.c b/drivers/gpu/drm/i915/display/intel_display_params.c
index 60fa0bbce77d..9067ffd6d2a9 100644
--- a/drivers/gpu/drm/i915/display/intel_display_params.c
+++ b/drivers/gpu/drm/i915/display/intel_display_params.c
@@ -47,6 +47,9 @@ intel_display_param_named_unsafe(enable_dc, int, 0400,
 	"(-1=auto [default]; 0=disable; 1=up to DC5; 2=up to DC6; "
 	"3=up to DC5 with DC3CO; 4=up to DC6 with DC3CO)");
 
+intel_display_param_named_unsafe(enable_dpt, bool, 0400,
+	"Enable display page table (DPT) (default: true)");
+
 intel_display_param_named_unsafe(enable_fbc, int, 0400,
 	"Enable frame buffer compression for power savings "
 	"(default: -1 (use per-chip default))");
diff --git a/drivers/gpu/drm/i915/display/intel_display_params.h b/drivers/gpu/drm/i915/display/intel_display_params.h
index 2cca06ad7d71..e5f139239f23 100644
--- a/drivers/gpu/drm/i915/display/intel_display_params.h
+++ b/drivers/gpu/drm/i915/display/intel_display_params.h
@@ -29,6 +29,7 @@ struct drm_i915_private;
 	param(int, panel_use_ssc, -1, 0600) \
 	param(int, vbt_sdvo_panel_type, -1, 0400) \
 	param(int, enable_dc, -1, 0400) \
+	param(bool, enable_dpt, true, 0400) \
 	param(int, enable_fbc, -1, 0600) \
 	param(int, enable_psr, -1, 0600) \
 	param(bool, psr_safest_params, false, 0400) \
diff --git a/drivers/gpu/drm/i915/display/intel_dpt.c b/drivers/gpu/drm/i915/display/intel_dpt.c
index 48582b31b7f7..2b067cb952f0 100644
--- a/drivers/gpu/drm/i915/display/intel_dpt.c
+++ b/drivers/gpu/drm/i915/display/intel_dpt.c
@@ -332,11 +332,13 @@ void intel_dpt_configure(struct intel_crtc *crtc)
 
 			intel_de_rmw(i915, PLANE_CHICKEN(pipe, plane_id),
 				     PLANE_CHICKEN_DISABLE_DPT,
-				     i915->params.enable_dpt ? 0 : PLANE_CHICKEN_DISABLE_DPT);
+				     i915->display.params.enable_dpt ? 0 :
+				     PLANE_CHICKEN_DISABLE_DPT);
 		}
 	} else if (DISPLAY_VER(i915) == 13) {
 		intel_de_rmw(i915, CHICKEN_MISC_2,
 			     CHICKEN_MISC_DISABLE_DPT,
-			     i915->params.enable_dpt ? 0 : CHICKEN_MISC_DISABLE_DPT);
+			     i915->display.params.enable_dpt ? 0 :
+			     CHICKEN_MISC_DISABLE_DPT);
 	}
 }
diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
index 93b2260d7005..c1777ea35761 100644
--- a/drivers/gpu/drm/i915/display/intel_fb.c
+++ b/drivers/gpu/drm/i915/display/intel_fb.c
@@ -764,7 +764,7 @@ bool intel_fb_modifier_uses_dpt(struct drm_i915_private *i915, u64 modifier)
 
 bool intel_fb_uses_dpt(const struct drm_framebuffer *fb)
 {
-	return fb && to_i915(fb->dev)->params.enable_dpt &&
+	return fb && to_i915(fb->dev)->display.params.enable_dpt &&
 		intel_fb_modifier_uses_dpt(to_i915(fb->dev), fb->modifier);
 }
 
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 49e9d40d5e67..68035675ae3c 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -2488,7 +2488,7 @@ skl_get_initial_plane_config(struct intel_crtc *crtc,
 		goto error;
 	}
 
-	if (!dev_priv->params.enable_dpt &&
+	if (!dev_priv->display.params.enable_dpt &&
 	    intel_fb_modifier_uses_dpt(dev_priv, fb->modifier)) {
 		drm_dbg_kms(&dev_priv->drm, "DPT disabled, skipping initial FB\n");
 		goto error;
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index 3d370e43df3c..773a0a709fc6 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -95,9 +95,6 @@ i915_param_named_unsafe(disable_power_well, int, 0400,
 
 i915_param_named_unsafe(enable_ips, int, 0400, "Enable IPS (default: true)");
 
-i915_param_named_unsafe(enable_dpt, bool, 0400,
-	"Enable display page table (DPT) (default: true)");
-
 i915_param_named_unsafe(load_detect_test, bool, 0400,
 	"Force-enable the VGA load detect code for testing (default:false). "
 	"For developers only.");
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index c3487b9d6937..b8728990cb8b 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -47,7 +47,6 @@ struct drm_printer;
  */
 #define I915_PARAMS_FOR_EACH(param) \
 	param(int, modeset, -1, 0400) \
-	param(bool, enable_dpt, true, 0400) \
 	param(bool, enable_sagv, true, 0600) \
 	param(int, disable_power_well, -1, 0400) \
 	param(int, enable_ips, 1, 0600) \
-- 
2.34.1


  parent reply	other threads:[~2023-10-24 12:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24 12:40 [Intel-gfx] [PATCH v4 00/23] Framework for display parameters Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 01/23] drm/i915/display: Add framework to add parameters specific to display Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 02/23] drm/i915/display: Dump also display parameters Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 03/23] drm/i915/display: Move enable_fbc module parameter under display Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 04/23] drm/i915/display: Move psr related module parameters " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 05/23] drm/i915/display: Move vbt_firmware module parameter " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 06/23] drm/i915/display: Move lvds_channel_mode " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 07/23] drm/i915/display: Move panel_use_ssc " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 08/23] drm/i915/display: Move vbt_sdvo_panel_type " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 09/23] drm/i915/display: Move enable_dc " Jouni Högander
2023-10-24 12:40 ` Jouni Högander [this message]
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 11/23] drm/i915/display: Move enable_sagv " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 12/23] drm/i915/display: Move disable_power_well " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 13/23] drm/i915/display: Move enable_ips " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 14/23] drm/i915/display: Move invert_brightness " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 15/23] drm/i915/display: Move edp_vswing " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 16/23] drm/i915/display: Move enable_dpcd_backlight " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 17/23] drm/i915/display: Move load_detect_test " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 18/23] drm/i915/display: Move force_reset_modeset_test " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 19/23] drm/i915/display: Move disable_display " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 20/23] drm/i915/display: Use device parameters instead of module in I915_STATE_WARN Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 21/23] drm/i915/display: Move verbose_state_checks under display Jouni Högander
2023-10-24 12:55   ` Coelho, Luciano
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 22/23] drm/i915/display: Move nuclear_pageflip " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 23/23] drm/i915/display: Move enable_dp_mst " Jouni Högander
2023-10-24 23:19 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Framework for display parameters (rev5) Patchwork
2023-10-24 23:19 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-10-24 23:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-10-25 15:00 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-10-26  9:23 ` [Intel-gfx] [PATCH v4 00/23] Framework for display parameters Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231024124109.384973-11-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=luciano.coelho@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox