From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Cc: "Nikula, Jani" <jani.nikula@intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH v4 00/23] Framework for display parameters
Date: Thu, 26 Oct 2023 09:23:16 +0000 [thread overview]
Message-ID: <272d7ae21a5418fc0e0c04698e1cbde15befbad0.camel@intel.com> (raw)
In-Reply-To: <20231024124109.384973-1-jouni.hogander@intel.com>
On Tue, 2023-10-24 at 15:40 +0300, Jouni Högander wrote:
> Currently all module parameters are handled by i915_param.c/h. This
> is a problem for display parameters when Xe driver is used.
>
> This patch set adds a mechanism to add parameters specific to the
> display. This is mainly copied from existing i915 parameters
> implementation with some naming changes and taking into account
> varying driver name.
>
> Also all display specific module parameters are moved under display
> and the
> module parameter are all converted as non-writable. This should be ok
> as we have writable device parameters under debugfs.
>
> v4:
> - Change verbose_state_checks device parameter permissions to 0400
>
> v3:
> - Change enable_ip as boolean
> - Fix enable_psr2_sel_fetch description
> - Add default value into psr_safest_params description
> - Drop unused predefinition (dentry) from
> intel_display_debugfs_params.h
> v2:
> - Drop fastboot parameter
> - Include display parameters into i915_capabilities debugfs
> interface
Thank you Luca, Jani and Tvrtko for checking my patches. These are all
now merged.
BR,
Jouni Högander
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Uma Shankar <uma.shankar@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Luca Coelho <luca@coelho.fi>
>
> Jouni Högander (23):
> drm/i915/display: Add framework to add parameters specific to
> display
> drm/i915/display: Dump also display parameters
> drm/i915/display: Move enable_fbc module parameter under display
> drm/i915/display: Move psr related module parameters under display
> drm/i915/display: Move vbt_firmware module parameter under display
> drm/i915/display: Move lvds_channel_mode module parameter under
> display
> drm/i915/display: Move panel_use_ssc module parameter under display
> drm/i915/display: Move vbt_sdvo_panel_type module parameter under
> display
> drm/i915/display: Move enable_dc module parameter under display
> drm/i915/display: Move enable_dpt module parameter under display
> drm/i915/display: Move enable_sagv module parameter under display
> drm/i915/display: Move disable_power_well module parameter under
> display
> drm/i915/display: Move enable_ips module parameter under display
> drm/i915/display: Move invert_brightness module parameter under
> display
> drm/i915/display: Move edp_vswing module parameter under display
> drm/i915/display: Move enable_dpcd_backlight module parameter under
> display
> drm/i915/display: Move load_detect_test parameter under display
> drm/i915/display: Move force_reset_modeset_test parameter under
> display
> drm/i915/display: Move disable_display parameter under display
> drm/i915/display: Use device parameters instead of module in
> I915_STATE_WARN
> drm/i915/display: Move verbose_state_checks under display
> drm/i915/display: Move nuclear_pageflip under display
> drm/i915/display: Move enable_dp_mst under display
>
> drivers/gpu/drm/i915/Makefile | 2 +
> drivers/gpu/drm/i915/display/hsw_ips.c | 4 +-
> drivers/gpu/drm/i915/display/i9xx_wm.c | 2 +-
> .../gpu/drm/i915/display/intel_backlight.c | 9 +-
> drivers/gpu/drm/i915/display/intel_bios.c | 6 +-
> drivers/gpu/drm/i915/display/intel_crt.c | 4 +-
> drivers/gpu/drm/i915/display/intel_display.h | 2 +-
> .../gpu/drm/i915/display/intel_display_core.h | 2 +
> .../drm/i915/display/intel_display_debugfs.c | 2 +
> .../display/intel_display_debugfs_params.c | 176 ++++++++++++++
> .../display/intel_display_debugfs_params.h | 13 ++
> .../drm/i915/display/intel_display_device.c | 13 +-
> .../drm/i915/display/intel_display_device.h | 1 +
> .../drm/i915/display/intel_display_params.c | 217
> ++++++++++++++++++
> .../drm/i915/display/intel_display_params.h | 61 +++++
> .../drm/i915/display/intel_display_power.c | 14 +-
> .../drm/i915/display/intel_display_reset.c | 2 +-
> drivers/gpu/drm/i915/display/intel_dp.c | 6 +-
> .../drm/i915/display/intel_dp_aux_backlight.c | 4 +-
> drivers/gpu/drm/i915/display/intel_dpt.c | 6 +-
> drivers/gpu/drm/i915/display/intel_fb.c | 2 +-
> drivers/gpu/drm/i915/display/intel_fbc.c | 10 +-
> drivers/gpu/drm/i915/display/intel_lvds.c | 4 +-
> drivers/gpu/drm/i915/display/intel_opregion.c | 2 +-
> drivers/gpu/drm/i915/display/intel_panel.c | 4 +-
> drivers/gpu/drm/i915/display/intel_psr.c | 14 +-
> .../drm/i915/display/skl_universal_plane.c | 2 +-
> drivers/gpu/drm/i915/display/skl_watermark.c | 5 +-
> drivers/gpu/drm/i915/i915_debugfs.c | 3 +
> drivers/gpu/drm/i915/i915_driver.c | 2 +
> drivers/gpu/drm/i915/i915_gpu_error.c | 3 +
> drivers/gpu/drm/i915/i915_gpu_error.h | 2 +
> drivers/gpu/drm/i915/i915_params.c | 89 -------
> drivers/gpu/drm/i915/i915_params.h | 22 --
> 34 files changed, 548 insertions(+), 162 deletions(-)
> create mode 100644
> drivers/gpu/drm/i915/display/intel_display_debugfs_params.c
> create mode 100644
> drivers/gpu/drm/i915/display/intel_display_debugfs_params.h
> create mode 100644
> drivers/gpu/drm/i915/display/intel_display_params.c
> create mode 100644
> drivers/gpu/drm/i915/display/intel_display_params.h
>
prev parent reply other threads:[~2023-10-26 9:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 12:40 [Intel-gfx] [PATCH v4 00/23] Framework for display parameters Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 01/23] drm/i915/display: Add framework to add parameters specific to display Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 02/23] drm/i915/display: Dump also display parameters Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 03/23] drm/i915/display: Move enable_fbc module parameter under display Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 04/23] drm/i915/display: Move psr related module parameters " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 05/23] drm/i915/display: Move vbt_firmware module parameter " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 06/23] drm/i915/display: Move lvds_channel_mode " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 07/23] drm/i915/display: Move panel_use_ssc " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 08/23] drm/i915/display: Move vbt_sdvo_panel_type " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 09/23] drm/i915/display: Move enable_dc " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 10/23] drm/i915/display: Move enable_dpt " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 11/23] drm/i915/display: Move enable_sagv " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 12/23] drm/i915/display: Move disable_power_well " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 13/23] drm/i915/display: Move enable_ips " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 14/23] drm/i915/display: Move invert_brightness " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 15/23] drm/i915/display: Move edp_vswing " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 16/23] drm/i915/display: Move enable_dpcd_backlight " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 17/23] drm/i915/display: Move load_detect_test " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 18/23] drm/i915/display: Move force_reset_modeset_test " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 19/23] drm/i915/display: Move disable_display " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 20/23] drm/i915/display: Use device parameters instead of module in I915_STATE_WARN Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 21/23] drm/i915/display: Move verbose_state_checks under display Jouni Högander
2023-10-24 12:55 ` Coelho, Luciano
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 22/23] drm/i915/display: Move nuclear_pageflip " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 23/23] drm/i915/display: Move enable_dp_mst " Jouni Högander
2023-10-24 23:19 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Framework for display parameters (rev5) Patchwork
2023-10-24 23:19 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-10-24 23:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-10-25 15:00 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-10-26 9:23 ` Hogander, Jouni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=272d7ae21a5418fc0e0c04698e1cbde15befbad0.camel@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox