Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Luca Coelho <luciano.coelho@intel.com>
Subject: [Intel-gfx] [PATCH v4 13/23] drm/i915/display: Move enable_ips module parameter under display
Date: Tue, 24 Oct 2023 15:40:59 +0300	[thread overview]
Message-ID: <20231024124109.384973-14-jouni.hogander@intel.com> (raw)
In-Reply-To: <20231024124109.384973-1-jouni.hogander@intel.com>

Move enable_ips module parameter under display and change it as boolean.

v2:
  - Change enable_ip as boolean
  - Fix copy paste error (i915_param -> intel_display_param)

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/gpu/drm/i915/display/hsw_ips.c              | 4 ++--
 drivers/gpu/drm/i915/display/intel_display_params.c | 2 ++
 drivers/gpu/drm/i915/display/intel_display_params.h | 1 +
 drivers/gpu/drm/i915/i915_params.c                  | 2 --
 drivers/gpu/drm/i915/i915_params.h                  | 1 -
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/hsw_ips.c b/drivers/gpu/drm/i915/display/hsw_ips.c
index 7dc38ac02092..611a7d6ef80c 100644
--- a/drivers/gpu/drm/i915/display/hsw_ips.c
+++ b/drivers/gpu/drm/i915/display/hsw_ips.c
@@ -193,7 +193,7 @@ bool hsw_crtc_state_ips_capable(const struct intel_crtc_state *crtc_state)
 	if (!hsw_crtc_supports_ips(crtc))
 		return false;
 
-	if (!i915->params.enable_ips)
+	if (!i915->display.params.enable_ips)
 		return false;
 
 	if (crtc_state->pipe_bpp > 24)
@@ -329,7 +329,7 @@ static int hsw_ips_debugfs_status_show(struct seq_file *m, void *unused)
 	wakeref = intel_runtime_pm_get(&i915->runtime_pm);
 
 	seq_printf(m, "Enabled by kernel parameter: %s\n",
-		   str_yes_no(i915->params.enable_ips));
+		   str_yes_no(i915->display.params.enable_ips));
 
 	if (DISPLAY_VER(i915) >= 8) {
 		seq_puts(m, "Currently: unknown\n");
diff --git a/drivers/gpu/drm/i915/display/intel_display_params.c b/drivers/gpu/drm/i915/display/intel_display_params.c
index 79a212dded80..ce991ad20006 100644
--- a/drivers/gpu/drm/i915/display/intel_display_params.c
+++ b/drivers/gpu/drm/i915/display/intel_display_params.c
@@ -57,6 +57,8 @@ intel_display_param_named_unsafe(disable_power_well, int, 0400,
 	"Disable display power wells when possible "
 	"(-1=auto [default], 0=power wells always on, 1=power wells disabled when possible)");
 
+intel_display_param_named_unsafe(enable_ips, bool, 0400, "Enable IPS (default: true)");
+
 intel_display_param_named_unsafe(enable_fbc, int, 0400,
 	"Enable frame buffer compression for power savings "
 	"(default: -1 (use per-chip default))");
diff --git a/drivers/gpu/drm/i915/display/intel_display_params.h b/drivers/gpu/drm/i915/display/intel_display_params.h
index aadbef664965..8d51488e3b3e 100644
--- a/drivers/gpu/drm/i915/display/intel_display_params.h
+++ b/drivers/gpu/drm/i915/display/intel_display_params.h
@@ -32,6 +32,7 @@ struct drm_i915_private;
 	param(bool, enable_dpt, true, 0400) \
 	param(bool, enable_sagv, true, 0600) \
 	param(int, disable_power_well, -1, 0400) \
+	param(bool, enable_ips, true, 0600) \
 	param(int, enable_fbc, -1, 0600) \
 	param(int, enable_psr, -1, 0600) \
 	param(bool, psr_safest_params, false, 0400) \
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index eab02f71a4e5..54dcce97da2a 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -86,8 +86,6 @@ i915_param_named_unsafe(force_probe, charp, 0400,
 	"Force probe options for specified supported devices. "
 	"See CONFIG_DRM_I915_FORCE_PROBE for details.");
 
-i915_param_named_unsafe(enable_ips, int, 0400, "Enable IPS (default: true)");
-
 i915_param_named_unsafe(load_detect_test, bool, 0400,
 	"Force-enable the VGA load detect code for testing (default:false). "
 	"For developers only.");
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index 060464df03c2..18bb8a93e0e8 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -47,7 +47,6 @@ struct drm_printer;
  */
 #define I915_PARAMS_FOR_EACH(param) \
 	param(int, modeset, -1, 0400) \
-	param(int, enable_ips, 1, 0600) \
 	param(int, invert_brightness, 0, 0600) \
 	param(int, enable_guc, -1, 0400) \
 	param(int, guc_log_level, -1, 0400) \
-- 
2.34.1


  parent reply	other threads:[~2023-10-24 12:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24 12:40 [Intel-gfx] [PATCH v4 00/23] Framework for display parameters Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 01/23] drm/i915/display: Add framework to add parameters specific to display Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 02/23] drm/i915/display: Dump also display parameters Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 03/23] drm/i915/display: Move enable_fbc module parameter under display Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 04/23] drm/i915/display: Move psr related module parameters " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 05/23] drm/i915/display: Move vbt_firmware module parameter " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 06/23] drm/i915/display: Move lvds_channel_mode " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 07/23] drm/i915/display: Move panel_use_ssc " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 08/23] drm/i915/display: Move vbt_sdvo_panel_type " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 09/23] drm/i915/display: Move enable_dc " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 10/23] drm/i915/display: Move enable_dpt " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 11/23] drm/i915/display: Move enable_sagv " Jouni Högander
2023-10-24 12:40 ` [Intel-gfx] [PATCH v4 12/23] drm/i915/display: Move disable_power_well " Jouni Högander
2023-10-24 12:40 ` Jouni Högander [this message]
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 14/23] drm/i915/display: Move invert_brightness " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 15/23] drm/i915/display: Move edp_vswing " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 16/23] drm/i915/display: Move enable_dpcd_backlight " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 17/23] drm/i915/display: Move load_detect_test " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 18/23] drm/i915/display: Move force_reset_modeset_test " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 19/23] drm/i915/display: Move disable_display " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 20/23] drm/i915/display: Use device parameters instead of module in I915_STATE_WARN Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 21/23] drm/i915/display: Move verbose_state_checks under display Jouni Högander
2023-10-24 12:55   ` Coelho, Luciano
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 22/23] drm/i915/display: Move nuclear_pageflip " Jouni Högander
2023-10-24 12:41 ` [Intel-gfx] [PATCH v4 23/23] drm/i915/display: Move enable_dp_mst " Jouni Högander
2023-10-24 23:19 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Framework for display parameters (rev5) Patchwork
2023-10-24 23:19 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-10-24 23:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-10-25 15:00 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-10-26  9:23 ` [Intel-gfx] [PATCH v4 00/23] Framework for display parameters Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231024124109.384973-14-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=luciano.coelho@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox