From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 02/12] drm/i915/psr: Do not check alpm on DP or capability change for panel replay
Date: Thu, 4 Jan 2024 12:48:11 +0200 [thread overview]
Message-ID: <20240104104821.1822988-3-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240104104821.1822988-1-jouni.hogander@intel.com>
Alpm is eDP specific. Do not check if not eDP. Also panel replay doesn't
know about capability changes -> no need to check that.
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
drivers/gpu/drm/i915/display/intel_psr.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index fc1b068755db..35cef210ff2f 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -2924,8 +2924,11 @@ void intel_psr_short_pulse(struct intel_dp *intel_dp)
/* clear status register */
drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_ERROR_STATUS, error_status);
- psr_alpm_check(intel_dp);
- psr_capability_changed_check(intel_dp);
+ if (intel_dp_is_edp(intel_dp))
+ psr_alpm_check(intel_dp);
+
+ if (!psr->panel_replay_enabled)
+ psr_capability_changed_check(intel_dp);
exit:
mutex_unlock(&psr->lock);
--
2.34.1
next prev parent reply other threads:[~2024-01-04 10:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 10:48 [PATCH 00/12] Panel replay selective update support Jouni Högander
2024-01-04 10:48 ` [PATCH 01/12] drm/i915/psr: Disable panel replay for now Jouni Högander
2024-01-04 10:48 ` Jouni Högander [this message]
2024-01-04 10:48 ` [PATCH 03/12] drm/i915/psr: Unify panel replay enable sink Jouni Högander
2024-01-04 10:48 ` [PATCH 04/12] drm/i915/psr: Rename has_psr2 as has_sel_update Jouni Högander
2024-01-04 10:48 ` [PATCH 05/12] drm/i915/psr: Rename psr2_enabled as sel_update_enabled Jouni Högander
2024-01-04 10:48 ` [PATCH 06/12] drm/i915/psr: Add some documentation of variables used in psr code Jouni Högander
2024-01-04 10:48 ` [PATCH 07/12] drm/i915/psr: Add sink_panel_replay_su_support to intel_psr Jouni Högander
2024-01-04 10:48 ` [PATCH 08/12] drm/i915/psr: Detect panel replay selective update support Jouni Högander
2024-01-04 10:48 ` [PATCH 09/12] drm/i915/psr: Split intel_psr2_config_valid for panel replay Jouni Högander
2024-01-04 10:48 ` [PATCH 10/12] drm/panelreplay: dpcd register definition for panelreplay SU Jouni Högander
2024-01-04 10:59 ` Dmitry Baryshkov
2024-01-10 13:20 ` Hogander, Jouni
2024-01-04 10:48 ` [PATCH 11/12] drm/i915/psr: Modify intel_dp_get_su_granularity to support panel replay Jouni Högander
2024-01-04 10:48 ` [PATCH 12/12] drm/i915/psr: Add panel replay sel update support to debugfs interface Jouni Högander
2024-01-04 13:14 ` ✗ Fi.CI.CHECKPATCH: warning for Panel replay selective update support Patchwork
2024-01-04 13:14 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-01-04 13:33 ` ✓ Fi.CI.BAT: success " Patchwork
2024-01-04 14:45 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240104104821.1822988-3-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox