Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 06/12] drm/i915/psr: Add some documentation of variables used in psr code
Date: Thu,  4 Jan 2024 12:48:15 +0200	[thread overview]
Message-ID: <20240104104821.1822988-7-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240104104821.1822988-1-jouni.hogander@intel.com>

We are adding more boolean variable into intel_psr and intel_crtc_state
structs. Add some documentation about these for sake of clarity.

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 29fe46ae016f..f66fdda7418a 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -171,6 +171,22 @@
  *
  * The rest of the bits are more self-explanatory and/or
  * irrelevant for normal operation.
+ *
+ * Description of intel_crtc_state variables. has_psr, has_panel_replay and
+ * has_sel_update:
+ *
+ *  has_psr (alone):			PSR1
+ *  has_psr + has_sel_update:		PSR2
+ *  has_panel_replay:			Panel Replay
+ *  has_panel_replay + has_sel_update:	Panel Replay Selective Update
+ *
+ * Description of some intel_psr enabled, panel_replay_enabled,
+ * sel_update_enabled
+ *
+ *  enabled (alone):						PSR1
+ *  enabled + sel_update_enabled:				PSR2
+ *  enabled + panel_replay_enabled:				Panel Replay
+ *  enabled + panel_replay_enabled + sel_update_enabled:	Panel Replay SU
  */
 
 bool intel_encoder_can_psr(struct intel_encoder *encoder)
-- 
2.34.1


  parent reply	other threads:[~2024-01-04 10:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-04 10:48 [PATCH 00/12] Panel replay selective update support Jouni Högander
2024-01-04 10:48 ` [PATCH 01/12] drm/i915/psr: Disable panel replay for now Jouni Högander
2024-01-04 10:48 ` [PATCH 02/12] drm/i915/psr: Do not check alpm on DP or capability change for panel replay Jouni Högander
2024-01-04 10:48 ` [PATCH 03/12] drm/i915/psr: Unify panel replay enable sink Jouni Högander
2024-01-04 10:48 ` [PATCH 04/12] drm/i915/psr: Rename has_psr2 as has_sel_update Jouni Högander
2024-01-04 10:48 ` [PATCH 05/12] drm/i915/psr: Rename psr2_enabled as sel_update_enabled Jouni Högander
2024-01-04 10:48 ` Jouni Högander [this message]
2024-01-04 10:48 ` [PATCH 07/12] drm/i915/psr: Add sink_panel_replay_su_support to intel_psr Jouni Högander
2024-01-04 10:48 ` [PATCH 08/12] drm/i915/psr: Detect panel replay selective update support Jouni Högander
2024-01-04 10:48 ` [PATCH 09/12] drm/i915/psr: Split intel_psr2_config_valid for panel replay Jouni Högander
2024-01-04 10:48 ` [PATCH 10/12] drm/panelreplay: dpcd register definition for panelreplay SU Jouni Högander
2024-01-04 10:59   ` Dmitry Baryshkov
2024-01-10 13:20     ` Hogander, Jouni
2024-01-04 10:48 ` [PATCH 11/12] drm/i915/psr: Modify intel_dp_get_su_granularity to support panel replay Jouni Högander
2024-01-04 10:48 ` [PATCH 12/12] drm/i915/psr: Add panel replay sel update support to debugfs interface Jouni Högander
2024-01-04 13:14 ` ✗ Fi.CI.CHECKPATCH: warning for Panel replay selective update support Patchwork
2024-01-04 13:14 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-01-04 13:33 ` ✓ Fi.CI.BAT: success " Patchwork
2024-01-04 14:45 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240104104821.1822988-7-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox