Re: [PATCH 10/12] drm/panelreplay: dpcd register definition for panelreplay SU

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Thu, 2024-01-04 at 12:59 +0200, Dmitry Baryshkov wrote:
> On Thu, 4 Jan 2024 at 12:49, Jouni Högander
> <jouni.hogander@intel.com> wrote:
> > 
> > Add definitions for panel replay selective update
> > 
> > Cc: dri-devel@lists.freedesktop.org
> > 
> 
> 1) This CC should not be necessary. It is already a part of
> maintainers entry for this file
> 
> 2) It probably doesn't work as expected. It is separated with the
> blank link from the rest of the trailers, so most of the tools will
> skip it.
> 
> 3) You have skipped the rest of the maintainers for this file. Please
> use ./scripts/get_maintainers.pl and pass corresponding options to
> git
> send-email.

Thank you Dmitry for checking my patch. Sent now version 2. of my patch
set. There I took care of your suggestions in patch 11.

BR,

Jouni Högander
> 
> > Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> > ---
> >  include/drm/display/drm_dp.h | 6 ++++++
> >  1 file changed, 6 insertions(+)
> 
> The patch itself looks good to me.
> 
> > 
> > diff --git a/include/drm/display/drm_dp.h
> > b/include/drm/display/drm_dp.h
> > index 3731828825bd..6a59d30b7b25 100644
> > --- a/include/drm/display/drm_dp.h
> > +++ b/include/drm/display/drm_dp.h
> > @@ -548,6 +548,12 @@
> >  # define DP_PANEL_REPLAY_SUPPORT            (1 << 0)
> >  # define DP_PANEL_REPLAY_SU_SUPPORT         (1 << 1)
> > 
> > +#define DP_PANEL_PANEL_REPLAY_CAPABILITY               0xb1
> > +# define DP_PANEL_PANEL_REPLAY_SU_GRANULARITY_REQUIRED (1 << 5)
> > +
> > +#define DP_PANEL_PANEL_REPLAY_X_GRANULARITY            0xb2
> > +#define DP_PANEL_PANEL_REPLAY_Y_GRANULARITY            0xb4
> > +
> >  /* Link Configuration */
> >  #define        DP_LINK_BW_SET                      0x100
> >  # define DP_LINK_RATE_TABLE                0x00    /* eDP 1.4 */
> > --
> > 2.34.1
> > 
> 
>