From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: stable@vger.kernel.org, "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: [PATCH v2 1/6] drm/i915/dp: Reset intel_dp->link_trained before retraining the link
Date: Mon, 8 Jul 2024 22:00:24 +0300 [thread overview]
Message-ID: <20240708190029.271247-2-imre.deak@intel.com> (raw)
In-Reply-To: <20240708190029.271247-1-imre.deak@intel.com>
Regularly retraining a link during an atomic commit happens with the
given pipe/link already disabled and hence intel_dp->link_trained being
false. Ensure this also for retraining a DP SST link via direct calls to
the link training functions (vs. an actual commit as for DP MST). So far
nothing depended on this, however the next patch will depend on
link_trained==false for changing the LTTPR mode to non-transparent.
Cc: <stable@vger.kernel.org> # v5.15+
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 3903f6ead6e66..59f11af3b0a1d 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -5314,6 +5314,8 @@ static int intel_dp_retrain_link(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state =
to_intel_crtc_state(crtc->base.state);
+ intel_dp->link_trained = false;
+
intel_dp_check_frl_training(intel_dp);
intel_dp_pcon_dsc_configure(intel_dp, crtc_state);
intel_dp_start_link_train(NULL, intel_dp, crtc_state);
--
2.43.3
next prev parent reply other threads:[~2024-07-08 19:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 19:00 [PATCH v2 0/6] drm/i915/dp: Fix LTTPR detection Imre Deak
2024-07-08 19:00 ` Imre Deak [this message]
2024-07-11 9:38 ` [PATCH v2 1/6] drm/i915/dp: Reset intel_dp->link_trained before retraining the link Nautiyal, Ankit K
2024-07-08 19:00 ` [PATCH v2 2/6] drm/i915/dp: Don't switch the LTTPR mode on an active link Imre Deak
2024-07-11 9:40 ` Nautiyal, Ankit K
2024-07-08 19:00 ` [PATCH v2 3/6] drm/i915/dp: Reset cached LTTPR count if number of LTTPRs is unsupported Imre Deak
2024-07-11 9:41 ` Nautiyal, Ankit K
2024-07-08 19:00 ` [PATCH v2 4/6] drm/i915/dp: Keep cached LTTPR mode up-to-date Imre Deak
2024-07-11 9:42 ` Nautiyal, Ankit K
2024-07-08 19:00 ` [PATCH v2 5/6] drm/dp: Add helper to dump an LTTPR PHY descriptor Imre Deak
2024-07-11 9:43 ` Nautiyal, Ankit K
2024-07-08 19:00 ` [PATCH v2 6/6] drm/i915/dp: Dump the LTTPR PHY descriptors Imre Deak
2024-07-11 9:50 ` Nautiyal, Ankit K
2024-07-11 10:53 ` Imre Deak
2024-07-08 19:50 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: Fix LTTPR detection (rev2) Patchwork
2024-07-08 19:50 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-07-08 19:59 ` ✓ Fi.CI.BAT: success " Patchwork
2024-07-09 11:12 ` ✓ Fi.CI.IGT: " Patchwork
2024-07-11 18:49 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240708190029.271247-2-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox