Re: [PATCH v2 6/6] drm/i915/dp: Dump the LTTPR PHY descriptors

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 7/9/2024 12:30 AM, Imre Deak wrote:
> Dump the descriptor of the detected LTTPRs in non-transparent mode to
> help the debugging related to LTTPRs easier.
>
> v2: Use drm_dp_dump_lttpr_desc() instead of the driver specific
>      equivalent.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> # v1
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_dp_link_training.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> index af0b71bdf1fcf..ab72aa1d664dc 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> @@ -20,6 +20,7 @@
>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
>    * IN THE SOFTWARE.
>    */
> +#include <drm/display/drm_dp_helper.h>

nitpick : I wonder if we should leave a line after the license header.

In any case patch looks good to me.

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

>   
>   #include "i915_drv.h"
>   #include "intel_display_types.h"
> @@ -206,8 +207,10 @@ static int intel_dp_init_lttpr(struct intel_dp *intel_dp, const u8 dpcd[DP_RECEI
>   
>   	lttpr_count = intel_dp_init_lttpr_phys(intel_dp, dpcd);
>   
> -	for (i = 0; i < lttpr_count; i++)
> +	for (i = 0; i < lttpr_count; i++) {
>   		intel_dp_read_lttpr_phy_caps(intel_dp, dpcd, DP_PHY_LTTPR(i));
> +		drm_dp_dump_lttpr_desc(&intel_dp->aux, DP_PHY_LTTPR(i));
> +	}
>   
>   	return lttpr_count;
>   }