From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Imre Deak <imre.deak@intel.com>, <intel-gfx@lists.freedesktop.org>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v2 3/6] drm/i915/dp: Reset cached LTTPR count if number of LTTPRs is unsupported
Date: Thu, 11 Jul 2024 15:11:25 +0530 [thread overview]
Message-ID: <c1355d11-1e61-4bd0-874a-b6b59b5941ce@intel.com> (raw)
In-Reply-To: <20240708190029.271247-4-imre.deak@intel.com>
LGTM.
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
On 7/9/2024 12:30 AM, Imre Deak wrote:
> After detection the cached LTTPR count can be checked to determine if
> LTTPRs in non-transparent mode were detected. Reset the cached LTTPR
> count if the reported number of LTTPRs is invalid to ensure the above
> checks work as expected.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> index d044c8e36bb3d..56b9c5cb1254d 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> @@ -174,7 +174,7 @@ static int intel_dp_init_lttpr_phys(struct intel_dp *intel_dp, const u8 dpcd[DP_
> * still taking into account any LTTPR common lane- rate/count limits.
> */
> if (lttpr_count < 0)
> - return 0;
> + goto out_reset_lttpr_count;
>
> if (!intel_dp_set_lttpr_transparent_mode(intel_dp, false)) {
> lt_dbg(intel_dp, DP_PHY_DPRX,
next prev parent reply other threads:[~2024-07-11 9:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 19:00 [PATCH v2 0/6] drm/i915/dp: Fix LTTPR detection Imre Deak
2024-07-08 19:00 ` [PATCH v2 1/6] drm/i915/dp: Reset intel_dp->link_trained before retraining the link Imre Deak
2024-07-11 9:38 ` Nautiyal, Ankit K
2024-07-08 19:00 ` [PATCH v2 2/6] drm/i915/dp: Don't switch the LTTPR mode on an active link Imre Deak
2024-07-11 9:40 ` Nautiyal, Ankit K
2024-07-08 19:00 ` [PATCH v2 3/6] drm/i915/dp: Reset cached LTTPR count if number of LTTPRs is unsupported Imre Deak
2024-07-11 9:41 ` Nautiyal, Ankit K [this message]
2024-07-08 19:00 ` [PATCH v2 4/6] drm/i915/dp: Keep cached LTTPR mode up-to-date Imre Deak
2024-07-11 9:42 ` Nautiyal, Ankit K
2024-07-08 19:00 ` [PATCH v2 5/6] drm/dp: Add helper to dump an LTTPR PHY descriptor Imre Deak
2024-07-11 9:43 ` Nautiyal, Ankit K
2024-07-08 19:00 ` [PATCH v2 6/6] drm/i915/dp: Dump the LTTPR PHY descriptors Imre Deak
2024-07-11 9:50 ` Nautiyal, Ankit K
2024-07-11 10:53 ` Imre Deak
2024-07-08 19:50 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: Fix LTTPR detection (rev2) Patchwork
2024-07-08 19:50 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-07-08 19:59 ` ✓ Fi.CI.BAT: success " Patchwork
2024-07-09 11:12 ` ✓ Fi.CI.IGT: " Patchwork
2024-07-11 18:49 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1355d11-1e61-4bd0-874a-b6b59b5941ce@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox