* [PATCH 0/4] Miscelaneous fixes for display tracepoints
@ 2024-08-29 22:00 Gustavo Sousa
2024-08-29 22:00 ` [PATCH 1/4] drm/i915/display: Fix out-of-bounds access in pipe-related tracepoints Gustavo Sousa
` (6 more replies)
0 siblings, 7 replies; 14+ messages in thread
From: Gustavo Sousa @ 2024-08-29 22:00 UTC (permalink / raw)
To: intel-gfx
I recently bumped into some issues while using trace-cmd to inspect i915
display trace events. This series of patches provides fixes for them.
Gustavo Sousa (4):
drm/i915/display: Fix out-of-bounds access in pipe-related tracepoints
drm/i915/display: Store pipe name in trace events
drm/i915/display: Do not use ids from enum pipe in TP_printk()
drm/i915/display: Cover all possible pipes in TP_printk()
.../drm/i915/display/intel_display_trace.h | 187 ++++++++++--------
1 file changed, 106 insertions(+), 81 deletions(-)
--
2.46.0
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/4] drm/i915/display: Fix out-of-bounds access in pipe-related tracepoints
2024-08-29 22:00 [PATCH 0/4] Miscelaneous fixes for display tracepoints Gustavo Sousa
@ 2024-08-29 22:00 ` Gustavo Sousa
2024-09-18 22:13 ` Matt Roper
2024-08-29 22:00 ` [PATCH 2/4] drm/i915/display: Store pipe name in trace events Gustavo Sousa
` (5 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Gustavo Sousa @ 2024-08-29 22:00 UTC (permalink / raw)
To: intel-gfx
Some display trace events use array members to store frame and scanline
counts for each pipe. However, those arrays are declared with 3 as the
hardcoded size, which cause out-of-bounds access when the trace event is
enabled on a platform that contains pipe D.
For example, when looking at the last 10 intel_pipe_enable events after
running IGT's testdisplay, we see the following on a MTL machine that
has pipe D available:
$ trace-cmd report -R -F intel_pipe_enable \
> | tail \
> | sed 's,\(frame=.*\) \(scanline=.*\),\n\t \1\n\t\2,'
testdisplay-6715 [002] 17591.063491: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[83, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
testdisplay-6715 [003] 17591.264742: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[89, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
testdisplay-6715 [003] 17591.464541: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[8f, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
testdisplay-6715 [001] 17591.695827: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[95, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
testdisplay-6715 [000] 17591.915841: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[9a, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
testdisplay-6715 [000] 17592.127114: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[a0, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
testdisplay-6715 [002] 17592.358351: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[a8, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
testdisplay-6715 [002] 17592.580467: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[ae, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
testdisplay-6715 [000] 17592.950946: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[b8, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
testdisplay-6715 [004] 17593.079597: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[bf, 01, 00, 00, 01, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[00, 00, 00, 00, 3a, 04, 00, 00, 00, 00, 00, 00] pipe=1
Which shows zeros for pipe A's scanline counts. That happens because
pipe D's frame counts are overwriting them.
Let's fix that by making the arrays bring able to store info for all
possible pipes.
With the fix, we get the following:
$ trace-cmd report -R -F intel_pipe_enable \
> | tail \
> | sed 's,\(frame=.*\) \(scanline=.*\),\n\t \1\n\t\2,'
testdisplay-7040 [003] 18067.489565: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[8c, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[8e, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
testdisplay-7040 [002] 18067.699312: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[92, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[58, 02, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
testdisplay-7040 [002] 18067.908868: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[98, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[58, 02, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
testdisplay-7040 [002] 18068.122802: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[9d, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[58, 02, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
testdisplay-7040 [003] 18068.331019: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[a2, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[e0, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
testdisplay-7040 [002] 18068.529067: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[a8, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[e0, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
testdisplay-7040 [003] 18068.742033: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[ae, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[e0, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
testdisplay-7040 [002] 18068.956229: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[b3, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[1f, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
testdisplay-7040 [002] 18069.295322: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[bb, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[7b, 08, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
testdisplay-7040 [010] 18069.423527: intel_pipe_enable: dev=0000:00:02.0
frame=ARRAY[c2, 01, 00, 00, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
scanline=ARRAY[d0, 05, 00, 00, 3a, 04, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=1
Which makes more sense now.
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
---
drivers/gpu/drm/i915/display/intel_display_trace.h | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_trace.h b/drivers/gpu/drm/i915/display/intel_display_trace.h
index c734ef1fba3c..8a3185862089 100644
--- a/drivers/gpu/drm/i915/display/intel_display_trace.h
+++ b/drivers/gpu/drm/i915/display/intel_display_trace.h
@@ -15,6 +15,7 @@
#include "i915_drv.h"
#include "intel_crtc.h"
+#include "intel_display_limits.h"
#include "intel_display_types.h"
#include "intel_vblank.h"
@@ -27,8 +28,8 @@ TRACE_EVENT(intel_pipe_enable,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(crtc))
- __array(u32, frame, 3)
- __array(u32, scanline, 3)
+ __array(u32, frame, I915_MAX_PIPES)
+ __array(u32, scanline, I915_MAX_PIPES)
__field(enum pipe, pipe)
),
TP_fast_assign(
@@ -55,8 +56,8 @@ TRACE_EVENT(intel_pipe_disable,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(crtc))
- __array(u32, frame, 3)
- __array(u32, scanline, 3)
+ __array(u32, frame, I915_MAX_PIPES)
+ __array(u32, scanline, I915_MAX_PIPES)
__field(enum pipe, pipe)
),
@@ -184,8 +185,8 @@ TRACE_EVENT(intel_memory_cxsr,
TP_STRUCT__entry(
__string(dev, __dev_name_i915(dev_priv))
- __array(u32, frame, 3)
- __array(u32, scanline, 3)
+ __array(u32, frame, I915_MAX_PIPES)
+ __array(u32, scanline, I915_MAX_PIPES)
__field(bool, old)
__field(bool, new)
),
--
2.46.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/4] drm/i915/display: Store pipe name in trace events
2024-08-29 22:00 [PATCH 0/4] Miscelaneous fixes for display tracepoints Gustavo Sousa
2024-08-29 22:00 ` [PATCH 1/4] drm/i915/display: Fix out-of-bounds access in pipe-related tracepoints Gustavo Sousa
@ 2024-08-29 22:00 ` Gustavo Sousa
2024-09-18 22:37 ` Matt Roper
2024-08-29 22:00 ` [PATCH 3/4] drm/i915/display: Do not use ids from enum pipe in TP_printk() Gustavo Sousa
` (4 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Gustavo Sousa @ 2024-08-29 22:00 UTC (permalink / raw)
To: intel-gfx
The first part[1] of the LWN series on using TRACE_EVENT() mentions
about TP_printk():
"Do not create new tracepoint-specific helpers, because that will
confuse user-space tools that know about the TRACE_EVENT() helper
macros but will not know how to handle ones created for individual
tracepoints."
It seems this is what we ended up doing when using pipe_name() in
TP_printk().
For example, the format for the intel_pipe_update_start event is as
follows:
# cat /sys/kernel/debug/tracing/events/i915/intel_pipe_update_start/format
name: intel_pipe_update_start
ID: 1136
format:
field:unsigned short common_type; offset:0; size:2; signed:0;
field:unsigned char common_flags; offset:2; size:1; signed:0;
field:unsigned char common_preempt_count; offset:3; size:1; signed:0;
field:int common_pid; offset:4; size:4; signed:1;
field:__data_loc char[] dev; offset:8; size:4; signed:0;
field:enum pipe pipe; offset:12; size:4; signed:1;
field:u32 frame; offset:16; size:4; signed:0;
field:u32 scanline; offset:20; size:4; signed:0;
field:u32 min; offset:24; size:4; signed:0;
field:u32 max; offset:28; size:4; signed:0;
print fmt: "dev %s, pipe %c, frame=%u, scanline=%u, min=%u, max=%u", __get_str(dev), ((REC->pipe) + 'A'), REC->frame, REC->scanline, REC->min, REC->max
The call to pipe_name(__entry->pipe) is expanted to ((REC->pipe) + 'A')
and that's how the format is saved.
Even though the output from /sys/kernel/debug/tracing/trace will look
correct (because it is generated in the kernel), we will see corrupted
lines when using a tool like trace-cmd to view the data.
While the output looks correct when looking at
/sys/kernel/debug/tracing/trace, we see corrupted lines when viewing the
trace data with "trace-cmd report":
$ trace-cmd report \
> | sed -n 's/.*dev 0000:00:02\.0, \(pipe .\).*/\1/p' \
> | cat -v | uniq -c
34 pipe ^A
, where ^A is a non-printable character.
As a fix, let's store the pipe name directly in the event. The fix was
done by applying the following sed script:
s/__field\s*(\s*enum\s\+pipe\s*,\s*pipe\s*)/__field(char, pipe_name)/
s/__entry\s*->\s*pipe\s*=\s*\([^;]\+\);/__entry->pipe_name = pipe_name(\1);/
s/pipe_name\s*(\s*__entry\s*->\s*pipe\s*)/__entry->pipe_name/
After these changes, using the same example, we have the following:
$ trace-cmd report \
> | sed -n 's/.*dev 0000:00:02\.0, \(pipe .\).*/\1/p' \
> | cat -v | sort | uniq -c
396 pipe A
34 pipe B
[1] https://lwn.net/Articles/379903/
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
---
.../drm/i915/display/intel_display_trace.h | 126 +++++++++---------
1 file changed, 63 insertions(+), 63 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_trace.h b/drivers/gpu/drm/i915/display/intel_display_trace.h
index 8a3185862089..ec2ab6fb743d 100644
--- a/drivers/gpu/drm/i915/display/intel_display_trace.h
+++ b/drivers/gpu/drm/i915/display/intel_display_trace.h
@@ -30,7 +30,7 @@ TRACE_EVENT(intel_pipe_enable,
__string(dev, __dev_name_kms(crtc))
__array(u32, frame, I915_MAX_PIPES)
__array(u32, scanline, I915_MAX_PIPES)
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
),
TP_fast_assign(
struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
@@ -40,11 +40,11 @@ TRACE_EVENT(intel_pipe_enable,
__entry->frame[it__->pipe] = intel_crtc_get_vblank_counter(it__);
__entry->scanline[it__->pipe] = intel_get_crtc_scanline(it__);
}
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
),
TP_printk("dev %s, pipe %c enable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
- __get_str(dev), pipe_name(__entry->pipe),
+ __get_str(dev), __entry->pipe_name,
__entry->frame[PIPE_A], __entry->scanline[PIPE_A],
__entry->frame[PIPE_B], __entry->scanline[PIPE_B],
__entry->frame[PIPE_C], __entry->scanline[PIPE_C])
@@ -58,7 +58,7 @@ TRACE_EVENT(intel_pipe_disable,
__string(dev, __dev_name_kms(crtc))
__array(u32, frame, I915_MAX_PIPES)
__array(u32, scanline, I915_MAX_PIPES)
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
),
TP_fast_assign(
@@ -69,11 +69,11 @@ TRACE_EVENT(intel_pipe_disable,
__entry->frame[it__->pipe] = intel_crtc_get_vblank_counter(it__);
__entry->scanline[it__->pipe] = intel_get_crtc_scanline(it__);
}
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
),
TP_printk("dev %s, pipe %c disable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
- __get_str(dev), pipe_name(__entry->pipe),
+ __get_str(dev), __entry->pipe_name,
__entry->frame[PIPE_A], __entry->scanline[PIPE_A],
__entry->frame[PIPE_B], __entry->scanline[PIPE_B],
__entry->frame[PIPE_C], __entry->scanline[PIPE_C])
@@ -85,20 +85,20 @@ TRACE_EVENT(intel_crtc_flip_done,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(crtc))
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
),
TP_fast_assign(
__assign_str(dev);
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
),
TP_printk("dev %s, pipe %c, frame=%u, scanline=%u",
- __get_str(dev), pipe_name(__entry->pipe),
+ __get_str(dev), __entry->pipe_name,
__entry->frame, __entry->scanline)
);
@@ -108,7 +108,7 @@ TRACE_EVENT(intel_pipe_crc,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(crtc))
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
__array(u32, crcs, 5)
@@ -116,14 +116,14 @@ TRACE_EVENT(intel_pipe_crc,
TP_fast_assign(
__assign_str(dev);
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
memcpy(__entry->crcs, crcs, sizeof(__entry->crcs));
),
TP_printk("dev %s, pipe %c, frame=%u, scanline=%u crc=%08x %08x %08x %08x %08x",
- __get_str(dev), pipe_name(__entry->pipe),
+ __get_str(dev), __entry->pipe_name,
__entry->frame, __entry->scanline,
__entry->crcs[0], __entry->crcs[1],
__entry->crcs[2], __entry->crcs[3],
@@ -136,7 +136,7 @@ TRACE_EVENT(intel_cpu_fifo_underrun,
TP_STRUCT__entry(
__string(dev, __dev_name_i915(dev_priv))
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
),
@@ -144,13 +144,13 @@ TRACE_EVENT(intel_cpu_fifo_underrun,
TP_fast_assign(
struct intel_crtc *crtc = intel_crtc_for_pipe(dev_priv, pipe);
__assign_str(dev);
- __entry->pipe = pipe;
+ __entry->pipe_name = pipe_name(pipe);
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
),
TP_printk("dev %s, pipe %c, frame=%u, scanline=%u",
- __get_str(dev), pipe_name(__entry->pipe),
+ __get_str(dev), __entry->pipe_name,
__entry->frame, __entry->scanline)
);
@@ -160,7 +160,7 @@ TRACE_EVENT(intel_pch_fifo_underrun,
TP_STRUCT__entry(
__string(dev, __dev_name_i915(dev_priv))
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
),
@@ -169,13 +169,13 @@ TRACE_EVENT(intel_pch_fifo_underrun,
enum pipe pipe = pch_transcoder;
struct intel_crtc *crtc = intel_crtc_for_pipe(dev_priv, pipe);
__assign_str(dev);
- __entry->pipe = pipe;
+ __entry->pipe_name = pipe_name(pipe);
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
),
TP_printk("dev %s, pch transcoder %c, frame=%u, scanline=%u",
- __get_str(dev), pipe_name(__entry->pipe),
+ __get_str(dev), __entry->pipe_name,
__entry->frame, __entry->scanline)
);
@@ -215,7 +215,7 @@ TRACE_EVENT(g4x_wm,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(crtc))
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
__field(u16, primary)
@@ -234,7 +234,7 @@ TRACE_EVENT(g4x_wm,
TP_fast_assign(
__assign_str(dev);
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
__entry->primary = wm->pipe[crtc->pipe].plane[PLANE_PRIMARY];
@@ -252,7 +252,7 @@ TRACE_EVENT(g4x_wm,
),
TP_printk("dev %s, pipe %c, frame=%u, scanline=%u, wm %d/%d/%d, sr %s/%d/%d/%d, hpll %s/%d/%d/%d, fbc %s",
- __get_str(dev), pipe_name(__entry->pipe),
+ __get_str(dev), __entry->pipe_name,
__entry->frame, __entry->scanline,
__entry->primary, __entry->sprite, __entry->cursor,
str_yes_no(__entry->cxsr), __entry->sr_plane, __entry->sr_cursor, __entry->sr_fbc,
@@ -266,7 +266,7 @@ TRACE_EVENT(vlv_wm,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(crtc))
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
__field(u32, level)
@@ -281,7 +281,7 @@ TRACE_EVENT(vlv_wm,
TP_fast_assign(
__assign_str(dev);
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
__entry->level = wm->level;
@@ -295,7 +295,7 @@ TRACE_EVENT(vlv_wm,
),
TP_printk("dev %s, pipe %c, frame=%u, scanline=%u, level=%d, cxsr=%d, wm %d/%d/%d/%d, sr %d/%d",
- __get_str(dev), pipe_name(__entry->pipe),
+ __get_str(dev), __entry->pipe_name,
__entry->frame, __entry->scanline,
__entry->level, __entry->cxsr,
__entry->primary, __entry->sprite0, __entry->sprite1, __entry->cursor,
@@ -308,7 +308,7 @@ TRACE_EVENT(vlv_fifo_size,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(crtc))
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
__field(u32, sprite0_start)
@@ -318,7 +318,7 @@ TRACE_EVENT(vlv_fifo_size,
TP_fast_assign(
__assign_str(dev);
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
__entry->sprite0_start = sprite0_start;
@@ -327,7 +327,7 @@ TRACE_EVENT(vlv_fifo_size,
),
TP_printk("dev %s, pipe %c, frame=%u, scanline=%u, %d/%d/%d",
- __get_str(dev), pipe_name(__entry->pipe),
+ __get_str(dev), __entry->pipe_name,
__entry->frame, __entry->scanline,
__entry->sprite0_start, __entry->sprite1_start, __entry->fifo_size)
);
@@ -338,7 +338,7 @@ TRACE_EVENT(intel_plane_async_flip,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(plane))
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
__field(bool, async_flip)
@@ -348,14 +348,14 @@ TRACE_EVENT(intel_plane_async_flip,
TP_fast_assign(
__assign_str(dev);
__assign_str(name);
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
__entry->async_flip = async_flip;
),
TP_printk("dev %s, pipe %c, plane %s, frame=%u, scanline=%u, async_flip=%s",
- __get_str(dev), pipe_name(__entry->pipe), __get_str(name),
+ __get_str(dev), __entry->pipe_name, __get_str(name),
__entry->frame, __entry->scanline, str_yes_no(__entry->async_flip))
);
@@ -365,7 +365,7 @@ TRACE_EVENT(intel_plane_update_noarm,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(plane))
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
__array(int, src, 4)
@@ -376,7 +376,7 @@ TRACE_EVENT(intel_plane_update_noarm,
TP_fast_assign(
__assign_str(dev);
__assign_str(name);
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
memcpy(__entry->src, &plane->base.state->src, sizeof(__entry->src));
@@ -384,7 +384,7 @@ TRACE_EVENT(intel_plane_update_noarm,
),
TP_printk("dev %s, pipe %c, plane %s, frame=%u, scanline=%u, " DRM_RECT_FP_FMT " -> " DRM_RECT_FMT,
- __get_str(dev), pipe_name(__entry->pipe), __get_str(name),
+ __get_str(dev), __entry->pipe_name, __get_str(name),
__entry->frame, __entry->scanline,
DRM_RECT_FP_ARG((const struct drm_rect *)__entry->src),
DRM_RECT_ARG((const struct drm_rect *)__entry->dst))
@@ -396,7 +396,7 @@ TRACE_EVENT(intel_plane_update_arm,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(plane))
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
__array(int, src, 4)
@@ -407,7 +407,7 @@ TRACE_EVENT(intel_plane_update_arm,
TP_fast_assign(
__assign_str(dev);
__assign_str(name);
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
memcpy(__entry->src, &plane->base.state->src, sizeof(__entry->src));
@@ -415,7 +415,7 @@ TRACE_EVENT(intel_plane_update_arm,
),
TP_printk("dev %s, pipe %c, plane %s, frame=%u, scanline=%u, " DRM_RECT_FP_FMT " -> " DRM_RECT_FMT,
- __get_str(dev), pipe_name(__entry->pipe), __get_str(name),
+ __get_str(dev), __entry->pipe_name, __get_str(name),
__entry->frame, __entry->scanline,
DRM_RECT_FP_ARG((const struct drm_rect *)__entry->src),
DRM_RECT_ARG((const struct drm_rect *)__entry->dst))
@@ -427,7 +427,7 @@ TRACE_EVENT(intel_plane_disable_arm,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(plane))
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
__string(name, plane->base.name)
@@ -436,13 +436,13 @@ TRACE_EVENT(intel_plane_disable_arm,
TP_fast_assign(
__assign_str(dev);
__assign_str(name);
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
),
TP_printk("dev %s, pipe %c, plane %s, frame=%u, scanline=%u",
- __get_str(dev), pipe_name(__entry->pipe), __get_str(name),
+ __get_str(dev), __entry->pipe_name, __get_str(name),
__entry->frame, __entry->scanline)
);
@@ -453,7 +453,7 @@ TRACE_EVENT(intel_fbc_activate,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(plane))
__string(name, plane->base.name)
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
),
@@ -463,13 +463,13 @@ TRACE_EVENT(intel_fbc_activate,
plane->pipe);
__assign_str(dev);
__assign_str(name);
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
),
TP_printk("dev %s, pipe %c, plane %s, frame=%u, scanline=%u",
- __get_str(dev), pipe_name(__entry->pipe), __get_str(name),
+ __get_str(dev), __entry->pipe_name, __get_str(name),
__entry->frame, __entry->scanline)
);
@@ -480,7 +480,7 @@ TRACE_EVENT(intel_fbc_deactivate,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(plane))
__string(name, plane->base.name)
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
),
@@ -490,13 +490,13 @@ TRACE_EVENT(intel_fbc_deactivate,
plane->pipe);
__assign_str(dev);
__assign_str(name);
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
),
TP_printk("dev %s, pipe %c, plane %s, frame=%u, scanline=%u",
- __get_str(dev), pipe_name(__entry->pipe), __get_str(name),
+ __get_str(dev), __entry->pipe_name, __get_str(name),
__entry->frame, __entry->scanline)
);
@@ -507,7 +507,7 @@ TRACE_EVENT(intel_fbc_nuke,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(plane))
__string(name, plane->base.name)
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
),
@@ -517,13 +517,13 @@ TRACE_EVENT(intel_fbc_nuke,
plane->pipe);
__assign_str(dev);
__assign_str(name);
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
),
TP_printk("dev %s, pipe %c, plane %s, frame=%u, scanline=%u",
- __get_str(dev), pipe_name(__entry->pipe), __get_str(name),
+ __get_str(dev), __entry->pipe_name, __get_str(name),
__entry->frame, __entry->scanline)
);
@@ -533,20 +533,20 @@ TRACE_EVENT(intel_crtc_vblank_work_start,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(crtc))
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
),
TP_fast_assign(
__assign_str(dev);
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
),
TP_printk("dev %s, pipe %c, frame=%u, scanline=%u",
- __get_str(dev), pipe_name(__entry->pipe),
+ __get_str(dev), __entry->pipe_name,
__entry->frame, __entry->scanline)
);
@@ -556,20 +556,20 @@ TRACE_EVENT(intel_crtc_vblank_work_end,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(crtc))
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
),
TP_fast_assign(
__assign_str(dev);
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
),
TP_printk("dev %s, pipe %c, frame=%u, scanline=%u",
- __get_str(dev), pipe_name(__entry->pipe),
+ __get_str(dev), __entry->pipe_name,
__entry->frame, __entry->scanline)
);
@@ -579,7 +579,7 @@ TRACE_EVENT(intel_pipe_update_start,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(crtc))
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
__field(u32, min)
@@ -588,7 +588,7 @@ TRACE_EVENT(intel_pipe_update_start,
TP_fast_assign(
__assign_str(dev);
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
__entry->frame = intel_crtc_get_vblank_counter(crtc);
__entry->scanline = intel_get_crtc_scanline(crtc);
__entry->min = crtc->debug.min_vbl;
@@ -596,7 +596,7 @@ TRACE_EVENT(intel_pipe_update_start,
),
TP_printk("dev %s, pipe %c, frame=%u, scanline=%u, min=%u, max=%u",
- __get_str(dev), pipe_name(__entry->pipe),
+ __get_str(dev), __entry->pipe_name,
__entry->frame, __entry->scanline,
__entry->min, __entry->max)
);
@@ -607,7 +607,7 @@ TRACE_EVENT(intel_pipe_update_vblank_evaded,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(crtc))
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
__field(u32, min)
@@ -616,7 +616,7 @@ TRACE_EVENT(intel_pipe_update_vblank_evaded,
TP_fast_assign(
__assign_str(dev);
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
__entry->frame = crtc->debug.start_vbl_count;
__entry->scanline = crtc->debug.scanline_start;
__entry->min = crtc->debug.min_vbl;
@@ -624,7 +624,7 @@ TRACE_EVENT(intel_pipe_update_vblank_evaded,
),
TP_printk("dev %s, pipe %c, frame=%u, scanline=%u, min=%u, max=%u",
- __get_str(dev), pipe_name(__entry->pipe),
+ __get_str(dev), __entry->pipe_name,
__entry->frame, __entry->scanline,
__entry->min, __entry->max)
);
@@ -635,20 +635,20 @@ TRACE_EVENT(intel_pipe_update_end,
TP_STRUCT__entry(
__string(dev, __dev_name_kms(crtc))
- __field(enum pipe, pipe)
+ __field(char, pipe_name)
__field(u32, frame)
__field(u32, scanline)
),
TP_fast_assign(
__assign_str(dev);
- __entry->pipe = crtc->pipe;
+ __entry->pipe_name = pipe_name(crtc->pipe);
__entry->frame = frame;
__entry->scanline = scanline_end;
),
TP_printk("dev %s, pipe %c, frame=%u, scanline=%u",
- __get_str(dev), pipe_name(__entry->pipe),
+ __get_str(dev), __entry->pipe_name,
__entry->frame, __entry->scanline)
);
--
2.46.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/4] drm/i915/display: Do not use ids from enum pipe in TP_printk()
2024-08-29 22:00 [PATCH 0/4] Miscelaneous fixes for display tracepoints Gustavo Sousa
2024-08-29 22:00 ` [PATCH 1/4] drm/i915/display: Fix out-of-bounds access in pipe-related tracepoints Gustavo Sousa
2024-08-29 22:00 ` [PATCH 2/4] drm/i915/display: Store pipe name in trace events Gustavo Sousa
@ 2024-08-29 22:00 ` Gustavo Sousa
2024-09-18 22:41 ` Matt Roper
2024-08-29 22:00 ` [PATCH 4/4] drm/i915/display: Cover all possible pipes " Gustavo Sousa
` (3 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Gustavo Sousa @ 2024-08-29 22:00 UTC (permalink / raw)
To: intel-gfx
Because much of kernel tracepoints is implemented at the C preprocessor
level, C identifiers used in TP_printk() are saved verbatim in the event
format, even when they represent compile-time constant values.
As an example, we can look at the format for the intel_pipe_enable
event:
# cat /sys/kernel/debug/tracing/events/i915/intel_pipe_enable/format | grep '^print fmt'
print fmt: "dev %s, pipe %c enable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u", __get_str(dev), REC->pipe_name, REC->frame[PIPE_A], REC->scanline[PIPE_A], REC->frame[PIPE_B], REC->scanline[PIPE_B], REC->frame[PIPE_C], REC->scanline[PIPE_C]
We see that PIPE_A, PIPE_B and PIPE_C are pasted directly in the format.
Because tools that interact with kernel tracepoints don't know about
those ids, they'll endup failing to parse the format or produce
corrupted output.
For example, we can see below that trace-cmd repeats PIPE_A's
frame/scanline counts for all pipes (probably because it evaluates
unknown ids as zero):
$ trace-cmd report -F intel_pipe_enable | tail -n5
testdisplay-8616 [000] 22048.276758: intel_pipe_enable: dev 0000:00:02.0, pipe A enable, pipe A: frame=861, scanline=480, pipe B: frame=861, scanline=480, pipe C: frame=861, scanline=480
testdisplay-8616 [001] 22048.490287: intel_pipe_enable: dev 0000:00:02.0, pipe A enable, pipe A: frame=867, scanline=480, pipe B: frame=867, scanline=480, pipe C: frame=867, scanline=480
testdisplay-8616 [003] 22048.700181: intel_pipe_enable: dev 0000:00:02.0, pipe A enable, pipe A: frame=872, scanline=400, pipe B: frame=872, scanline=400, pipe C: frame=872, scanline=400
testdisplay-8616 [002] 22049.054220: intel_pipe_enable: dev 0000:00:02.0, pipe A enable, pipe A: frame=881, scanline=2170, pipe B: frame=881, scanline=2170, pipe C: frame=881, scanline=2170
testdisplay-8616 [002] 22049.166851: intel_pipe_enable: dev 0000:00:02.0, pipe B enable, pipe A: frame=887, scanline=1632, pipe B: frame=887, scanline=1632, pipe C: frame=887, scanline=1632
, while in fact we have different values for each pipe, which can be
confirmed with the raw view of the events:
$ trace-cmd report -R -F intel_pipe_enable | tail -n5
testdisplay-8616 [000] 22048.276758: intel_pipe_enable: dev=0000:00:02.0 frame=ARRAY[5d, 03, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] scanline=ARRAY[e0, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe_name=A
testdisplay-8616 [001] 22048.490287: intel_pipe_enable: dev=0000:00:02.0 frame=ARRAY[63, 03, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] scanline=ARRAY[e0, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe_name=A
testdisplay-8616 [003] 22048.700181: intel_pipe_enable: dev=0000:00:02.0 frame=ARRAY[68, 03, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] scanline=ARRAY[90, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe_name=A
testdisplay-8616 [002] 22049.054220: intel_pipe_enable: dev=0000:00:02.0 frame=ARRAY[71, 03, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] scanline=ARRAY[7a, 08, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe_name=A
testdisplay-8616 [002] 22049.166851: intel_pipe_enable: dev=0000:00:02.0 frame=ARRAY[77, 03, 00, 00, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] scanline=ARRAY[60, 06, 00, 00, 39, 04, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe_name=B
To fix that, we need a fix that looks more like a hack: use macros that
result to integer constants instead of enum pipe values. This fixes the
issue, but could break if, for whatever unlikely reason, the underlying
values in the enum are changed.
In the future, we should find a better way to handle this, but for now,
the hack took care of the job:
$ trace-cmd report -F intel_pipe_enable | tail -n5
testdisplay-9224 [003] 24324.455375: intel_pipe_enable: dev 0000:00:02.0, pipe A enable, pipe A: frame=1103, scanline=480, pipe B: frame=0, scanline=0, pipe C: frame=0, scanline=0
testdisplay-9224 [002] 24324.669845: intel_pipe_enable: dev 0000:00:02.0, pipe A enable, pipe A: frame=1109, scanline=480, pipe B: frame=0, scanline=0, pipe C: frame=0, scanline=0
testdisplay-9224 [003] 24324.900105: intel_pipe_enable: dev 0000:00:02.0, pipe A enable, pipe A: frame=1115, scanline=31, pipe B: frame=0, scanline=0, pipe C: frame=0, scanline=0
testdisplay-9224 [002] 24325.256408: intel_pipe_enable: dev 0000:00:02.0, pipe A enable, pipe A: frame=1124, scanline=2171, pipe B: frame=0, scanline=0, pipe C: frame=0, scanline=0
testdisplay-9224 [003] 24325.380789: intel_pipe_enable: dev 0000:00:02.0, pipe B enable, pipe A: frame=1131, scanline=979, pipe B: frame=1, scanline=1082, pipe C: frame=0, scanline=0
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
---
.../drm/i915/display/intel_display_trace.h | 27 ++++++++++++-------
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_trace.h b/drivers/gpu/drm/i915/display/intel_display_trace.h
index ec2ab6fb743d..759b985c84a9 100644
--- a/drivers/gpu/drm/i915/display/intel_display_trace.h
+++ b/drivers/gpu/drm/i915/display/intel_display_trace.h
@@ -22,6 +22,15 @@
#define __dev_name_i915(i915) dev_name((i915)->drm.dev)
#define __dev_name_kms(obj) dev_name((obj)->base.dev->dev)
+/*
+ * Using identifiers from enum pipe in TP_printk() will confuse tools that
+ * parse /sys/kernel/debug/tracing/{xe,i915}/<event>/format. So we use CPP
+ * macros instead.
+ */
+#define _TRACE_PIPE_A 0
+#define _TRACE_PIPE_B 1
+#define _TRACE_PIPE_C 2
+
TRACE_EVENT(intel_pipe_enable,
TP_PROTO(struct intel_crtc *crtc),
TP_ARGS(crtc),
@@ -45,9 +54,9 @@ TRACE_EVENT(intel_pipe_enable,
TP_printk("dev %s, pipe %c enable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
__get_str(dev), __entry->pipe_name,
- __entry->frame[PIPE_A], __entry->scanline[PIPE_A],
- __entry->frame[PIPE_B], __entry->scanline[PIPE_B],
- __entry->frame[PIPE_C], __entry->scanline[PIPE_C])
+ __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A],
+ __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B],
+ __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C])
);
TRACE_EVENT(intel_pipe_disable,
@@ -74,9 +83,9 @@ TRACE_EVENT(intel_pipe_disable,
TP_printk("dev %s, pipe %c disable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
__get_str(dev), __entry->pipe_name,
- __entry->frame[PIPE_A], __entry->scanline[PIPE_A],
- __entry->frame[PIPE_B], __entry->scanline[PIPE_B],
- __entry->frame[PIPE_C], __entry->scanline[PIPE_C])
+ __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A],
+ __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B],
+ __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C])
);
TRACE_EVENT(intel_crtc_flip_done,
@@ -204,9 +213,9 @@ TRACE_EVENT(intel_memory_cxsr,
TP_printk("dev %s, cxsr %s->%s, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
__get_str(dev), str_on_off(__entry->old), str_on_off(__entry->new),
- __entry->frame[PIPE_A], __entry->scanline[PIPE_A],
- __entry->frame[PIPE_B], __entry->scanline[PIPE_B],
- __entry->frame[PIPE_C], __entry->scanline[PIPE_C])
+ __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A],
+ __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B],
+ __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C])
);
TRACE_EVENT(g4x_wm,
--
2.46.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 4/4] drm/i915/display: Cover all possible pipes in TP_printk()
2024-08-29 22:00 [PATCH 0/4] Miscelaneous fixes for display tracepoints Gustavo Sousa
` (2 preceding siblings ...)
2024-08-29 22:00 ` [PATCH 3/4] drm/i915/display: Do not use ids from enum pipe in TP_printk() Gustavo Sousa
@ 2024-08-29 22:00 ` Gustavo Sousa
2024-09-18 22:49 ` Matt Roper
2024-08-30 0:02 ` ✗ Fi.CI.CHECKPATCH: warning for Miscelaneous fixes for display tracepoints Patchwork
` (2 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Gustavo Sousa @ 2024-08-29 22:00 UTC (permalink / raw)
To: intel-gfx
Tracepoints that display frame and scanline counters for all pipes were
added with commit 1489bba82433 ("drm/i915: Add cxsr toggle tracepoint")
and commit 0b2599a43ca9 ("drm/i915: Add pipe enable/disable
tracepoints"). At that time, we only had pipes A, B and C. Now that we
can also have pipe D, the TP_printk() calls are missing it.
As a quick and dirty fix for that, let's define two common macros to be
used for the format and values respectively, and also ensure we raise a
build bug if more pipes are added to enum pipe.
In the future, we should probably have a way of printing information for
available pipes only.
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
---
.../drm/i915/display/intel_display_trace.h | 43 +++++++++++++------
1 file changed, 29 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_trace.h b/drivers/gpu/drm/i915/display/intel_display_trace.h
index 759b985c84a9..2ce66dffdfa5 100644
--- a/drivers/gpu/drm/i915/display/intel_display_trace.h
+++ b/drivers/gpu/drm/i915/display/intel_display_trace.h
@@ -30,6 +30,29 @@
#define _TRACE_PIPE_A 0
#define _TRACE_PIPE_B 1
#define _TRACE_PIPE_C 2
+#define _TRACE_PIPE_D 3
+
+/*
+ * FIXME: Several TP_printk() calls below display frame and scanline numbers for
+ * all possible pipes (regardless of whether they are available) and that is
+ * done with a constant format string. A better approach would be to generate
+ * that info dynamically based on available pipes, but, while we do not have
+ * that implemented yet, let's assert that the constant format string indeed
+ * covers all possible pipes.
+ */
+static_assert(I915_MAX_PIPES - 1 == _TRACE_PIPE_D);
+
+#define _PIPES_FRAME_AND_SCANLINE_FMT \
+ "pipe A: frame=%u, scanline=%u" \
+ ", pipe B: frame=%u, scanline=%u" \
+ ", pipe C: frame=%u, scanline=%u" \
+ ", pipe D: frame=%u, scanline=%u"
+
+#define _PIPES_FRAME_AND_SCANLINE_VALUES \
+ __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A] \
+ , __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B] \
+ , __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C] \
+ , __entry->frame[_TRACE_PIPE_D], __entry->scanline[_TRACE_PIPE_D]
TRACE_EVENT(intel_pipe_enable,
TP_PROTO(struct intel_crtc *crtc),
@@ -52,11 +75,8 @@ TRACE_EVENT(intel_pipe_enable,
__entry->pipe_name = pipe_name(crtc->pipe);
),
- TP_printk("dev %s, pipe %c enable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
- __get_str(dev), __entry->pipe_name,
- __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A],
- __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B],
- __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C])
+ TP_printk("dev %s, pipe %c enable, " _PIPES_FRAME_AND_SCANLINE_FMT,
+ __get_str(dev), __entry->pipe_name, _PIPES_FRAME_AND_SCANLINE_VALUES)
);
TRACE_EVENT(intel_pipe_disable,
@@ -81,11 +101,8 @@ TRACE_EVENT(intel_pipe_disable,
__entry->pipe_name = pipe_name(crtc->pipe);
),
- TP_printk("dev %s, pipe %c disable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
- __get_str(dev), __entry->pipe_name,
- __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A],
- __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B],
- __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C])
+ TP_printk("dev %s, pipe %c disable, " _PIPES_FRAME_AND_SCANLINE_FMT,
+ __get_str(dev), __entry->pipe_name, _PIPES_FRAME_AND_SCANLINE_VALUES)
);
TRACE_EVENT(intel_crtc_flip_done,
@@ -211,11 +228,9 @@ TRACE_EVENT(intel_memory_cxsr,
__entry->new = new;
),
- TP_printk("dev %s, cxsr %s->%s, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
+ TP_printk("dev %s, cxsr %s->%s, " _PIPES_FRAME_AND_SCANLINE_FMT,
__get_str(dev), str_on_off(__entry->old), str_on_off(__entry->new),
- __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A],
- __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B],
- __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C])
+ _PIPES_FRAME_AND_SCANLINE_VALUES)
);
TRACE_EVENT(g4x_wm,
--
2.46.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for Miscelaneous fixes for display tracepoints
2024-08-29 22:00 [PATCH 0/4] Miscelaneous fixes for display tracepoints Gustavo Sousa
` (3 preceding siblings ...)
2024-08-29 22:00 ` [PATCH 4/4] drm/i915/display: Cover all possible pipes " Gustavo Sousa
@ 2024-08-30 0:02 ` Patchwork
2024-08-30 0:09 ` ✓ Fi.CI.BAT: success " Patchwork
2024-08-31 13:52 ` ✗ Fi.CI.IGT: failure " Patchwork
6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2024-08-30 0:02 UTC (permalink / raw)
To: Gustavo Sousa; +Cc: intel-gfx
== Series Details ==
Series: Miscelaneous fixes for display tracepoints
URL : https://patchwork.freedesktop.org/series/137978/
State : warning
== Summary ==
Error: dim checkpatch failed
0d985968394b drm/i915/display: Fix out-of-bounds access in pipe-related tracepoints
-:19: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#19:
testdisplay-6715 [002] 17591.063491: intel_pipe_enable: dev=0000:00:02.0
total: 0 errors, 1 warnings, 0 checks, 37 lines checked
9c55f3e323a3 drm/i915/display: Store pipe name in trace events
-:20: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#20:
# cat /sys/kernel/debug/tracing/events/i915/intel_pipe_update_start/format
total: 0 errors, 1 warnings, 0 checks, 488 lines checked
29d4bb0aeb33 drm/i915/display: Do not use ids from enum pipe in TP_printk()
-:14: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#14:
# cat /sys/kernel/debug/tracing/events/i915/intel_pipe_enable/format | grep '^print fmt'
total: 0 errors, 1 warnings, 0 checks, 51 lines checked
2256bbde484d drm/i915/display: Cover all possible pipes in TP_printk()
-:47: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#47: FILE: drivers/gpu/drm/i915/display/intel_display_trace.h:51:
+#define _PIPES_FRAME_AND_SCANLINE_VALUES \
+ __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A] \
+ , __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B] \
+ , __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C] \
+ , __entry->frame[_TRACE_PIPE_D], __entry->scanline[_TRACE_PIPE_D]
total: 1 errors, 0 warnings, 0 checks, 68 lines checked
^ permalink raw reply [flat|nested] 14+ messages in thread
* ✓ Fi.CI.BAT: success for Miscelaneous fixes for display tracepoints
2024-08-29 22:00 [PATCH 0/4] Miscelaneous fixes for display tracepoints Gustavo Sousa
` (4 preceding siblings ...)
2024-08-30 0:02 ` ✗ Fi.CI.CHECKPATCH: warning for Miscelaneous fixes for display tracepoints Patchwork
@ 2024-08-30 0:09 ` Patchwork
2024-08-31 13:52 ` ✗ Fi.CI.IGT: failure " Patchwork
6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2024-08-30 0:09 UTC (permalink / raw)
To: Gustavo Sousa; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 12936 bytes --]
== Series Details ==
Series: Miscelaneous fixes for display tracepoints
URL : https://patchwork.freedesktop.org/series/137978/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15327 -> Patchwork_137978v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/index.html
Participating hosts (36 -> 36)
------------------------------
Additional (3): bat-dg2-11 bat-arlh-2 fi-kbl-8809g
Missing (3): bat-arls-2 fi-cfl-8109u fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_137978v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-arlh-2: NOTRUN -> [SKIP][1] ([i915#9318])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-arlh-2/igt@debugfs_test@basic-hwmon.html
* igt@fbdev@eof:
- bat-arlh-2: NOTRUN -> [SKIP][2] ([i915#11345]) +3 other tests skip
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-arlh-2/igt@fbdev@eof.html
* igt@fbdev@info:
- bat-arlh-2: NOTRUN -> [SKIP][3] ([i915#1849])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-arlh-2/igt@fbdev@info.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-8809g: NOTRUN -> [SKIP][4] ([i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/fi-kbl-8809g/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-8809g: NOTRUN -> [SKIP][5] ([i915#4613]) +3 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/fi-kbl-8809g/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@parallel-random-engines:
- bat-arlh-2: NOTRUN -> [SKIP][6] ([i915#10213] / [i915#11671]) +3 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-arlh-2/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_mmap@basic:
- bat-arlh-2: NOTRUN -> [SKIP][7] ([i915#11343])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-arlh-2/igt@gem_mmap@basic.html
- bat-dg2-11: NOTRUN -> [SKIP][8] ([i915#4083])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-dg2-11/igt@gem_mmap@basic.html
* igt@gem_render_tiled_blits@basic:
- bat-arlh-2: NOTRUN -> [SKIP][9] ([i915#10197] / [i915#11725])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-arlh-2/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-arlh-2: NOTRUN -> [SKIP][10] ([i915#10196]) +4 other tests skip
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-arlh-2/igt@gem_tiled_fence_blits@basic.html
- bat-dg2-11: NOTRUN -> [SKIP][11] ([i915#4077]) +2 other tests skip
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-dg2-11/igt@gem_tiled_fence_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-arlh-2: NOTRUN -> [SKIP][12] ([i915#10206] / [i915#11724])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-arlh-2/igt@gem_tiled_pread_basic.html
- bat-dg2-11: NOTRUN -> [SKIP][13] ([i915#4079]) +1 other test skip
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-dg2-11/igt@gem_tiled_pread_basic.html
* igt@i915_pm_rps@basic-api:
- bat-arlh-2: NOTRUN -> [SKIP][14] ([i915#10209] / [i915#11681])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-arlh-2/igt@i915_pm_rps@basic-api.html
- bat-dg2-11: NOTRUN -> [SKIP][15] ([i915#11681] / [i915#6621])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-dg2-11/igt@i915_pm_rps@basic-api.html
* igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy:
- bat-dg2-11: NOTRUN -> [SKIP][16] ([i915#4212]) +7 other tests skip
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-dg2-11/igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-dg2-11: NOTRUN -> [SKIP][17] ([i915#5190])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-dg2-11/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_addfb_basic@basic-x-tiled-legacy:
- bat-arlh-2: NOTRUN -> [SKIP][18] ([i915#10200] / [i915#11666]) +9 other tests skip
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-arlh-2/igt@kms_addfb_basic@basic-x-tiled-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg2-11: NOTRUN -> [SKIP][19] ([i915#4215] / [i915#5190])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-dg2-11/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- bat-dg2-11: NOTRUN -> [SKIP][20] ([i915#4103] / [i915#4213]) +1 other test skip
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-dg2-11/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_dsc@dsc-basic:
- bat-dg2-11: NOTRUN -> [SKIP][21] ([i915#3555] / [i915#3840])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-dg2-11/igt@kms_dsc@dsc-basic.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-kbl-8809g: NOTRUN -> [SKIP][22] +30 other tests skip
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/fi-kbl-8809g/igt@kms_force_connector_basic@force-load-detect.html
- bat-dg2-11: NOTRUN -> [SKIP][23]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-dg2-11/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-dg2-11: NOTRUN -> [SKIP][24] ([i915#5274])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-dg2-11/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][25] ([i915#9197]) +3 other tests skip
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
* igt@kms_pm_backlight@basic-brightness:
- bat-arlh-2: NOTRUN -> [SKIP][26] ([i915#11346]) +32 other tests skip
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-arlh-2/igt@kms_pm_backlight@basic-brightness.html
- bat-dg2-11: NOTRUN -> [SKIP][27] ([i915#5354])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-dg2-11/igt@kms_pm_backlight@basic-brightness.html
* igt@kms_psr@psr-sprite-plane-onoff:
- bat-dg2-11: NOTRUN -> [SKIP][28] ([i915#1072] / [i915#9732]) +3 other tests skip
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-dg2-11/igt@kms_psr@psr-sprite-plane-onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-arlh-2: NOTRUN -> [SKIP][29] ([i915#10208] / [i915#8809])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-arlh-2/igt@kms_setmode@basic-clone-single-crtc.html
- bat-dg2-11: NOTRUN -> [SKIP][30] ([i915#3555])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-dg2-11/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-dg2-11: NOTRUN -> [SKIP][31] ([i915#3708])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-dg2-11/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-mmap:
- bat-dg2-11: NOTRUN -> [SKIP][32] ([i915#3708] / [i915#4077]) +1 other test skip
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-dg2-11/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-fence-read:
- bat-arlh-2: NOTRUN -> [SKIP][33] ([i915#10212] / [i915#11726])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-arlh-2/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-read:
- bat-dg2-11: NOTRUN -> [SKIP][34] ([i915#3291] / [i915#3708]) +2 other tests skip
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-dg2-11/igt@prime_vgem@basic-read.html
- bat-arlh-2: NOTRUN -> [SKIP][35] ([i915#10214] / [i915#11726])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-arlh-2/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-write:
- bat-arlh-2: NOTRUN -> [SKIP][36] ([i915#10216] / [i915#11723])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/bat-arlh-2/igt@prime_vgem@basic-write.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#10196]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10196
[i915#10197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10197
[i915#10200]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10200
[i915#10206]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10206
[i915#10208]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10208
[i915#10209]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10209
[i915#10212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10212
[i915#10213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10213
[i915#10214]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10214
[i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#11343]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11343
[i915#11345]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11345
[i915#11346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11346
[i915#11666]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11666
[i915#11671]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11671
[i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
[i915#11723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11723
[i915#11724]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11724
[i915#11725]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11725
[i915#11726]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11726
[i915#12041]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12041
[i915#1849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1849
[i915#2190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2190
[i915#3291]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4215
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#6621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6621
[i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809
[i915#9197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197
[i915#9318]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9318
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
Build changes
-------------
* Linux: CI_DRM_15327 -> Patchwork_137978v1
CI-20190529: 20190529
CI_DRM_15327: c5380bcbaed118a5fc23dbb445b3c599a45b0ccb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7999: a73311079a5d8ac99eb25336a8369a2c3c6b519b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_137978v1: c5380bcbaed118a5fc23dbb445b3c599a45b0ccb @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/index.html
[-- Attachment #2: Type: text/html, Size: 14674 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* ✗ Fi.CI.IGT: failure for Miscelaneous fixes for display tracepoints
2024-08-29 22:00 [PATCH 0/4] Miscelaneous fixes for display tracepoints Gustavo Sousa
` (5 preceding siblings ...)
2024-08-30 0:09 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2024-08-31 13:52 ` Patchwork
6 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2024-08-31 13:52 UTC (permalink / raw)
To: Gustavo Sousa; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 81853 bytes --]
== Series Details ==
Series: Miscelaneous fixes for display tracepoints
URL : https://patchwork.freedesktop.org/series/137978/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15327_full -> Patchwork_137978v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_137978v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_137978v1_full, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_137978v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0:
- shard-glk: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-glk5/igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0.html
* igt@i915_pm_rps@reset:
- shard-dg1: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@i915_pm_rps@reset.html
#### Warnings ####
* igt@i915_pm_rps@reset:
- shard-dg2: [FAIL][3] ([i915#12033]) -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-dg2-10/igt@i915_pm_rps@reset.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-11/igt@i915_pm_rps@reset.html
Known issues
------------
Here are the changes found in Patchwork_137978v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@api_intel_bb@blit-reloc-purge-cache:
- shard-dg2: NOTRUN -> [SKIP][5] ([i915#8411])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@api_intel_bb@blit-reloc-purge-cache.html
* igt@device_reset@unbind-cold-reset-rebind:
- shard-rkl: NOTRUN -> [SKIP][6] ([i915#11078])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-6/igt@device_reset@unbind-cold-reset-rebind.html
- shard-dg1: NOTRUN -> [SKIP][7] ([i915#11078])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@device_reset@unbind-cold-reset-rebind.html
* igt@drm_fdinfo@busy@vcs1:
- shard-dg1: NOTRUN -> [SKIP][8] ([i915#8414]) +4 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@drm_fdinfo@busy@vcs1.html
* igt@drm_fdinfo@virtual-busy-all:
- shard-dg2: NOTRUN -> [SKIP][9] ([i915#8414]) +2 other tests skip
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@drm_fdinfo@virtual-busy-all.html
* igt@gem_basic@multigpu-create-close:
- shard-dg1: NOTRUN -> [SKIP][10] ([i915#7697])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@gem_basic@multigpu-create-close.html
- shard-tglu: NOTRUN -> [SKIP][11] ([i915#7697])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-5/igt@gem_basic@multigpu-create-close.html
* igt@gem_busy@semaphore:
- shard-dg2: NOTRUN -> [SKIP][12] ([i915#3936])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@gem_busy@semaphore.html
* igt@gem_ccs@block-multicopy-compressed:
- shard-rkl: NOTRUN -> [SKIP][13] ([i915#9323]) +1 other test skip
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-4/igt@gem_ccs@block-multicopy-compressed.html
* igt@gem_close_race@multigpu-basic-process:
- shard-mtlp: NOTRUN -> [SKIP][14] ([i915#7697])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-2/igt@gem_close_race@multigpu-basic-process.html
* igt@gem_ctx_engines@invalid-engines:
- shard-mtlp: [PASS][15] -> [FAIL][16] ([i915#12027])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-mtlp-8/igt@gem_ctx_engines@invalid-engines.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-4/igt@gem_ctx_engines@invalid-engines.html
* igt@gem_ctx_persistence@hang:
- shard-mtlp: NOTRUN -> [SKIP][17] ([i915#8555])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-2/igt@gem_ctx_persistence@hang.html
* igt@gem_ctx_sseu@invalid-args:
- shard-rkl: NOTRUN -> [SKIP][18] ([i915#280])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@gem_ctx_sseu@invalid-args.html
* igt@gem_ctx_sseu@invalid-sseu:
- shard-dg1: NOTRUN -> [SKIP][19] ([i915#280])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@gem_ctx_sseu@invalid-sseu.html
* igt@gem_eio@unwedge-stress:
- shard-dg1: [PASS][20] -> [FAIL][21] ([i915#5784])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-dg1-15/igt@gem_eio@unwedge-stress.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-16/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel:
- shard-rkl: NOTRUN -> [SKIP][22] ([i915#4525]) +2 other tests skip
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@gem_exec_balancer@parallel.html
* igt@gem_exec_capture@capture-invisible@smem0:
- shard-rkl: NOTRUN -> [SKIP][23] ([i915#6334])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@gem_exec_capture@capture-invisible@smem0.html
* igt@gem_exec_capture@capture@vecs0-lmem0:
- shard-dg2: NOTRUN -> [FAIL][24] ([i915#11965]) +3 other tests fail
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@gem_exec_capture@capture@vecs0-lmem0.html
* igt@gem_exec_fair@basic-deadline:
- shard-rkl: [PASS][25] -> [FAIL][26] ([i915#2846])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-rkl-1/igt@gem_exec_fair@basic-deadline.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-5/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-rkl: [PASS][27] -> [FAIL][28] ([i915#2842])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-rkl-4/igt@gem_exec_fair@basic-pace@bcs0.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-5/igt@gem_exec_fair@basic-pace@bcs0.html
* igt@gem_exec_fair@basic-sync:
- shard-dg2: NOTRUN -> [SKIP][29] ([i915#3539])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@gem_exec_fair@basic-sync.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: NOTRUN -> [FAIL][30] ([i915#2842]) +1 other test fail
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_flush@basic-uc-rw-default:
- shard-dg1: NOTRUN -> [SKIP][31] ([i915#3539] / [i915#4852]) +2 other tests skip
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@gem_exec_flush@basic-uc-rw-default.html
* igt@gem_exec_flush@basic-wb-prw-default:
- shard-dg2: NOTRUN -> [SKIP][32] ([i915#3539] / [i915#4852]) +1 other test skip
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@gem_exec_flush@basic-wb-prw-default.html
* igt@gem_exec_reloc@basic-cpu-gtt-noreloc:
- shard-dg2: NOTRUN -> [SKIP][33] ([i915#3281]) +8 other tests skip
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@gem_exec_reloc@basic-cpu-gtt-noreloc.html
* igt@gem_exec_reloc@basic-wc-read-noreloc:
- shard-rkl: NOTRUN -> [SKIP][34] ([i915#3281]) +13 other tests skip
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@gem_exec_reloc@basic-wc-read-noreloc.html
* igt@gem_exec_reloc@basic-write-read-noreloc:
- shard-dg1: NOTRUN -> [SKIP][35] ([i915#3281]) +4 other tests skip
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@gem_exec_reloc@basic-write-read-noreloc.html
* igt@gem_exec_schedule@semaphore-power:
- shard-dg1: NOTRUN -> [SKIP][36] ([i915#4812]) +2 other tests skip
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@gem_exec_schedule@semaphore-power.html
* igt@gem_exec_suspend@basic-s4-devices@smem:
- shard-rkl: NOTRUN -> [ABORT][37] ([i915#7975] / [i915#8213])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-4/igt@gem_exec_suspend@basic-s4-devices@smem.html
* igt@gem_fence_thrash@bo-write-verify-threaded-none:
- shard-dg1: NOTRUN -> [SKIP][38] ([i915#4860]) +2 other tests skip
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@gem_fence_thrash@bo-write-verify-threaded-none.html
* igt@gem_huc_copy@huc-copy:
- shard-glk: NOTRUN -> [SKIP][39] ([i915#2190])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-glk6/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-mtlp: NOTRUN -> [SKIP][40] ([i915#4613])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-2/igt@gem_lmem_swapping@heavy-verify-random.html
* igt@gem_lmem_swapping@parallel-random-verify-ccs:
- shard-rkl: NOTRUN -> [SKIP][41] ([i915#4613]) +4 other tests skip
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@gem_lmem_swapping@parallel-random-verify-ccs.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- shard-dg1: [PASS][42] -> [TIMEOUT][43] ([i915#5493])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-dg1-17/igt@gem_lmem_swapping@smem-oom@lmem0.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-17/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@gem_lmem_swapping@verify-random-ccs:
- shard-glk: NOTRUN -> [SKIP][44] ([i915#4613]) +1 other test skip
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-glk4/igt@gem_lmem_swapping@verify-random-ccs.html
* igt@gem_mmap@pf-nonblock:
- shard-dg1: NOTRUN -> [SKIP][45] ([i915#4083]) +1 other test skip
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@gem_mmap@pf-nonblock.html
* igt@gem_mmap_gtt@medium-copy-odd:
- shard-dg1: NOTRUN -> [SKIP][46] ([i915#4077]) +18 other tests skip
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@gem_mmap_gtt@medium-copy-odd.html
* igt@gem_mmap_wc@pf-nonblock:
- shard-dg2: NOTRUN -> [SKIP][47] ([i915#4083]) +4 other tests skip
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@gem_mmap_wc@pf-nonblock.html
* igt@gem_partial_pwrite_pread@write-uncached:
- shard-dg2: NOTRUN -> [SKIP][48] ([i915#3282]) +1 other test skip
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@gem_partial_pwrite_pread@write-uncached.html
* igt@gem_partial_pwrite_pread@writes-after-reads-display:
- shard-dg1: NOTRUN -> [SKIP][49] ([i915#3282]) +3 other tests skip
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@gem_partial_pwrite_pread@writes-after-reads-display.html
* igt@gem_pwrite_snooped:
- shard-rkl: NOTRUN -> [SKIP][50] ([i915#3282]) +4 other tests skip
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@gem_pwrite_snooped.html
* igt@gem_pxp@create-protected-buffer:
- shard-dg1: NOTRUN -> [SKIP][51] ([i915#4270]) +5 other tests skip
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@gem_pxp@create-protected-buffer.html
* igt@gem_pxp@reject-modify-context-protection-off-2:
- shard-dg2: NOTRUN -> [SKIP][52] ([i915#4270]) +2 other tests skip
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@gem_pxp@reject-modify-context-protection-off-2.html
- shard-rkl: NOTRUN -> [SKIP][53] ([i915#4270]) +2 other tests skip
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@gem_pxp@reject-modify-context-protection-off-2.html
* igt@gem_pxp@verify-pxp-stale-buf-optout-execution:
- shard-tglu: NOTRUN -> [SKIP][54] ([i915#4270])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-5/igt@gem_pxp@verify-pxp-stale-buf-optout-execution.html
* igt@gem_render_copy@y-tiled-ccs-to-x-tiled:
- shard-mtlp: NOTRUN -> [SKIP][55] ([i915#8428])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-2/igt@gem_render_copy@y-tiled-ccs-to-x-tiled.html
* igt@gem_render_copy@y-tiled-ccs-to-y-tiled:
- shard-dg2: NOTRUN -> [SKIP][56] ([i915#5190] / [i915#8428]) +4 other tests skip
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@gem_render_copy@y-tiled-ccs-to-y-tiled.html
* igt@gem_tiled_partial_pwrite_pread@writes:
- shard-dg2: NOTRUN -> [SKIP][57] ([i915#4077]) +5 other tests skip
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@gem_tiled_partial_pwrite_pread@writes.html
* igt@gem_tiled_pread_basic:
- shard-dg1: NOTRUN -> [SKIP][58] ([i915#4079])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@gem_tiled_pread_basic.html
* igt@gem_userptr_blits@coherency-sync:
- shard-rkl: NOTRUN -> [SKIP][59] ([i915#3297])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-4/igt@gem_userptr_blits@coherency-sync.html
* igt@gem_userptr_blits@map-fixed-invalidate:
- shard-dg2: NOTRUN -> [SKIP][60] ([i915#3297] / [i915#4880])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@gem_userptr_blits@map-fixed-invalidate.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap:
- shard-dg1: NOTRUN -> [SKIP][61] ([i915#3297] / [i915#4880])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@gem_userptr_blits@map-fixed-invalidate-overlap.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-mtlp: NOTRUN -> [SKIP][62] ([i915#3297])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-2/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-dg1: NOTRUN -> [SKIP][63] ([i915#3297]) +3 other tests skip
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@gem_userptr_blits@unsync-unmap-cycles.html
* igt@gen9_exec_parse@batch-invalid-length:
- shard-dg1: NOTRUN -> [SKIP][64] ([i915#2527]) +1 other test skip
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@gen9_exec_parse@batch-invalid-length.html
* igt@gen9_exec_parse@bb-chained:
- shard-rkl: NOTRUN -> [SKIP][65] ([i915#2527]) +3 other tests skip
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@gen9_exec_parse@bb-chained.html
* igt@gen9_exec_parse@unaligned-access:
- shard-dg2: NOTRUN -> [SKIP][66] ([i915#2856]) +2 other tests skip
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@gen9_exec_parse@unaligned-access.html
* igt@i915_fb_tiling:
- shard-dg2: NOTRUN -> [SKIP][67] ([i915#4881])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@i915_fb_tiling.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-snb: [PASS][68] -> [ABORT][69] ([i915#9820])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-snb2/igt@i915_module_load@reload-with-fault-injection.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-snb5/igt@i915_module_load@reload-with-fault-injection.html
- shard-tglu: [PASS][70] -> [ABORT][71] ([i915#9820])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-tglu-6/igt@i915_module_load@reload-with-fault-injection.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-9/igt@i915_module_load@reload-with-fault-injection.html
- shard-glk: [PASS][72] -> [ABORT][73] ([i915#9820])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-glk2/igt@i915_module_load@reload-with-fault-injection.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-glk8/igt@i915_module_load@reload-with-fault-injection.html
- shard-dg2: [PASS][74] -> [ABORT][75] ([i915#9820])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-dg2-11/igt@i915_module_load@reload-with-fault-injection.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-6/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_freq_api@freq-reset-multiple:
- shard-rkl: NOTRUN -> [SKIP][76] ([i915#8399]) +1 other test skip
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@i915_pm_freq_api@freq-reset-multiple.html
* igt@i915_pm_freq_mult@media-freq@gt0:
- shard-rkl: NOTRUN -> [SKIP][77] ([i915#6590])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-6/igt@i915_pm_freq_mult@media-freq@gt0.html
- shard-dg1: NOTRUN -> [SKIP][78] ([i915#6590])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@i915_pm_freq_mult@media-freq@gt0.html
* igt@i915_pm_rc6_residency@rc6-idle@gt0-rcs0:
- shard-dg1: NOTRUN -> [FAIL][79] ([i915#3591])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@i915_pm_rc6_residency@rc6-idle@gt0-rcs0.html
* igt@i915_pm_rps@basic-api:
- shard-dg2: NOTRUN -> [SKIP][80] ([i915#11681] / [i915#6621])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@i915_pm_rps@basic-api.html
* igt@i915_pm_rps@min-max-config-loaded:
- shard-dg1: NOTRUN -> [SKIP][81] ([i915#11681] / [i915#6621])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@i915_pm_rps@min-max-config-loaded.html
* igt@i915_pm_rps@thresholds:
- shard-dg1: NOTRUN -> [SKIP][82] ([i915#11681])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@i915_pm_rps@thresholds.html
* igt@kms_addfb_basic@tile-pitch-mismatch:
- shard-dg1: NOTRUN -> [SKIP][83] ([i915#4212]) +2 other tests skip
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@kms_addfb_basic@tile-pitch-mismatch.html
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-hdmi-a-2-y-rc-ccs-cc:
- shard-rkl: NOTRUN -> [SKIP][84] ([i915#8709]) +3 other tests skip
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-hdmi-a-2-y-rc-ccs-cc.html
* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-dg1: NOTRUN -> [SKIP][85] ([i915#9531])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@kms_atomic@plane-primary-overlay-mutable-zpos.html
* igt@kms_atomic_transition@modeset-transition-nonblocking-fencing@2x-outputs:
- shard-glk: [PASS][86] -> [FAIL][87] ([i915#11859])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-glk5/igt@kms_atomic_transition@modeset-transition-nonblocking-fencing@2x-outputs.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-glk8/igt@kms_atomic_transition@modeset-transition-nonblocking-fencing@2x-outputs.html
* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-dg2: NOTRUN -> [SKIP][88] ([i915#1769] / [i915#3555])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
- shard-glk: NOTRUN -> [SKIP][89] ([i915#1769])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-glk6/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-1:
- shard-snb: [PASS][90] -> [FAIL][91] ([i915#5956])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-snb7/igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-1.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-snb2/igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-1.html
* igt@kms_atomic_transition@plane-toggle-modeset-transition@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [FAIL][92] ([i915#5956])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-11/igt@kms_atomic_transition@plane-toggle-modeset-transition@pipe-a-dp-4.html
* igt@kms_big_fb@4-tiled-32bpp-rotate-270:
- shard-tglu: NOTRUN -> [SKIP][93] ([i915#5286]) +1 other test skip
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-5/igt@kms_big_fb@4-tiled-32bpp-rotate-270.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-rkl: NOTRUN -> [SKIP][94] ([i915#5286]) +7 other tests skip
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-4/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-dg1: NOTRUN -> [SKIP][95] ([i915#4538] / [i915#5286]) +5 other tests skip
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_big_fb@linear-64bpp-rotate-90:
- shard-dg1: NOTRUN -> [SKIP][96] ([i915#3638]) +3 other tests skip
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_big_fb@linear-64bpp-rotate-90.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-270:
- shard-dg2: NOTRUN -> [SKIP][97] +10 other tests skip
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@kms_big_fb@x-tiled-64bpp-rotate-270.html
* igt@kms_big_fb@y-tiled-8bpp-rotate-270:
- shard-rkl: NOTRUN -> [SKIP][98] ([i915#3638]) +1 other test skip
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-6/igt@kms_big_fb@y-tiled-8bpp-rotate-270.html
* igt@kms_big_fb@y-tiled-addfb:
- shard-dg2: NOTRUN -> [SKIP][99] ([i915#5190])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@kms_big_fb@y-tiled-addfb.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-dg2: NOTRUN -> [SKIP][100] ([i915#4538] / [i915#5190]) +5 other tests skip
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-180:
- shard-mtlp: NOTRUN -> [SKIP][101] +2 other tests skip
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-6/igt@kms_big_fb@yf-tiled-32bpp-rotate-180.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180:
- shard-dg1: NOTRUN -> [SKIP][102] ([i915#4538]) +5 other tests skip
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180.html
* igt@kms_big_joiner@basic:
- shard-dg1: NOTRUN -> [SKIP][103] ([i915#10656])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@kms_big_joiner@basic.html
* igt@kms_big_joiner@invalid-modeset-force-joiner:
- shard-dg2: NOTRUN -> [SKIP][104] ([i915#10656])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@kms_big_joiner@invalid-modeset-force-joiner.html
- shard-rkl: NOTRUN -> [SKIP][105] ([i915#10656]) +1 other test skip
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@kms_big_joiner@invalid-modeset-force-joiner.html
* igt@kms_ccs@bad-rotation-90-4-tiled-dg2-rc-ccs-cc@pipe-d-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][106] ([i915#6095]) +3 other tests skip
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-6/igt@kms_ccs@bad-rotation-90-4-tiled-dg2-rc-ccs-cc@pipe-d-edp-1.html
* igt@kms_ccs@bad-rotation-90-y-tiled-gen12-mc-ccs@pipe-b-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][107] ([i915#6095]) +3 other tests skip
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-5/igt@kms_ccs@bad-rotation-90-y-tiled-gen12-mc-ccs@pipe-b-hdmi-a-1.html
* igt@kms_ccs@bad-rotation-90-y-tiled-gen12-rc-ccs@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][108] ([i915#10307] / [i915#10434] / [i915#6095]) +2 other tests skip
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-4/igt@kms_ccs@bad-rotation-90-y-tiled-gen12-rc-ccs@pipe-d-hdmi-a-1.html
* igt@kms_ccs@crc-primary-rotation-180-4-tiled-bmg-ccs:
- shard-rkl: NOTRUN -> [SKIP][109] ([i915#12042])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-6/igt@kms_ccs@crc-primary-rotation-180-4-tiled-bmg-ccs.html
* igt@kms_ccs@crc-primary-rotation-180-4-tiled-dg2-mc-ccs@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][110] ([i915#6095]) +93 other tests skip
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-4/igt@kms_ccs@crc-primary-rotation-180-4-tiled-dg2-mc-ccs@pipe-b-hdmi-a-1.html
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-bmg-ccs:
- shard-dg1: NOTRUN -> [SKIP][111] ([i915#12042]) +4 other tests skip
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-bmg-ccs.html
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-lnl-ccs:
- shard-tglu: NOTRUN -> [SKIP][112] ([i915#12042])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-5/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-lnl-ccs.html
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-mc-ccs@pipe-a-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][113] ([i915#10307] / [i915#6095]) +144 other tests skip
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-mc-ccs@pipe-a-hdmi-a-3.html
* igt@kms_ccs@missing-ccs-buffer-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][114] ([i915#6095]) +31 other tests skip
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_ccs@missing-ccs-buffer-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-4.html
* igt@kms_ccs@random-ccs-data-4-tiled-bmg-ccs:
- shard-dg2: NOTRUN -> [SKIP][115] ([i915#12042]) +1 other test skip
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@kms_ccs@random-ccs-data-4-tiled-bmg-ccs.html
* igt@kms_cdclk@mode-transition@pipe-b-hdmi-a-2:
- shard-dg2: NOTRUN -> [SKIP][116] ([i915#7213]) +3 other tests skip
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-3/igt@kms_cdclk@mode-transition@pipe-b-hdmi-a-2.html
* igt@kms_cdclk@plane-scaling@pipe-b-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][117] ([i915#4087]) +3 other tests skip
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@kms_cdclk@plane-scaling@pipe-b-hdmi-a-3.html
* igt@kms_chamelium_audio@dp-audio:
- shard-mtlp: NOTRUN -> [SKIP][118] ([i915#7828]) +1 other test skip
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-2/igt@kms_chamelium_audio@dp-audio.html
* igt@kms_chamelium_audio@hdmi-audio-edid:
- shard-dg1: NOTRUN -> [SKIP][119] ([i915#7828]) +6 other tests skip
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@kms_chamelium_audio@hdmi-audio-edid.html
* igt@kms_chamelium_edid@hdmi-edid-stress-resolution-non-4k:
- shard-dg2: NOTRUN -> [SKIP][120] ([i915#7828]) +5 other tests skip
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@kms_chamelium_edid@hdmi-edid-stress-resolution-non-4k.html
* igt@kms_chamelium_frames@vga-frame-dump:
- shard-rkl: NOTRUN -> [SKIP][121] ([i915#7828]) +10 other tests skip
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@kms_chamelium_frames@vga-frame-dump.html
* igt@kms_chamelium_hpd@vga-hpd-without-ddc:
- shard-tglu: NOTRUN -> [SKIP][122] ([i915#7828]) +2 other tests skip
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-5/igt@kms_chamelium_hpd@vga-hpd-without-ddc.html
* igt@kms_color@deep-color:
- shard-dg2: NOTRUN -> [SKIP][123] ([i915#3555]) +6 other tests skip
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-6/igt@kms_color@deep-color.html
* igt@kms_content_protection@content-type-change:
- shard-dg2: NOTRUN -> [SKIP][124] ([i915#9424])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@kms_content_protection@content-type-change.html
* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-dg1: NOTRUN -> [SKIP][125] ([i915#3299])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@kms_content_protection@dp-mst-lic-type-1.html
* igt@kms_content_protection@legacy:
- shard-rkl: NOTRUN -> [SKIP][126] ([i915#7118] / [i915#9424])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@kms_content_protection@legacy.html
* igt@kms_content_protection@lic-type-1:
- shard-dg1: NOTRUN -> [SKIP][127] ([i915#9424])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_content_protection@lic-type-1.html
- shard-tglu: NOTRUN -> [SKIP][128] ([i915#6944] / [i915#9424])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-5/igt@kms_content_protection@lic-type-1.html
* igt@kms_content_protection@uevent:
- shard-dg2: NOTRUN -> [SKIP][129] ([i915#7118] / [i915#9424])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-6/igt@kms_content_protection@uevent.html
* igt@kms_cursor_crc@cursor-offscreen-512x170:
- shard-dg1: NOTRUN -> [SKIP][130] ([i915#11453])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@kms_cursor_crc@cursor-offscreen-512x170.html
* igt@kms_cursor_crc@cursor-random-32x32:
- shard-dg1: NOTRUN -> [SKIP][131] ([i915#3555]) +11 other tests skip
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@kms_cursor_crc@cursor-random-32x32.html
* igt@kms_cursor_crc@cursor-random-512x170:
- shard-mtlp: NOTRUN -> [SKIP][132] ([i915#3359])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-2/igt@kms_cursor_crc@cursor-random-512x170.html
* igt@kms_cursor_crc@cursor-rapid-movement-256x85:
- shard-mtlp: NOTRUN -> [SKIP][133] ([i915#8814])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-2/igt@kms_cursor_crc@cursor-rapid-movement-256x85.html
* igt@kms_cursor_crc@cursor-sliding-32x32:
- shard-tglu: NOTRUN -> [SKIP][134] ([i915#3555])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-5/igt@kms_cursor_crc@cursor-sliding-32x32.html
* igt@kms_cursor_crc@cursor-sliding-512x170:
- shard-dg2: NOTRUN -> [SKIP][135] ([i915#11453])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@kms_cursor_crc@cursor-sliding-512x170.html
* igt@kms_cursor_crc@cursor-sliding-512x512:
- shard-rkl: NOTRUN -> [SKIP][136] ([i915#11453]) +1 other test skip
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@kms_cursor_crc@cursor-sliding-512x512.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-glk: NOTRUN -> [FAIL][137] ([i915#2346])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions:
- shard-dg2: NOTRUN -> [SKIP][138] ([i915#4103] / [i915#4213])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions.html
* igt@kms_dirtyfb@drrs-dirtyfb-ioctl:
- shard-dg2: NOTRUN -> [SKIP][139] ([i915#9833])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@kms_dirtyfb@drrs-dirtyfb-ioctl.html
- shard-rkl: NOTRUN -> [SKIP][140] ([i915#9723])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@kms_dirtyfb@drrs-dirtyfb-ioctl.html
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][141] ([i915#3804])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-4/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1.html
* igt@kms_dsc@dsc-fractional-bpp-with-bpc:
- shard-dg1: NOTRUN -> [SKIP][142] ([i915#3840])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@kms_dsc@dsc-fractional-bpp-with-bpc.html
* igt@kms_dsc@dsc-with-bpc-formats:
- shard-rkl: NOTRUN -> [SKIP][143] ([i915#3555] / [i915#3840]) +1 other test skip
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@kms_dsc@dsc-with-bpc-formats.html
* igt@kms_dsc@dsc-with-output-formats-with-bpc:
- shard-dg2: NOTRUN -> [SKIP][144] ([i915#3840] / [i915#9053])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@kms_dsc@dsc-with-output-formats-with-bpc.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-dg1: NOTRUN -> [SKIP][145] ([i915#3469])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_feature_discovery@chamelium:
- shard-dg2: NOTRUN -> [SKIP][146] ([i915#4854])
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@kms_feature_discovery@chamelium.html
* igt@kms_feature_discovery@display-2x:
- shard-dg2: NOTRUN -> [SKIP][147] ([i915#1839])
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@kms_feature_discovery@display-2x.html
* igt@kms_feature_discovery@display-3x:
- shard-dg1: NOTRUN -> [SKIP][148] ([i915#1839])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_feature_discovery@display-3x.html
* igt@kms_feature_discovery@display-4x:
- shard-rkl: NOTRUN -> [SKIP][149] ([i915#1839]) +2 other tests skip
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@kms_feature_discovery@display-4x.html
* igt@kms_feature_discovery@psr2:
- shard-dg1: NOTRUN -> [SKIP][150] ([i915#658])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_feature_discovery@psr2.html
* igt@kms_flip@2x-busy-flip:
- shard-tglu: NOTRUN -> [SKIP][151] ([i915#3637])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-5/igt@kms_flip@2x-busy-flip.html
* igt@kms_flip@2x-flip-vs-dpms:
- shard-dg1: NOTRUN -> [SKIP][152] ([i915#9934]) +3 other tests skip
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_flip@2x-flip-vs-dpms.html
* igt@kms_flip@2x-flip-vs-fences-interruptible:
- shard-dg1: NOTRUN -> [SKIP][153] ([i915#8381])
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@kms_flip@2x-flip-vs-fences-interruptible.html
* igt@kms_flip@2x-flip-vs-wf_vblank-interruptible:
- shard-mtlp: NOTRUN -> [SKIP][154] ([i915#3637])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-2/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible.html
* igt@kms_flip@2x-plain-flip-ts-check@ab-vga1-hdmi-a1:
- shard-snb: [PASS][155] -> [FAIL][156] ([i915#2122])
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-snb2/igt@kms_flip@2x-plain-flip-ts-check@ab-vga1-hdmi-a1.html
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-snb7/igt@kms_flip@2x-plain-flip-ts-check@ab-vga1-hdmi-a1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1:
- shard-glk: [PASS][157] -> [FAIL][158] ([i915#79])
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-valid-mode:
- shard-dg2: NOTRUN -> [SKIP][159] ([i915#2672]) +2 other tests skip
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-rkl: NOTRUN -> [SKIP][160] ([i915#2672]) +6 other tests skip
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-dg1: NOTRUN -> [SKIP][161] ([i915#2587] / [i915#2672]) +1 other test skip
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-upscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-dg2: [PASS][162] -> [FAIL][163] ([i915#6880])
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-dg2-11/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-mtlp: NOTRUN -> [SKIP][164] ([i915#1825]) +3 other tests skip
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-dg1: NOTRUN -> [SKIP][165] ([i915#8708]) +16 other tests skip
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-dg2: NOTRUN -> [SKIP][166] ([i915#3458]) +14 other tests skip
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-indfb-fliptrack-mmap-gtt:
- shard-rkl: NOTRUN -> [SKIP][167] +34 other tests skip
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-indfb-fliptrack-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-rkl: NOTRUN -> [SKIP][168] ([i915#1825]) +40 other tests skip
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-pwrite:
- shard-dg1: NOTRUN -> [SKIP][169] +38 other tests skip
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-fullscreen:
- shard-tglu: NOTRUN -> [SKIP][170] +13 other tests skip
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-5/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-fullscreen.html
* igt@kms_frontbuffer_tracking@fbcpsr-tiling-4:
- shard-dg1: NOTRUN -> [SKIP][171] ([i915#5439])
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@kms_frontbuffer_tracking@fbcpsr-tiling-4.html
* igt@kms_frontbuffer_tracking@pipe-fbc-rte:
- shard-dg1: NOTRUN -> [SKIP][172] ([i915#9766])
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_frontbuffer_tracking@pipe-fbc-rte.html
- shard-tglu: NOTRUN -> [SKIP][173] ([i915#9766])
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-5/igt@kms_frontbuffer_tracking@pipe-fbc-rte.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][174] ([i915#8708]) +9 other tests skip
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-onoff:
- shard-dg2: NOTRUN -> [SKIP][175] ([i915#5354]) +26 other tests skip
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-onoff.html
* igt@kms_frontbuffer_tracking@psr-modesetfrombusy:
- shard-rkl: NOTRUN -> [SKIP][176] ([i915#3023]) +28 other tests skip
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-modesetfrombusy.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-cpu:
- shard-dg1: NOTRUN -> [SKIP][177] ([i915#3458]) +16 other tests skip
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-cpu.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-rkl: NOTRUN -> [SKIP][178] ([i915#3555] / [i915#8228]) +1 other test skip
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-6/igt@kms_hdr@bpc-switch-dpms.html
- shard-dg1: NOTRUN -> [SKIP][179] ([i915#3555] / [i915#8228])
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_hdr@static-toggle-dpms:
- shard-dg2: NOTRUN -> [SKIP][180] ([i915#3555] / [i915#8228]) +1 other test skip
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@kms_hdr@static-toggle-dpms.html
* igt@kms_plane_lowres@tiling-none@pipe-b-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][181] ([i915#10226] / [i915#11614] / [i915#3582]) +2 other tests skip
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-2/igt@kms_plane_lowres@tiling-none@pipe-b-edp-1.html
* igt@kms_plane_lowres@tiling-none@pipe-d-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][182] ([i915#11614] / [i915#3582])
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-2/igt@kms_plane_lowres@tiling-none@pipe-d-edp-1.html
* igt@kms_plane_multiple@tiling-yf:
- shard-rkl: NOTRUN -> [SKIP][183] ([i915#3555]) +7 other tests skip
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-6/igt@kms_plane_multiple@tiling-yf.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [FAIL][184] ([i915#8292])
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-4/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-rotation@pipe-b-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][185] ([i915#9423]) +7 other tests skip
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-rotation@pipe-b-hdmi-a-3.html
* igt@kms_plane_scaling@plane-downscale-factor-0-5-with-rotation@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][186] ([i915#9423]) +11 other tests skip
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-4/igt@kms_plane_scaling@plane-downscale-factor-0-5-with-rotation@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@plane-upscale-factor-0-25-with-rotation@pipe-d-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][187] ([i915#9423]) +3 other tests skip
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_plane_scaling@plane-upscale-factor-0-25-with-rotation@pipe-d-hdmi-a-4.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][188] ([i915#9728]) +7 other tests skip
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-3/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][189] ([i915#5235]) +1 other test skip
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-a-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][190] ([i915#5235]) +2 other tests skip
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-2/igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-a-edp-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-d-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][191] ([i915#3555] / [i915#5235])
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-2/igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-d-edp-1.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][192] ([i915#9728]) +3 other tests skip
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-5/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-d-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][193] ([i915#9728]) +3 other tests skip
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-d-hdmi-a-4.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-1:
- shard-glk: NOTRUN -> [SKIP][194] +176 other tests skip
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-glk4/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-1.html
* igt@kms_pm_backlight@bad-brightness:
- shard-rkl: NOTRUN -> [SKIP][195] ([i915#5354]) +1 other test skip
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-6/igt@kms_pm_backlight@bad-brightness.html
- shard-dg1: NOTRUN -> [SKIP][196] ([i915#5354]) +1 other test skip
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_pm_backlight@bad-brightness.html
* igt@kms_pm_dc@dc5-dpms-negative:
- shard-mtlp: NOTRUN -> [SKIP][197] ([i915#9293])
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-2/igt@kms_pm_dc@dc5-dpms-negative.html
* igt@kms_pm_dc@dc6-psr:
- shard-dg2: NOTRUN -> [SKIP][198] ([i915#9685]) +1 other test skip
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@kms_pm_dc@dc6-psr.html
* igt@kms_pm_dc@dc9-dpms:
- shard-rkl: NOTRUN -> [SKIP][199] ([i915#3361])
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-4/igt@kms_pm_dc@dc9-dpms.html
- shard-tglu: [PASS][200] -> [SKIP][201] ([i915#4281])
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-tglu-10/igt@kms_pm_dc@dc9-dpms.html
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-8/igt@kms_pm_dc@dc9-dpms.html
* igt@kms_pm_lpsp@kms-lpsp:
- shard-rkl: NOTRUN -> [SKIP][202] ([i915#9340])
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@kms_pm_lpsp@kms-lpsp.html
* igt@kms_pm_rpm@dpms-mode-unset-lpsp:
- shard-dg2: [PASS][203] -> [SKIP][204] ([i915#9519])
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-dg2-4/igt@kms_pm_rpm@dpms-mode-unset-lpsp.html
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-3/igt@kms_pm_rpm@dpms-mode-unset-lpsp.html
* igt@kms_pm_rpm@dpms-non-lpsp:
- shard-tglu: NOTRUN -> [SKIP][205] ([i915#9519])
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-5/igt@kms_pm_rpm@dpms-non-lpsp.html
* igt@kms_pm_rpm@modeset-lpsp:
- shard-dg2: NOTRUN -> [SKIP][206] ([i915#9519])
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@kms_pm_rpm@modeset-lpsp.html
* igt@kms_pm_rpm@modeset-lpsp-stress:
- shard-dg1: NOTRUN -> [SKIP][207] ([i915#9519])
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@kms_pm_rpm@modeset-lpsp-stress.html
* igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-rkl: [PASS][208] -> [SKIP][209] ([i915#9519])
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-rkl-5/igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-2/igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-dg2: NOTRUN -> [SKIP][210] ([i915#11520]) +2 other tests skip
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_sf@fbc-cursor-plane-move-continuous-exceed-sf:
- shard-rkl: NOTRUN -> [SKIP][211] ([i915#11520]) +1 other test skip
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-4/igt@kms_psr2_sf@fbc-cursor-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_sf@fbc-cursor-plane-move-continuous-sf:
- shard-dg1: NOTRUN -> [SKIP][212] ([i915#11520]) +2 other tests skip
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@kms_psr2_sf@fbc-cursor-plane-move-continuous-sf.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-tglu: NOTRUN -> [SKIP][213] ([i915#11520])
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-5/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html
* igt@kms_psr2_su@page_flip-nv12:
- shard-dg2: NOTRUN -> [SKIP][214] ([i915#9683])
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@kms_psr2_su@page_flip-nv12.html
* igt@kms_psr2_su@page_flip-p010:
- shard-dg1: NOTRUN -> [SKIP][215] ([i915#9683])
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@kms_psr2_su@page_flip-p010.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-rkl: NOTRUN -> [SKIP][216] ([i915#9683]) +1 other test skip
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@fbc-pr-cursor-mmap-cpu:
- shard-rkl: NOTRUN -> [SKIP][217] ([i915#1072] / [i915#9732]) +26 other tests skip
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-6/igt@kms_psr@fbc-pr-cursor-mmap-cpu.html
* igt@kms_psr@fbc-psr2-basic:
- shard-dg1: NOTRUN -> [SKIP][218] ([i915#1072] / [i915#9732]) +19 other tests skip
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@kms_psr@fbc-psr2-basic.html
* igt@kms_psr@pr-cursor-render:
- shard-mtlp: NOTRUN -> [SKIP][219] ([i915#9688])
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-2/igt@kms_psr@pr-cursor-render.html
* igt@kms_psr@psr-primary-render:
- shard-tglu: NOTRUN -> [SKIP][220] ([i915#9732]) +4 other tests skip
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-5/igt@kms_psr@psr-primary-render.html
* igt@kms_psr@psr2-primary-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][221] ([i915#1072] / [i915#9732]) +14 other tests skip
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@kms_psr@psr2-primary-mmap-gtt.html
* igt@kms_rotation_crc@exhaust-fences:
- shard-dg1: NOTRUN -> [SKIP][222] ([i915#4884])
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_rotation_crc@exhaust-fences.html
* igt@kms_rotation_crc@primary-4-tiled-reflect-x-0:
- shard-dg1: NOTRUN -> [SKIP][223] ([i915#5289])
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_rotation_crc@primary-4-tiled-reflect-x-0.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180:
- shard-rkl: NOTRUN -> [SKIP][224] ([i915#5289]) +2 other tests skip
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270:
- shard-dg2: NOTRUN -> [SKIP][225] ([i915#11131] / [i915#5190]) +1 other test skip
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270.html
* igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
- shard-dg2: NOTRUN -> [SKIP][226] ([i915#11131])
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@kms_rotation_crc@sprite-rotation-90-pos-100-0.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [FAIL][227] ([i915#9196])
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-4/igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1.html
* igt@kms_vrr@lobf:
- shard-rkl: NOTRUN -> [SKIP][228] ([i915#11920])
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-6/igt@kms_vrr@lobf.html
- shard-dg1: NOTRUN -> [SKIP][229] ([i915#11920])
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@kms_vrr@lobf.html
* igt@kms_vrr@max-min:
- shard-dg1: NOTRUN -> [SKIP][230] ([i915#9906]) +1 other test skip
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@kms_vrr@max-min.html
* igt@kms_vrr@seamless-rr-switch-drrs:
- shard-rkl: NOTRUN -> [SKIP][231] ([i915#9906])
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@kms_vrr@seamless-rr-switch-drrs.html
* igt@kms_writeback@writeback-check-output-xrgb2101010:
- shard-rkl: NOTRUN -> [SKIP][232] ([i915#2437] / [i915#9412])
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-4/igt@kms_writeback@writeback-check-output-xrgb2101010.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-glk: NOTRUN -> [SKIP][233] ([i915#2437]) +1 other test skip
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-glk6/igt@kms_writeback@writeback-pixel-formats.html
- shard-dg2: NOTRUN -> [SKIP][234] ([i915#2437] / [i915#9412])
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@kms_writeback@writeback-pixel-formats.html
* igt@perf@global-sseu-config:
- shard-dg2: NOTRUN -> [SKIP][235] ([i915#7387])
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@perf@global-sseu-config.html
* igt@perf@non-zero-reason@0-rcs0:
- shard-dg2: NOTRUN -> [FAIL][236] ([i915#9100])
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@perf@non-zero-reason@0-rcs0.html
* igt@perf@per-context-mode-unprivileged:
- shard-dg1: NOTRUN -> [SKIP][237] ([i915#2433])
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-15/igt@perf@per-context-mode-unprivileged.html
* igt@perf_pmu@rc6-all-gts:
- shard-dg2: NOTRUN -> [SKIP][238] ([i915#8516])
[238]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@perf_pmu@rc6-all-gts.html
- shard-rkl: NOTRUN -> [SKIP][239] ([i915#8516])
[239]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@perf_pmu@rc6-all-gts.html
* igt@prime_vgem@basic-write:
- shard-dg2: NOTRUN -> [SKIP][240] ([i915#3291] / [i915#3708])
[240]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@prime_vgem@basic-write.html
* igt@prime_vgem@coherency-gtt:
- shard-dg2: NOTRUN -> [SKIP][241] ([i915#3708] / [i915#4077])
[241]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-7/igt@prime_vgem@coherency-gtt.html
- shard-rkl: NOTRUN -> [SKIP][242] ([i915#3708]) +1 other test skip
[242]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@prime_vgem@coherency-gtt.html
* igt@sriov_basic@bind-unbind-vf:
- shard-rkl: NOTRUN -> [SKIP][243] ([i915#9917]) +1 other test skip
[243]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-1/igt@sriov_basic@bind-unbind-vf.html
* igt@sriov_basic@enable-vfs-bind-unbind-each:
- shard-dg2: NOTRUN -> [SKIP][244] ([i915#9917])
[244]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-5/igt@sriov_basic@enable-vfs-bind-unbind-each.html
* igt@syncobj_wait@invalid-wait-zero-handles:
- shard-dg1: NOTRUN -> [FAIL][245] ([i915#9781])
[245]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-18/igt@syncobj_wait@invalid-wait-zero-handles.html
#### Possible fixes ####
* igt@drm_fdinfo@virtual-idle:
- shard-rkl: [FAIL][246] ([i915#11900] / [i915#7742]) -> [PASS][247]
[246]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-rkl-6/igt@drm_fdinfo@virtual-idle.html
[247]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-5/igt@drm_fdinfo@virtual-idle.html
* igt@gem_eio@in-flight-1us:
- shard-dg2: [INCOMPLETE][248] -> [PASS][249]
[248]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-dg2-10/igt@gem_eio@in-flight-1us.html
[249]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-11/igt@gem_eio@in-flight-1us.html
* igt@gem_exec_big@single:
- shard-tglu: [ABORT][250] ([i915#11713]) -> [PASS][251]
[250]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-tglu-3/igt@gem_exec_big@single.html
[251]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-5/igt@gem_exec_big@single.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][252] ([i915#2842]) -> [PASS][253]
[252]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[253]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html
- shard-tglu: [FAIL][254] ([i915#2842]) -> [PASS][255]
[254]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-tglu-9/igt@gem_exec_fair@basic-pace-share@rcs0.html
[255]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-3/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_sync@basic-all:
- shard-mtlp: [INCOMPLETE][256] -> [PASS][257]
[256]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-mtlp-5/igt@gem_sync@basic-all.html
[257]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-6/igt@gem_sync@basic-all.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-rkl: [ABORT][258] ([i915#9820]) -> [PASS][259]
[258]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-rkl-3/igt@i915_module_load@reload-with-fault-injection.html
[259]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-4/igt@i915_module_load@reload-with-fault-injection.html
- shard-mtlp: [ABORT][260] ([i915#10131] / [i915#10887] / [i915#9820]) -> [PASS][261]
[260]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-mtlp-3/igt@i915_module_load@reload-with-fault-injection.html
[261]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-2/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0:
- shard-dg1: [INCOMPLETE][262] -> [PASS][263]
[262]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-dg1-13/igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0.html
[263]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg1-13/igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0.html
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing@pipe-a-hdmi-a-1:
- shard-tglu: [FAIL][264] ([i915#11808]) -> [PASS][265]
[264]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-tglu-9/igt@kms_atomic_transition@plane-all-modeset-transition-fencing@pipe-a-hdmi-a-1.html
[265]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-tglu-8/igt@kms_atomic_transition@plane-all-modeset-transition-fencing@pipe-a-hdmi-a-1.html
* igt@kms_atomic_transition@plane-toggle-modeset-transition@pipe-a-edp-1:
- shard-mtlp: [FAIL][266] ([i915#11808] / [i915#5956]) -> [PASS][267]
[266]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-mtlp-5/igt@kms_atomic_transition@plane-toggle-modeset-transition@pipe-a-edp-1.html
[267]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-mtlp-6/igt@kms_atomic_transition@plane-toggle-modeset-transition@pipe-a-edp-1.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][268] ([i915#2346]) -> [PASS][269]
[268]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[269]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@torture-bo@pipe-a:
- shard-glk: [DMESG-WARN][270] ([i915#10166]) -> [PASS][271]
[270]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-glk4/igt@kms_cursor_legacy@torture-bo@pipe-a.html
[271]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-glk6/igt@kms_cursor_legacy@torture-bo@pipe-a.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-snb: [SKIP][272] -> [PASS][273]
[272]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-snb2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-gtt.html
[273]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-snb7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-gtt.html
* igt@kms_pm_rpm@modeset-non-lpsp-stress:
- shard-rkl: [SKIP][274] ([i915#9519]) -> [PASS][275] +3 other tests pass
[274]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-rkl-2/igt@kms_pm_rpm@modeset-non-lpsp-stress.html
[275]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-3/igt@kms_pm_rpm@modeset-non-lpsp-stress.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1:
- shard-snb: [FAIL][276] ([i915#9196]) -> [PASS][277]
[276]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-snb2/igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1.html
[277]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-snb7/igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1.html
#### Warnings ####
* igt@gem_ctx_engines@invalid-engines:
- shard-glk: [FAIL][278] -> [FAIL][279] ([i915#12027])
[278]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-glk1/igt@gem_ctx_engines@invalid-engines.html
[279]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-glk2/igt@gem_ctx_engines@invalid-engines.html
* igt@kms_cursor_crc@cursor-offscreen-512x512:
- shard-dg2: [SKIP][280] ([i915#11453] / [i915#3359]) -> [SKIP][281] ([i915#11453])
[280]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-dg2-11/igt@kms_cursor_crc@cursor-offscreen-512x512.html
[281]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-2/igt@kms_cursor_crc@cursor-offscreen-512x512.html
* igt@kms_cursor_crc@cursor-random-512x512:
- shard-dg2: [SKIP][282] ([i915#11453]) -> [SKIP][283] ([i915#11453] / [i915#3359]) +1 other test skip
[282]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-dg2-6/igt@kms_cursor_crc@cursor-random-512x512.html
[283]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-11/igt@kms_cursor_crc@cursor-random-512x512.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
- shard-dg2: [SKIP][284] ([i915#10433] / [i915#3458]) -> [SKIP][285] ([i915#3458]) +1 other test skip
[284]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-dg2-4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
[285]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-rkl: [SKIP][286] ([i915#4070] / [i915#4816]) -> [SKIP][287] ([i915#4816])
[286]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-rkl-6/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
[287]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-rkl-4/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
* igt@kms_psr@psr-cursor-mmap-cpu:
- shard-dg2: [SKIP][288] ([i915#1072] / [i915#9732]) -> [SKIP][289] ([i915#1072] / [i915#9673] / [i915#9732]) +14 other tests skip
[288]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-dg2-10/igt@kms_psr@psr-cursor-mmap-cpu.html
[289]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-11/igt@kms_psr@psr-cursor-mmap-cpu.html
* igt@kms_psr@psr-cursor-render:
- shard-dg2: [SKIP][290] ([i915#1072] / [i915#9673] / [i915#9732]) -> [SKIP][291] ([i915#1072] / [i915#9732]) +14 other tests skip
[290]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-dg2-11/igt@kms_psr@psr-cursor-render.html
[291]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-2/igt@kms_psr@psr-cursor-render.html
* igt@kms_rotation_crc@primary-rotation-270:
- shard-dg2: [SKIP][292] ([i915#11131]) -> [SKIP][293] ([i915#11131] / [i915#4235]) +1 other test skip
[292]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-dg2-6/igt@kms_rotation_crc@primary-rotation-270.html
[293]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-11/igt@kms_rotation_crc@primary-rotation-270.html
* igt@kms_rotation_crc@sprite-rotation-90:
- shard-dg2: [SKIP][294] ([i915#11131] / [i915#4235]) -> [SKIP][295] ([i915#11131])
[294]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15327/shard-dg2-11/igt@kms_rotation_crc@sprite-rotation-90.html
[295]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/shard-dg2-6/igt@kms_rotation_crc@sprite-rotation-90.html
[i915#10131]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10131
[i915#10166]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10166
[i915#10226]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10226
[i915#10307]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10307
[i915#10433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10433
[i915#10434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10434
[i915#10656]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10656
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#10887]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10887
[i915#11078]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11078
[i915#11131]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11131
[i915#11453]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11453
[i915#11520]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11520
[i915#11614]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11614
[i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
[i915#11713]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11713
[i915#11808]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11808
[i915#11859]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11859
[i915#11900]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11900
[i915#11920]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11920
[i915#11965]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11965
[i915#12027]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12027
[i915#12033]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12033
[i915#12042]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12042
[i915#1769]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1839
[i915#2122]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2346
[i915#2433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2433
[i915#2437]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2527
[i915#2587]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2672
[i915#280]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3582]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3582
[i915#3591]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3638
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#3804]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3804
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#3936]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3936
[i915#4070]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4087]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4087
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4213
[i915#4235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4235
[i915#4270]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4281
[i915#4525]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4816
[i915#4852]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4854
[i915#4860]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4881
[i915#4884]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4884
[i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
[i915#5235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5289
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#5439]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5439
[i915#5493]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5493
[i915#5784]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5784
[i915#5956]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5956
[i915#6095]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6095
[i915#6334]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6334
[i915#658]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6590
[i915#6621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6621
[i915#6880]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6880
[i915#6944]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6944
[i915#7118]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7118
[i915#7213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7213
[i915#7387]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7387
[i915#7697]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7697
[i915#7742]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/79
[i915#7975]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7975
[i915#8213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8228
[i915#8292]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8292
[i915#8381]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8381
[i915#8399]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8399
[i915#8411]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8411
[i915#8414]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8414
[i915#8428]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8428
[i915#8516]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8516
[i915#8555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8555
[i915#8708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8708
[i915#8709]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8709
[i915#8814]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8814
[i915#9053]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9053
[i915#9100]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9100
[i915#9196]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9196
[i915#9293]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9293
[i915#9323]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9323
[i915#9340]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9340
[i915#9412]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9412
[i915#9423]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9423
[i915#9424]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9424
[i915#9519]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9519
[i915#9531]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9531
[i915#9673]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9673
[i915#9683]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9683
[i915#9685]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9685
[i915#9688]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9688
[i915#9723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9723
[i915#9728]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9728
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
[i915#9766]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9766
[i915#9781]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9781
[i915#9820]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9820
[i915#9833]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9833
[i915#9906]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9906
[i915#9917]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9917
[i915#9934]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9934
Build changes
-------------
* Linux: CI_DRM_15327 -> Patchwork_137978v1
CI-20190529: 20190529
CI_DRM_15327: c5380bcbaed118a5fc23dbb445b3c599a45b0ccb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7999: a73311079a5d8ac99eb25336a8369a2c3c6b519b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_137978v1: c5380bcbaed118a5fc23dbb445b3c599a45b0ccb @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v1/index.html
[-- Attachment #2: Type: text/html, Size: 99870 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/4] drm/i915/display: Fix out-of-bounds access in pipe-related tracepoints
2024-08-29 22:00 ` [PATCH 1/4] drm/i915/display: Fix out-of-bounds access in pipe-related tracepoints Gustavo Sousa
@ 2024-09-18 22:13 ` Matt Roper
0 siblings, 0 replies; 14+ messages in thread
From: Matt Roper @ 2024-09-18 22:13 UTC (permalink / raw)
To: Gustavo Sousa; +Cc: intel-gfx
On Thu, Aug 29, 2024 at 07:00:44PM -0300, Gustavo Sousa wrote:
> Some display trace events use array members to store frame and scanline
> counts for each pipe. However, those arrays are declared with 3 as the
> hardcoded size, which cause out-of-bounds access when the trace event is
> enabled on a platform that contains pipe D.
>
> For example, when looking at the last 10 intel_pipe_enable events after
> running IGT's testdisplay, we see the following on a MTL machine that
> has pipe D available:
>
> $ trace-cmd report -R -F intel_pipe_enable \
> > | tail \
> > | sed 's,\(frame=.*\) \(scanline=.*\),\n\t \1\n\t\2,'
> testdisplay-6715 [002] 17591.063491: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[83, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
> testdisplay-6715 [003] 17591.264742: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[89, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
> testdisplay-6715 [003] 17591.464541: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[8f, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
> testdisplay-6715 [001] 17591.695827: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[95, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
> testdisplay-6715 [000] 17591.915841: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[9a, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
> testdisplay-6715 [000] 17592.127114: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[a0, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
> testdisplay-6715 [002] 17592.358351: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[a8, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
> testdisplay-6715 [002] 17592.580467: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[ae, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
> testdisplay-6715 [000] 17592.950946: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[b8, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
> testdisplay-6715 [004] 17593.079597: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[bf, 01, 00, 00, 01, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[00, 00, 00, 00, 3a, 04, 00, 00, 00, 00, 00, 00] pipe=1
>
> Which shows zeros for pipe A's scanline counts. That happens because
> pipe D's frame counts are overwriting them.
>
> Let's fix that by making the arrays bring able to store info for all
> possible pipes.
>
> With the fix, we get the following:
>
> $ trace-cmd report -R -F intel_pipe_enable \
> > | tail \
> > | sed 's,\(frame=.*\) \(scanline=.*\),\n\t \1\n\t\2,'
> testdisplay-7040 [003] 18067.489565: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[8c, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[8e, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
> testdisplay-7040 [002] 18067.699312: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[92, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[58, 02, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
> testdisplay-7040 [002] 18067.908868: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[98, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[58, 02, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
> testdisplay-7040 [002] 18068.122802: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[9d, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[58, 02, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
> testdisplay-7040 [003] 18068.331019: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[a2, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[e0, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
> testdisplay-7040 [002] 18068.529067: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[a8, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[e0, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
> testdisplay-7040 [003] 18068.742033: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[ae, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[e0, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
> testdisplay-7040 [002] 18068.956229: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[b3, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[1f, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
> testdisplay-7040 [002] 18069.295322: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[bb, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[7b, 08, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=0
> testdisplay-7040 [010] 18069.423527: intel_pipe_enable: dev=0000:00:02.0
> frame=ARRAY[c2, 01, 00, 00, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00]
> scanline=ARRAY[d0, 05, 00, 00, 3a, 04, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe=1
>
> Which makes more sense now.
>
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
I guess nobody has really needed to use these tracepoints much for
debugging since TGL added the 4th pipe.
Matt
> ---
> drivers/gpu/drm/i915/display/intel_display_trace.h | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_trace.h b/drivers/gpu/drm/i915/display/intel_display_trace.h
> index c734ef1fba3c..8a3185862089 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_trace.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_trace.h
> @@ -15,6 +15,7 @@
>
> #include "i915_drv.h"
> #include "intel_crtc.h"
> +#include "intel_display_limits.h"
> #include "intel_display_types.h"
> #include "intel_vblank.h"
>
> @@ -27,8 +28,8 @@ TRACE_EVENT(intel_pipe_enable,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(crtc))
> - __array(u32, frame, 3)
> - __array(u32, scanline, 3)
> + __array(u32, frame, I915_MAX_PIPES)
> + __array(u32, scanline, I915_MAX_PIPES)
> __field(enum pipe, pipe)
> ),
> TP_fast_assign(
> @@ -55,8 +56,8 @@ TRACE_EVENT(intel_pipe_disable,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(crtc))
> - __array(u32, frame, 3)
> - __array(u32, scanline, 3)
> + __array(u32, frame, I915_MAX_PIPES)
> + __array(u32, scanline, I915_MAX_PIPES)
> __field(enum pipe, pipe)
> ),
>
> @@ -184,8 +185,8 @@ TRACE_EVENT(intel_memory_cxsr,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_i915(dev_priv))
> - __array(u32, frame, 3)
> - __array(u32, scanline, 3)
> + __array(u32, frame, I915_MAX_PIPES)
> + __array(u32, scanline, I915_MAX_PIPES)
> __field(bool, old)
> __field(bool, new)
> ),
> --
> 2.46.0
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/4] drm/i915/display: Store pipe name in trace events
2024-08-29 22:00 ` [PATCH 2/4] drm/i915/display: Store pipe name in trace events Gustavo Sousa
@ 2024-09-18 22:37 ` Matt Roper
2024-09-23 14:30 ` Gustavo Sousa
0 siblings, 1 reply; 14+ messages in thread
From: Matt Roper @ 2024-09-18 22:37 UTC (permalink / raw)
To: Gustavo Sousa; +Cc: intel-gfx
On Thu, Aug 29, 2024 at 07:00:45PM -0300, Gustavo Sousa wrote:
> The first part[1] of the LWN series on using TRACE_EVENT() mentions
> about TP_printk():
>
> "Do not create new tracepoint-specific helpers, because that will
> confuse user-space tools that know about the TRACE_EVENT() helper
> macros but will not know how to handle ones created for individual
> tracepoints."
>
> It seems this is what we ended up doing when using pipe_name() in
> TP_printk().
>
> For example, the format for the intel_pipe_update_start event is as
> follows:
>
> # cat /sys/kernel/debug/tracing/events/i915/intel_pipe_update_start/format
> name: intel_pipe_update_start
> ID: 1136
> format:
> field:unsigned short common_type; offset:0; size:2; signed:0;
> field:unsigned char common_flags; offset:2; size:1; signed:0;
> field:unsigned char common_preempt_count; offset:3; size:1; signed:0;
> field:int common_pid; offset:4; size:4; signed:1;
>
> field:__data_loc char[] dev; offset:8; size:4; signed:0;
> field:enum pipe pipe; offset:12; size:4; signed:1;
> field:u32 frame; offset:16; size:4; signed:0;
> field:u32 scanline; offset:20; size:4; signed:0;
> field:u32 min; offset:24; size:4; signed:0;
> field:u32 max; offset:28; size:4; signed:0;
>
> print fmt: "dev %s, pipe %c, frame=%u, scanline=%u, min=%u, max=%u", __get_str(dev), ((REC->pipe) + 'A'), REC->frame, REC->scanline, REC->min, REC->max
>
> The call to pipe_name(__entry->pipe) is expanted to ((REC->pipe) + 'A')
> and that's how the format is saved.
>
> Even though the output from /sys/kernel/debug/tracing/trace will look
> correct (because it is generated in the kernel), we will see corrupted
> lines when using a tool like trace-cmd to view the data.
>
> While the output looks correct when looking at
> /sys/kernel/debug/tracing/trace, we see corrupted lines when viewing the
> trace data with "trace-cmd report":
>
> $ trace-cmd report \
> > | sed -n 's/.*dev 0000:00:02\.0, \(pipe .\).*/\1/p' \
> > | cat -v | uniq -c
> 34 pipe ^A
>
> , where ^A is a non-printable character.
>
> As a fix, let's store the pipe name directly in the event. The fix was
> done by applying the following sed script:
>
> s/__field\s*(\s*enum\s\+pipe\s*,\s*pipe\s*)/__field(char, pipe_name)/
> s/__entry\s*->\s*pipe\s*=\s*\([^;]\+\);/__entry->pipe_name = pipe_name(\1);/
> s/pipe_name\s*(\s*__entry\s*->\s*pipe\s*)/__entry->pipe_name/
>
> After these changes, using the same example, we have the following:
>
> $ trace-cmd report \
> > | sed -n 's/.*dev 0000:00:02\.0, \(pipe .\).*/\1/p' \
> > | cat -v | sort | uniq -c
> 396 pipe A
> 34 pipe B
>
> [1] https://lwn.net/Articles/379903/
>
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
Interesting; I hadn't ever realized how the parsing in trace-cmd worked.
Are some of the other macros/function helpers like DRM_RECT_ARG that we
use in our TP_printks similarly problematic?
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Matt
> ---
> .../drm/i915/display/intel_display_trace.h | 126 +++++++++---------
> 1 file changed, 63 insertions(+), 63 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_trace.h b/drivers/gpu/drm/i915/display/intel_display_trace.h
> index 8a3185862089..ec2ab6fb743d 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_trace.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_trace.h
> @@ -30,7 +30,7 @@ TRACE_EVENT(intel_pipe_enable,
> __string(dev, __dev_name_kms(crtc))
> __array(u32, frame, I915_MAX_PIPES)
> __array(u32, scanline, I915_MAX_PIPES)
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> ),
> TP_fast_assign(
> struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
> @@ -40,11 +40,11 @@ TRACE_EVENT(intel_pipe_enable,
> __entry->frame[it__->pipe] = intel_crtc_get_vblank_counter(it__);
> __entry->scanline[it__->pipe] = intel_get_crtc_scanline(it__);
> }
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> ),
>
> TP_printk("dev %s, pipe %c enable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
> - __get_str(dev), pipe_name(__entry->pipe),
> + __get_str(dev), __entry->pipe_name,
> __entry->frame[PIPE_A], __entry->scanline[PIPE_A],
> __entry->frame[PIPE_B], __entry->scanline[PIPE_B],
> __entry->frame[PIPE_C], __entry->scanline[PIPE_C])
> @@ -58,7 +58,7 @@ TRACE_EVENT(intel_pipe_disable,
> __string(dev, __dev_name_kms(crtc))
> __array(u32, frame, I915_MAX_PIPES)
> __array(u32, scanline, I915_MAX_PIPES)
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> ),
>
> TP_fast_assign(
> @@ -69,11 +69,11 @@ TRACE_EVENT(intel_pipe_disable,
> __entry->frame[it__->pipe] = intel_crtc_get_vblank_counter(it__);
> __entry->scanline[it__->pipe] = intel_get_crtc_scanline(it__);
> }
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> ),
>
> TP_printk("dev %s, pipe %c disable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
> - __get_str(dev), pipe_name(__entry->pipe),
> + __get_str(dev), __entry->pipe_name,
> __entry->frame[PIPE_A], __entry->scanline[PIPE_A],
> __entry->frame[PIPE_B], __entry->scanline[PIPE_B],
> __entry->frame[PIPE_C], __entry->scanline[PIPE_C])
> @@ -85,20 +85,20 @@ TRACE_EVENT(intel_crtc_flip_done,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(crtc))
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> ),
>
> TP_fast_assign(
> __assign_str(dev);
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> __entry->frame = intel_crtc_get_vblank_counter(crtc);
> __entry->scanline = intel_get_crtc_scanline(crtc);
> ),
>
> TP_printk("dev %s, pipe %c, frame=%u, scanline=%u",
> - __get_str(dev), pipe_name(__entry->pipe),
> + __get_str(dev), __entry->pipe_name,
> __entry->frame, __entry->scanline)
> );
>
> @@ -108,7 +108,7 @@ TRACE_EVENT(intel_pipe_crc,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(crtc))
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> __array(u32, crcs, 5)
> @@ -116,14 +116,14 @@ TRACE_EVENT(intel_pipe_crc,
>
> TP_fast_assign(
> __assign_str(dev);
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> __entry->frame = intel_crtc_get_vblank_counter(crtc);
> __entry->scanline = intel_get_crtc_scanline(crtc);
> memcpy(__entry->crcs, crcs, sizeof(__entry->crcs));
> ),
>
> TP_printk("dev %s, pipe %c, frame=%u, scanline=%u crc=%08x %08x %08x %08x %08x",
> - __get_str(dev), pipe_name(__entry->pipe),
> + __get_str(dev), __entry->pipe_name,
> __entry->frame, __entry->scanline,
> __entry->crcs[0], __entry->crcs[1],
> __entry->crcs[2], __entry->crcs[3],
> @@ -136,7 +136,7 @@ TRACE_EVENT(intel_cpu_fifo_underrun,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_i915(dev_priv))
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> ),
> @@ -144,13 +144,13 @@ TRACE_EVENT(intel_cpu_fifo_underrun,
> TP_fast_assign(
> struct intel_crtc *crtc = intel_crtc_for_pipe(dev_priv, pipe);
> __assign_str(dev);
> - __entry->pipe = pipe;
> + __entry->pipe_name = pipe_name(pipe);
> __entry->frame = intel_crtc_get_vblank_counter(crtc);
> __entry->scanline = intel_get_crtc_scanline(crtc);
> ),
>
> TP_printk("dev %s, pipe %c, frame=%u, scanline=%u",
> - __get_str(dev), pipe_name(__entry->pipe),
> + __get_str(dev), __entry->pipe_name,
> __entry->frame, __entry->scanline)
> );
>
> @@ -160,7 +160,7 @@ TRACE_EVENT(intel_pch_fifo_underrun,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_i915(dev_priv))
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> ),
> @@ -169,13 +169,13 @@ TRACE_EVENT(intel_pch_fifo_underrun,
> enum pipe pipe = pch_transcoder;
> struct intel_crtc *crtc = intel_crtc_for_pipe(dev_priv, pipe);
> __assign_str(dev);
> - __entry->pipe = pipe;
> + __entry->pipe_name = pipe_name(pipe);
> __entry->frame = intel_crtc_get_vblank_counter(crtc);
> __entry->scanline = intel_get_crtc_scanline(crtc);
> ),
>
> TP_printk("dev %s, pch transcoder %c, frame=%u, scanline=%u",
> - __get_str(dev), pipe_name(__entry->pipe),
> + __get_str(dev), __entry->pipe_name,
> __entry->frame, __entry->scanline)
> );
>
> @@ -215,7 +215,7 @@ TRACE_EVENT(g4x_wm,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(crtc))
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> __field(u16, primary)
> @@ -234,7 +234,7 @@ TRACE_EVENT(g4x_wm,
>
> TP_fast_assign(
> __assign_str(dev);
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> __entry->frame = intel_crtc_get_vblank_counter(crtc);
> __entry->scanline = intel_get_crtc_scanline(crtc);
> __entry->primary = wm->pipe[crtc->pipe].plane[PLANE_PRIMARY];
> @@ -252,7 +252,7 @@ TRACE_EVENT(g4x_wm,
> ),
>
> TP_printk("dev %s, pipe %c, frame=%u, scanline=%u, wm %d/%d/%d, sr %s/%d/%d/%d, hpll %s/%d/%d/%d, fbc %s",
> - __get_str(dev), pipe_name(__entry->pipe),
> + __get_str(dev), __entry->pipe_name,
> __entry->frame, __entry->scanline,
> __entry->primary, __entry->sprite, __entry->cursor,
> str_yes_no(__entry->cxsr), __entry->sr_plane, __entry->sr_cursor, __entry->sr_fbc,
> @@ -266,7 +266,7 @@ TRACE_EVENT(vlv_wm,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(crtc))
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> __field(u32, level)
> @@ -281,7 +281,7 @@ TRACE_EVENT(vlv_wm,
>
> TP_fast_assign(
> __assign_str(dev);
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> __entry->frame = intel_crtc_get_vblank_counter(crtc);
> __entry->scanline = intel_get_crtc_scanline(crtc);
> __entry->level = wm->level;
> @@ -295,7 +295,7 @@ TRACE_EVENT(vlv_wm,
> ),
>
> TP_printk("dev %s, pipe %c, frame=%u, scanline=%u, level=%d, cxsr=%d, wm %d/%d/%d/%d, sr %d/%d",
> - __get_str(dev), pipe_name(__entry->pipe),
> + __get_str(dev), __entry->pipe_name,
> __entry->frame, __entry->scanline,
> __entry->level, __entry->cxsr,
> __entry->primary, __entry->sprite0, __entry->sprite1, __entry->cursor,
> @@ -308,7 +308,7 @@ TRACE_EVENT(vlv_fifo_size,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(crtc))
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> __field(u32, sprite0_start)
> @@ -318,7 +318,7 @@ TRACE_EVENT(vlv_fifo_size,
>
> TP_fast_assign(
> __assign_str(dev);
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> __entry->frame = intel_crtc_get_vblank_counter(crtc);
> __entry->scanline = intel_get_crtc_scanline(crtc);
> __entry->sprite0_start = sprite0_start;
> @@ -327,7 +327,7 @@ TRACE_EVENT(vlv_fifo_size,
> ),
>
> TP_printk("dev %s, pipe %c, frame=%u, scanline=%u, %d/%d/%d",
> - __get_str(dev), pipe_name(__entry->pipe),
> + __get_str(dev), __entry->pipe_name,
> __entry->frame, __entry->scanline,
> __entry->sprite0_start, __entry->sprite1_start, __entry->fifo_size)
> );
> @@ -338,7 +338,7 @@ TRACE_EVENT(intel_plane_async_flip,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(plane))
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> __field(bool, async_flip)
> @@ -348,14 +348,14 @@ TRACE_EVENT(intel_plane_async_flip,
> TP_fast_assign(
> __assign_str(dev);
> __assign_str(name);
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> __entry->frame = intel_crtc_get_vblank_counter(crtc);
> __entry->scanline = intel_get_crtc_scanline(crtc);
> __entry->async_flip = async_flip;
> ),
>
> TP_printk("dev %s, pipe %c, plane %s, frame=%u, scanline=%u, async_flip=%s",
> - __get_str(dev), pipe_name(__entry->pipe), __get_str(name),
> + __get_str(dev), __entry->pipe_name, __get_str(name),
> __entry->frame, __entry->scanline, str_yes_no(__entry->async_flip))
> );
>
> @@ -365,7 +365,7 @@ TRACE_EVENT(intel_plane_update_noarm,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(plane))
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> __array(int, src, 4)
> @@ -376,7 +376,7 @@ TRACE_EVENT(intel_plane_update_noarm,
> TP_fast_assign(
> __assign_str(dev);
> __assign_str(name);
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> __entry->frame = intel_crtc_get_vblank_counter(crtc);
> __entry->scanline = intel_get_crtc_scanline(crtc);
> memcpy(__entry->src, &plane->base.state->src, sizeof(__entry->src));
> @@ -384,7 +384,7 @@ TRACE_EVENT(intel_plane_update_noarm,
> ),
>
> TP_printk("dev %s, pipe %c, plane %s, frame=%u, scanline=%u, " DRM_RECT_FP_FMT " -> " DRM_RECT_FMT,
> - __get_str(dev), pipe_name(__entry->pipe), __get_str(name),
> + __get_str(dev), __entry->pipe_name, __get_str(name),
> __entry->frame, __entry->scanline,
> DRM_RECT_FP_ARG((const struct drm_rect *)__entry->src),
> DRM_RECT_ARG((const struct drm_rect *)__entry->dst))
> @@ -396,7 +396,7 @@ TRACE_EVENT(intel_plane_update_arm,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(plane))
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> __array(int, src, 4)
> @@ -407,7 +407,7 @@ TRACE_EVENT(intel_plane_update_arm,
> TP_fast_assign(
> __assign_str(dev);
> __assign_str(name);
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> __entry->frame = intel_crtc_get_vblank_counter(crtc);
> __entry->scanline = intel_get_crtc_scanline(crtc);
> memcpy(__entry->src, &plane->base.state->src, sizeof(__entry->src));
> @@ -415,7 +415,7 @@ TRACE_EVENT(intel_plane_update_arm,
> ),
>
> TP_printk("dev %s, pipe %c, plane %s, frame=%u, scanline=%u, " DRM_RECT_FP_FMT " -> " DRM_RECT_FMT,
> - __get_str(dev), pipe_name(__entry->pipe), __get_str(name),
> + __get_str(dev), __entry->pipe_name, __get_str(name),
> __entry->frame, __entry->scanline,
> DRM_RECT_FP_ARG((const struct drm_rect *)__entry->src),
> DRM_RECT_ARG((const struct drm_rect *)__entry->dst))
> @@ -427,7 +427,7 @@ TRACE_EVENT(intel_plane_disable_arm,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(plane))
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> __string(name, plane->base.name)
> @@ -436,13 +436,13 @@ TRACE_EVENT(intel_plane_disable_arm,
> TP_fast_assign(
> __assign_str(dev);
> __assign_str(name);
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> __entry->frame = intel_crtc_get_vblank_counter(crtc);
> __entry->scanline = intel_get_crtc_scanline(crtc);
> ),
>
> TP_printk("dev %s, pipe %c, plane %s, frame=%u, scanline=%u",
> - __get_str(dev), pipe_name(__entry->pipe), __get_str(name),
> + __get_str(dev), __entry->pipe_name, __get_str(name),
> __entry->frame, __entry->scanline)
> );
>
> @@ -453,7 +453,7 @@ TRACE_EVENT(intel_fbc_activate,
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(plane))
> __string(name, plane->base.name)
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> ),
> @@ -463,13 +463,13 @@ TRACE_EVENT(intel_fbc_activate,
> plane->pipe);
> __assign_str(dev);
> __assign_str(name);
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> __entry->frame = intel_crtc_get_vblank_counter(crtc);
> __entry->scanline = intel_get_crtc_scanline(crtc);
> ),
>
> TP_printk("dev %s, pipe %c, plane %s, frame=%u, scanline=%u",
> - __get_str(dev), pipe_name(__entry->pipe), __get_str(name),
> + __get_str(dev), __entry->pipe_name, __get_str(name),
> __entry->frame, __entry->scanline)
> );
>
> @@ -480,7 +480,7 @@ TRACE_EVENT(intel_fbc_deactivate,
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(plane))
> __string(name, plane->base.name)
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> ),
> @@ -490,13 +490,13 @@ TRACE_EVENT(intel_fbc_deactivate,
> plane->pipe);
> __assign_str(dev);
> __assign_str(name);
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> __entry->frame = intel_crtc_get_vblank_counter(crtc);
> __entry->scanline = intel_get_crtc_scanline(crtc);
> ),
>
> TP_printk("dev %s, pipe %c, plane %s, frame=%u, scanline=%u",
> - __get_str(dev), pipe_name(__entry->pipe), __get_str(name),
> + __get_str(dev), __entry->pipe_name, __get_str(name),
> __entry->frame, __entry->scanline)
> );
>
> @@ -507,7 +507,7 @@ TRACE_EVENT(intel_fbc_nuke,
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(plane))
> __string(name, plane->base.name)
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> ),
> @@ -517,13 +517,13 @@ TRACE_EVENT(intel_fbc_nuke,
> plane->pipe);
> __assign_str(dev);
> __assign_str(name);
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> __entry->frame = intel_crtc_get_vblank_counter(crtc);
> __entry->scanline = intel_get_crtc_scanline(crtc);
> ),
>
> TP_printk("dev %s, pipe %c, plane %s, frame=%u, scanline=%u",
> - __get_str(dev), pipe_name(__entry->pipe), __get_str(name),
> + __get_str(dev), __entry->pipe_name, __get_str(name),
> __entry->frame, __entry->scanline)
> );
>
> @@ -533,20 +533,20 @@ TRACE_EVENT(intel_crtc_vblank_work_start,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(crtc))
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> ),
>
> TP_fast_assign(
> __assign_str(dev);
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> __entry->frame = intel_crtc_get_vblank_counter(crtc);
> __entry->scanline = intel_get_crtc_scanline(crtc);
> ),
>
> TP_printk("dev %s, pipe %c, frame=%u, scanline=%u",
> - __get_str(dev), pipe_name(__entry->pipe),
> + __get_str(dev), __entry->pipe_name,
> __entry->frame, __entry->scanline)
> );
>
> @@ -556,20 +556,20 @@ TRACE_EVENT(intel_crtc_vblank_work_end,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(crtc))
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> ),
>
> TP_fast_assign(
> __assign_str(dev);
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> __entry->frame = intel_crtc_get_vblank_counter(crtc);
> __entry->scanline = intel_get_crtc_scanline(crtc);
> ),
>
> TP_printk("dev %s, pipe %c, frame=%u, scanline=%u",
> - __get_str(dev), pipe_name(__entry->pipe),
> + __get_str(dev), __entry->pipe_name,
> __entry->frame, __entry->scanline)
> );
>
> @@ -579,7 +579,7 @@ TRACE_EVENT(intel_pipe_update_start,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(crtc))
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> __field(u32, min)
> @@ -588,7 +588,7 @@ TRACE_EVENT(intel_pipe_update_start,
>
> TP_fast_assign(
> __assign_str(dev);
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> __entry->frame = intel_crtc_get_vblank_counter(crtc);
> __entry->scanline = intel_get_crtc_scanline(crtc);
> __entry->min = crtc->debug.min_vbl;
> @@ -596,7 +596,7 @@ TRACE_EVENT(intel_pipe_update_start,
> ),
>
> TP_printk("dev %s, pipe %c, frame=%u, scanline=%u, min=%u, max=%u",
> - __get_str(dev), pipe_name(__entry->pipe),
> + __get_str(dev), __entry->pipe_name,
> __entry->frame, __entry->scanline,
> __entry->min, __entry->max)
> );
> @@ -607,7 +607,7 @@ TRACE_EVENT(intel_pipe_update_vblank_evaded,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(crtc))
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> __field(u32, min)
> @@ -616,7 +616,7 @@ TRACE_EVENT(intel_pipe_update_vblank_evaded,
>
> TP_fast_assign(
> __assign_str(dev);
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> __entry->frame = crtc->debug.start_vbl_count;
> __entry->scanline = crtc->debug.scanline_start;
> __entry->min = crtc->debug.min_vbl;
> @@ -624,7 +624,7 @@ TRACE_EVENT(intel_pipe_update_vblank_evaded,
> ),
>
> TP_printk("dev %s, pipe %c, frame=%u, scanline=%u, min=%u, max=%u",
> - __get_str(dev), pipe_name(__entry->pipe),
> + __get_str(dev), __entry->pipe_name,
> __entry->frame, __entry->scanline,
> __entry->min, __entry->max)
> );
> @@ -635,20 +635,20 @@ TRACE_EVENT(intel_pipe_update_end,
>
> TP_STRUCT__entry(
> __string(dev, __dev_name_kms(crtc))
> - __field(enum pipe, pipe)
> + __field(char, pipe_name)
> __field(u32, frame)
> __field(u32, scanline)
> ),
>
> TP_fast_assign(
> __assign_str(dev);
> - __entry->pipe = crtc->pipe;
> + __entry->pipe_name = pipe_name(crtc->pipe);
> __entry->frame = frame;
> __entry->scanline = scanline_end;
> ),
>
> TP_printk("dev %s, pipe %c, frame=%u, scanline=%u",
> - __get_str(dev), pipe_name(__entry->pipe),
> + __get_str(dev), __entry->pipe_name,
> __entry->frame, __entry->scanline)
> );
>
> --
> 2.46.0
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/4] drm/i915/display: Do not use ids from enum pipe in TP_printk()
2024-08-29 22:00 ` [PATCH 3/4] drm/i915/display: Do not use ids from enum pipe in TP_printk() Gustavo Sousa
@ 2024-09-18 22:41 ` Matt Roper
0 siblings, 0 replies; 14+ messages in thread
From: Matt Roper @ 2024-09-18 22:41 UTC (permalink / raw)
To: Gustavo Sousa; +Cc: intel-gfx
On Thu, Aug 29, 2024 at 07:00:46PM -0300, Gustavo Sousa wrote:
> Because much of kernel tracepoints is implemented at the C preprocessor
> level, C identifiers used in TP_printk() are saved verbatim in the event
> format, even when they represent compile-time constant values.
>
> As an example, we can look at the format for the intel_pipe_enable
> event:
>
> # cat /sys/kernel/debug/tracing/events/i915/intel_pipe_enable/format | grep '^print fmt'
> print fmt: "dev %s, pipe %c enable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u", __get_str(dev), REC->pipe_name, REC->frame[PIPE_A], REC->scanline[PIPE_A], REC->frame[PIPE_B], REC->scanline[PIPE_B], REC->frame[PIPE_C], REC->scanline[PIPE_C]
>
> We see that PIPE_A, PIPE_B and PIPE_C are pasted directly in the format.
> Because tools that interact with kernel tracepoints don't know about
> those ids, they'll endup failing to parse the format or produce
> corrupted output.
>
> For example, we can see below that trace-cmd repeats PIPE_A's
> frame/scanline counts for all pipes (probably because it evaluates
> unknown ids as zero):
>
> $ trace-cmd report -F intel_pipe_enable | tail -n5
> testdisplay-8616 [000] 22048.276758: intel_pipe_enable: dev 0000:00:02.0, pipe A enable, pipe A: frame=861, scanline=480, pipe B: frame=861, scanline=480, pipe C: frame=861, scanline=480
> testdisplay-8616 [001] 22048.490287: intel_pipe_enable: dev 0000:00:02.0, pipe A enable, pipe A: frame=867, scanline=480, pipe B: frame=867, scanline=480, pipe C: frame=867, scanline=480
> testdisplay-8616 [003] 22048.700181: intel_pipe_enable: dev 0000:00:02.0, pipe A enable, pipe A: frame=872, scanline=400, pipe B: frame=872, scanline=400, pipe C: frame=872, scanline=400
> testdisplay-8616 [002] 22049.054220: intel_pipe_enable: dev 0000:00:02.0, pipe A enable, pipe A: frame=881, scanline=2170, pipe B: frame=881, scanline=2170, pipe C: frame=881, scanline=2170
> testdisplay-8616 [002] 22049.166851: intel_pipe_enable: dev 0000:00:02.0, pipe B enable, pipe A: frame=887, scanline=1632, pipe B: frame=887, scanline=1632, pipe C: frame=887, scanline=1632
>
> , while in fact we have different values for each pipe, which can be
> confirmed with the raw view of the events:
>
> $ trace-cmd report -R -F intel_pipe_enable | tail -n5
> testdisplay-8616 [000] 22048.276758: intel_pipe_enable: dev=0000:00:02.0 frame=ARRAY[5d, 03, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] scanline=ARRAY[e0, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe_name=A
> testdisplay-8616 [001] 22048.490287: intel_pipe_enable: dev=0000:00:02.0 frame=ARRAY[63, 03, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] scanline=ARRAY[e0, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe_name=A
> testdisplay-8616 [003] 22048.700181: intel_pipe_enable: dev=0000:00:02.0 frame=ARRAY[68, 03, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] scanline=ARRAY[90, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe_name=A
> testdisplay-8616 [002] 22049.054220: intel_pipe_enable: dev=0000:00:02.0 frame=ARRAY[71, 03, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] scanline=ARRAY[7a, 08, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe_name=A
> testdisplay-8616 [002] 22049.166851: intel_pipe_enable: dev=0000:00:02.0 frame=ARRAY[77, 03, 00, 00, 01, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] scanline=ARRAY[60, 06, 00, 00, 39, 04, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00] pipe_name=B
>
> To fix that, we need a fix that looks more like a hack: use macros that
> result to integer constants instead of enum pipe values. This fixes the
> issue, but could break if, for whatever unlikely reason, the underlying
> values in the enum are changed.
I guess if we're paranoid about it we could put a
BUILD_BUG_ON(_TRACE_PIPE_A != PIPE_A)
somewhere to catch that unlikely case?
>
> In the future, we should find a better way to handle this, but for now,
> the hack took care of the job:
>
> $ trace-cmd report -F intel_pipe_enable | tail -n5
> testdisplay-9224 [003] 24324.455375: intel_pipe_enable: dev 0000:00:02.0, pipe A enable, pipe A: frame=1103, scanline=480, pipe B: frame=0, scanline=0, pipe C: frame=0, scanline=0
> testdisplay-9224 [002] 24324.669845: intel_pipe_enable: dev 0000:00:02.0, pipe A enable, pipe A: frame=1109, scanline=480, pipe B: frame=0, scanline=0, pipe C: frame=0, scanline=0
> testdisplay-9224 [003] 24324.900105: intel_pipe_enable: dev 0000:00:02.0, pipe A enable, pipe A: frame=1115, scanline=31, pipe B: frame=0, scanline=0, pipe C: frame=0, scanline=0
> testdisplay-9224 [002] 24325.256408: intel_pipe_enable: dev 0000:00:02.0, pipe A enable, pipe A: frame=1124, scanline=2171, pipe B: frame=0, scanline=0, pipe C: frame=0, scanline=0
> testdisplay-9224 [003] 24325.380789: intel_pipe_enable: dev 0000:00:02.0, pipe B enable, pipe A: frame=1131, scanline=979, pipe B: frame=1, scanline=1082, pipe C: frame=0, scanline=0
>
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> .../drm/i915/display/intel_display_trace.h | 27 ++++++++++++-------
> 1 file changed, 18 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_trace.h b/drivers/gpu/drm/i915/display/intel_display_trace.h
> index ec2ab6fb743d..759b985c84a9 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_trace.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_trace.h
> @@ -22,6 +22,15 @@
> #define __dev_name_i915(i915) dev_name((i915)->drm.dev)
> #define __dev_name_kms(obj) dev_name((obj)->base.dev->dev)
>
> +/*
> + * Using identifiers from enum pipe in TP_printk() will confuse tools that
> + * parse /sys/kernel/debug/tracing/{xe,i915}/<event>/format. So we use CPP
> + * macros instead.
> + */
> +#define _TRACE_PIPE_A 0
> +#define _TRACE_PIPE_B 1
> +#define _TRACE_PIPE_C 2
> +
> TRACE_EVENT(intel_pipe_enable,
> TP_PROTO(struct intel_crtc *crtc),
> TP_ARGS(crtc),
> @@ -45,9 +54,9 @@ TRACE_EVENT(intel_pipe_enable,
>
> TP_printk("dev %s, pipe %c enable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
> __get_str(dev), __entry->pipe_name,
> - __entry->frame[PIPE_A], __entry->scanline[PIPE_A],
> - __entry->frame[PIPE_B], __entry->scanline[PIPE_B],
> - __entry->frame[PIPE_C], __entry->scanline[PIPE_C])
> + __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A],
> + __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B],
> + __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C])
> );
>
> TRACE_EVENT(intel_pipe_disable,
> @@ -74,9 +83,9 @@ TRACE_EVENT(intel_pipe_disable,
>
> TP_printk("dev %s, pipe %c disable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
> __get_str(dev), __entry->pipe_name,
> - __entry->frame[PIPE_A], __entry->scanline[PIPE_A],
> - __entry->frame[PIPE_B], __entry->scanline[PIPE_B],
> - __entry->frame[PIPE_C], __entry->scanline[PIPE_C])
> + __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A],
> + __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B],
> + __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C])
> );
>
> TRACE_EVENT(intel_crtc_flip_done,
> @@ -204,9 +213,9 @@ TRACE_EVENT(intel_memory_cxsr,
>
> TP_printk("dev %s, cxsr %s->%s, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
> __get_str(dev), str_on_off(__entry->old), str_on_off(__entry->new),
> - __entry->frame[PIPE_A], __entry->scanline[PIPE_A],
> - __entry->frame[PIPE_B], __entry->scanline[PIPE_B],
> - __entry->frame[PIPE_C], __entry->scanline[PIPE_C])
> + __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A],
> + __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B],
> + __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C])
> );
>
> TRACE_EVENT(g4x_wm,
> --
> 2.46.0
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 4/4] drm/i915/display: Cover all possible pipes in TP_printk()
2024-08-29 22:00 ` [PATCH 4/4] drm/i915/display: Cover all possible pipes " Gustavo Sousa
@ 2024-09-18 22:49 ` Matt Roper
2024-09-23 16:55 ` Gustavo Sousa
0 siblings, 1 reply; 14+ messages in thread
From: Matt Roper @ 2024-09-18 22:49 UTC (permalink / raw)
To: Gustavo Sousa; +Cc: intel-gfx
On Thu, Aug 29, 2024 at 07:00:47PM -0300, Gustavo Sousa wrote:
> Tracepoints that display frame and scanline counters for all pipes were
> added with commit 1489bba82433 ("drm/i915: Add cxsr toggle tracepoint")
> and commit 0b2599a43ca9 ("drm/i915: Add pipe enable/disable
> tracepoints"). At that time, we only had pipes A, B and C. Now that we
> can also have pipe D, the TP_printk() calls are missing it.
>
> As a quick and dirty fix for that, let's define two common macros to be
> used for the format and values respectively, and also ensure we raise a
> build bug if more pipes are added to enum pipe.
>
> In the future, we should probably have a way of printing information for
> available pipes only.
>
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
I didn't did through the details of the tracepoint system, but I'm
assuming you checked that the underlying structure is zero-allocated so
that anything we don't specifically assign in TP_fast_assign will be 0
rather than uninitialized garbage? E.g., on an ICL platform with only
three pipes the pipe D output is guaranteed to be zero?
Assuming that's the case,
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> .../drm/i915/display/intel_display_trace.h | 43 +++++++++++++------
> 1 file changed, 29 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_trace.h b/drivers/gpu/drm/i915/display/intel_display_trace.h
> index 759b985c84a9..2ce66dffdfa5 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_trace.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_trace.h
> @@ -30,6 +30,29 @@
> #define _TRACE_PIPE_A 0
> #define _TRACE_PIPE_B 1
> #define _TRACE_PIPE_C 2
> +#define _TRACE_PIPE_D 3
> +
> +/*
> + * FIXME: Several TP_printk() calls below display frame and scanline numbers for
> + * all possible pipes (regardless of whether they are available) and that is
> + * done with a constant format string. A better approach would be to generate
> + * that info dynamically based on available pipes, but, while we do not have
> + * that implemented yet, let's assert that the constant format string indeed
> + * covers all possible pipes.
> + */
> +static_assert(I915_MAX_PIPES - 1 == _TRACE_PIPE_D);
> +
> +#define _PIPES_FRAME_AND_SCANLINE_FMT \
> + "pipe A: frame=%u, scanline=%u" \
> + ", pipe B: frame=%u, scanline=%u" \
> + ", pipe C: frame=%u, scanline=%u" \
> + ", pipe D: frame=%u, scanline=%u"
> +
> +#define _PIPES_FRAME_AND_SCANLINE_VALUES \
> + __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A] \
> + , __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B] \
> + , __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C] \
> + , __entry->frame[_TRACE_PIPE_D], __entry->scanline[_TRACE_PIPE_D]
>
> TRACE_EVENT(intel_pipe_enable,
> TP_PROTO(struct intel_crtc *crtc),
> @@ -52,11 +75,8 @@ TRACE_EVENT(intel_pipe_enable,
> __entry->pipe_name = pipe_name(crtc->pipe);
> ),
>
> - TP_printk("dev %s, pipe %c enable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
> - __get_str(dev), __entry->pipe_name,
> - __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A],
> - __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B],
> - __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C])
> + TP_printk("dev %s, pipe %c enable, " _PIPES_FRAME_AND_SCANLINE_FMT,
> + __get_str(dev), __entry->pipe_name, _PIPES_FRAME_AND_SCANLINE_VALUES)
> );
>
> TRACE_EVENT(intel_pipe_disable,
> @@ -81,11 +101,8 @@ TRACE_EVENT(intel_pipe_disable,
> __entry->pipe_name = pipe_name(crtc->pipe);
> ),
>
> - TP_printk("dev %s, pipe %c disable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
> - __get_str(dev), __entry->pipe_name,
> - __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A],
> - __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B],
> - __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C])
> + TP_printk("dev %s, pipe %c disable, " _PIPES_FRAME_AND_SCANLINE_FMT,
> + __get_str(dev), __entry->pipe_name, _PIPES_FRAME_AND_SCANLINE_VALUES)
> );
>
> TRACE_EVENT(intel_crtc_flip_done,
> @@ -211,11 +228,9 @@ TRACE_EVENT(intel_memory_cxsr,
> __entry->new = new;
> ),
>
> - TP_printk("dev %s, cxsr %s->%s, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
> + TP_printk("dev %s, cxsr %s->%s, " _PIPES_FRAME_AND_SCANLINE_FMT,
> __get_str(dev), str_on_off(__entry->old), str_on_off(__entry->new),
> - __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A],
> - __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B],
> - __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C])
> + _PIPES_FRAME_AND_SCANLINE_VALUES)
> );
>
> TRACE_EVENT(g4x_wm,
> --
> 2.46.0
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/4] drm/i915/display: Store pipe name in trace events
2024-09-18 22:37 ` Matt Roper
@ 2024-09-23 14:30 ` Gustavo Sousa
0 siblings, 0 replies; 14+ messages in thread
From: Gustavo Sousa @ 2024-09-23 14:30 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
Quoting Matt Roper (2024-09-18 19:37:35-03:00)
>On Thu, Aug 29, 2024 at 07:00:45PM -0300, Gustavo Sousa wrote:
>> The first part[1] of the LWN series on using TRACE_EVENT() mentions
>> about TP_printk():
>>
>> "Do not create new tracepoint-specific helpers, because that will
>> confuse user-space tools that know about the TRACE_EVENT() helper
>> macros but will not know how to handle ones created for individual
>> tracepoints."
>>
>> It seems this is what we ended up doing when using pipe_name() in
>> TP_printk().
>>
>> For example, the format for the intel_pipe_update_start event is as
>> follows:
>>
>> # cat /sys/kernel/debug/tracing/events/i915/intel_pipe_update_start/format
>> name: intel_pipe_update_start
>> ID: 1136
>> format:
>> field:unsigned short common_type; offset:0; size:2; signed:0;
>> field:unsigned char common_flags; offset:2; size:1; signed:0;
>> field:unsigned char common_preempt_count; offset:3; size:1; signed:0;
>> field:int common_pid; offset:4; size:4; signed:1;
>>
>> field:__data_loc char[] dev; offset:8; size:4; signed:0;
>> field:enum pipe pipe; offset:12; size:4; signed:1;
>> field:u32 frame; offset:16; size:4; signed:0;
>> field:u32 scanline; offset:20; size:4; signed:0;
>> field:u32 min; offset:24; size:4; signed:0;
>> field:u32 max; offset:28; size:4; signed:0;
>>
>> print fmt: "dev %s, pipe %c, frame=%u, scanline=%u, min=%u, max=%u", __get_str(dev), ((REC->pipe) + 'A'), REC->frame, REC->scanline, REC->min, REC->max
>>
>> The call to pipe_name(__entry->pipe) is expanted to ((REC->pipe) + 'A')
>> and that's how the format is saved.
>>
>> Even though the output from /sys/kernel/debug/tracing/trace will look
>> correct (because it is generated in the kernel), we will see corrupted
>> lines when using a tool like trace-cmd to view the data.
>>
>> While the output looks correct when looking at
>> /sys/kernel/debug/tracing/trace, we see corrupted lines when viewing the
>> trace data with "trace-cmd report":
>>
>> $ trace-cmd report \
>> > | sed -n 's/.*dev 0000:00:02\.0, \(pipe .\).*/\1/p' \
>> > | cat -v | uniq -c
>> 34 pipe ^A
>>
>> , where ^A is a non-printable character.
>>
>> As a fix, let's store the pipe name directly in the event. The fix was
>> done by applying the following sed script:
>>
>> s/__field\s*(\s*enum\s\+pipe\s*,\s*pipe\s*)/__field(char, pipe_name)/
>> s/__entry\s*->\s*pipe\s*=\s*\([^;]\+\);/__entry->pipe_name = pipe_name(\1);/
>> s/pipe_name\s*(\s*__entry\s*->\s*pipe\s*)/__entry->pipe_name/
>>
>> After these changes, using the same example, we have the following:
>>
>> $ trace-cmd report \
>> > | sed -n 's/.*dev 0000:00:02\.0, \(pipe .\).*/\1/p' \
>> > | cat -v | sort | uniq -c
>> 396 pipe A
>> 34 pipe B
>>
>> [1] https://lwn.net/Articles/379903/
>>
>> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
>
>Interesting; I hadn't ever realized how the parsing in trace-cmd worked.
>Are some of the other macros/function helpers like DRM_RECT_ARG that we
>use in our TP_printks similarly problematic?
Yep. I noticed some of those as well, but I didn't take time to take a
good look at the other cases though (which I wasn't using during a
specific debug). I could try looking at other cases a follow-up task.
>
>Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Thanks!
--
Gustavo Sousa
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 4/4] drm/i915/display: Cover all possible pipes in TP_printk()
2024-09-18 22:49 ` Matt Roper
@ 2024-09-23 16:55 ` Gustavo Sousa
0 siblings, 0 replies; 14+ messages in thread
From: Gustavo Sousa @ 2024-09-23 16:55 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
Quoting Matt Roper (2024-09-18 19:49:27-03:00)
>On Thu, Aug 29, 2024 at 07:00:47PM -0300, Gustavo Sousa wrote:
>> Tracepoints that display frame and scanline counters for all pipes were
>> added with commit 1489bba82433 ("drm/i915: Add cxsr toggle tracepoint")
>> and commit 0b2599a43ca9 ("drm/i915: Add pipe enable/disable
>> tracepoints"). At that time, we only had pipes A, B and C. Now that we
>> can also have pipe D, the TP_printk() calls are missing it.
>>
>> As a quick and dirty fix for that, let's define two common macros to be
>> used for the format and values respectively, and also ensure we raise a
>> build bug if more pipes are added to enum pipe.
>>
>> In the future, we should probably have a way of printing information for
>> available pipes only.
>>
>> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
>
>I didn't did through the details of the tracepoint system, but I'm
>assuming you checked that the underlying structure is zero-allocated so
>that anything we don't specifically assign in TP_fast_assign will be 0
>rather than uninitialized garbage? E.g., on an ICL platform with only
>three pipes the pipe D output is guaranteed to be zero?
That's a good point. I actually missed doing this check. I just verified
this on a MTL machine by making the driver think pipe D is fused off and
I got some garbage in the trace data:
$ trace-cmd report -F 'i915/intel_pipe_\(enable\|disable\)' | grep -o 'pipe D: frame=.*' | sort | uniq -c
57 pipe D: frame=0, scanline=0
1 pipe D: frame=1752461056, scanline=11
1 pipe D: frame=4294936705, scanline=1752461056
1 pipe D: frame=48, scanline=0
1 pipe D: frame=740, scanline=6
2 pipe D: frame=808333872, scanline=0
1 pipe D: frame=976236602, scanline=66670
Then adding a patch to memset() the arrays to zero before the loop fixes
the issue:
$ trace-cmd report -F 'i915/intel_pipe_\(enable\|disable\)' | grep -o 'pipe D: frame=.*' | sort | uniq -c
64 pipe D: frame=0, scanline=0
Since this issue would be observed for fused-off pipes as well and not
only for platforms with less than 4 pipes, I'll send a v2 of this series
with such a patch. Such a patch will come before this one.
Thanks for catching this.
--
Gustavo Sousa
>
>Assuming that's the case,
>
>Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>
>> ---
>> .../drm/i915/display/intel_display_trace.h | 43 +++++++++++++------
>> 1 file changed, 29 insertions(+), 14 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_trace.h b/drivers/gpu/drm/i915/display/intel_display_trace.h
>> index 759b985c84a9..2ce66dffdfa5 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_trace.h
>> +++ b/drivers/gpu/drm/i915/display/intel_display_trace.h
>> @@ -30,6 +30,29 @@
>> #define _TRACE_PIPE_A 0
>> #define _TRACE_PIPE_B 1
>> #define _TRACE_PIPE_C 2
>> +#define _TRACE_PIPE_D 3
>> +
>> +/*
>> + * FIXME: Several TP_printk() calls below display frame and scanline numbers for
>> + * all possible pipes (regardless of whether they are available) and that is
>> + * done with a constant format string. A better approach would be to generate
>> + * that info dynamically based on available pipes, but, while we do not have
>> + * that implemented yet, let's assert that the constant format string indeed
>> + * covers all possible pipes.
>> + */
>> +static_assert(I915_MAX_PIPES - 1 == _TRACE_PIPE_D);
>> +
>> +#define _PIPES_FRAME_AND_SCANLINE_FMT \
>> + "pipe A: frame=%u, scanline=%u" \
>> + ", pipe B: frame=%u, scanline=%u" \
>> + ", pipe C: frame=%u, scanline=%u" \
>> + ", pipe D: frame=%u, scanline=%u"
>> +
>> +#define _PIPES_FRAME_AND_SCANLINE_VALUES \
>> + __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A] \
>> + , __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B] \
>> + , __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C] \
>> + , __entry->frame[_TRACE_PIPE_D], __entry->scanline[_TRACE_PIPE_D]
>>
>> TRACE_EVENT(intel_pipe_enable,
>> TP_PROTO(struct intel_crtc *crtc),
>> @@ -52,11 +75,8 @@ TRACE_EVENT(intel_pipe_enable,
>> __entry->pipe_name = pipe_name(crtc->pipe);
>> ),
>>
>> - TP_printk("dev %s, pipe %c enable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
>> - __get_str(dev), __entry->pipe_name,
>> - __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A],
>> - __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B],
>> - __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C])
>> + TP_printk("dev %s, pipe %c enable, " _PIPES_FRAME_AND_SCANLINE_FMT,
>> + __get_str(dev), __entry->pipe_name, _PIPES_FRAME_AND_SCANLINE_VALUES)
>> );
>>
>> TRACE_EVENT(intel_pipe_disable,
>> @@ -81,11 +101,8 @@ TRACE_EVENT(intel_pipe_disable,
>> __entry->pipe_name = pipe_name(crtc->pipe);
>> ),
>>
>> - TP_printk("dev %s, pipe %c disable, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
>> - __get_str(dev), __entry->pipe_name,
>> - __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A],
>> - __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B],
>> - __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C])
>> + TP_printk("dev %s, pipe %c disable, " _PIPES_FRAME_AND_SCANLINE_FMT,
>> + __get_str(dev), __entry->pipe_name, _PIPES_FRAME_AND_SCANLINE_VALUES)
>> );
>>
>> TRACE_EVENT(intel_crtc_flip_done,
>> @@ -211,11 +228,9 @@ TRACE_EVENT(intel_memory_cxsr,
>> __entry->new = new;
>> ),
>>
>> - TP_printk("dev %s, cxsr %s->%s, pipe A: frame=%u, scanline=%u, pipe B: frame=%u, scanline=%u, pipe C: frame=%u, scanline=%u",
>> + TP_printk("dev %s, cxsr %s->%s, " _PIPES_FRAME_AND_SCANLINE_FMT,
>> __get_str(dev), str_on_off(__entry->old), str_on_off(__entry->new),
>> - __entry->frame[_TRACE_PIPE_A], __entry->scanline[_TRACE_PIPE_A],
>> - __entry->frame[_TRACE_PIPE_B], __entry->scanline[_TRACE_PIPE_B],
>> - __entry->frame[_TRACE_PIPE_C], __entry->scanline[_TRACE_PIPE_C])
>> + _PIPES_FRAME_AND_SCANLINE_VALUES)
>> );
>>
>> TRACE_EVENT(g4x_wm,
>> --
>> 2.46.0
>>
>
>--
>Matt Roper
>Graphics Software Engineer
>Linux GPU Platform Enablement
>Intel Corporation
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2024-09-23 16:55 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-29 22:00 [PATCH 0/4] Miscelaneous fixes for display tracepoints Gustavo Sousa
2024-08-29 22:00 ` [PATCH 1/4] drm/i915/display: Fix out-of-bounds access in pipe-related tracepoints Gustavo Sousa
2024-09-18 22:13 ` Matt Roper
2024-08-29 22:00 ` [PATCH 2/4] drm/i915/display: Store pipe name in trace events Gustavo Sousa
2024-09-18 22:37 ` Matt Roper
2024-09-23 14:30 ` Gustavo Sousa
2024-08-29 22:00 ` [PATCH 3/4] drm/i915/display: Do not use ids from enum pipe in TP_printk() Gustavo Sousa
2024-09-18 22:41 ` Matt Roper
2024-08-29 22:00 ` [PATCH 4/4] drm/i915/display: Cover all possible pipes " Gustavo Sousa
2024-09-18 22:49 ` Matt Roper
2024-09-23 16:55 ` Gustavo Sousa
2024-08-30 0:02 ` ✗ Fi.CI.CHECKPATCH: warning for Miscelaneous fixes for display tracepoints Patchwork
2024-08-30 0:09 ` ✓ Fi.CI.BAT: success " Patchwork
2024-08-31 13:52 ` ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox