From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.saarinen@intel.com, ville.syrjala@linux.intel.com
Subject: [PATCH 01/14] drm/i915/display: Modify debugfs for joiner to force n pipes
Date: Fri, 6 Sep 2024 18:27:54 +0530 [thread overview]
Message-ID: <20240906125807.3960642-2-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20240906125807.3960642-1-ankit.k.nautiyal@intel.com>
At the moment, the debugfs for joiner allows only to force enable/disable
pipe joiner for 2 pipes. Modify it to force join 'n' number of pipes,
where n is a valid pipe joiner configuration.
This will help in case of ultra joiner where 4 pipes are joined.
v2:
-Fix commit message to state that only valid joiner config can be
forced. (Suraj)
-Rename the identifiers to have INTEL_BIG/NONE_JOINER_PIPES. (Suraj)
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
.../drm/i915/display/intel_display_debugfs.c | 71 ++++++++++++++++++-
.../drm/i915/display/intel_display_types.h | 8 ++-
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
3 files changed, 77 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index 830b9eb60976..0ef573afd8a1 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -1504,6 +1504,73 @@ static int intel_crtc_pipe_show(struct seq_file *m, void *unused)
}
DEFINE_SHOW_ATTRIBUTE(intel_crtc_pipe);
+static int i915_joiner_show(struct seq_file *m, void *data)
+{
+ struct intel_connector *connector = m->private;
+ struct drm_i915_private *i915 = to_i915(connector->base.dev);
+ int ret;
+
+ ret = drm_modeset_lock_single_interruptible(&i915->drm.mode_config.connection_mutex);
+ if (ret)
+ return ret;
+
+ seq_printf(m, "Force_joined_pipes: %d\n", connector->force_joined_pipes);
+
+ drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+ return ret;
+}
+
+static ssize_t i915_joiner_write(struct file *file,
+ const char __user *ubuf,
+ size_t len, loff_t *offp)
+{
+ struct seq_file *m = file->private_data;
+ struct intel_connector *connector = m->private;
+ struct drm_i915_private *i915 = to_i915(connector->base.dev);
+ int force_join_pipes = 0;
+ int ret;
+
+ if (len == 0)
+ return 0;
+
+ drm_dbg(&i915->drm,
+ "Copied %zu bytes from user to force joiner\n", len);
+
+ ret = kstrtoint_from_user(ubuf, len, 0, &force_join_pipes);
+ if (ret < 0)
+ return ret;
+
+ drm_dbg(&i915->drm, "Got %d for force joining pipes\n", force_join_pipes);
+
+ if (force_join_pipes < INTEL_NONE_JOINER_PIPES ||
+ force_join_pipes >= INTEL_INVALID_JOINER_PIPES) {
+ drm_dbg(&i915->drm, "Ignoring Invalid num of pipes %d for force joining\n",
+ force_join_pipes);
+ connector->force_joined_pipes = INTEL_NONE_JOINER_PIPES;
+ } else {
+ connector->force_joined_pipes = force_join_pipes;
+ }
+
+ *offp += len;
+
+ return len;
+}
+
+static int i915_joiner_open(struct inode *inode, struct file *file)
+{
+ return single_open(file, i915_joiner_show, inode->i_private);
+}
+
+static const struct file_operations i915_joiner_fops = {
+ .owner = THIS_MODULE,
+ .open = i915_joiner_open,
+ .read = seq_read,
+ .llseek = seq_lseek,
+ .release = single_release,
+ .write = i915_joiner_write
+};
+
/**
* intel_connector_debugfs_add - add i915 specific connector debugfs files
* @connector: pointer to a registered intel_connector
@@ -1553,8 +1620,8 @@ void intel_connector_debugfs_add(struct intel_connector *connector)
if (DISPLAY_VER(i915) >= 11 &&
(connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
connector_type == DRM_MODE_CONNECTOR_eDP)) {
- debugfs_create_bool("i915_bigjoiner_force_enable", 0644, root,
- &connector->force_bigjoiner_enable);
+ debugfs_create_file("i915_joiner_force_enable", 0644, root,
+ connector, &i915_joiner_fops);
}
if (connector_type == DRM_MODE_CONNECTOR_DSI ||
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 733de5edcfdb..c213fb61ceb7 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -486,6 +486,12 @@ struct intel_hdcp {
enum transcoder stream_transcoder;
};
+enum intel_joiner_pipe_count {
+ INTEL_NONE_JOINER_PIPES = 0,
+ INTEL_BIG_JOINER_PIPES = 2,
+ INTEL_INVALID_JOINER_PIPES,
+};
+
struct intel_connector {
struct drm_connector base;
/*
@@ -524,7 +530,7 @@ struct intel_connector {
struct intel_dp *mst_port;
- bool force_bigjoiner_enable;
+ enum intel_joiner_pipe_count force_joined_pipes;
struct {
struct drm_dp_aux *dsc_decompression_aux;
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index a1fcedfd404b..862a460c32b7 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1271,7 +1271,7 @@ bool intel_dp_need_joiner(struct intel_dp *intel_dp,
return false;
return clock > i915->display.cdclk.max_dotclk_freq || hdisplay > 5120 ||
- connector->force_bigjoiner_enable;
+ connector->force_joined_pipes == INTEL_BIG_JOINER_PIPES;
}
bool intel_dp_has_dsc(const struct intel_connector *connector)
--
2.45.2
next prev parent reply other threads:[~2024-09-06 12:56 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 12:57 [PATCH 00/14] Ultrajoiner basic functionality series Ankit Nautiyal
2024-09-06 12:57 ` Ankit Nautiyal [this message]
2024-09-06 14:46 ` [PATCH 01/14] drm/i915/display: Modify debugfs for joiner to force n pipes Ville Syrjälä
2024-09-06 14:54 ` Ville Syrjälä
2024-09-09 5:40 ` Nautiyal, Ankit K
2024-09-09 13:40 ` Ville Syrjälä
2024-09-10 5:42 ` Nautiyal, Ankit K
2024-09-10 11:46 ` Ville Syrjälä
2024-09-10 14:10 ` Nautiyal, Ankit K
2024-09-10 14:16 ` Ville Syrjälä
2024-09-09 5:34 ` Nautiyal, Ankit K
2024-09-06 12:57 ` [PATCH 02/14] drm/i915/display: Use joined pipes in intel_dp_joiner_needs_dsc Ankit Nautiyal
2024-09-06 12:57 ` [PATCH 03/14] drm/i915/display: Use joined pipes in intel_mode_valid_max_plane_size Ankit Nautiyal
2024-09-06 14:52 ` Ville Syrjälä
2024-09-09 6:10 ` Nautiyal, Ankit K
2024-09-06 12:57 ` [PATCH 04/14] drm/i915/display: Use joined pipes in dsc helpers for slices, bpp Ankit Nautiyal
2024-09-06 12:57 ` [PATCH 05/14] drm/i915: Add some essential functionality for joiners Ankit Nautiyal
2024-09-06 15:24 ` Ville Syrjälä
2024-09-09 7:47 ` Nautiyal, Ankit K
2024-09-09 13:42 ` Ville Syrjälä
2024-09-06 12:57 ` [PATCH 06/14] drm/i915: Split current joiner hw state readout Ankit Nautiyal
2024-09-06 15:29 ` Ville Syrjälä
2024-09-09 7:55 ` Nautiyal, Ankit K
2024-09-06 12:58 ` [PATCH 07/14] drm/i915: Add bigjoiner and uncompressed joiner hw readout sanity checks Ankit Nautiyal
2024-09-06 15:39 ` Ville Syrjälä
2024-09-09 8:31 ` Nautiyal, Ankit K
2024-09-09 8:40 ` Nautiyal, Ankit K
2024-09-06 12:58 ` [PATCH 08/14] drm/i915: Implement hw state readout and checks for ultrajoiner Ankit Nautiyal
2024-09-06 15:58 ` Ville Syrjälä
2024-09-09 8:44 ` Nautiyal, Ankit K
2024-09-06 12:58 ` [PATCH 09/14] drm/i915/display: Add helpers to check for ultrajoiner primary Ankit Nautiyal
2024-09-06 12:58 ` [PATCH 10/14] drm/i915/display/vdsc: Add ultrajoiner support with DSC Ankit Nautiyal
2024-09-06 16:30 ` Ville Syrjälä
2024-09-06 16:39 ` Ville Syrjälä
2024-09-09 9:23 ` Nautiyal, Ankit K
2024-09-09 13:46 ` Ville Syrjälä
2024-09-06 12:58 ` [PATCH 11/14] drm/i915: Add new abstraction layer to handle pipe order for different joiners Ankit Nautiyal
2024-09-06 12:58 ` [PATCH 12/14] drm/i915: Compute config and mode valid changes for ultrajoiner Ankit Nautiyal
2024-09-06 12:58 ` [PATCH 13/14] drm/i915/display: Consider ultrajoiner for computing maxdotclock Ankit Nautiyal
2024-09-06 12:58 ` [PATCH 14/14] drm/i915/intel_dp: Add support for forcing ultrajoiner Ankit Nautiyal
2024-09-06 14:08 ` ✗ Fi.CI.CHECKPATCH: warning for Ultrajoiner basic functionality series (rev7) Patchwork
2024-09-06 14:08 ` ✗ Fi.CI.SPARSE: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240906125807.3960642-2-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.saarinen@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox