From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-xe@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, Maarten Lankhorst <dev@lankhorst.se>
Subject: [PATCH v2] drm/xe: Defer irq init until after xe_display_init_noaccel
Date: Mon, 9 Dec 2024 12:17:21 +0100 [thread overview]
Message-ID: <20241209111721.13686-1-dev@lankhorst.se> (raw)
In-Reply-To: <20241206185956.3290-5-dev@lankhorst.se>
We want to merge xe_display_init_noirq and xe_display_init_noaccel,
by not enabling interrupts in between, this should be safe to do.
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
v2: Remove memirq parts, reword commit message.
drivers/gpu/drm/xe/xe_device.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index c1b4601a14779..fbec176ee64ad 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -701,10 +701,6 @@ int xe_device_probe(struct xe_device *xe)
if (err)
return err;
- err = xe_irq_install(xe);
- if (err)
- goto err;
-
err = probe_has_flat_ccs(xe);
if (err)
goto err;
@@ -738,6 +734,10 @@ int xe_device_probe(struct xe_device *xe)
goto err;
}
+ err = xe_irq_install(xe);
+ if (err)
+ goto err;
+
for_each_gt(gt, xe, id) {
last_gt = id;
--
2.45.2
next prev parent reply other threads:[~2024-12-09 11:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 18:59 [PATCH 0/5] drm/xe/display: Rework display init for reducing flickering Maarten Lankhorst
2024-12-06 18:59 ` [PATCH 1/5] drm/xe/display: Add intel_plane_initial_vblank_wait Maarten Lankhorst
2024-12-06 18:59 ` [PATCH 2/5] drm/xe: Remove double pageflip Maarten Lankhorst
2024-12-06 18:59 ` [PATCH 3/5] drm/xe: Move suballocator init to after display init Maarten Lankhorst
2024-12-06 18:59 ` [PATCH 4/5] drm/xe: Defer irq init until after xe_display_init_noaccel Maarten Lankhorst
2024-12-09 11:17 ` Maarten Lankhorst [this message]
2024-12-06 18:59 ` [PATCH 5/5] drm/xe/display: Use a single early init call for display Maarten Lankhorst
2024-12-09 15:51 ` [PATCH] " Maarten Lankhorst
2024-12-10 9:35 ` Jani Nikula
2024-12-11 18:32 ` Maarten Lankhorst
2024-12-12 14:27 ` Rodrigo Vivi
2024-12-06 19:44 ` ✗ Fi.CI.CHECKPATCH: warning for drm/xe/display: Rework display init for reducing flickering Patchwork
2024-12-06 19:44 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-12-06 19:58 ` ✗ i915.CI.BAT: failure " Patchwork
2024-12-09 10:39 ` [PATCH 0/5] " Jani Nikula
2024-12-09 18:36 ` ✗ Fi.CI.CHECKPATCH: warning for drm/xe/display: Rework display init for reducing flickering. (rev3) Patchwork
2024-12-09 18:36 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-12-09 18:51 ` ✓ i915.CI.BAT: success " Patchwork
2024-12-09 21:58 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241209111721.13686-1-dev@lankhorst.se \
--to=dev@lankhorst.se \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox