Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, ville.syrjala@intel.com
Subject: [PATCH v4 10/17] drm/i915/vrr: Write DC balance params to hw registers
Date: Tue,  6 May 2025 20:25:10 +0530	[thread overview]
Message-ID: <20250506145517.4129419-11-mitulkumar.ajitkumar.golani@intel.com> (raw)
In-Reply-To: <20250506145517.4129419-1-mitulkumar.ajitkumar.golani@intel.com>

Write DC Balance parameters to hw registers.

--v2:
- Update commit header.
- Separate crtc_state params from this patch. (Ankit)

--v3:
- Write registers at compute config.
- Update condition for write.

Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_vrr.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index dcaae7631b0a..420ee917d6a9 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -483,6 +483,8 @@ void intel_vrr_set_transcoder_timings(const struct intel_crtc_state *crtc_state)
 {
 	struct intel_display *display = to_intel_display(crtc_state);
 	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
+	struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
+	enum pipe pipe = crtc->pipe;
 
 	/*
 	 * This bit seems to have two meanings depending on the platform:
@@ -510,6 +512,24 @@ void intel_vrr_set_transcoder_timings(const struct intel_crtc_state *crtc_state)
 			       lower_32_bits(crtc_state->cmrr.cmrr_n));
 	}
 
+	if (HAS_VRR_DC_BALANCE(display) &&
+	    (crtc_state->vrr.dc_balance.vmin || crtc_state->vrr.dc_balance.vmax)) {
+		intel_de_write(display, PIPEDMC_DCB_VMIN(pipe),
+			       crtc_state->vrr.dc_balance.vmin - 1);
+		intel_de_write(display, PIPEDMC_DCB_VMAX(pipe),
+			       crtc_state->vrr.dc_balance.vmax - 1);
+		intel_de_write(display, PIPEDMC_DCB_MAX_INCREASE(pipe),
+			       crtc_state->vrr.dc_balance.max_increase);
+		intel_de_write(display, PIPEDMC_DCB_MAX_DECREASE(pipe),
+			       crtc_state->vrr.dc_balance.max_decrease);
+		intel_de_write(display, PIPEDMC_DCB_GUARDBAND(pipe),
+			       crtc_state->vrr.dc_balance.guardband);
+		intel_de_write(display, PIPEDMC_DCB_SLOPE(pipe),
+			       crtc_state->vrr.dc_balance.slope);
+		intel_de_write(display, PIPEDMC_DCB_VBLANK(pipe),
+			       crtc_state->vrr.dc_balance.vblank_target);
+	}
+
 	intel_vrr_set_fixed_rr_timings(crtc_state);
 
 	if (!intel_vrr_always_use_vrr_tg(display) && !crtc_state->vrr.enable)
-- 
2.48.1


  parent reply	other threads:[~2025-05-06 14:57 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-06 14:55 [PATCH v4 00/17] Enable/Disable DC balance along with VRR DSB Mitul Golani
2025-05-06 14:55 ` [PATCH v4 01/17] drm/i915/vrr: Fix the adjustment for the fixed rr vtotal for Display < 13 Mitul Golani
2025-05-07 15:45   ` Ville Syrjälä
2025-05-06 14:55 ` [PATCH v4 02/17] drm/i915/vrr: Refactor vmin/vmax stuff Mitul Golani
2025-05-07  8:41   ` Nautiyal, Ankit K
2025-05-06 14:55 ` [PATCH v4 03/17] drm/i915/display: Add source param for dc balance Mitul Golani
2025-05-06 14:55 ` [PATCH v4 04/17] drm/i915/display: Add pipe dmc registers and bits for DC Balance Mitul Golani
2025-05-07  6:40   ` Nautiyal, Ankit K
2025-05-06 14:55 ` [PATCH v4 05/17] drm/i915/display: Add VRR DC balance registers Mitul Golani
2025-05-07  6:52   ` Nautiyal, Ankit K
2025-05-06 14:55 ` [PATCH v4 06/17] drm/i915/vrr: Add functions to read out vmin/vmax stuff Mitul Golani
2025-05-06 14:55 ` [PATCH v4 07/17] drm/i915/vrr: Add DC Balance params to crtc_state Mitul Golani
2025-05-07  8:27   ` Nautiyal, Ankit K
2025-05-06 14:55 ` [PATCH v4 08/17] drm/i915/vrr: Add state dump for DC Balance params Mitul Golani
2025-05-06 14:55 ` [PATCH v4 09/17] drm/i915/vrr: Add compute config " Mitul Golani
2025-05-07  8:32   ` Nautiyal, Ankit K
2025-05-06 14:55 ` Mitul Golani [this message]
2025-05-06 14:55 ` [PATCH v4 11/17] drm/i915: Extract vrr_vblank_start() Mitul Golani
2025-05-06 14:55 ` [PATCH v4 12/17] drm/i915/vrr: Implement vblank evasion with DC balancing Mitul Golani
2025-05-06 14:55 ` [PATCH v4 13/17] drm/i915/dsb: Add pipedmc dc balance enable/disable Mitul Golani
2025-05-06 14:55 ` [PATCH v4 14/17] drm/i915/vrr: Restructure VRR enablement bit Mitul Golani
2025-05-06 14:55 ` [PATCH v4 15/17] drm/i915/vrr: Pause DC Balancing for DSB commits Mitul Golani
2025-05-06 14:55 ` [PATCH v4 16/17] drm/i915/vrr: Add function to check if DC Balance Possible Mitul Golani
2025-05-07  8:40   ` Nautiyal, Ankit K
2025-05-06 14:55 ` [PATCH v4 17/17] drm/i915/vrr: Enable DC Balance bit Mitul Golani
2025-05-06 16:39 ` ✗ Fi.CI.SPARSE: warning for Enable/Disable DC balance along with VRR DSB (rev4) Patchwork
2025-05-06 17:23 ` ✗ i915.CI.BAT: failure " Patchwork
2025-05-06 17:34   ` Golani, Mitulkumar Ajitkumar
2025-05-07  6:54 ` ✓ i915.CI.BAT: success " Patchwork
2025-05-07  8:38 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250506145517.4129419-11-mitulkumar.ajitkumar.golani@intel.com \
    --to=mitulkumar.ajitkumar.golani@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox