From: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, ville.syrjala@intel.com
Subject: [PATCH v4 12/17] drm/i915/vrr: Implement vblank evasion with DC balancing
Date: Tue, 6 May 2025 20:25:12 +0530 [thread overview]
Message-ID: <20250506145517.4129419-13-mitulkumar.ajitkumar.golani@intel.com> (raw)
In-Reply-To: <20250506145517.4129419-1-mitulkumar.ajitkumar.golani@intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Add vblank evasion logic when vrr is already enabled along with
dc balance is computed.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
drivers/gpu/drm/i915/display/intel_dsb.c | 31 ++++++++++++++++++++-
drivers/gpu/drm/i915/display/intel_vblank.c | 26 +++++++++++++++--
2 files changed, 53 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index 481488d1fe67..14b9edbcc6c8 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -578,7 +578,36 @@ void intel_dsb_vblank_evade(struct intel_atomic_state *state,
if (crtc_state->has_psr)
intel_dsb_emit_wait_dsl(dsb, DSB_OPCODE_WAIT_DSL_OUT, 0, 0);
- if (pre_commit_is_vrr_active(state, crtc)) {
+ if (pre_commit_is_vrr_active(state, crtc) && crtc_state->vrr.dc_balance.enable) {
+ int vblank_delay = intel_vrr_vblank_delay(crtc_state);
+ int vmin_vblank_start, vmax_vblank_start;
+
+ vmin_vblank_start = intel_vrr_dcb_vmin_vblank_start_next(crtc_state);
+
+ if (vmin_vblank_start >= 0) {
+ end = vmin_vblank_start;
+ start = end - vblank_delay - latency;
+ intel_dsb_wait_scanline_out(state, dsb, start, end);
+ }
+
+ vmax_vblank_start = intel_vrr_dcb_vmax_vblank_start_next(crtc_state);
+
+ if (vmax_vblank_start >= 0) {
+ end = vmax_vblank_start;
+ start = end - vblank_delay - latency;
+ intel_dsb_wait_scanline_out(state, dsb, start, end);
+ }
+
+ vmin_vblank_start = intel_vrr_dcb_vmin_vblank_start_final(crtc_state);
+ end = vmin_vblank_start;
+ start = end - vblank_delay - latency;
+ intel_dsb_wait_scanline_out(state, dsb, start, end);
+
+ vmax_vblank_start = intel_vrr_dcb_vmax_vblank_start_final(crtc_state);
+ end = vmax_vblank_start;
+ start = end - vblank_delay - latency;
+ intel_dsb_wait_scanline_out(state, dsb, start, end);
+ } else if (pre_commit_is_vrr_active(state, crtc)) {
int vblank_delay = intel_vrr_vblank_delay(crtc_state);
end = intel_vrr_vmin_vblank_start(crtc_state);
diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c b/drivers/gpu/drm/i915/display/intel_vblank.c
index 680013f00fc0..eb74d08d6690 100644
--- a/drivers/gpu/drm/i915/display/intel_vblank.c
+++ b/drivers/gpu/drm/i915/display/intel_vblank.c
@@ -644,10 +644,30 @@ intel_pre_commit_crtc_state(struct intel_atomic_state *state,
static int vrr_vblank_start(const struct intel_crtc_state *crtc_state)
{
- if (intel_vrr_is_push_sent(crtc_state))
- return intel_vrr_vmin_vblank_start(crtc_state);
+ bool is_push_sent = intel_vrr_is_push_sent(crtc_state);
+ int vblank_start;
+
+ if (!crtc_state->vrr.dc_balance.enable) {
+ if (is_push_sent)
+ return intel_vrr_vmin_vblank_start(crtc_state);
+ else
+ return intel_vrr_vmax_vblank_start(crtc_state);
+ }
+
+ if (is_push_sent)
+ vblank_start = intel_vrr_dcb_vmin_vblank_start_next(crtc_state);
else
- return intel_vrr_vmax_vblank_start(crtc_state);
+ vblank_start = intel_vrr_dcb_vmax_vblank_start_next(crtc_state);
+
+ if (vblank_start >= 0)
+ return vblank_start;
+
+ if (is_push_sent)
+ vblank_start = intel_vrr_dcb_vmin_vblank_start_final(crtc_state);
+ else
+ vblank_start = intel_vrr_dcb_vmax_vblank_start_final(crtc_state);
+
+ return vblank_start;
}
void intel_vblank_evade_init(const struct intel_crtc_state *old_crtc_state,
--
2.48.1
next prev parent reply other threads:[~2025-05-06 14:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 14:55 [PATCH v4 00/17] Enable/Disable DC balance along with VRR DSB Mitul Golani
2025-05-06 14:55 ` [PATCH v4 01/17] drm/i915/vrr: Fix the adjustment for the fixed rr vtotal for Display < 13 Mitul Golani
2025-05-07 15:45 ` Ville Syrjälä
2025-05-06 14:55 ` [PATCH v4 02/17] drm/i915/vrr: Refactor vmin/vmax stuff Mitul Golani
2025-05-07 8:41 ` Nautiyal, Ankit K
2025-05-06 14:55 ` [PATCH v4 03/17] drm/i915/display: Add source param for dc balance Mitul Golani
2025-05-06 14:55 ` [PATCH v4 04/17] drm/i915/display: Add pipe dmc registers and bits for DC Balance Mitul Golani
2025-05-07 6:40 ` Nautiyal, Ankit K
2025-05-06 14:55 ` [PATCH v4 05/17] drm/i915/display: Add VRR DC balance registers Mitul Golani
2025-05-07 6:52 ` Nautiyal, Ankit K
2025-05-06 14:55 ` [PATCH v4 06/17] drm/i915/vrr: Add functions to read out vmin/vmax stuff Mitul Golani
2025-05-06 14:55 ` [PATCH v4 07/17] drm/i915/vrr: Add DC Balance params to crtc_state Mitul Golani
2025-05-07 8:27 ` Nautiyal, Ankit K
2025-05-06 14:55 ` [PATCH v4 08/17] drm/i915/vrr: Add state dump for DC Balance params Mitul Golani
2025-05-06 14:55 ` [PATCH v4 09/17] drm/i915/vrr: Add compute config " Mitul Golani
2025-05-07 8:32 ` Nautiyal, Ankit K
2025-05-06 14:55 ` [PATCH v4 10/17] drm/i915/vrr: Write DC balance params to hw registers Mitul Golani
2025-05-06 14:55 ` [PATCH v4 11/17] drm/i915: Extract vrr_vblank_start() Mitul Golani
2025-05-06 14:55 ` Mitul Golani [this message]
2025-05-06 14:55 ` [PATCH v4 13/17] drm/i915/dsb: Add pipedmc dc balance enable/disable Mitul Golani
2025-05-06 14:55 ` [PATCH v4 14/17] drm/i915/vrr: Restructure VRR enablement bit Mitul Golani
2025-05-06 14:55 ` [PATCH v4 15/17] drm/i915/vrr: Pause DC Balancing for DSB commits Mitul Golani
2025-05-06 14:55 ` [PATCH v4 16/17] drm/i915/vrr: Add function to check if DC Balance Possible Mitul Golani
2025-05-07 8:40 ` Nautiyal, Ankit K
2025-05-06 14:55 ` [PATCH v4 17/17] drm/i915/vrr: Enable DC Balance bit Mitul Golani
2025-05-06 16:39 ` ✗ Fi.CI.SPARSE: warning for Enable/Disable DC balance along with VRR DSB (rev4) Patchwork
2025-05-06 17:23 ` ✗ i915.CI.BAT: failure " Patchwork
2025-05-06 17:34 ` Golani, Mitulkumar Ajitkumar
2025-05-07 6:54 ` ✓ i915.CI.BAT: success " Patchwork
2025-05-07 8:38 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250506145517.4129419-13-mitulkumar.ajitkumar.golani@intel.com \
--to=mitulkumar.ajitkumar.golani@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox