Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org
Cc: arun.r.murthy@intel.com, Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH v3 12/13] drm/i915/backlight: Use drm helper to set edp backlight
Date: Fri, 20 Jun 2025 12:04:44 +0530	[thread overview]
Message-ID: <20250620063445.3603086-13-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20250620063445.3603086-1-suraj.kandpal@intel.com>

Now that the drm helper sets the backlight using luminance
too we can use that. Remove the obselete function.

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
---
 .../drm/i915/display/intel_dp_aux_backlight.c | 34 ++-----------------
 1 file changed, 3 insertions(+), 31 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index 117c762fa2fe..8f33c5b78079 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -475,31 +475,6 @@ static u32 intel_dp_aux_vesa_get_backlight(struct intel_connector *connector, en
 	return connector->panel.backlight.level;
 }
 
-static int
-intel_dp_aux_vesa_set_luminance(struct intel_connector *connector, u32 level)
-{
-	struct intel_dp *intel_dp = enc_to_intel_dp(connector->encoder);
-	u8 buf[3];
-	int ret;
-
-	level = level * 1000;
-	level &= 0xffffff;
-	buf[0] = (level & 0x0000ff);
-	buf[1] = (level & 0x00ff00) >> 8;
-	buf[2] = (level & 0xff0000) >> 16;
-
-	ret = drm_dp_dpcd_write(&intel_dp->aux, DP_EDP_PANEL_TARGET_LUMINANCE_VALUE,
-				buf, sizeof(buf));
-	if (ret != sizeof(buf)) {
-		drm_err(intel_dp->aux.drm_dev,
-			"%s: Failed to set VESA Aux Luminance: %d\n",
-			intel_dp->aux.name, ret);
-		return -EINVAL;
-	} else {
-		return 0;
-	}
-}
-
 static void
 intel_dp_aux_vesa_set_backlight(const struct drm_connector_state *conn_state, u32 level)
 {
@@ -507,11 +482,6 @@ intel_dp_aux_vesa_set_backlight(const struct drm_connector_state *conn_state, u3
 	struct intel_panel *panel = &connector->panel;
 	struct intel_dp *intel_dp = enc_to_intel_dp(connector->encoder);
 
-	if (panel->backlight.edp.vesa.luminance_control_support) {
-		if (!intel_dp_aux_vesa_set_luminance(connector, level))
-			return;
-	}
-
 	if (!panel->backlight.edp.vesa.info.aux_set) {
 		const u32 pwm_level = intel_backlight_level_to_pwm(connector, level);
 
@@ -537,7 +507,9 @@ intel_dp_aux_vesa_enable_backlight(const struct intel_crtc_state *crtc_state,
 		if (ret == 1)
 			return;
 
-		if (!intel_dp_aux_vesa_set_luminance(connector, level))
+		if (!drm_edp_backlight_set_level(&intel_dp->aux,
+						 &panel->backlight.edp.vesa.info,
+						 level))
 			return;
 	}
 
-- 
2.34.1


  parent reply	other threads:[~2025-06-20  6:35 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-20  6:34 [PATCH 00/13] Modify drm helpers to use luminance Suraj Kandpal
2025-06-20  6:34 ` [PATCH v3 01/13] drm/dp: Introduce new member in drm_backlight_info Suraj Kandpal
2025-06-20  6:34 ` [PATCH v3 02/13] drm/dp: Add argument in drm_edp_backlight_init Suraj Kandpal
2025-06-20  6:34 ` [PATCH v3 03/13] drm/dp: Add argument for max luminance " Suraj Kandpal
2025-06-24  4:42   ` Murthy, Arun R
2025-06-20  6:34 ` [PATCH v3 04/13] drm/dp: Move from u16 to u32 for max in drm_edp_backlight_info Suraj Kandpal
2025-06-24  4:44   ` Murthy, Arun R
2025-06-20  6:34 ` [PATCH v3 05/13] drm/dp: Change current_level argument type to u32 Suraj Kandpal
2025-06-20  6:34 ` [PATCH v3 06/13] drm/dp: Modify drm_edp_probe_state Suraj Kandpal
2025-06-20  6:34 ` [PATCH v3 07/13] drm/dp: Change argument type for drm_edp_backlight_set_level Suraj Kandpal
2025-06-20  6:34 ` [PATCH v3 08/13] drm/dp: Modify drm_edp_backlight_set_level Suraj Kandpal
2025-06-20  6:34 ` [PATCH v3 09/13] drm/dp: Change argument type of drm_edp_backlight_enable Suraj Kandpal
2025-06-20  6:34 ` [PATCH v3 10/13] drm/dp: Enable backlight control using luminance Suraj Kandpal
2025-06-20  6:34 ` [PATCH v3 11/13] drm/i915/backlight: Use drm helper to initialize edp backlight Suraj Kandpal
2025-06-24  4:47   ` Murthy, Arun R
2025-06-24  4:52     ` Kandpal, Suraj
2025-06-24  5:01       ` Murthy, Arun R
2025-06-24  5:13         ` Kandpal, Suraj
2025-06-24  5:20         ` Kandpal, Suraj
2025-06-20  6:34 ` Suraj Kandpal [this message]
2025-06-20  6:34 ` [PATCH v3 13/13] drm/i915/backlight: Use drm_edp_backlight_enable Suraj Kandpal
2025-06-20  7:25 ` ✓ i915.CI.BAT: success for Modify drm helpers to use luminance (rev4) Patchwork
2025-06-20 10:59 ` ✓ i915.CI.Full: " Patchwork
2025-06-25  9:03 ` [PATCH 00/13] Modify drm helpers to use luminance Jani Nikula
2025-06-25 11:20   ` Kandpal, Suraj
2025-06-30  6:58     ` Kandpal, Suraj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250620063445.3603086-13-suraj.kandpal@intel.com \
    --to=suraj.kandpal@intel.com \
    --cc=arun.r.murthy@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox