Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org
Cc: arun.r.murthy@intel.com, Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH v3 06/13] drm/dp: Modify drm_edp_probe_state
Date: Fri, 20 Jun 2025 12:04:38 +0530	[thread overview]
Message-ID: <20250620063445.3603086-7-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20250620063445.3603086-1-suraj.kandpal@intel.com>

Modify drm_edp_probe_state to read current level from
DP_EDP_PANEL_TARGET_LUMINANCE_VALUE. We divide it by
1000 since the value in this register is in millinits.

--v2
-Add comment on the unit sent back [Arun]

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
---
 drivers/gpu/drm/display/drm_dp_helper.c | 40 ++++++++++++++++++-------
 1 file changed, 30 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
index daeb3bdc87a3..53f02dc6c3f1 100644
--- a/drivers/gpu/drm/display/drm_dp_helper.c
+++ b/drivers/gpu/drm/display/drm_dp_helper.c
@@ -4209,7 +4209,7 @@ drm_edp_backlight_probe_state(struct drm_dp_aux *aux, struct drm_edp_backlight_i
 			      u8 *current_mode)
 {
 	int ret;
-	u8 buf[2];
+	u8 buf[3];
 	u8 mode_reg;
 
 	ret = drm_dp_dpcd_read_byte(aux, DP_EDP_BACKLIGHT_MODE_SET_REGISTER, &mode_reg);
@@ -4226,17 +4226,37 @@ drm_edp_backlight_probe_state(struct drm_dp_aux *aux, struct drm_edp_backlight_i
 	if (*current_mode == DP_EDP_BACKLIGHT_CONTROL_MODE_DPCD) {
 		int size = 1 + bl->lsb_reg_used;
 
-		ret = drm_dp_dpcd_read_data(aux, DP_EDP_BACKLIGHT_BRIGHTNESS_MSB, buf, size);
-		if (ret < 0) {
-			drm_dbg_kms(aux->drm_dev, "%s: Failed to read backlight level: %d\n",
-				    aux->name, ret);
-			return ret;
+		if (bl->luminance_set) {
+			ret = drm_dp_dpcd_read_data(aux, DP_EDP_PANEL_TARGET_LUMINANCE_VALUE,
+						    buf, sizeof(buf));
+			if (ret < 0) {
+				drm_dbg_kms(aux->drm_dev,
+					    "%s: Failed to read backlight level: %d\n",
+					    aux->name, ret);
+				return ret;
 		}
 
-		if (bl->lsb_reg_used)
-			return (buf[0] << 8) | buf[1];
-		else
-			return buf[0];
+		/*
+		 * Incase luminance is set we want to send the value back in nits but since
+		 * DP_EDP_PANEL_TARGET_LUMINANCE stores values in millinits we need to divide
+		 * by 1000.
+		 */
+		return (buf[0] | buf[1] << 8 | buf[2] << 16) / 1000;
+		} else {
+			ret = drm_dp_dpcd_read_data(aux, DP_EDP_BACKLIGHT_BRIGHTNESS_MSB,
+						    buf, size);
+			if (ret < 0) {
+				drm_dbg_kms(aux->drm_dev,
+					    "%s: Failed to read backlight level: %d\n",
+					    aux->name, ret);
+				return ret;
+			}
+
+			if (bl->lsb_reg_used)
+				return (buf[0] << 8) | buf[1];
+			else
+				return buf[0];
+		}
 	}
 
 	/*
-- 
2.34.1


  parent reply	other threads:[~2025-06-20  6:35 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-20  6:34 [PATCH 00/13] Modify drm helpers to use luminance Suraj Kandpal
2025-06-20  6:34 ` [PATCH v3 01/13] drm/dp: Introduce new member in drm_backlight_info Suraj Kandpal
2025-06-20  6:34 ` [PATCH v3 02/13] drm/dp: Add argument in drm_edp_backlight_init Suraj Kandpal
2025-06-20  6:34 ` [PATCH v3 03/13] drm/dp: Add argument for max luminance " Suraj Kandpal
2025-06-24  4:42   ` Murthy, Arun R
2025-06-20  6:34 ` [PATCH v3 04/13] drm/dp: Move from u16 to u32 for max in drm_edp_backlight_info Suraj Kandpal
2025-06-24  4:44   ` Murthy, Arun R
2025-06-20  6:34 ` [PATCH v3 05/13] drm/dp: Change current_level argument type to u32 Suraj Kandpal
2025-06-20  6:34 ` Suraj Kandpal [this message]
2025-06-20  6:34 ` [PATCH v3 07/13] drm/dp: Change argument type for drm_edp_backlight_set_level Suraj Kandpal
2025-06-20  6:34 ` [PATCH v3 08/13] drm/dp: Modify drm_edp_backlight_set_level Suraj Kandpal
2025-06-20  6:34 ` [PATCH v3 09/13] drm/dp: Change argument type of drm_edp_backlight_enable Suraj Kandpal
2025-06-20  6:34 ` [PATCH v3 10/13] drm/dp: Enable backlight control using luminance Suraj Kandpal
2025-06-20  6:34 ` [PATCH v3 11/13] drm/i915/backlight: Use drm helper to initialize edp backlight Suraj Kandpal
2025-06-24  4:47   ` Murthy, Arun R
2025-06-24  4:52     ` Kandpal, Suraj
2025-06-24  5:01       ` Murthy, Arun R
2025-06-24  5:13         ` Kandpal, Suraj
2025-06-24  5:20         ` Kandpal, Suraj
2025-06-20  6:34 ` [PATCH v3 12/13] drm/i915/backlight: Use drm helper to set " Suraj Kandpal
2025-06-20  6:34 ` [PATCH v3 13/13] drm/i915/backlight: Use drm_edp_backlight_enable Suraj Kandpal
2025-06-20  7:25 ` ✓ i915.CI.BAT: success for Modify drm helpers to use luminance (rev4) Patchwork
2025-06-20 10:59 ` ✓ i915.CI.Full: " Patchwork
2025-06-25  9:03 ` [PATCH 00/13] Modify drm helpers to use luminance Jani Nikula
2025-06-25 11:20   ` Kandpal, Suraj
2025-06-30  6:58     ` Kandpal, Suraj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250620063445.3603086-7-suraj.kandpal@intel.com \
    --to=suraj.kandpal@intel.com \
    --cc=arun.r.murthy@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox