From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH 4/4] drm/i915/wm: Use fb->modfier to check for tiled vs. untiled
Date: Thu, 2 Oct 2025 14:54:34 +0300 [thread overview]
Message-ID: <20251002115434.6486-5-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20251002115434.6486-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
There is no point in checking the bo fence tiling mode when
we can just check the fb modifier instead.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/i9xx_wm.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/i9xx_wm.c b/drivers/gpu/drm/i915/display/i9xx_wm.c
index fd3b7b35f351..b262319bc83d 100644
--- a/drivers/gpu/drm/i915/display/i9xx_wm.c
+++ b/drivers/gpu/drm/i915/display/i9xx_wm.c
@@ -2295,12 +2295,11 @@ static void i9xx_update_wm(struct intel_display *display)
crtc = single_enabled_crtc(display);
if (display->platform.i915gm && crtc) {
- struct drm_gem_object *obj;
-
- obj = intel_fb_bo(crtc->base.primary->state->fb);
+ const struct drm_framebuffer *fb =
+ crtc->base.primary->state->fb;
/* self-refresh seems busted with untiled */
- if (!intel_bo_is_tiled(obj))
+ if (fb->modifier == DRM_FORMAT_MOD_LINEAR)
crtc = NULL;
}
--
2.49.1
next prev parent reply other threads:[~2025-10-02 11:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 11:54 [PATCH 0/4] drm/i915: fb fixes and claenups Ville Syrjala
2025-10-02 11:54 ` [PATCH 1/4] drm/i915/fb: Fix the set_tiling vs. addfb race, again Ville Syrjala
2025-10-02 13:59 ` Jani Nikula
2025-10-02 16:41 ` Ville Syrjälä
2025-10-02 16:44 ` [PATCH v2 " Ville Syrjala
2025-10-02 11:54 ` [PATCH 2/4] drm/i915/fbdev: Select linear modifier explicitly Ville Syrjala
2025-10-02 14:25 ` Jani Nikula
2025-10-02 11:54 ` [PATCH 3/4] drm/i915/fb: Drop the 'fb' argument from intel_fb_bo_framebuffer_init() Ville Syrjala
2025-10-02 14:27 ` Jani Nikula
2025-10-02 11:54 ` Ville Syrjala [this message]
2025-10-02 15:05 ` [PATCH 4/4] drm/i915/wm: Use fb->modfier to check for tiled vs. untiled Jani Nikula
2025-10-02 15:41 ` ✓ i915.CI.BAT: success for drm/i915: fb fixes and claenups Patchwork
2025-10-02 18:53 ` ✓ i915.CI.BAT: success for drm/i915: fb fixes and claenups (rev2) Patchwork
2025-10-03 10:49 ` ✓ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251002115434.6486-5-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox