Re: [PATCH 4/4] drm/i915/wm: Use fb->modfier to check for tiled vs. untiled

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 02 Oct 2025, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> There is no point in checking the bo fence tiling mode when
> we can just check the fb modifier instead.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/i9xx_wm.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/i9xx_wm.c b/drivers/gpu/drm/i915/display/i9xx_wm.c
> index fd3b7b35f351..b262319bc83d 100644
> --- a/drivers/gpu/drm/i915/display/i9xx_wm.c
> +++ b/drivers/gpu/drm/i915/display/i9xx_wm.c
> @@ -2295,12 +2295,11 @@ static void i9xx_update_wm(struct intel_display *display)
>  
>  	crtc = single_enabled_crtc(display);
>  	if (display->platform.i915gm && crtc) {
> -		struct drm_gem_object *obj;
> -
> -		obj = intel_fb_bo(crtc->base.primary->state->fb);
> +		const struct drm_framebuffer *fb =
> +			crtc->base.primary->state->fb;
>  
>  		/* self-refresh seems busted with untiled */
> -		if (!intel_bo_is_tiled(obj))
> +		if (fb->modifier == DRM_FORMAT_MOD_LINEAR)
>  			crtc = NULL;
>  	}

-- 
Jani Nikula, Intel