Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH 00/16] drm/i915/de: Register polling cleanup
Date: Mon, 10 Nov 2025 19:27:39 +0200	[thread overview]
Message-ID: <20251110172756.2132-1-ville.syrjala@linux.intel.com> (raw)

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Clean up the register polling stuff:
- rename the current wait stuff to
  intel_de_wait_{,for_set,for_clear}_ms()
- introduce intel_de_wait_{,for_set,for_clear}_us()
- nuke intel_de_wait_custom()
- change the wakelock stuff to use _fw() instead of
  hand rolling yet another level of register accessors
- a few other minor cleanups

After this it should be fairly easy to switch over to
poll_timeout_us().

Ville Syrjälä (16):
  drm/i915/de: Implement register waits one way
  drm/i915/de: Have intel_de_wait() hand out the final register value
  drm/i915/de: Include units in intel_de_wait*() function names
  drm/i915/de: Introduce intel_de_wait_us()
  drm/i915/de: Use intel_de_wait_us()
  drm/i915/de: Use intel_de_wait_ms() for the obvious cases
  drm/i915/de: Nuke intel_de_wait_custom()
  drm/i915/de: Introduce intel_de_wait_for_{set,clear}_us()
  drm/i915/de: Use intel_de_wait_for_{set,clear}_us()
  drm/i915/de: Use intel_de_wait_for_{set,clear}_ms()
  drm/1915/dpio: Stop using intel_de_wait_fw_ms()
  drm/u195/de: Replace __intel_de_rmw_nowl() with intel_de_rmw_fw()
  drm/i915/de: Nuke wakelocks from intel_de_wait_fw_ms()
  drm/i915/de: Replace __intel_de_wait_for_register_nowl() with
    intel_de_wait_fw_us_atomic()
  drm/i915/power: Use the intel_de_wait_ms() out value
  drm/i915/dpio: Use the intel_de_wait_ms() out value

 drivers/gpu/drm/i915/display/hsw_ips.c        |   4 +-
 drivers/gpu/drm/i915/display/icl_dsi.c        |  35 +++---
 drivers/gpu/drm/i915/display/intel_cdclk.c    |  30 +++--
 drivers/gpu/drm/i915/display/intel_crt.c      |  16 +--
 drivers/gpu/drm/i915/display/intel_cx0_phy.c  |  98 ++++++++--------
 drivers/gpu/drm/i915/display/intel_ddi.c      |  34 +++---
 drivers/gpu/drm/i915/display/intel_de.h       | 107 +++++++++---------
 drivers/gpu/drm/i915/display/intel_display.c  |   4 +-
 .../drm/i915/display/intel_display_power.c    |  14 +--
 .../i915/display/intel_display_power_well.c   |  42 +++----
 drivers/gpu/drm/i915/display/intel_dmc_wl.c   |  25 ++--
 drivers/gpu/drm/i915/display/intel_dp_aux.c   |   6 +-
 drivers/gpu/drm/i915/display/intel_dp_hdcp.c  |  14 +--
 drivers/gpu/drm/i915/display/intel_dpio_phy.c |  10 +-
 drivers/gpu/drm/i915/display/intel_dpll.c     |   4 +-
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c |  27 +++--
 drivers/gpu/drm/i915/display/intel_fbc.c      |   4 +-
 drivers/gpu/drm/i915/display/intel_flipq.c    |   8 +-
 drivers/gpu/drm/i915/display/intel_gmbus.c    |   2 +-
 drivers/gpu/drm/i915/display/intel_hdcp.c     |  49 ++++----
 drivers/gpu/drm/i915/display/intel_hdmi.c     |   4 +-
 drivers/gpu/drm/i915/display/intel_lt_phy.c   |  57 +++++-----
 drivers/gpu/drm/i915/display/intel_lvds.c     |   6 +-
 .../gpu/drm/i915/display/intel_pch_display.c  |  12 +-
 .../gpu/drm/i915/display/intel_pch_refclk.c   |  10 +-
 drivers/gpu/drm/i915/display/intel_pmdemand.c |  18 +--
 drivers/gpu/drm/i915/display/intel_psr.c      |  10 +-
 drivers/gpu/drm/i915/display/intel_sbi.c      |   6 +-
 drivers/gpu/drm/i915/display/intel_snps_phy.c |   8 +-
 drivers/gpu/drm/i915/display/intel_tc.c       |   8 +-
 drivers/gpu/drm/i915/display/intel_vrr.c      |   6 +-
 drivers/gpu/drm/i915/display/vlv_dsi.c        |  54 ++++-----
 drivers/gpu/drm/i915/display/vlv_dsi_pll.c    |   8 +-
 .../drm/xe/compat-i915-headers/intel_uncore.h |  31 ++---
 34 files changed, 369 insertions(+), 402 deletions(-)

-- 
2.49.1


             reply	other threads:[~2025-11-10 17:28 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-10 17:27 Ville Syrjala [this message]
2025-11-10 17:27 ` [PATCH 01/16] drm/i915/de: Implement register waits one way Ville Syrjala
2025-11-11  4:52   ` Kandpal, Suraj
2025-11-10 17:27 ` [PATCH 02/16] drm/i915/de: Have intel_de_wait() hand out the final register value Ville Syrjala
2025-11-11  4:14   ` Kandpal, Suraj
2025-11-10 17:27 ` [PATCH 03/16] drm/i915/de: Include units in intel_de_wait*() function names Ville Syrjala
2025-11-11  4:21   ` Kandpal, Suraj
2025-11-11 17:45     ` Ville Syrjälä
2025-11-10 17:27 ` [PATCH 04/16] drm/i915/de: Introduce intel_de_wait_us() Ville Syrjala
2025-11-11  4:24   ` Kandpal, Suraj
2025-11-10 17:27 ` [PATCH 05/16] drm/i915/de: Use intel_de_wait_us() Ville Syrjala
2025-11-11  4:28   ` Kandpal, Suraj
2025-11-10 17:27 ` [PATCH 06/16] drm/i915/de: Use intel_de_wait_ms() for the obvious cases Ville Syrjala
2025-11-11  4:32   ` Kandpal, Suraj
2025-11-11 17:41     ` Ville Syrjälä
2025-11-10 17:27 ` [PATCH 07/16] drm/i915/de: Nuke intel_de_wait_custom() Ville Syrjala
2025-11-11  4:33   ` Kandpal, Suraj
2025-11-10 17:27 ` [PATCH 08/16] drm/i915/de: Introduce intel_de_wait_for_{set, clear}_us() Ville Syrjala
2025-11-11  4:35   ` Kandpal, Suraj
2025-11-10 17:27 ` [PATCH 09/16] drm/i915/de: Use intel_de_wait_for_{set,clear}_us() Ville Syrjala
2025-11-11  4:38   ` [PATCH 09/16] drm/i915/de: Use intel_de_wait_for_{set, clear}_us() Kandpal, Suraj
2025-11-10 17:27 ` [PATCH 10/16] drm/i915/de: Use intel_de_wait_for_{set,clear}_ms() Ville Syrjala
2025-11-11  4:39   ` [PATCH 10/16] drm/i915/de: Use intel_de_wait_for_{set, clear}_ms() Kandpal, Suraj
2025-11-10 17:27 ` [PATCH 11/16] drm/1915/dpio: Stop using intel_de_wait_fw_ms() Ville Syrjala
2025-11-11  4:41   ` Kandpal, Suraj
2025-11-10 17:27 ` [PATCH 12/16] drm/u195/de: Replace __intel_de_rmw_nowl() with intel_de_rmw_fw() Ville Syrjala
2025-11-11  4:44   ` Kandpal, Suraj
2025-11-10 17:27 ` [PATCH 13/16] drm/i915/de: Nuke wakelocks from intel_de_wait_fw_ms() Ville Syrjala
2025-11-11  4:45   ` Kandpal, Suraj
2025-11-10 17:27 ` [PATCH 14/16] drm/i915/de: Replace __intel_de_wait_for_register_nowl() with intel_de_wait_fw_us_atomic() Ville Syrjala
2025-11-11  4:46   ` Kandpal, Suraj
2025-11-10 17:27 ` [PATCH 15/16] drm/i915/power: Use the intel_de_wait_ms() out value Ville Syrjala
2025-11-11  4:48   ` Kandpal, Suraj
2025-11-10 17:27 ` [PATCH 16/16] drm/i915/dpio: " Ville Syrjala
2025-11-11  4:50   ` Kandpal, Suraj
2025-11-10 21:24 ` ✓ i915.CI.BAT: success for drm/i915/de: Register polling cleanup Patchwork
2025-11-11  3:41 ` ✗ i915.CI.Full: failure " Patchwork
2025-11-11  8:01 ` [PATCH 00/16] " Jani Nikula
2025-11-11 16:11   ` Ville Syrjälä
2025-11-11 19:09 ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251110172756.2132-1-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox