From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: [i915-rt v4 14/20] drm/i915: Drop the irqs_disabled() check
Date: Thu, 18 Dec 2025 17:34:02 +0100 [thread overview]
Message-ID: <20251218163408.97508-15-dev@lankhorst.se> (raw)
In-Reply-To: <20251218163408.97508-1-dev@lankhorst.se>
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
The !irqs_disabled() check triggers on PREEMPT_RT even with
i915_sched_engine::lock acquired. The reason is the lock is transformed
into a sleeping lock on PREEMPT_RT and does not disable interrupts.
There is no need to check for disabled interrupts. The lockdep
annotation below already check if the lock has been acquired by the
caller and will yell if the interrupts are not disabled.
Remove the !irqs_disabled() check.
Reported-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Acked-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
drivers/gpu/drm/i915/i915_request.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index 4399941236cbf..d82105408bd8f 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -610,7 +610,6 @@ bool __i915_request_submit(struct i915_request *request)
RQ_TRACE(request, "\n");
- GEM_BUG_ON(!irqs_disabled());
lockdep_assert_held(&engine->sched_engine->lock);
/*
@@ -719,7 +718,6 @@ void __i915_request_unsubmit(struct i915_request *request)
*/
RQ_TRACE(request, "\n");
- GEM_BUG_ON(!irqs_disabled());
lockdep_assert_held(&engine->sched_engine->lock);
/*
--
2.51.0
next prev parent reply other threads:[~2025-12-18 16:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 16:33 [i915-rt v4 00/20] drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 01/20] drm/i915/display: Fix intel_lpe_audio_irq_handler for PREEMPT-RT Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 02/20] drm/i915/display: Make get_vblank_counter use intel_de_read_fw() Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 03/20] drm/i915/display: Use intel_de_write_fw in intel_pipe_fastset Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 04/20] drm/i915/display: Make set_pipeconf use the fw variants Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 05/20] drm/i915/display: Move vblank put until after critical section Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 06/20] drm/i915/display: Remove locking from intel_vblank_evade " Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 07/20] drm/i915/display: Handle vlv dsi workaround in scanline_in_safe_range too Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 08/20] drm/i915/display: Make icl_dsi_frame_update use _fw too Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 09/20] drm/i915/display: Enable interrupts earlier on PREEMPT_RT Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 10/20] drm/i915: Use preempt_disable/enable_rt() where recommended Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 11/20] PREEMPT_RT injection Maarten Lankhorst
2025-12-18 16:34 ` [i915-rt v4 12/20] drm/i915/display: Use intel_de_read_fw in colorops Maarten Lankhorst
2025-12-18 16:34 ` [i915-rt v4 13/20] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock() Maarten Lankhorst
2025-12-18 16:34 ` Maarten Lankhorst [this message]
2025-12-18 16:34 ` [i915-rt v4 15/20] drm/i915/guc: Consider also RCU depth in busy loop Maarten Lankhorst
2025-12-18 16:34 ` [i915-rt v4 16/20] Revert "drm/i915: Depend on !PREEMPT_RT." Maarten Lankhorst
2025-12-18 16:34 ` [i915-rt v4 17/20] drm/i915/gt: Fix selftests on PREEMPT_RT Maarten Lankhorst
2025-12-18 16:34 ` [i915-rt v4 18/20] drm/i915/gt: Set stop_timeout() correctly on PREEMPT-RT Maarten Lankhorst
2025-12-18 16:34 ` [i915-rt v4 19/20] drm/i915/display: Do not take uncore lock in i915_get_vblank_counter Maarten Lankhorst
2025-12-18 19:33 ` [i915-rt v4.1] " Maarten Lankhorst
2025-12-20 15:20 ` [i915-rt v4 19/20] " kernel test robot
2025-12-20 15:43 ` kernel test robot
2025-12-21 0:35 ` kernel test robot
2025-12-18 16:34 ` [i915-rt v4 20/20] drm/i915/display: Remove uncore lock from vlv_atomic_update_fifo Maarten Lankhorst
2025-12-18 21:06 ` [i915-rt v4.1] " Maarten Lankhorst
2025-12-18 21:50 ` [i915-rt v4.2] " Maarten Lankhorst
2025-12-20 18:23 ` [i915-rt v4 20/20] " kernel test robot
2025-12-18 17:42 ` ✗ Fi.CI.BUILD: failure for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev5) Patchwork
2025-12-18 20:08 ` ✗ Fi.CI.BUILD: failure for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev6) Patchwork
2025-12-18 21:28 ` ✗ Fi.CI.BUILD: failure for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev7) Patchwork
2025-12-18 23:31 ` ✗ i915.CI.BAT: failure for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev8) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251218163408.97508-15-dev@lankhorst.se \
--to=dev@lankhorst.se \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox