Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: [i915-rt v4 01/20] drm/i915/display: Fix intel_lpe_audio_irq_handler for PREEMPT-RT
Date: Thu, 18 Dec 2025 17:33:49 +0100	[thread overview]
Message-ID: <20251218163408.97508-2-dev@lankhorst.se> (raw)
In-Reply-To: <20251218163408.97508-1-dev@lankhorst.se>

The LPE audio interrupt comes from the i915 interrupt handler. It
should be in irq disabled context.

With PREEMPT_RT enabled, the IRQ handler is threaded.
Because intel_lpe_audio_irq_handler() may be called in threaded IRQ context,
generic_handle_irq_safe API disables the interrupts before calling LPE's
interrupt top half handler.

This fixes braswell audio issues with RT enabled.

Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/i915/display/intel_lpe_audio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_lpe_audio.c b/drivers/gpu/drm/i915/display/intel_lpe_audio.c
index 5b41abe1c64d5..172c0062237eb 100644
--- a/drivers/gpu/drm/i915/display/intel_lpe_audio.c
+++ b/drivers/gpu/drm/i915/display/intel_lpe_audio.c
@@ -262,7 +262,7 @@ void intel_lpe_audio_irq_handler(struct intel_display *display)
 	if (!HAS_LPE_AUDIO(display))
 		return;
 
-	ret = generic_handle_irq(display->audio.lpe.irq);
+	ret = generic_handle_irq_safe(display->audio.lpe.irq);
 	if (ret)
 		drm_err_ratelimited(display->drm,
 				    "error handling LPE audio irq: %d\n", ret);
-- 
2.51.0


  reply	other threads:[~2025-12-18 16:33 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-18 16:33 [i915-rt v4 00/20] drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe Maarten Lankhorst
2025-12-18 16:33 ` Maarten Lankhorst [this message]
2025-12-18 16:33 ` [i915-rt v4 02/20] drm/i915/display: Make get_vblank_counter use intel_de_read_fw() Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 03/20] drm/i915/display: Use intel_de_write_fw in intel_pipe_fastset Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 04/20] drm/i915/display: Make set_pipeconf use the fw variants Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 05/20] drm/i915/display: Move vblank put until after critical section Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 06/20] drm/i915/display: Remove locking from intel_vblank_evade " Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 07/20] drm/i915/display: Handle vlv dsi workaround in scanline_in_safe_range too Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 08/20] drm/i915/display: Make icl_dsi_frame_update use _fw too Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 09/20] drm/i915/display: Enable interrupts earlier on PREEMPT_RT Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 10/20] drm/i915: Use preempt_disable/enable_rt() where recommended Maarten Lankhorst
2025-12-18 16:33 ` [i915-rt v4 11/20] PREEMPT_RT injection Maarten Lankhorst
2025-12-18 16:34 ` [i915-rt v4 12/20] drm/i915/display: Use intel_de_read_fw in colorops Maarten Lankhorst
2025-12-18 16:34 ` [i915-rt v4 13/20] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock() Maarten Lankhorst
2025-12-18 16:34 ` [i915-rt v4 14/20] drm/i915: Drop the irqs_disabled() check Maarten Lankhorst
2025-12-18 16:34 ` [i915-rt v4 15/20] drm/i915/guc: Consider also RCU depth in busy loop Maarten Lankhorst
2025-12-18 16:34 ` [i915-rt v4 16/20] Revert "drm/i915: Depend on !PREEMPT_RT." Maarten Lankhorst
2025-12-18 16:34 ` [i915-rt v4 17/20] drm/i915/gt: Fix selftests on PREEMPT_RT Maarten Lankhorst
2025-12-18 16:34 ` [i915-rt v4 18/20] drm/i915/gt: Set stop_timeout() correctly on PREEMPT-RT Maarten Lankhorst
2025-12-18 16:34 ` [i915-rt v4 19/20] drm/i915/display: Do not take uncore lock in i915_get_vblank_counter Maarten Lankhorst
2025-12-18 19:33   ` [i915-rt v4.1] " Maarten Lankhorst
2025-12-20 15:20   ` [i915-rt v4 19/20] " kernel test robot
2025-12-20 15:43   ` kernel test robot
2025-12-21  0:35   ` kernel test robot
2025-12-18 16:34 ` [i915-rt v4 20/20] drm/i915/display: Remove uncore lock from vlv_atomic_update_fifo Maarten Lankhorst
2025-12-18 21:06   ` [i915-rt v4.1] " Maarten Lankhorst
2025-12-18 21:50     ` [i915-rt v4.2] " Maarten Lankhorst
2025-12-20 18:23   ` [i915-rt v4 20/20] " kernel test robot
2025-12-18 17:42 ` ✗ Fi.CI.BUILD: failure for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev5) Patchwork
2025-12-18 20:08 ` ✗ Fi.CI.BUILD: failure for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev6) Patchwork
2025-12-18 21:28 ` ✗ Fi.CI.BUILD: failure for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev7) Patchwork
2025-12-18 23:31 ` ✗ i915.CI.BAT: failure for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev8) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251218163408.97508-2-dev@lankhorst.se \
    --to=dev@lankhorst.se \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox